Adriaan de Groot
b23f4f3bb0
Merge branch 'issue-1164'
...
FIXES #1164
2019-06-07 16:13:07 +02:00
Adriaan de Groot
4f221b41d1
[libcalamares] Close stdin on process jobs
...
- This avoids processes that wait on stdin, and e.g. improves
reaction to having just "cat" (no file) in a command, or
a package manager that asks for input.
2019-06-07 16:11:54 +02:00
Adriaan de Groot
4e13f780f1
[libcalamares] Expand tests for runCommand
...
- try both with and without a working-directory set, this would have
shown up the problem with bad indentation much earlier.
2019-06-07 16:00:37 +02:00
Adriaan de Groot
7be33b8196
[libcalamares] runCommand doesn't need queue or settings
...
- JobQueue is only needed to get global settings, which are needed
when running in the target; for host commands, allow running
without a queue.
- Settings is needed for the value of debugsettings; assume if
there's no settings object, that we're in a test and should
print debugging information.
2019-06-07 15:53:27 +02:00
Adriaan de Groot
5a835f32b8
[libcalamares] Start extending tests to runCommand()
2019-06-07 13:56:16 +02:00
Adriaan de Groot
07a59bd09c
[libcalamares] All commands with workingDirectory failed
...
- This is the same as EFAIL: a block is indented as if it's a multi-
line else block. This isn't Python though, and the return always
applies.
- Add the necessary braces.
- Apparently noone uses this code path (until ProcessJob was re-
factored to do so).
2019-06-07 13:37:46 +02:00
Adriaan de Groot
d7f5134121
[libcalamares] Be more verbose in error situations
...
- runCommand can return NoWorkingDirectory in multiple places,
make sure the log contains a more specific reason.
2019-06-07 13:32:31 +02:00
Adriaan de Groot
b587d77e31
[libcalamares] Fix untranslatable string.
...
- This would substitue an untranslated "in chroot" into the
translated string, which is weird.
2019-06-07 12:40:20 +02:00
Adriaan de Groot
6055f08aff
[libcalamares] Refactor ProcessJob
...
- Use the system runCommand() instead of a 90% copy of it.
This **does** change the overall command to `env /bin/sh -c`
rather than running only `/bin/sh -c`, though.
2019-06-07 12:30:38 +02:00
Adriaan de Groot
92d03c2cf7
[libcalamares] Introduce enum class for special process exit values
...
- Replace magic numbers like -3 with named enum values
(NoWorkingDirectory, for -3).
- Downside is big-ugly static_casts, but that's what you get
for having an int as return value for processes.
2019-06-07 12:10:22 +02:00
Adriaan de Groot
61b78d8895
[libcalamares] Stop job threads before exit
...
- This solves a crash where the thread is destroyed while still
running (e.g. cancelling during install).
- The thread might not cooperate in being terminated, but then we
have a bigger problem anyway (and Calamares will still crash on
exit).
FIXES #1164
2019-06-07 11:46:08 +02:00
Adriaan de Groot
e49beaea91
CMake: switch WITH_PYTHONQT default to OFF
2019-06-07 10:55:03 +02:00
Adriaan de Groot
0619f19536
CMake: post-release housekeeping
2019-06-07 10:45:53 +02:00
Calamares CI
a7e5488f77
i18n: [python] Automatic merge of Transifex translations
2019-06-07 10:44:02 +02:00
Calamares CI
bbc0edecd3
i18n: [dummypythonqt] Automatic merge of Transifex translations
2019-06-07 10:44:01 +02:00
Calamares CI
21f6ff0e60
i18n: [calamares] Automatic merge of Transifex translations
2019-06-07 10:44:01 +02:00
Adriaan de Groot
40d1856bb1
Changes: remove reference to QML loading, add some issue numbers
2019-06-03 15:04:41 +02:00
Adriaan de Groot
3335c2003e
[fsresizer] Fix tests
...
- Again? The checks on the job name (using filesystem or device
name) all looked very bogus, unless it was previously not
setting them at all.
2019-06-03 15:00:04 +02:00
Adriaan de Groot
6dc83d692c
CMake: pre-release housekeeping
2019-06-03 15:00:04 +02:00
Adriaan de Groot
de34cacadd
Document (hoped-for) speedups in slideshow loading.
2019-06-03 15:00:04 +02:00
Calamares CI
bdac6d1e30
i18n: [python] Automatic merge of Transifex translations
2019-06-03 15:00:04 +02:00
Calamares CI
8f553c0b61
i18n: [calamares] Automatic merge of Transifex translations
2019-06-03 15:00:04 +02:00
Adriaan de Groot
8506949ecd
Changes: Document new welcome-theming
2019-05-31 17:28:33 +02:00
Adriaan de Groot
4c6218f005
Merge branch 'brand-language'
2019-05-31 17:27:25 +02:00
Adriaan de Groot
f54b7dee9f
[welcome] Use convenience image loader from Branding
2019-05-31 17:27:11 +02:00
Adriaan de Groot
07c638ed48
[welcome] Allow theming the international language-select icon
2019-05-31 17:27:11 +02:00
Adriaan de Groot
75ce391e7e
[libcalamaresui] Add branding-aware function for loading image by name
2019-05-31 17:27:11 +02:00
Adriaan de Groot
1438729b72
[libcalamaresui] Do filename checks more sanely
...
- check directory exists before trying to open file from it
- re-use the componentDir already found for later tests.
2019-05-31 17:27:11 +02:00
Adriaan de Groot
69dabcae32
[libcalamares] Avoid static destructor
...
- The static destructor issues a warning on exit:
QBasicTimer::start: QBasicTimer can only be used with threads
started with QThread
so instead, heap-allocate the model. This leaks memory, but
it's a singleton *and* we're exiting anyway.
2019-05-31 12:38:34 +02:00
Adriaan de Groot
a263381996
[partition] Avoid an assert when running Calamares as user.
2019-05-31 12:27:32 +02:00
Adriaan de Groot
1ef902a41f
Merge branch 'issue-1141'
...
FIXES #1141
2019-05-31 12:21:18 +02:00
Adriaan de Groot
4a6b9f3528
[partition] Call update from init() in BootLoaderModel
...
- update() (might) add some extra rows for boot and root,
which otherwise vanish temporarily when calling init.
2019-05-31 12:11:48 +02:00
Adriaan de Groot
d5f0bdd28c
[partition] Simplify negative logic
...
- Instead of multiple continue statements to avoid negative cases,
state the one positive case instead.
2019-05-31 12:08:58 +02:00
Adriaan de Groot
3bdbfe6bff
[partition] Avoid crash if combobox is gone and model resets
...
- Since the lambda is connected to the model only, it should
check that the target combo exists as well.
2019-05-31 12:08:58 +02:00
Adriaan de Groot
2ce2b08027
[partition] Indent lambdas to tab-stop.
...
- Lambdas are all over the place in this codebase, formulate
a standard and start adjusting code to it in passing.
2019-05-31 12:08:58 +02:00
Adriaan de Groot
353e713f81
[partition] Complain loudly on dangling Partition pointers
...
- Don't crash if a bad pointer gets into colorutils.
2019-05-31 12:08:58 +02:00
Adriaan de Groot
2bc95d11d3
[partition] Unrelated typo in comment
2019-05-31 12:08:58 +02:00
Adriaan de Groot
f1f5b6c1bb
[partition] Restore BootLoader path in Choice Page
...
- after model resets, restore what was previously selected.
- This avoids having an **empty** combobox, SEE #1141 but does
not actually set it back to the value the user had previously
picked (e.g. changing swap settings **still** breaks the
selection).
2019-05-31 12:08:58 +02:00
Adriaan de Groot
0ebabfafd4
[partition] Move BootLoaderModel convenience functions
...
- These were hidden inside PartitionPage, but are useful elsewhere.
2019-05-31 12:08:58 +02:00
Adriaan de Groot
a2e54fcf65
Changes: prep for release
2019-05-31 12:07:58 +02:00
Philip Müller
b9686a8a84
[Authors] Philip only needs to be listed once
...
I don't need to be listed more then one time ;)
2019-05-30 13:40:42 +02:00
Adriaan de Groot
8d451622db
[partition] Idiomatic use of Calamares::JobList
2019-05-28 16:39:00 +02:00
Adriaan de Groot
e2b71e669e
[partition] When running UNSAFE, no-install-partition is a warning
2019-05-28 16:29:45 +02:00
Adriaan de Groot
447a39d71d
Merge branch 'issue-1151'
...
FIXES #1151
2019-05-28 13:40:49 +02:00
Adriaan de Groot
95009a5222
[libcalamaresui] Fix disable-cancel behavior
...
- d78bc0c5
added an early `return false` when cancel is disabled,
before checking if we were at the last step; so last-step
didn't get any special handling.
- refactor so that last-step now gets special handling first,
**then** disable-cancel handling, and then the usual case.
2019-05-28 13:38:28 +02:00
Adriaan de Groot
0c24a01eb9
[finished] Improve logging of restart mode
...
- Don't use weirdly-named mode, store named mode in page,
- Log the actual mode name when setting up the restart button.
2019-05-28 13:27:21 +02:00
Adriaan de Groot
38c36e2439
[finished] Use idiomatic Calamares::JobList
2019-05-28 13:20:19 +02:00
Adriaan de Groot
1915547004
[finished] Improve logging when restarting.
2019-05-28 13:05:40 +02:00
Calamares CI
2d3f9bcdbb
i18n: [python] Automatic merge of Transifex translations
2019-05-28 12:56:23 +02:00
Calamares CI
644aade0f5
i18n: [dummypythonqt] Automatic merge of Transifex translations
2019-05-28 12:56:23 +02:00