Adriaan de Groot
f6373561d3
[partition] One more job that uses KPMCore
2019-06-14 23:39:44 +02:00
Adriaan de Groot
9c85537659
[partition] The VG jobs also use KPMCore
...
- Give them a manager just like other KPMCore-based jobs,
so that the privileged helper can be shut off on time.
2019-06-14 23:32:34 +02:00
Adriaan de Groot
042cef0945
[partition] Make kpmcore includes consistent
2019-06-14 23:20:26 +02:00
Adriaan de Groot
c7da99d870
[partition] More includes fixes, "" instead of <>
2019-06-14 23:14:11 +02:00
Adriaan de Groot
e8408cb5b2
[partition] Fix include path type
...
- Don't use #include <> for files in the current source directory.
2019-06-14 22:59:40 +02:00
Adriaan de Groot
4df9bd8917
[partition] Use KPM manager in partitioning jobs
...
- This gives all the partition-changing jobs an easy way to
manage the lifetime of the privileged helper.
2019-06-14 22:51:35 +02:00
Adriaan de Groot
ed999a247a
[fsresizer] Use partition service
...
- Don't need to initialize KPMCore ourself.
- Simplify error paths.
2019-06-13 23:39:06 +02:00
Adriaan de Groot
d0d017f5fe
[libcalamares] Add convenience backend() to KPMManager
2019-06-13 23:39:06 +02:00
Adriaan de Groot
d039f9bbb8
[partition] Remove initKPMCore() from KPMHelpers
...
- This is a job for KPMManager, from the partition service.
- In tests, needs to be a little hackish.
2019-06-13 23:39:06 +02:00
Adriaan de Groot
a01539b664
[libcalamares] Fix memory ownership of KPMManager
...
- The InternalManager object should have at most one living
instance at a time.
- getInternal() hands out shared_ptr<>s to the one living instance,
or creates a new one.
- The creation of a new InternalManager shouldn't count as a reference
to it, and it mustn't be deleted after the shared_ptr<>s have done
their work.
- So static shared_ptr<InternalManager> was the wrong choice,
since that leads to double deletes.
- While here, be a little more chatty when loading KPMCore.
2019-06-13 23:38:50 +02:00
Adriaan de Groot
1674c81e9c
[libcalamares] Add query for kpmcore status
2019-06-13 23:38:50 +02:00
Adriaan de Groot
7adbc8cda6
[libcalamares] Add KPMCore manager
...
- This handles cleaning up KPMCore on exit
2019-06-13 23:38:50 +02:00
Adriaan de Groot
8eb04a082e
[libcalamares] Move FS-related code to partition service
...
- only moves one function right now, providing user-visible
name for filesystem name.
2019-06-13 14:55:43 +02:00
Adriaan de Groot
a7a3c4f2d8
[libcalamares] Unused include
2019-06-13 14:51:13 +02:00
Adriaan de Groot
93742a8efe
[libcalamares] Reformat new code in partition service
2019-06-13 14:47:44 +02:00
Adriaan de Groot
4b3bb54320
[libcalamares] Move partition-finding into libcalamares
...
- Moved from KPMHelpers to the partition service
- The is-partition and find-partition methods that make sense
in general, are moved to libcalamares.
2019-06-13 14:41:33 +02:00
Adriaan de Groot
3930826e93
[fsresizer] [partition] Drop special cases for kpmcore 3.3.1
2019-06-13 14:10:49 +02:00
Adriaan de Groot
9f0f08b571
[partition] Replace useless qobject_cast
...
- We know the type of the widget, but were declaring it as
a QWidget. Just forward-declare the class and be done with it.
2019-06-13 14:02:43 +02:00
Adriaan de Groot
ca9f21d805
[libcalamares] Refortmat the partition service
2019-06-13 12:35:32 +02:00
Adriaan de Groot
ebc4ebbbcc
CI: don't indent namespaces at all
2019-06-13 12:33:36 +02:00
Adriaan de Groot
4202126f34
[fsresizer] [partition] Fix build with moved headers
...
- PartitionIterator has moved into libcalamares
- While here, sort and organize #include lines
- Add using to keep code impact small
2019-06-13 12:27:39 +02:00
Adriaan de Groot
8885611ae3
[libcalamares] Fix build with non-namespaced KPMCore types
2019-06-13 12:27:21 +02:00
Adriaan de Groot
d8dc512f45
[libcalamares] Move PartitionIterator to partition service.
...
- Starting to centralize utility code for partitioning into
libcalamares instead of scattered and weirdly shared between
modules.
- This particular commit breaks compiling the modules, though.
2019-06-13 12:12:47 +02:00
Adriaan de Groot
f1822c2adb
[partition] [fsresizer] For simplicity, disallow beta KPMcore
2019-06-13 11:45:20 +02:00
Adriaan de Groot
83d296bcd0
Merge branch 'clang-format'
...
- Update coding style (more braces!) and coding documentation,
reformat parts. The idea is to go through and re-do the
coding style across the whole codebase incrementally, but
systematically, in the next release or two.
2019-06-13 11:11:01 +02:00
Adriaan de Groot
3b146d47d0
CI: Remove mention of cLog from documentation
2019-06-13 11:07:45 +02:00
Adriaan de Groot
5dfc4884b3
[calamares] Increase constness
...
- The model shouldn't change items at all.
2019-06-12 12:45:47 +02:00
Adriaan de Groot
85845c9b3e
[calamares] cLog() isn't a thing, return to cDebug()
2019-06-12 08:32:28 +02:00
Adriaan de Groot
a6d7fcdadf
[calamares] Reformat the rest of the application
2019-06-11 13:44:29 +02:00
Adriaan de Groot
9235499f7f
[calamares] Reformat the progresstree
...
- add { } to single-line blocks
- group some includes better
- lines broken at a different length, some shuffling around of
parameter lists.
2019-06-11 13:44:29 +02:00
Adriaan de Groot
8053bf6f3a
CI: use both tools for code-formatting
...
- astyle can do some things that clang-format doesn't (e.g.
adding brackets; you need clang-tidy for that),
- clang-format does a much nicer job with lambdas and certain
other constructions,
- allow passing in directories at a time for formatting.
2019-06-11 13:44:29 +02:00
Adriaan de Groot
54c3adb466
CI: add brackets to one-line blocks
...
- since we mix Python (indentation is important) with C++ (it isn't),
having indented one-line blocks which suddenly need {} when a
statment is added is confusing and error-prone. Instead, make
the blocks explicit, always, in C++.
2019-06-11 13:44:29 +02:00
Adriaan de Groot
94bea9baaf
CI: update documentation of debug-levels
2019-06-11 13:44:29 +02:00
Adriaan de Groot
0a1b27fcfa
CI: add clang-format as a tool
...
- update the style guide to require braces around blocks
- add a clang-format file that is pretty close to the
astyle configuration
2019-06-11 13:44:29 +02:00
Adriaan de Groot
39675655a0
[calamares] Tidy up include-guard comments
2019-06-11 11:17:44 +02:00
Adriaan de Groot
0d507ec265
[calamares] Tidy up application code
...
- remove commented code, fix logging around it
- misplaced include
2019-06-11 11:17:44 +02:00
Adriaan de Groot
7f968e0c83
Merge branch 'issue-1169'
...
FIXES #1169
2019-06-08 14:39:54 +02:00
Adriaan de Groot
7bda89dac4
Changes: mention issue number in the notes
2019-06-08 14:39:38 +02:00
Adriaan de Groot
1a29555ce0
Changes: document new partition setting
2019-06-08 14:39:17 +02:00
Adriaan de Groot
74432f698f
[partition] Allow the requiredStorage setting to propagate
...
- store into globalStorage if the welcome module hasn't already done so.
- this ends up used in PartUtils (via globalStorage).
2019-06-08 14:36:11 +02:00
Adriaan de Groot
20c0256932
CI: update AppImage configs
...
- Use GiB terminology like the example configs already do,
to match commit 599b34c7
2019-06-08 08:19:08 -04:00
Adriaan de Groot
e6a2cb607f
[partition] Add setting for requiredstorage
...
- If the welcome module isn't used, can set a required amount
of storage for the installation here.
2019-06-08 07:48:47 -04:00
Adriaan de Groot
b5c50c8d04
[partition] Update canBeReplaced
...
- Use GiB consistently
- Provide same kind of debugging information as canBeResized()
2019-06-07 23:19:24 +02:00
Adriaan de Groot
79934aa513
[partition] Use GiB consistently in code
2019-06-07 23:04:24 +02:00
Adriaan de Groot
962776804c
[libcalamares] Add BytesToGiB (extends BytesToMiB)
2019-06-07 23:01:18 +02:00
Adriaan de Groot
acf3dbcdcb
[partition] Refactor getting the globalStorage value
2019-06-07 22:55:50 +02:00
Adriaan de Groot
3548792d1b
[partition] Improve check canBeResized
...
- Report the globalSettings name properly (with "GiB")
- Bail out on bad conversion early.
2019-06-07 22:51:33 +02:00
Adriaan de Groot
830e67fae2
Merge branch 'issue-1168'
...
FIXES #1168
2019-06-07 21:58:51 +02:00
Adriaan de Groot
64ef331562
Changes: document bugfix
2019-06-07 21:58:35 +02:00
Adriaan de Groot
c233bbb23d
[libcalamaresui] Handle no-finished-page scenarios
...
- From an exec section, next() is called automatically when
all the jobs in that section are done.
- If there **is** no next section (e.g. there's no finished
page to show after the exec), then m_steps.at() would assert
on an out-of-range index.
- Introdcuce a helper predicate isAtVeryEnd() which handles both
out-of-range and normal at-the-end scenarios.
- If there's no page following the exec section, stay with the
slideshow but update buttons to match the normal last-page
behavior, and don't ask about cancel (since we're done).
2019-06-07 21:54:07 +02:00