Fix dangling pointers causing erratic timer behaviour (affects taskbar with spacing); use calloc instead of malloc for safer initializations
git-svn-id: http://tint2.googlecode.com/svn/trunk@758 121b4492-b84c-0410-8b4c-0d4edfb3f3cc
This commit is contained in:
committed by
mrovi9000@gmail.com
parent
778b9f0ebf
commit
66cae4bb7c
@@ -34,12 +34,12 @@ xsettings_setting_copy (XSettingsSetting *setting)
|
||||
XSettingsSetting *result;
|
||||
size_t str_len;
|
||||
|
||||
result = malloc (sizeof *result);
|
||||
result = calloc (1, sizeof *result);
|
||||
if (!result)
|
||||
return NULL;
|
||||
|
||||
str_len = strlen (setting->name);
|
||||
result->name = malloc (str_len + 1);
|
||||
result->name = calloc (str_len + 1, 1);
|
||||
if (!result->name)
|
||||
goto err;
|
||||
|
||||
@@ -57,7 +57,7 @@ xsettings_setting_copy (XSettingsSetting *setting)
|
||||
break;
|
||||
case XSETTINGS_TYPE_STRING:
|
||||
str_len = strlen (setting->data.v_string);
|
||||
result->data.v_string = malloc (str_len + 1);
|
||||
result->data.v_string = calloc (str_len + 1, 1);
|
||||
if (!result->data.v_string)
|
||||
goto err;
|
||||
|
||||
@@ -90,7 +90,7 @@ xsettings_list_copy (XSettingsList *list)
|
||||
{
|
||||
XSettingsList *new_node;
|
||||
|
||||
new_node = malloc (sizeof *new_node);
|
||||
new_node = calloc (1, sizeof *new_node);
|
||||
if (!new_node)
|
||||
goto error;
|
||||
|
||||
@@ -180,7 +180,7 @@ xsettings_list_insert (XSettingsList **list,
|
||||
XSettingsList *iter;
|
||||
XSettingsList *last = NULL;
|
||||
|
||||
node = malloc (sizeof *node);
|
||||
node = calloc (1, sizeof *node);
|
||||
if (!node)
|
||||
return XSETTINGS_NO_MEM;
|
||||
node->setting = setting;
|
||||
|
||||
Reference in New Issue
Block a user