Adriaan de Groot
502d43d111
[welcome] [partition] Rename GlobalStorage variable used for storage
...
- Change name passed into GS to use "GiB" instead of "GB", for
consistency. This needs to be done in consumers as well.
2019-05-06 16:39:14 +02:00
Adriaan de Groot
599b34c70e
[welcome] Rename GB variable to GiB
...
- User visible string with GiB
- Update documentation in welcome.conf to match code
- Rename variable because it was always GiB just named wrong
2019-05-06 16:31:23 +02:00
Adriaan de Groot
30a306f1b4
[welcome] Make check consistent with verbiage
...
SEE #1129
2019-05-06 16:18:19 +02:00
Kevin Kofler
a01d4707e1
[partition] Do not unmount /dev/mapper/live-* in ClearMountsJob
...
src/modules/partition/jobs/ClearMountsJob.cpp
(ClearMountsJob::getCryptoDevices): Skip not only `/dev/mapper/control`,
but also `/dev/mapper/live-*`. Fedora live images use
`/dev/mapper/live-*` internally. We must not unmount those devices,
because they are used by the live image and because we need
`/dev/mapper/live-base` in the `unpackfs` module.
2019-05-06 15:08:10 +02:00
Kevin Kofler
71d991e2e4
[unpackfs] Do not use -o loop
on a device
...
src/modules/unpackfs/main.py (UnpackOperation.mount_image): Check
whether entry.source is a regular file or a device and only use
`-o loop` on regular files, not devices.
At least on Fedora >= 29, `-o loop` fails on the read-only device
`/dev/mapper/live-base` (though `-o loop,ro` would be accepted).
2019-05-06 15:04:58 +02:00
Kevin Kofler
02c7fe8345
[umount]: Fix default srcLog in umount.conf
...
Also fix the introductory comment, which also contained the old
location.
2019-05-06 15:01:30 +02:00
Adriaan de Groot
44107d6c33
[finished] Actually read the new-style config value
2019-05-06 12:23:10 +02:00
Adriaan de Groot
f3c86810a1
[finished] More (display) modes for restarting
...
- Use a named enum instead of a collection of booleans
- Support old-style configuration but complain about it
- Update AppImage config as well
The new setup allows four different restart modes: never,
always, user-unchecked and user-checked. The user-modes
are interactive and give the user a choice (defaulting to
unchecked-don't-restart and checked-do-restart respectively).
The non-interactive versions vary in how they are
displayed.
2019-05-06 10:35:09 +02:00
Adriaan de Groot
e281a74552
[finished] Fix up include guards and include style
2019-05-06 10:04:28 +02:00
Adriaan de Groot
d6c7e53966
[finished] Warnings should be logged as such
2019-05-06 09:57:19 +02:00
Adriaan de Groot
ef4196dbd8
[finished] Simplify configuration code
2019-05-06 09:57:19 +02:00
Adriaan de Groot
8774b605fa
[locale] Update to use newer configuration
...
- deprecate the old entries
- use a geoip sub-map for GeoIP configuration
- polish up documentation
- drop mention of blank and "legacy" styles for GeoIP config,
just update your URLs already.
2019-05-03 11:37:12 -04:00
Adriaan de Groot
5f01a8ccc5
[oemid] If the configuration is broken, complain loudly
...
- Adds an InvalidConfiguration value for internal errors
SEE #1136
2019-05-03 09:01:19 -04:00
Adriaan de Groot
e0a79f4c0f
[partition] Reduce scope for nullptr dereference
...
- document what types are in use
- avoid at least one nullptr deref
2019-05-03 08:47:34 -04:00
Adriaan de Groot
f1ddd0c233
[welcome] Simplify configuration code
2019-05-02 14:00:32 -04:00
Adriaan de Groot
25d97efe48
[locale] Use GeoIP Handler instead of own implementation
2019-05-02 13:48:19 -04:00
Adriaan de Groot
9bc8d28800
[libcalamares] Shuffle GeoIP into a namespace
...
- Use CalamaresUtils::GeoIP for GeoIP code
- Name the public interface parts generically, while the
implementation details retain GeoIP<foo> names.
2019-05-02 07:25:48 -04:00
Adriaan de Groot
73a5e7dd62
[libcalamares] Put GeoIP in namespace
...
- Use consistent include-guard style
- Put things in namespace CalamaresUtils
2019-05-02 05:58:52 -04:00
Adriaan de Groot
ce909f00cc
[libcalamares] Drop unnecessary HAVE_XML
...
- Linking to QtXml gives us a -DQT_XML_LIB already, so use that.
2019-05-01 06:39:20 -04:00
Adriaan de Groot
a1b1ebcd29
[locale] Compile with moved GeoIP handling
2019-05-01 06:31:31 -04:00
Adriaan de Groot
9ed46fc275
[libcalamares] [locale] Adjust CMakeLists to moved code
2019-04-30 17:01:10 -04:00
Adriaan de Groot
7ec7278fd3
[libcalamares] [locale] Move GeoIP code to the library
2019-04-30 16:52:31 -04:00
Adriaan de Groot
dd33848975
[oemid] Tweak layout some more
2019-04-30 14:47:46 +02:00
Adriaan de Groot
a01262a535
CMake: massage dependency-finding
...
- If KPMCore is not found, don't require the KF5 components
that it would depend on.
- If ECM is found, use KDEInstallDirs always, not just when
the partitioning module is used.
2019-04-30 13:38:46 +02:00
Adriaan de Groot
2620829515
[webview] Make optional based on presence of dependencies
2019-04-30 13:12:16 +02:00
Adriaan de Groot
ea95913be9
[oemid] Expand documentation a little.
2019-04-29 11:25:34 -04:00
Adriaan de Groot
127c425a9a
[oemid] Write batch-identifier into standard file location
2019-04-29 11:22:53 -04:00
Adriaan de Groot
2b12bd82e4
[oemid] Stub of a Job
...
- Create job, run it, and just debug-log what it should do.
2019-04-29 10:41:33 -04:00
Adriaan de Groot
1df726fc1d
[oemid] Add summary widget text
2019-04-29 10:37:32 -04:00
Adriaan de Groot
672634547b
[oemid] Tweak UI layout
2019-04-29 10:19:28 -04:00
Adriaan de Groot
e510c829e1
[oemid] Add form explanation
2019-04-29 10:16:59 -04:00
Adriaan de Groot
ae85381aae
[oemid] Initial version of UI
2019-04-29 09:40:13 -04:00
Adriaan de Groot
96828c1df0
[oemid] Handle substitution in config-string
2019-04-29 09:03:10 -04:00
Adriaan de Groot
7d8b122835
[oemid] New module, stub
...
- OEMID is a module for configuring phase-0 things for an OEM,
like batch-ID. This is just a stub.
- Currently planned functionality is limited to just batch-ID.
2019-04-29 08:49:53 -04:00
Adriaan de Groot
8d0f076591
[libcalamares] Rename CalamaresUtils -> String
...
- The only remaining functions in the file are string-related, so
rename to match their purpose.
- Drop this include file from most places, since they don't actually
use the string functionality at all.
2019-04-29 06:49:16 -04:00
Adriaan de Groot
f076dd76ad
[libcalamares] Rename YamlUtils.h
...
- Since we have the utils/ filesystem namespace, and use CalamaresUtils::
as C++ namespace, simplify naming.
2019-04-29 06:14:21 -04:00
Adriaan de Groot
090aee9196
Modules: adjust to split-out utils/Variant.h
...
- Most modules only needed the variant support, not the "whole"
CalamaresUtils header.
- While here improve ordering of headers as well.
2019-04-29 06:14:21 -04:00
Adriaan de Groot
d2dd4fd76b
Modules: Improve error reporting
...
- Remaining modules [networkcfg] [openrcdmcryptcfg] [rawfs] with
code that throws on bad configuration. Replace with meaningful
error messages, to better check cases of SyntaxError &c.
2019-04-28 14:43:39 -04:00
Adriaan de Groot
7d0874e23b
[mount] Bail on bad config
...
- One might argue whether an empty list of partitions to mount is
a bad thing. It suggests that the partition module wasn't used,
and so we're in an OEM situation -- but then everything should
already be mounted anyway. That's why I choose empty -> bail.
2019-04-28 14:36:56 -04:00
Adriaan de Groot
ec0fe2ccd3
Modules: Improve error reporting
...
- [initcpio] remove superfluous inner function
- [initcpio] catch errors from mkinitcpio itself and report them in a nice
readable format.
- Save translators the effort of doing a dozen messages
with just the name of the module changed. All of these modules
bail out on bad configurations with a meaningful message.
- [initcpiocfg]
- [fstab]
- [initramfscfg]
- [localecfg]
- [luksbootkeyfile]
- [luksopenswaphookcfg]
- [machineid] Warn on bad config. It's conceivable that this is run
with an empty rootMountPoint (i.e. "") to modify the running system,
so only bail on None.
2019-04-28 14:34:39 -04:00
Adriaan de Groot
b8be07573b
[initramfs] Fix syntax error
2019-04-27 14:12:03 -04:00
Adriaan de Groot
e072b76fea
[shellprocess] [contextualprocess] Unneeded module.desc
...
- C++ modules should have a CMakeLists.txt which does the
right thing, e.g. calamares_add_plugin() , and don't need
a textual module.desc
2019-04-27 11:37:12 -04:00
Adriaan de Groot
6f9548af34
CMake: Check module interfaces
...
- Only allow meaningful interface strings
- Improve documentation of which interfaces work for
which module types.
2019-04-27 11:30:16 -04:00
Adriaan de Groot
cf08e59501
[localecfg] Add missing import
2019-04-27 11:04:10 -04:00
Adriaan de Groot
ca3110d429
[partition] Drop extra ; (warnings--)
2019-04-25 10:17:07 -04:00
Adriaan de Groot
e8264a4503
[partition] Prefer GPT on EFI systems for new partition table
2019-04-25 14:40:27 +02:00
Adriaan de Groot
a68a381481
[license] Fix compiler warnings
...
- out-of-order and incomplete initialization
- documentation style
- missing assignment operator
2019-04-25 14:15:14 +02:00
Adriaan de Groot
516b3b4b6c
[partition] Adjust to logging-API changes
...
- missed due to #ifdef on a KPMcore API version I don't have on
my main workstation.
2019-04-25 13:42:59 +02:00
Adriaan de Groot
3ddb49afb7
Merge branch 'issue-1061'
...
FIXES #1061
2019-04-25 06:47:32 -04:00
Adriaan de Groot
74d42fe229
[summary] Tidy scrollbar handling
...
- Handle different window-expansion strategies
2019-04-24 13:58:38 -04:00
Adriaan de Groot
3533bb3c2d
Merge branch 'master' into issue-1061
2019-04-24 12:26:01 -04:00
Adriaan de Groot
3ab9c0efdf
Merge branch 'issue-1052'
...
FIXES #1052
2019-04-24 07:06:30 -04:00
Adriaan de Groot
58770037f4
[license] Allow more things locally
...
- If it says file:, it's local (don't require a specific file
extension).
- Report actual path loaded.
2019-04-24 07:04:38 -04:00
Adriaan de Groot
ca870a6d41
[license] Update example
...
- Explain that the GPLv3 isn't actually a proprietary license, but
is used as convenient text for the license page.
- Invent a Calamares, Inc.
2019-04-24 07:03:57 -04:00
Adriaan de Groot
3608f62ec0
[license] Adjust tooltip and button texts
...
- Handle various states of the link and tool buttons,
give them appropriate texts and tooltips.
2019-04-24 06:53:31 -04:00
Adriaan de Groot
4ce6fdbd90
[license] Make area scrollable
...
- Since the list of license entries may be long (especially
if the text is expanded) make it scrollable.
2019-04-24 06:43:00 -04:00
Adriaan de Groot
f0d26a74b7
[license] Set object names
...
- This is prep-work now that the CSS styling branch has merged
2019-04-23 17:05:44 -04:00
Adriaan de Groot
08e4090354
Merge remote-tracking branch 'origin/raurodse-branding'
...
FIXES #961
2019-04-23 16:41:22 -04:00
Adriaan de Groot
982a3fb372
[license] Apply stylesheet so displayed text is nicer.
2019-04-23 08:41:32 -04:00
Adriaan de Groot
4bdae0cab0
[license] Load full license text if local
...
- Load full text, toggle display
- Swap Up and Down arrow semantics on button, to match usual
text-editor display (down means it's expanded, displayed)
2019-04-23 08:29:32 -04:00
Adriaan de Groot
92a3666dce
[license] Simplify isLocal() by using Qt method
2019-04-23 08:16:54 -04:00
Adriaan de Groot
ddf541774b
[license] Make local and external links more consistent
...
- Capitalization of message
- Add a right-pointing "open" button to external links as well
2019-04-23 04:10:43 -04:00
Adriaan de Groot
c696b5c19d
[license] Add show-license toggle button
...
- Non-functional as yet
- Toggles expand / collapse arrow and tooltip
2019-04-21 20:36:11 +02:00
Adriaan de Groot
3b7b0d6f04
Merge branch 'master' into patch-1
2019-04-21 16:55:42 +02:00
Adriaan de Groot
32ed3f6db6
[license] Add GPLv3 as an example in the license.conf
2019-04-21 14:23:56 +02:00
Adriaan de Groot
cb80d47682
[license] Move translation / retranslation to LicenseWidget
...
- Language change didn't otherwise apply to the license items
2019-04-21 13:50:06 +02:00
Adriaan de Groot
1235207ead
[license] Refactor LicenseWidget
...
- Move all the widget code into its own file
2019-04-21 13:36:28 +02:00
Adriaan de Groot
35f23c86c6
[license] Add stub LicenseWidget files
...
- Prepare for refactoring
- Clean up weirdness in the CMakeLists.txt
2019-04-21 12:43:04 +02:00
Adriaan de Groot
d2957fbad3
[license] Handle the case where all the licenses are optional
...
- If all of the licenses are optional, you should be able to
continue without accepting. Refactor to a single visible
slot to check the conditions.
- Always set the globalsettings value; to "false" on entry
to make sure it's there.
- When setting the list of entries, check the conditions
(because if the list is empty, or all of them are optional,
then it's ok to continue).
FIXES #1124
FIXES #1125
2019-04-20 15:27:00 -04:00
Adriaan de Groot
c245238b89
[license] Use standard algorithms, simplify code
...
- Introduce isRequired() for readability later
- Use std::any_of instead of rolling own loop
2019-04-20 11:58:01 -04:00
Adriaan de Groot
937f332441
[license] Refactor LicenseEntry
...
- Follow Calamares conventions for member naming
- Switch to struct since everything is public anyway
2019-04-20 11:53:16 -04:00
Adriaan de Groot
dc006d58b2
[license] Use NamedEnum
2019-04-20 11:43:19 -04:00
Adriaan de Groot
614bd3c6de
[license] Move logic to LicenseEntry class
2019-04-20 09:52:29 -04:00
Adriaan de Groot
81016667ae
[license] Change to enum class
...
- non-functional change, just chasing modern C++
2019-04-20 09:52:28 -04:00
Adriaan de Groot
f299b86a3b
[license] start to document license.conf
...
- document keys and values in a way consistent with other modules
- document **intended** use of local URLs.
2019-04-20 09:52:28 -04:00
Adriaan de Groot
e326b658ef
Enable translation in Python modules
...
- covers all the remaining Python modules
- most only get a translatable pretty name, some also return
error messages
2019-04-20 11:22:32 +02:00
Adriaan de Groot
c364e4fc38
[dracut] [fstab] Translate module names and error messages
2019-04-19 17:08:53 +02:00
Adriaan de Groot
ff6a3608a6
[mount] [networkcfg] [openrcdmcryptcfg] Translate module name
2019-04-19 17:02:03 +02:00
Adriaan de Groot
dd5c0d1629
[bootloader] Log when the bootloader-module does nothing
2019-04-19 16:47:53 +02:00
Adriaan de Groot
333f0d9215
[bootloader] Simplify finding the ESP
2019-04-19 16:43:07 +02:00
Adriaan de Groot
df37c51c1e
[bootloader] [hwclock] Translate module name
2019-04-19 16:39:41 +02:00
Adriaan de Groot
c44e221fb6
Merge branch 'issue-1107'
...
FIXES #1107
2019-04-19 16:27:19 +02:00
Adriaan de Groot
81acc496dc
[welcome] Introduce a delegate for drawing the languages list
...
- Show the native name left, English name right
2019-04-19 13:40:28 +02:00
Adriaan de Groot
0b833b1e75
[welcome] Switch model to a list model
...
- There doesn't seem to be a real benefit to providing the
name and label as separate columns.
2019-04-19 11:38:43 +02:00
Adriaan de Groot
53fd1590b8
[welcome] Don't use combobox itemdata for locale information
2019-04-19 10:24:10 +02:00
Adriaan de Groot
e5d1c0ae27
[welcome] Fix matched-with-a-locale
...
- Previously the matchLocale() function set the index in the
combobox; do it separately now.
2019-04-19 10:15:57 +02:00
Adriaan de Groot
57452b8c38
[locale] [welcome] Adjust to moved LocaleLabel
...
- Adjust #includes
- In [welcome], use find() on the model rather than querying
the combo-box.
2019-04-19 10:10:36 +02:00
Adriaan de Groot
0c868dbd17
[welcome] Another find() overload
...
- Also find a specific locale
- While here, apply Calamares coding style
2019-04-19 09:39:19 +02:00
Adriaan de Groot
314aee8d68
[welcome] Switch to QVector
...
- QVector is a better match with passing in QStringList, otherwise
you end up dealing with Qt's int indexes vs. std::vector's uint
indexes everywhere.
- Introduce find()
2019-04-19 09:31:16 +02:00
Adriaan de Groot
94765d40cd
[welcome] Switch to using LocaleModel for language combobox
...
- Use the model instead of inserting items
- While here, tidy includes and documentation
2019-04-18 23:17:49 +02:00
Adriaan de Groot
589168685e
[welcome] Complete LocaleModel implementation
...
- It's a table with two columns (localized name and english name)
2019-04-18 23:16:02 +02:00
Adriaan de Groot
7f8411c3b7
[welcome] Add standard language-chooser icon
...
- After discussion with Red Hat UI advice, switch to standard icon
- Tooltip as well
2019-04-18 22:38:12 +02:00
Adriaan de Groot
f04d084548
[welcome] Start on a model for the locale choices
2019-04-18 14:27:37 +02:00
Adriaan de Groot
c99742bc70
Merge pull request #1127 from a-wai/partition-layout-size-checks
...
Add various checks for partition layout configuration
2019-04-18 13:48:50 +02:00
Adriaan de Groot
cf51eb7aab
[keyboard] Apply source formatting
...
- Move errant attribution line to the copyright headers;
unsure of the year though.
- Apply Calamares coding style.
2019-04-18 13:41:42 +02:00
Adriaan de Groot
118f9255fd
[keyboard] Refactor sectioning
...
- Look for section in a consistent fashion
- Simplify parsing loops
2019-04-18 13:36:12 +02:00
Adriaan de Groot
fa70b3aa60
[keyboard] Refactor keyboard model loading
...
- Don't need private static methods
- Pass char* if that's what we've got
2019-04-18 13:22:12 +02:00
Adriaan de Groot
3c014a868c
[keyboard] Make keyboard preview more robust
...
- Replace #define with static const char
- Handle FreeBSD as well (for testing purposes)
2019-04-18 13:06:50 +02:00
Adriaan de Groot
b704933b58
[keyboard] Avoid crash with unconfigured keyboards
...
- If there's no items at all, ->currentItem() can return nullptr,
so don't dereference that.
Found on FreeBSD.
2019-04-18 12:56:56 +02:00
Adriaan de Groot
a1e08d2236
[keyboard] Don't use useless rvalue-ref
...
- Weird && usage here made redundant through RVO, just return
something normally instead.
2019-04-18 12:06:17 +02:00