Gaël PORTAY
db7cf74034
[partition] Remove the call the method contains
...
- The variant helper getString() calls contains() already.
2020-10-30 09:17:12 -04:00
Gaël PORTAY
d6ea30b23e
[partition] Move initLayout logic to object PartitionLayout
...
- The logic of the method initLayout belongs to the object
PartitionLayout. Move logic to that object.
- Use a single method initLayout in object PartitionCoreModule.
- Member m_partLayout in object PartitionCoreModule is no longer
allocated.
2020-10-30 09:17:12 -04:00
Gaël PORTAY
eae1e90dce
[partition] Remove unused PartitionLayout constructor
...
- The constructor PartitionLayout with PartitionEntry appears to be
unused since its always. Drop it!
2020-10-30 09:17:12 -04:00
Gaël PORTAY
f2960366c8
[partition] Remove unused addEntry method
...
- The method addEntry with PartitionEntry appears to be unused since its
always. Drop it!
2020-10-30 09:17:12 -04:00
Adriaan de Groot
478c394d99
[partition] Don't needlessly expose a test symbol
2020-10-25 17:49:26 +01:00
Adriaan de Groot
84936a95fc
[libcalamaresui] Warnings-- for Qt 5.15 deprecations
...
Introduce a GUI-oriented compatibility header that introduces aliases
for some enum values that are deprecated in Qt 5.15
2020-10-24 13:00:48 +02:00
Adriaan de Groot
27f6eaaf75
[partition] Remove unused variables
2020-10-24 02:24:37 +02:00
Adriaan de Groot
89b1f8d96b
[partition] Warnings-- in tests related to virtual destructors
2020-10-24 02:21:32 +02:00
Adriaan de Groot
01b75ef4b5
[partition] Use C++-style cast
2020-10-24 02:19:05 +02:00
Adriaan de Groot
6605e11394
[partition] Warnings-- in test: don't expose internal variable
2020-10-24 02:05:14 +02:00
Adriaan de Groot
d7e64de24a
[partition] Adjust docs to function
...
- @params referring to things that don't exist
- @brief that is 3 lines long
2020-10-23 23:14:00 +02:00
Adriaan de Groot
eb8e95bb87
[partition] Warnings--, explain why we're using a void*
2020-10-23 22:39:05 +02:00
Adriaan de Groot
9910b23152
[partition] Avoid uninitialized variable
...
- if the partition size is invalid, then warn about it but do
not print the (uninitialized) size of the partition.
- shuffle code to continue earlier, allowing the "good path"
code to be out-dented.
2020-10-23 22:34:53 +02:00
Adriaan de Groot
687a795b71
[partition] Warnings-- by initialization order
2020-10-23 22:31:22 +02:00
Adriaan de Groot
44a11bd93b
[partition] Initialize in the initializer list, if possible
2020-10-23 22:27:30 +02:00
Adriaan de Groot
51b47862cd
[partition] Mark destructors override
...
This reduces compiler warnings related to virtual-overriding
functions: all the destructors are virtual.
2020-10-23 22:23:10 +02:00
Gaël PORTAY
d91683eec6
[partition] Fix message user if no option available
...
The button m_eraseButton is not tested while the button
m_somethingElseButton is tested twice.
2020-10-22 13:23:36 -04:00
Adriaan de Groot
27dc81f8b9
[partition] Fix typo in debug message, reported by Kevin Kofler
2020-10-17 16:41:08 +02:00
Adriaan de Groot
36396d0cfd
[partition] Adjust message and fix debug message
2020-10-16 22:32:32 +02:00
Yuri Chornoivan
1448a9b9a1
Add missing space
2020-10-15 20:55:37 +03:00
Adriaan de Groot
a955791766
Apply coding style globally again
2020-10-12 14:27:01 +02:00
Adriaan de Groot
1df4239c02
Merge pull request #1436 from gportay/osprober-strip-extra-file-after-at-sign
...
[partition] Strip extra file after the at sign
2020-10-12 13:33:10 +02:00
Gaël PORTAY
2b1e516ec1
[partition] Strip extra file after the at sign
...
- os-proper may return an extra file after the device:
/dev/sda1:Ubuntu 19.10 (19.10):Ubuntu:linux
/dev/sdb1@/EFI/Microsoft/Boot/bootmgfw.efi:Windows Boot Manager:Windows:efi
2020-10-07 09:57:18 -04:00
Gaël PORTAY
2bbbb68838
[partition] Add setting for requiredPartitionTableType
2020-10-07 08:10:24 -04:00
Gaël PORTAY
70f8beb931
[partition] Add setting for defaultPartitionTableType
2020-10-06 20:46:17 -04:00
Adriaan de Groot
9486ee6fbf
Merge pull request #1524 from gportay/partition-message-user-if-no-option-available
...
[partition] Message user if no option available
2020-10-07 01:32:13 +02:00
Adriaan de Groot
40aa0fcaba
CMake: add a helper module for finding KPMcore
...
I think we had this (kind of) module a long time ago and it was
removed for over-complicating things; re-introduce one now that
KPMcore is used in 3 different places and all would benefit
from consistent API handling / defines.
2020-10-07 00:11:18 +02:00
Adriaan de Groot
db537535ee
[partition] Support KPMCore 3.3 in tests
2020-10-06 23:51:30 +02:00
Adriaan de Groot
f28d28a455
[partition] Ignore KPMCore 4 beta versions
2020-10-06 23:49:11 +02:00
Adriaan de Groot
88b1d36009
Merge branch 'issues-1166' into calamares
...
FIXES #1166
2020-10-06 22:25:33 +02:00
Corentin Noël
a7bd1040c5
[partition] Add tests for Layout-constrained partionning
2020-10-06 17:48:12 +02:00
Adriaan de Groot
77e2701365
[partition] Coding style
...
- various clang-format versions battle for supremacy
2020-10-06 17:21:54 +02:00
Adriaan de Groot
b4cbf73e2d
Merge branch 'calamares' into issues-1166
2020-10-06 17:19:14 +02:00
Adriaan de Groot
0b3a6baeea
[fstab] If swap is "file" then create it here
...
- handle swapfiles when writing /etc/fstab in the target system
- special-case mountpoint
- since swapfiles are not a partition, take the setting out
of partitionChoices
- create the physical swapfile as well (there's no other place
where it would make sense)
2020-10-06 17:05:22 +02:00
Adriaan de Groot
029c3f1c74
[partition] Write the install choices to Global Storage
2020-10-06 15:54:26 +02:00
Adriaan de Groot
92a874dae7
[partition] move the swap-choice to Config
2020-10-06 15:44:14 +02:00
Corentin Noël
08138f5a41
[partition] Reduce direct dependency of PartUtils on PartitionCoreModule
2020-10-06 14:28:20 +02:00
Gaël PORTAY
79740c77a3
[partition] Message user if no option available
2020-10-06 04:10:27 -04:00
Adriaan de Groot
6e30a7b8f6
[partition] Move is-manual-partitioning-allowed to the Config object
2020-10-02 13:04:12 +02:00
Adriaan de Groot
f79fbd4105
[partition] Add swap choice to config object
2020-10-02 12:40:13 +02:00
Adriaan de Groot
0f4fe6294c
[partition] Migrate type for SwapChoice to Config object
2020-10-02 12:22:53 +02:00
Adriaan de Groot
881661e94b
[partition] Migrate InstallChoice to the Config object
2020-10-02 12:08:42 +02:00
Corentin Noël
0293015b09
[partition] Fix regression in partition size assignment
...
In some cases, the partition size was set to zero as the maxSize isn't always defined.
2020-10-01 15:38:18 +02:00
Adriaan de Groot
010526ee2a
[partition] Coding style
2020-09-29 14:04:12 +02:00
Adriaan de Groot
b41e4624c9
[partition] Move 'selected installation option' to Config
2020-09-29 14:00:49 +02:00
Adriaan de Groot
10d194d693
[partition] Simplify button-selection
2020-09-29 12:22:50 +02:00
Adriaan de Groot
a92cb32cef
[partition] set the right buttons if an action is pre-selected
2020-09-28 17:46:42 +02:00
Adriaan de Groot
b518ef7dfe
[partition] Select initial swap choice
2020-09-28 15:37:12 +02:00
Adriaan de Groot
9f0f600aa4
[partition] Remove the 'swapfile-unsupported' message
2020-09-28 14:53:38 +02:00
Adriaan de Groot
3bb5adcfca
[partition] Simplify *efiSystemPartition* settings
2020-09-28 14:52:18 +02:00