Adriaan de Groot
c44e221fb6
Merge branch 'issue-1107'
...
FIXES #1107
2019-04-19 16:27:19 +02:00
Adriaan de Groot
cb5825a521
[libcalamares] English label with country
2019-04-19 13:52:19 +02:00
Adriaan de Groot
81acc496dc
[welcome] Introduce a delegate for drawing the languages list
...
- Show the native name left, English name right
2019-04-19 13:40:28 +02:00
Adriaan de Groot
0b833b1e75
[welcome] Switch model to a list model
...
- There doesn't seem to be a real benefit to providing the
name and label as separate columns.
2019-04-19 11:38:43 +02:00
Adriaan de Groot
53fd1590b8
[welcome] Don't use combobox itemdata for locale information
2019-04-19 10:24:10 +02:00
Adriaan de Groot
e5d1c0ae27
[welcome] Fix matched-with-a-locale
...
- Previously the matchLocale() function set the index in the
combobox; do it separately now.
2019-04-19 10:15:57 +02:00
Adriaan de Groot
57452b8c38
[locale] [welcome] Adjust to moved LocaleLabel
...
- Adjust #includes
- In [welcome], use find() on the model rather than querying
the combo-box.
2019-04-19 10:10:36 +02:00
Adriaan de Groot
58aa9f4989
[libcalamares] Move LocaleLabel from libcalamaresui to libcalamares
...
- This isn't a UI-dependent class
- Doesn't make much sense in CalamaresUtilsGui either
2019-04-19 10:04:49 +02:00
Adriaan de Groot
242d756731
[libcalamaresui] Add convenience name() to LocaleLabel
2019-04-19 09:55:51 +02:00
Adriaan de Groot
0c868dbd17
[welcome] Another find() overload
...
- Also find a specific locale
- While here, apply Calamares coding style
2019-04-19 09:39:19 +02:00
Adriaan de Groot
314aee8d68
[welcome] Switch to QVector
...
- QVector is a better match with passing in QStringList, otherwise
you end up dealing with Qt's int indexes vs. std::vector's uint
indexes everywhere.
- Introduce find()
2019-04-19 09:31:16 +02:00
Adriaan de Groot
bd0af4bb77
[libcalamaresui] Give LocaleLabel a default constructor
...
- Needed for use in containers
- While here refactor building the english label
2019-04-19 09:18:26 +02:00
Adriaan de Groot
94765d40cd
[welcome] Switch to using LocaleModel for language combobox
...
- Use the model instead of inserting items
- While here, tidy includes and documentation
2019-04-18 23:17:49 +02:00
Adriaan de Groot
589168685e
[welcome] Complete LocaleModel implementation
...
- It's a table with two columns (localized name and english name)
2019-04-18 23:16:02 +02:00
Adriaan de Groot
7f8411c3b7
[welcome] Add standard language-chooser icon
...
- After discussion with Red Hat UI advice, switch to standard icon
- Tooltip as well
2019-04-18 22:38:12 +02:00
Adriaan de Groot
f04d084548
[welcome] Start on a model for the locale choices
2019-04-18 14:27:37 +02:00
Adriaan de Groot
c99742bc70
Merge pull request #1127 from a-wai/partition-layout-size-checks
...
Add various checks for partition layout configuration
2019-04-18 13:48:50 +02:00
Adriaan de Groot
cf51eb7aab
[keyboard] Apply source formatting
...
- Move errant attribution line to the copyright headers;
unsure of the year though.
- Apply Calamares coding style.
2019-04-18 13:41:42 +02:00
Adriaan de Groot
118f9255fd
[keyboard] Refactor sectioning
...
- Look for section in a consistent fashion
- Simplify parsing loops
2019-04-18 13:36:12 +02:00
Adriaan de Groot
fa70b3aa60
[keyboard] Refactor keyboard model loading
...
- Don't need private static methods
- Pass char* if that's what we've got
2019-04-18 13:22:12 +02:00
Adriaan de Groot
3c014a868c
[keyboard] Make keyboard preview more robust
...
- Replace #define with static const char
- Handle FreeBSD as well (for testing purposes)
2019-04-18 13:06:50 +02:00
Adriaan de Groot
b704933b58
[keyboard] Avoid crash with unconfigured keyboards
...
- If there's no items at all, ->currentItem() can return nullptr,
so don't dereference that.
Found on FreeBSD.
2019-04-18 12:56:56 +02:00
Adriaan de Groot
fd5097c466
Merge branch 'reduce-warnings'
2019-04-18 12:42:10 +02:00
Adriaan de Groot
3e88b408fa
[calamares] Remove unused item Role
2019-04-18 12:40:04 +02:00
Adriaan de Groot
3ccbcdc1bd
[libcalamares] Don't moc on JobQueue
...
- There is no reason for JobThread to have a Q_OBJECT macro,
so drop the moccing (this also stops some warnings from
the generated moc code).
- Define the (virtual) destructor out-of-line to avoid vtable
warnings.
2019-04-18 12:21:29 +02:00
Adriaan de Groot
a1e08d2236
[keyboard] Don't use useless rvalue-ref
...
- Weird && usage here made redundant through RVO, just return
something normally instead.
2019-04-18 12:06:17 +02:00
Adriaan de Groot
123c774a47
Use new automoc options
2019-04-18 12:06:16 +02:00
Adriaan de Groot
bdb7bf71a8
Reduce warnings from moc-generated code
...
- The auto-generated code produces a lot of warnings from
Clang 8; this obscures the more meaningful warnings from
actual Calamares code, so tone the warnings down.
- For Clang, set CALAMARES_MOC_OPTIONS.
- Add convenience CMake function for automoccing. It applies
the options as needed to a given target.
2019-04-18 12:06:09 +02:00
Adriaan de Groot
cef2f50510
Reduce warnings about extra ;
...
- Trailing ; after Q_UNUSED
- Trailing ; after CALAMARES_RETRANSLATE
2019-04-18 12:06:09 +02:00
Adriaan de Groot
c83395ff6d
Reduce warnings for yaml-cpp
...
- Use only utils/YamlUtils.h to pull in yaml-cpp and supporting code.
- When compiling with clang, turn off warnings that the system header
for yaml-cpp would generate.
2019-04-18 12:06:09 +02:00
Adriaan de Groot
27140ff5bb
[libcalamares] Reduce warnings in KDAB code
...
- This is an older copy of kdsingleapplicationguard, now updated for
C++11 warnings; removed __ in header guards, fixed up last of 0-for-
nullptr, signedness mismatch.
2019-04-18 12:06:09 +02:00
Arnaud Ferraris
123222c0a8
Add global checks for partition layout
...
This commit adds several checks while reading the configuration of the
`partition` module, in case the partition layout configuration is
misformed. If an error is encountered, an message is printed to the
console and the module reverts to the default partition layout.
Checks are also added when implementing the partition layout, in case a
problem occurs that couldn't be anticipated (for example, when a
partition size is in %, checking its absolute value require knowing the
total device size, which is not the case when the configuration is
being read).
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.com>
2019-04-18 10:55:47 +02:00
Arnaud Ferraris
d32733bf59
Switch to using PartSize class for partition sizes
...
Every call of `ParseStringSize` is replaced by using an instance of the
`PartUtils::PartSize` class.
This commit also removes the now-unused previous size parsing functions.
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.com>
2019-04-18 10:55:47 +02:00
Arnaud Ferraris
3a58ae5e8b
Introduce new partition size class based on NamedSuffix
...
In order to maintain consistency, and make use, create a new PartSize
class in the PartUtils namespace, which inherits from NamedSuffix for
easier parsing and handling of size strings.
The switch to using this class instead of the previous functions will be
done in a follow-up commit.
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.com>
2019-04-18 10:55:47 +02:00
Arnaud Ferraris
680b0bc472
Add missing header to NamedEnum
...
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.com>
2019-04-18 10:55:47 +02:00
Adriaan de Groot
92b60dac65
[libcalamares] Warnings-- over extra ;
2019-04-17 12:02:14 +02:00
Adriaan de Groot
620940c75b
[libcalamaresui] Drop now-unused sortKey from LocaleLabel
...
- sortKey is unused
- add englishLabel for reverse-i18n
2019-04-16 23:49:27 +02:00
Adriaan de Groot
5e951466df
[libcalamaresui] Sort languages by ISO code
...
- this puts the Englishes together, and is less confusing than
sorting with American first.
2019-04-16 15:38:06 +02:00
Adriaan de Groot
5994e9b4ce
Changes: document what this branch will do
2019-04-16 15:34:09 +02:00
Adriaan de Groot
1f66062c81
CMake: bump version, new stub in CHANGES
2019-04-15 11:27:25 -04:00
Adriaan de Groot
c6d51f2527
CHANGES: Fix release date of 3.2.5
2019-04-15 11:25:51 -04:00
Adriaan de Groot
44de004068
CHANGES: Fix up Caio's name
2019-04-15 11:25:23 -04:00
Adriaan de Groot
329bd36929
[libcalamares] Sanitize logging
2019-04-15 10:59:57 -04:00
Adriaan de Groot
93be1a6582
[partition] Remove confusing spaces in logging
2019-04-15 10:16:09 -04:00
Adriaan de Groot
dbac9ecf7b
[partition] Remove unused code
...
- The name table is in PartitionActions::Choices
2019-04-15 10:14:37 -04:00
Adriaan de Groot
d2404851cd
[partition] Reduce warnings (shadow, ;, types)
2019-04-15 10:06:21 -04:00
Adriaan de Groot
1a4a265262
[partition] Refactor check for ISO9660
2019-04-15 10:06:03 -04:00
Adriaan de Groot
75f1a05fec
[partition] No copy-constructor for CDebug
2019-04-15 10:05:29 -04:00
Adriaan de Groot
009dfd7de5
[locale] Reduce warnings (shadowed global)
2019-04-15 10:03:12 -04:00
Adriaan de Groot
094110dccf
CI: make the release script more flexible
2019-04-15 09:52:43 -04:00