napcok/calamares
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
10,082 Commits 8 Branches 95 Tags 88 MiB
af813ac95b
Commit Graph

7506 Commits

Author SHA1 Message Date
Adriaan de Groot
db3160145e Merge remote-tracking branch 'origin/issue-1904' into calamares 
This is mostly a confirmation that the subsequent changes
to #1905 were correct; the "name" key set in a partition
configuration is applied to the partition.

FIXES #1904
 2022-03-21 15:09:50 +01:00
Adriaan de Groot
6f28120401 [partition] Fix typo in example configuration 2022-03-21 14:16:54 +01:00
Adriaan de Groot
1ee82e390b [users] Adjust test to expect root to succeed 2022-03-21 14:15:15 +01:00
Adriaan de Groot
88d392f612 [users] Explain why the second setting-hostname test succeeds. 2022-03-21 14:12:18 +01:00
Adriaan de Groot
9b651b4f00 [users] Don't mangle the hostname with a test 2022-03-21 14:08:17 +01:00
Adriaan de Groot
f4a10a313c [partition] Address default-labeling issues 2022-03-18 14:35:35 +01:00
Adriaan de Groot
7d89643146 [partition] More const in getters 2022-03-18 14:30:31 +01:00
Adriaan de Groot
fa28999561
Merge pull request #1905 from santoshmahto7/santo/avoid-root-naming 
Avoid setting rootfs partition name to "root" by default.
 2022-03-18 13:51:33 +01:00
Decator
b2aa5d8dea
Added spaces and line-breaks to fix formatting. 
Fixes a formatting issue by adding some spaces and a line-break. Increases readability
 2022-03-15 10:43:10 -04:00
Adriaan de Groot
b44091b4e3 SPDX: tag forgotten files 2022-03-15 14:59:05 +01:00
Adriaan de Groot
05468016a1 Merge branch 'work/adridg/improve-log-window' into calamares 2022-03-15 14:45:34 +01:00
Adriaan de Groot
f0d4788e6d [libcalamaresui] SPDX-tagging for Bob 2022-03-15 14:42:27 +01:00
Adriaan de Groot
28bf8478c4 [libcalamaresui] Simplify log-window 
Scrolling explicitly to the bottom isn't needed; leaving it
up to appendPlainText() has the following behavior:

- if the text is scrolled all the way down, follows the text
  and scrolls further down (tailing)
- if it is not scrolled all the way down, keeps current position.
 2022-03-15 14:39:59 +01:00
Adriaan de Groot
d998c9e24b [libcalamaresui] Try to improve 'tailing' experience 2022-03-15 14:02:24 +01:00
Adriaan de Groot
26a613fff1 Merge branch 'issue-1894' into calamares 
FIXES #1894
 2022-03-15 13:30:40 +01:00
Adriaan de Groot
1a3f41ff33 [libcalamaresui] Allow more options for icon 2022-03-15 12:45:19 +01:00
Adriaan de Groot
d5e0fca490 [libcalamaresui] Allow starting and stopping the log-follower. 2022-03-15 12:45:19 +01:00
Adriaan de Groot
87c8c3e6ee [libcalamaresui] Convenience for 'give-me-one-of-these-icons' 2022-03-15 12:44:19 +01:00
Adriaan de Groot
20c44ff99a [partition] Obtain flag name from KPMCore 
- makes the displayed flag name consistent between dialog and
  pop-up and debug-messages.
 2022-03-14 16:45:56 +01:00
Adriaan de Groot
1a6fb1c3d2 [libcalamaresui] Polish on LogWidget 
- apply coding style
- reduce shadowed variables
- use Q_EMIT to mark signals
 2022-03-14 16:14:40 +01:00
Adriaan de Groot
d89955f4b3
Merge pull request #1899 from bobvanderlinden/pr-log 
allow viewing live log during execution
 2022-03-14 14:19:43 +01:00
Adriaan de Groot
f60def5ecc [partition] Don't reinitialize partition layout 
Existing code reinitialized the layout, losing whatever
layout was set in the config. Refactor so that you can
access the partition-layout API, and change the default
FS through that -- which is the point of the code block
here in `doAutopartition()`, to look up the currently-
selected default FS.

Inspired by Santosh's work in #1903, #1759.
 2022-03-14 11:27:00 +01:00
Santosh Mahto
4b905d5b52 Avoid setting rootfs partition name to "root" by default. 
By default, calamares renames the label of root partition
to "root" overriding the name specified in partiton.conf

Signed-off-by: Santosh Mahto <santosh.mahto@collabora.com>
 2022-03-14 12:01:06 +05:30
dalto
b5faf1be9b [fstab] Fix empty UUID detection 2022-03-12 15:47:54 -06:00
Bob van der Linden
ea061ae239
destruct LogThread correctly 2022-03-10 20:33:22 +01:00
Bob van der Linden
9e522eddf8
replace text widget with log widget 2022-03-10 20:08:13 +01:00
Bob van der Linden
923379def6
use terminal icon for log toggle button 2022-03-10 20:07:16 +01:00
Bob van der Linden
53d3fcb2fd
introduce widget that shows logs 2022-03-10 20:06:37 +01:00
Bob van der Linden
a6afb6be7c
add log widget to ExecutionViewStep 2022-03-06 12:33:06 +01:00
Adriaan de Groot
569db7c018 [packages] Disable pacman progress-reporting, it is crashy 2022-03-04 14:28:07 +01:00
Huang Jia Wen
dca5d9b52b [bootloader] Add loongarch64 support for bootloader 2022-03-04 10:57:38 +01:00
Adriaan de Groot
7aafeec2cb [libcalamares] Fix entry-format, it was totally bogus 2022-03-01 16:14:45 +01:00
Adriaan de Groot
2f782f18c4 [libcalamares] Fix file reading 
- atEnd() doesn't behave as expected
- drop the textstream, not needed
- rename variables to be more descriptive
 2022-03-01 16:13:25 +01:00
Adriaan de Groot
53c4bbe4e0 [umount] Log briefly what is going to be unmounted 2022-03-01 16:03:28 +01:00
Adriaan de Groot
4fe55533d7 [partition] Log in more human-readable form 2022-03-01 14:37:52 +01:00
Adriaan de Groot
60630efa6a [partition] Log DBus calls and switch to blocking calls to ensure they happen 2022-03-01 14:03:04 +01:00
Adriaan de Groot
7e51731167 [partititon] Slightly better debug-logging for automount 2022-03-01 13:52:50 +01:00
Adriaan de Groot
c5fec83f64 [libcalamares] Fix typo 2022-02-28 11:30:36 +01:00
Adriaan de Groot
f2a6736883 [libcalamares] More chatty when DBus fails 2022-02-28 11:29:45 +01:00
Adriaan de Groot
5b40f17b9c [libcalamares] Prep-work for supporting non-Solid automounting 2022-02-28 11:26:57 +01:00
Calamares CI
05991c9ee9 i18n: [dummypythonqt] Automatic merge of Transifex translations 2022-02-25 14:11:58 +01:00
Adriaan de Groot
c3224e60d6 [users] Add a switch to write different styles of sudo file 2022-02-21 15:49:10 +01:00
Adriaan de Groot
c1f1934c27 Merge branch 'issue-1883' into calamares 
FIXES #1883
 2022-02-21 15:07:58 +01:00
Adriaan de Groot
23f501c071 [fstab] Recognize mmc and nvme disks correctly 
- basename() returns the last path component, so never includes
  the leading '/dev/'
- the check for mmc and nvme looked for device names starting
  with '/dev/mmc' .. but '/dev/' has just been stripped away
  by the call to basename, so this never matched
- stripped the trailing digits rather than trailing 'p[0-9]',
  so 'nvme0n1p2' became 'nvme0n1p' which isn't a useful
  device name.

FIXES #1883
 2022-02-21 15:03:51 +01:00
Adriaan de Groot
92f4ab30ea [partition] Add a note and an icon about unusually-configured partition module 2022-02-21 13:00:40 +01:00
Adriaan de Groot
682ae24b7d [partition] Introduce skipping-partitioning-jobs 
Don't do the actual KPM work, but pretend that they were done.
This can be useful -- independently of the existing unsafe-
options and failing partitioning entirely -- for testing
partition layouts in modules following the *partition* one.
 2022-02-21 12:39:56 +01:00
Adriaan de Groot
7129a2239c [partition] Tidy up description in prettyStatus 
- the length parameter to diskDescription() is worse than
  useless, because it doesn't say anything about what will
  be done if there's more than one disk.
 2022-02-21 12:30:34 +01:00
Adriaan de Groot
f04f0a7e1d [partition] Remove unused text 2022-02-21 12:13:11 +01:00
Adriaan de Groot
99d11f754f [partition] Tighten up determining job labels for description 2022-02-21 12:12:20 +01:00
Adriaan de Groot
62888f7984 [partition] Rename setting to BAIL_OUT 
- unsafe partitioning will bail out (and end the installation)
  if BAIL_OUT is set (previously _LAME).
 2022-02-21 11:56:41 +01:00
Adriaan de Groot
240c89c585
[luksbootkeyfile] Merge pull request #1888 from dalto8/trailingslash 
Ensure that a trailing slash doesn't cause issues with an unencrypted /boot
 2022-02-21 11:43:11 +01:00
Adriaan de Groot
b1742876fd [zfs] Correct user-visible spelling of ZFS 
In Camel-cased source code, Zfs, but for user-visible strings,
ZFS (or zfs, but needs to be consistent).
 2022-02-17 15:51:15 +01:00
dalto
f34008b518 [LuksBootKeyFile] Remove trailing slashes when matching mountpoint 2022-02-16 16:21:52 -06:00
Adriaan de Groot
9f6f82405b [libcalamaresui] Avoid crash if modules-list is empty 
If there are no modules at all before an exec: section is
reached (e.g. right now due to a bug in module-loading)
then the last() call would crash. Instead, use a nullptr
for the last-module-loaded.

While here, apply code-formatting.
 2022-02-07 19:05:55 +01:00
Adriaan de Groot
932ab17c9a [libcalamares] Avoid parameter name 'stdin' 2022-02-07 12:54:16 +01:00
Adriaan de Groot
ebdcb15703 [libcalamares] Don't use reserved identifiers 2022-02-07 12:51:22 +01:00
Adriaan de Groot
660b198da0 [libcalamares] Avoid more moc warnings with recent Clang 2022-02-07 12:51:06 +01:00
Adriaan de Groot
fa7394723c [users] Don't mess up cursor position when typing hostname 
If the hostname changes while the field has focus, that means
that the user is typing in the field, and we shouldn't mess
with the cursor position.

FIXES #1884
 2022-02-07 11:51:48 +01:00
Adriaan de Groot
3ea25a901e [libcalamares] Avoid compiler warnings when stdin is defined to something else 2022-02-07 11:32:22 +01:00
Adriaan de Groot
d5c6a70442 [libcalamares] Use signed sizes 2022-02-07 11:22:13 +01:00
Adriaan de Groot
0fff01e36e [partition] Use signed sizes 
Unfortunate effect of having ints in some parts of the API
is that signedness trickles down everywhere; either cast
all over, or stick to signed ints.
 2022-02-07 11:21:53 +01:00
Adriaan de Groot
9127b76e5f [bootloader] Fix typo's 2022-02-01 16:49:18 +01:00
Adriaan de Groot
cf913b87ff [partition] Apply coding style 
This applies the new(er) style to the whole module,
rather than just the files that recently changed.
 2022-02-01 16:35:19 +01:00
Adriaan de Groot
7f90b99388 [partition Simplify mountpoint-input 
- if nothing is selected (index -1, which now shows the placeholder), the text is empty
- if something has been entered, return it (e.g. if the user is typing)
- if something is selected, the text gets set to that anyway
 2022-02-01 16:01:04 +01:00
Adriaan de Groot
f4720ae02c [partition] <pre> formatting is block-oriented 2022-02-01 14:54:49 +01:00
Adriaan de Groot
45fff23499 [partition] Move message closer to input field 
The warning about the mount point -- that it was in-use or
invalid -- had been separated from the drop-down by the
FSLabel field. Move it back, rename the variable for
clarity while we're at it.
 2022-02-01 14:50:53 +01:00
Adriaan de Groot
82dcc1b57b [partition] Refactor common validate-the-mount-point logic 2022-02-01 14:42:18 +01:00
Adriaan de Groot
d8be9a9443 [partition] Mount points should start with a / 2022-02-01 14:07:38 +01:00
Adriaan de Groot
fbcd1ffbbe [partition] Make the "no mount point" a placeholder 2022-02-01 14:06:30 +01:00
Adriaan de Groot
d8c875f351 [partition] UI-tweak mount-point and fs-label boxes 
- make the boxes expand, rather than stick to a minimum
  size that doesn't align with other boxes in the dialog,
  and which may be too small to contain the text they display.
 2022-02-01 13:13:29 +01:00
Adriaan de Groot
6f738813a6 [fstab] GS configuration for a btrfs setup 2022-02-01 12:15:49 +01:00
Adriaan de Groot
4a30aae9bb [calamares] Tighten logging in 'loadmodule' test-executable 2022-02-01 12:15:49 +01:00
Adriaan de Groot
e9899d0345 [packagechooser,netinstall] Apply coding style 2022-01-31 23:42:20 +01:00
Adriaan de Groot
ffeab32403 [libcalamares] Apply coding style 2022-01-31 23:41:37 +01:00
Adriaan de Groot
80300e412c [libcalamares] When logging extra lines to warning or error, suppress label 
Avoid logs like

23:29:57 [2]: void Config::setConfigurationMap(const QVariantMap&)
    WARNING: Configuration for *initialSwapChoice* is not one of the *userSwapChoices*
WARNING:    .. Choice "small" added.

where the label is duplicated.
 2022-01-31 23:27:35 +01:00
Adriaan de Groot
51f67f6c3e [partition] If initialSwapChoice can't be satisfied, add it 
There is a mismatch between how the configuration interprets
*initialSwapChoice* when it is not a valid choice, and how
the UI interprets it. If you e.g. do not have a *userSwapChoices*
setting at all, whatever *initialSwapChoice* is set is interpreted
by the UI as "suspend".

Avoid that by putting the choice in the configuration and
warning the user (which ought to be a warning to the distro).

FIXES #1881
 2022-01-31 23:15:04 +01:00
Adriaan de Groot
cf2899b1e6 [netinstall] Avoid negative row indexes 2022-01-31 12:59:03 +01:00
Adriaan de Groot
c0f4b80cbe [netinstall] Tighten up comments and code 
- comment wandered away from the function it applies to
- use overloaded name for recursive helpers
- document this new feature
 2022-01-31 12:55:54 +01:00
Adriaan de Groot
19afa46978 [netinstall] Match comment to code (casing of the identifier) 2022-01-31 12:51:56 +01:00
Adriaan de Groot
6a2e80a0b7
Merge pull request #1879 from dalto8/pkgchooser-netinstall 
Allow the packagechooser module to modify the netinstall module
 2022-01-31 12:44:02 +01:00
Adriaan de Groot
5b994f85c9 [grubcfg] Keep kernel_params as 'quiet' by default 
- mark some TODO
- tighten up the YAML schema a little bit
- when unset, use 'quiet' rather than empty, to preserve compatibility
  with existing configuration files.

SEE #1882
 2022-01-31 12:38:20 +01:00
Adriaan de Groot
37e189992e
Merge pull request #1882 from dalto8/grub-defaults 
[grubcfg] Add configuration for default kernel_params
 2022-01-31 12:12:06 +01:00
dalto
e597998021 [packagechooser,netinstall] Clean up duplication and pruning logic for netinstall-add 2022-01-27 19:31:34 -06:00
dalto
f65feedcce [grubcfg] Add configuration for default kernel_params 2022-01-27 15:53:34 -06:00
dalto
6be1208488 Document global storage keys 2022-01-25 17:52:45 -06:00
dalto
63ed2e5fb8 [packagechooser,netinstall] Change globalstorage keys to camel case 2022-01-25 17:43:19 -06:00
dalto
22c9d888b4 [packagechooser,netinstall] Proper implementation of source field 2022-01-24 17:01:16 -06:00
dalto
1db217931b [netinstall] Minor changes from code review 2022-01-24 15:39:14 -06:00
dalto
a657d7388c [packagechooser] Remove obsolete functionality from netinstall-add 2022-01-23 14:47:14 -06:00
dalto
f4c2db7f21 [packagechooser,netinstall] Fix issues where going back and forth between pkgchooser and netinstall produced unexpected behavior 2022-01-23 13:58:10 -06:00
Adriaan de Groot
95122fdcf5 [partition] Warn if the system won't support encryption in a useful way 
This is the infrastructure bit; if someone can come up with a way
of **meaningfully** detecting support, the detection function can
be given a better implementation.

FIXES #1725
 2022-01-22 22:52:50 +01:00
dalto
2aa8c2f0e0 [packagechooser] Ensure multiple instances don't override the GS values 2022-01-19 16:48:56 -06:00
Adriaan de Groot
929496552e [bootloader] Optionally generate unique suffix for bootloader 2022-01-18 15:09:44 +01:00
Adriaan de Groot
c9156d41b1 [bootloader] Extend tests and docs with a few more error cases 2022-01-18 14:31:13 +01:00
Adriaan de Groot
7a462f4522 [bootloader] Fix issues identified by tests 
- expectation derp11 was wrong, there were only 10 calls to next()
- using whole name instead of the not-the-suffix-bit was wrong
- phrase generator wrong length
 2022-01-18 13:32:24 +01:00
Adriaan de Groot
ed5c4c9c87 [bootloader] Add generators for various suffix-flavors 2022-01-18 13:32:24 +01:00
Adriaan de Groot
b4b7deac2d [bootloader] Document intentions 
It may be easiest to modify the efiBootloaderId, since that does not
normally show up in the UI. I cannot quickly come up with a way to
do the same kind of suffixing on the user-visible name.

SEE #1820
 2022-01-18 13:32:24 +01:00
Adriaan de Groot
c587145bdd [umount] Drop all mention of removed configuration keys 2022-01-18 13:25:58 +01:00
dalto
4d5ae96db6 [umount] Add support for umount to be an emergency module 2022-01-18 13:25:00 +01:00
Adriaan de Groot
6034feb69d [umount] Complete C++ implementation 
- as a design decision, the deprecated "save some files" functionality
  has been dropped from this implementation.
 2022-01-18 13:22:45 +01:00
Adriaan de Groot
afa5e75d76 [umount] Start C++ port 2022-01-18 13:22:42 +01:00
Adriaan de Groot
5e4866c439 [partition] Simplify ClearTempMounts 
- use the shared function for reading mtab entries
 2022-01-18 13:22:20 +01:00
Adriaan de Groot
0070dd2c01 [libcalamares] Add a convenience for reading mtab 
- used by umount and cleartempmounts (in future)
 2022-01-18 13:22:20 +01:00
Adriaan de Groot
546780d7a8 Merge branch 'issue-1864' into calamares 
FIXES #1864
 2022-01-18 12:39:46 +01:00
Adriaan de Groot
da2612d2d9 [locale] Update language even if there is a current location 
- the first time we arrive at locale, there isn't a current location
  and the setCurrentLocation(...) method ends up calling setLanguage(),
  usually. The second time, this call is skipped (not called from
  the overloaded setCurrentLocation() which is called from onActivate),
  so the language didn't update.
- now call setLanguage() unless there has been one set explicitly.
 2022-01-18 12:28:57 +01:00
dalto
4811c59e33 [packages] Make pacman output more verbose 2022-01-17 16:24:56 -06:00
Adriaan de Groot
11f3f938d8
Merge pull request #1875 from dalto8/pacman-logs 
[packages] Ensure all pacman output is available in debug log
 2022-01-17 15:20:55 +01:00
Adriaan de Groot
6101dd9079 [locale] Code style 2022-01-17 14:51:42 +01:00
tjpark88
79a91b486a [locale] Update language always 
onActivate of locale updates the language only when currentLocation changed
or when onActivate of locale is called for the first time.
However, It is irrelevant solution since the language is set by the welcome.
So language should be updated always.
The language is used by keyboard module to guessing a layout of keyboard.
Once you face the locale, you can't change language in the welcome
if you don't change the timezone.
 2022-01-17 14:51:42 +01:00
Adriaan de Groot
2aaaabe152 [partition] Set bigtime on XFS filesystems 
FIXES #1874
 2022-01-17 14:50:43 +01:00
Adriaan de Groot
a93126a6d0 [libcalamares] More meaningful name for JobResult success 2022-01-17 14:19:28 +01:00
dalto
112d0b2e90 [packages] Ensure all pacman output is available in debug log 2022-01-17 07:07:09 -06:00
Adriaan de Groot
e6813949af [libcalamares] Hook up Python's error() to error, rather than warning 2022-01-17 13:47:47 +01:00
Adriaan de Groot
4be932ff9d [umount] Now mark deprecated use as an error 2022-01-17 13:42:36 +01:00
dalto
b4ac6b73c8 [packagechooser,netinstall] Add documentation for packagechooser/netinstall integration 2022-01-15 11:13:17 -06:00
dalto
2eda55d3af [packagechooser,netinstall] Add support for packagechooser to drive netinstall 2022-01-15 09:41:23 -06:00
Adriaan de Groot
a8f6596d38 Merge branch 'issue-1870' into calamares 
- Improve the error messages in general
- Warn specifically if there isn't an *unpack* key

FIXES #1870
 2022-01-12 14:39:54 +01:00
Adriaan de Groot
b227419f01
Merge pull request #1871 from dalto8/zfsfix-initcpiocfg 
[initcpiocfg] Only add zfs hook if zfs is enabled
 2022-01-12 11:31:53 +01:00
Adriaan de Groot
da03e12b7b
Merge pull request #1869 from dalto8/initramfs-fix 
[initramfs] Fix condition when call to uname fails
 2022-01-12 11:31:13 +01:00
Adriaan de Groot
624bb13736
Merge pull request #1868 from dalto8/fix-initcpio 
initcpio module fixes
 2022-01-12 11:19:36 +01:00
Adriaan de Groot
94bca61491 Docs: be a little more explicit about emergency mode 2022-01-12 11:16:42 +01:00
Adriaan de Groot
ee2fea74df
Merge pull request #1866 from dalto8/umount-emergency 
[umount] Add support for umount to be an emergency module
 2022-01-12 11:11:20 +01:00
dalto
1f9ae6cae6 [initcpiocfg] Only add zfshook if zfs is enabled 2022-01-07 14:49:26 -06:00
Adriaan de Groot
e14fa5de75 [unpackfs] Improve error messages 
- the module is 'unpackfs', not 'unsquash'
- add a warning + specific error if there is no unpack key in the config
- the 'doing nothing' part isn't true: the module errors out instead
  of doing nothing.

SEE #1870
 2022-01-06 23:51:18 +01:00
dalto
626ab98949 [initramfs] Fix condition when call to uname fails 2022-01-02 08:41:47 -06:00
dalto
3be6946d93 [initcpio] Minor documentation updates 2022-01-01 12:14:42 -06:00
dalto
475c0d21a1 [initcpio] Spell mkinitcpio properly 2022-01-01 10:48:48 -06:00
dalto
c2ae5fad96 [initcpio] Make implementation match config description and remove broken uname option 2022-01-01 10:05:00 -06:00
dalto
4fe5f1c06f [umount] Add support for umount to be an emergency module 2021-12-31 08:06:13 -06:00
Adriaan de Groot
4e61f24960 [partition] Tidy up iso9660 detection 2021-12-25 18:27:13 +01:00
demmm
7cfa654a68 [luksopenswaphookcfg] set plugin name according to module name 
either this, or have all distros adjust settings.conf from luksopenswaphookcfg to luksopenswaphook
 2021-12-22 22:17:13 +01:00
dalto
f0aba5db96 Update modules readme for Python emergency modules support 2021-12-19 15:29:42 -06:00
Adriaan de Groot
da72e815dc [luksopenswaphookcfg] Fix build, missing include 2021-12-18 00:43:30 +01:00
Adriaan de Groot
7fc2859f23
[luksopenswaphookcfg] Port to C++ 
Merge pull request #1845 from calamares/issue-1659

FIXES #1659
FIXES #1644
 2021-12-17 20:31:05 +01:00
Adriaan de Groot
587a18a6fa [partition] Use runCommand() for future-proofing 2021-12-14 12:50:27 +01:00
Adriaan de Groot
f04394d014 [partition] Improve rendering of KPMCore errors 2021-12-13 20:02:52 +01:00
Adriaan de Groot
07354a26a9 [partition] Simplify debug calls to executables 
- Use the Calamares support-functions for running lsblk and mount
  (these might need to have privilege support if Cala is not
  running as root, so this is future-proofing)
 2021-12-13 20:02:52 +01:00
Adriaan de Groot
fdf0f208f0 [partition] Use lvalue-overload of execute() convenience 
- These jobs may take a long time, and report progress; we need
  the operation around to be able to connect the signals and slots
 2021-12-13 20:02:52 +01:00
Adriaan de Groot
6680584724 [partition] Use convenience function execute() 
This job needs the lvalue-overload of execute() because it needs to
call a method on the operation after execute() finishes successfully.
 2021-12-13 20:02:52 +01:00
Adriaan de Groot
c5573a1997 [partition] Add non-const lvalue overload for execute() 2021-12-13 20:02:52 +01:00
Adriaan de Groot
b8ce21d572 [partition] Use convenience function for running operations 2021-12-13 20:02:52 +01:00
Adriaan de Groot
1356012fb4 [partition] With rvalue, code becomes even more compact 2021-12-13 20:02:52 +01:00
Adriaan de Groot
8bb2c5fc6b [partition] Use convenience-method for running operation 2021-12-13 20:02:52 +01:00
Adriaan de Groot
dc7a1e43b7 [partition] Add helper for running a KPMCore operation 
Most *partition* module jobs run an operation and turn that into
a JobResult -- ok if it succeeds, and with the report text otherwise.
Factor it out into a separate method that can be used as shorthand.
 2021-12-13 20:02:52 +01:00
Adriaan de Groot
d3ed5663d0 [preservefiles] Add a schema-file 2021-12-13 16:56:07 +01:00
Adriaan de Groot
778c2855f4 [preservefiles] Introduce the notion of optionally-preserved files 2021-12-13 16:34:38 +01:00
Adriaan de Groot
445ed870cc [preservefiles] Simplify code to help gcc warnings 2021-12-13 15:53:42 +01:00
Adriaan de Groot
3be52f8b37 [preservefiles] Expand tests with reading some existing config-items 2021-12-13 15:53:42 +01:00
Adriaan de Groot
a1b7ba0dc5 [preservefiles] Accessor for item-type (needed for tests) 2021-12-13 15:44:07 +01:00
Adriaan de Groot
8b5e49d980 [preservefiles] Add (stub) tests 2021-12-13 15:07:24 +01:00