napcok/calamares
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[users] Don't mangle the hostname with a test

Browse Source
This commit is contained in:
Adriaan de Groot 2022-03-21 14:08:17 +01:00
parent f4a10a313c
commit 9b651b4f00
1 changed files with 16 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/modules/users/TestSetHostNameJob.cpp
View File

@ -41,6 +41,7 @@ private Q_SLOTS:
private:
QTemporaryDir m_dir;
QString m_originalHostName;
};
UsersTests::UsersTests()
@ -70,6 +71,15 @@ UsersTests::initTestCase()
= Calamares::JobQueue::instance() ? Calamares::JobQueue::instance()->globalStorage() : nullptr;
QVERIFY( gs );
gs->insert( "rootMountPoint", m_dir.path() );
if ( m_originalHostName.isEmpty() )
{
QFile hostname( QStringLiteral( "/etc/hostname" ) );
if ( hostname.exists() && hostname.open( QIODevice::ReadOnly | QIODevice::Text ) )
{
m_originalHostName = hostname.readAll().trimmed();
}
}
}
void
@ -115,7 +125,12 @@ UsersTests::testHostnamed()
// FreeBSD, docker, ..) we're not going to fail a test here.
// There's also the permissions problem to think of.
QEXPECT_FAIL( "", "Hostname changes are access-controlled", Continue );
QVERIFY( setSystemdHostname( "tubophone.calamares.io" ) );
QVERIFY( setSystemdHostname( QStringLiteral( "tubophone.calamares.io" ) ) );
if ( !m_originalHostName.isEmpty() )
{
QEXPECT_FAIL( "", "Hostname changes are access-controlled (restore)", Continue );
QVERIFY( setSystemdHostname( m_originalHostName ) );
}
}