Commit Graph

805 Commits

Author SHA1 Message Date
Andrius Štikonas
1b21668bff [partition] Switch to scoped Device enums. 2018-04-18 23:59:15 +03:00
Adriaan de Groot
c7629182e4 Merge branch 'master' into requirements-checking 2018-03-06 17:06:35 +01:00
Adriaan de Groot
a72bdfac52 Merge branch 'master' into requirements-checking 2018-03-06 14:57:17 +01:00
Adriaan de Groot
3315df5df1 [modules] Use new convenience logging methods across the board 2018-02-13 11:07:12 +01:00
Adriaan de Groot
0b03d56a40 i18n: Massage code to help lupdate understand 2018-02-07 17:43:26 +01:00
Adriaan de Groot
e3b7a2884b [partition] Relax check with UI-level warning message, too 2018-01-09 11:15:30 -05:00
Adriaan de Groot
05967311de [partition] Be defensive against no device-device-available.
Scenario is this: you have no suitable installation devices on
your system (everything is mounted, or HDD has died), click through
to partition page, where you have all the buttons available, but no
devices in the list. The following actions then cause a crash:

 - clicking "back"
 - clicking any button

Prevent that:
 - you can click "back", but if there is no device selected
   nothing happens to the device state (no nullptr deref,
   and no crash)
 - button code is now more resilient to this scenario
 - buttons are hidden until a device is available, so you
   can't even click on them to trigger the code.
2018-01-09 06:58:46 -05:00
Adriaan de Groot
1a42b8af41 Merge branch 'kpmcore-3.2'
- Bumps requireed KPMCore to 3.3 (in spite of the branch name)
 - Cleans up some dependencies

Thanks to Andrius Stikonas.
2018-01-02 13:25:11 +01:00
Adriaan de Groot
762ad54344 Documentation: change http links to GitHub to https 2017-12-20 08:39:09 -05:00
Adriaan de Groot
29e532a790 [partition] Insert annoying 3-sec delay
This is intended for testing -- it helps debug where a slow
requirement check blocks the UI.
2017-12-12 07:17:16 -05:00
Adriaan de Groot
4566e53d01 [partition] Delay requirements checking until pmcore is initialized 2017-12-02 12:11:56 -05:00
Adriaan de Groot
ba21a221df [partition] C++ style 2017-12-02 11:43:20 -05:00
Adriaan de Groot
16fbe4dc8c [partition] Sample of requirement checking
- There should be at least device to select, overwise we can't continue.
   The check currently **always** fails, so it blocks installation.
2017-12-02 11:42:56 -05:00
Chantara Tith
2a785bdf89 Disable newPartitionTableButton for LVM device. 2017-11-11 21:47:30 +00:00
Andrius Štikonas
4912d8a6c2 Fix create partition job to work with LVM devices. 2017-10-09 17:31:22 +01:00
Adriaan de Groot
e3e519c06f Clang: reduce warnings, nullptr, unused parameters 2017-09-21 04:04:01 -04:00
Adriaan de Groot
d23818b27c Fix code using re-imported spinner 2017-09-19 16:26:26 +02:00
Adriaan de Groot
13807ceabf Licensing: add self
- to all the files I've touched recently
 - to (very incomplete) AUTHORS list

Licensing: add license info to top-level CMakeLists.txt
2017-09-19 15:57:25 +02:00
Adriaan de Groot
ca60a7fc16 Clang: warnings-- 2017-09-14 07:02:24 -04:00
Adriaan de Groot
9116718448 Clang: warnings-reduction 2017-09-10 15:19:36 -04:00
Adriaan de Groot
31fa9e4251 Clang: fix warnings on partition splitter
- initialize all the fields
 - member-initialization order
 - silence warnings about double<->int
 - drop unused parameter to setSplitPartition
2017-09-10 06:17:28 -04:00
Adriaan de Groot
3e5916157f A mounted partition cannot be resized or replaced
- add check for isMounted()
 - a device with a mounted partition cannot be (entirely) erased

FIXES #639
2017-09-07 04:55:44 -04:00
Adriaan de Groot
851379628c Reduce Qt runtime warnings.
- deleteLater() doesn't like nullptr (produces a warning, but is harmless)
 - reparenting across threads doesn't work, comment on that but leave
   it in, since this may be relevant for memory management.
2017-09-07 04:24:08 -04:00
Adriaan de Groot
d5dca07e22 Fix uninitialized values (valgrind report) 2017-08-31 04:13:18 -04:00
Adriaan de Groot
1ea79efce8 Uninitialized value 2017-08-29 14:00:48 -04:00
Adriaan de Groot
7791c3cb19 DeviceInfo: refactor translation of DeviceInfoPage
- For Boot and Device info widgets, add a retranslateUi() method,
   since the labels change not only in response to translation
   events but also UI events.

FIXES #779
2017-08-28 05:44:43 -04:00
Adriaan de Groot
7e66499f36 Refactor check for EFI system.
The TODO stands, to delegate this to KPMCore.
2017-08-28 05:36:45 -04:00
Lisa Vitolo
9be15e68b6 Change both size box suffices to MiB. 2017-07-09 18:20:00 +01:00
Lisa Vitolo
925d3a61a7 Add "MB" suffix to the "edit partition" size box.
Makes it easier to know which unit Calamares is using when
resizing a partition. The "Create partition" dialog has
it already.
2017-07-09 10:10:04 -04:00
Adriaan de Groot
3c3c0f99f8 C++ trickery, part two: shorten code 2017-07-04 08:42:14 -04:00
Adriaan de Groot
ee4e4dfccc C++ trickery to make the code shorter to read. 2017-07-03 18:07:18 -04:00
Adriaan de Groot
c0b3f3fe9d Clang: reduce warnings; make enum-switch explicit 2017-06-28 05:49:53 -04:00
Adriaan de Groot
7ebbcc33b2 Partitionmanager: remove unused code files 2017-06-20 07:23:04 -04:00
Teo Mrnjavac
6545443b24 Documentation++ 2017-03-03 12:32:44 +01:00
Teo Mrnjavac
3aebb79d30 Add optional config value neverCreateSwap in partition module.
CAL-458 #close The feature has landed in master, please test.
2017-02-09 18:08:47 +01:00
Ramon Buldó
f0b4a21b2d partition: use always double click to activate a partition tree view item
Using activated signal may use single or double click depending on environment settings
2017-02-07 17:58:56 +01:00
Teo Mrnjavac
06b1d4abd2 Don't hardcode /dev/sd* as device path. 2017-02-02 16:59:17 +01:00
Teo Mrnjavac
f4732de975 Always write bootloader path. 2017-01-18 19:38:12 +01:00
Teo Mrnjavac
45adde11e1 Do not write bootloader install path if the system is EFI. 2017-01-18 12:11:25 +01:00
Teo Mrnjavac
a59a79a816 bootloaderInstallPath only applies if !isEfi. 2017-01-12 13:28:34 +01:00
Teo Mrnjavac
f3848cd428 The sender QObject should be in scope so the bootloader path is written.
CAL-388
CAL-417
CAL-441
2017-01-10 14:46:07 +01:00
Teo Mrnjavac
c158893b22 Style + translation. 2017-01-04 15:28:09 +01:00
Teo Mrnjavac
2aeadf9682 Better to keep font style manipulation to a minimum. 2017-01-04 15:28:09 +01:00
Teo Mrnjavac
e9f113a6a8 Translate user-visible strings! 2017-01-04 15:28:09 +01:00
Teo Mrnjavac
028f56d94a Better to keep font style manipulation to a minimum. 2017-01-04 15:28:09 +01:00
Teo Mrnjavac
3ec7c6f881 Style. 2017-01-04 15:28:09 +01:00
Lisa
02abc0d0a7 Merge pull request #276 from shainer/mountpoint
Disallow assigning the same mountpoint to two partitions
2016-12-31 18:49:05 +01:00
Teo Mrnjavac
45315e6ae9 Improve debug output for bootloader code path. 2016-12-02 18:36:02 +01:00
shainer
2759529841 Remove current partition's mountpoint from used list.
This means that when we edit a partition, we don't consider
its current mountpoint invalid because it is already in-use.

We need to do this for both "edit existing partition" and
"edit a partition that we are still creating".
2016-11-20 23:19:33 +00:00
shainer
349470ae71 Check mountpoints when editing a partition too. 2016-11-20 23:06:03 +00:00
shainer
8c1199df2d Check first selection of mountpoint too.
When opening the dialog.
2016-11-20 23:05:44 +00:00
shainer
f51b05e8aa Get the mountpoint from PartitionInfo.
The Partition object includes the root mountpoint in
the partition mountpoint, which is not what we want.
2016-11-20 22:46:28 +00:00
shainer
c8dbeb5341 Avoid creating a new partition with a used mountpoint.
We get the mountpoints already used by other partitions, and
disable the Ok button in the "Create new partition" dialog if
the user selects/writes a mountpoint which is already used.

We are going to do the same in the Edit partition dialog
after testing.
2016-11-20 22:05:55 +00:00
Teo Mrnjavac
83b51a5867 Show warning. 2016-11-17 19:03:24 +01:00
Teo Mrnjavac
17fe2d82f4 Oops. 2016-11-17 18:28:58 +01:00
Teo Mrnjavac
a55bef5d2d Warn user about encrypted root with unencrypted /boot. 2016-11-17 18:15:37 +01:00
Teo Mrnjavac
6e7dc0b437 Use the target system's boot name in partitioning summary widget. 2016-10-14 15:27:24 +02:00
Teo Mrnjavac
5796b05fda Allow disabling automated LUKS modes. 2016-09-26 13:14:54 +02:00
Teo Mrnjavac
c316d22b08 Keep an immutable copy for every scanned Device* to avoid rescans. 2016-09-09 11:28:39 +02:00
Chantara Tith
aa10fe982a API Changes, logicalSectorSize -> logicalSize, totalSectors -> totalLogical. 2016-09-09 11:28:39 +02:00
Andrius Štikonas
9f0ca042fe Port away from most cases of Q_FOREACH to C++11 ranged for loop.
In order to avoid deep copies, Qt containers over which we iterate must be const
The remaining unported cases require qAsConst (Qt 5.7) or std::as_const (C++17)
2016-09-01 16:46:14 +01:00
Teo Mrnjavac
e9da3acd95 Fix EncryptWidget height. 2016-07-22 16:36:26 +02:00
Teo Mrnjavac
04ab71bad9 Fix default new partition text. 2016-07-22 16:36:26 +02:00
Teo Mrnjavac
9c90a2a500 Useless margins are useless. 2016-07-22 16:36:26 +02:00
Teo Mrnjavac
edeee85cd3 Write reuse Home check box string. 2016-07-22 16:36:26 +02:00
Teo Mrnjavac
e6f9714f84 Avoid homePartitionPath going out of scope. 2016-07-22 16:36:26 +02:00
Teo Mrnjavac
90bb64fb17 Pass current index by value. 2016-07-22 16:36:26 +02:00
Teo Mrnjavac
aaf85407fb Only look for a separate /home partition if a partition was found. 2016-07-22 16:36:26 +02:00
Teo Mrnjavac
6c6e4a1f88 Write reuseHome to GlobalStorage. 2016-07-22 16:36:26 +02:00
Teo Mrnjavac
8b0b4c73de Add Q_UNUSED where relevant. 2016-07-22 16:36:26 +02:00
Teo Mrnjavac
d44a3d831b Warning fixes: avoid C-style casts. 2016-07-22 16:36:26 +02:00
Teo Mrnjavac
30ff216dea Warning fix: implicit cast. 2016-07-22 16:36:26 +02:00
Teo Mrnjavac
90c06bd733 Warning fixage (init list order, lossy cast, Q_UNUSED). 2016-07-22 16:36:26 +02:00
Teo Mrnjavac
c1e535a8e8 Hide reuse checkbox on action selection change. 2016-07-22 16:36:26 +02:00
Teo Mrnjavac
a17f369cee React to reuse home checkbox by setting /home mount point.
Rearranged Replace workflow a bit: onPartitionReplaceSelected is now
the on choice slot, which in turn calls doReplaceSelectedPartition.
onHomeCheckBoxStateChanged also calls doReplaceSelectedPartition if we
need to redo the Replace task with/without a separate home to keep.
m_reuseHomeCheckBox is hidden by default.
2016-07-22 16:36:26 +02:00
Teo Mrnjavac
bc345b3ddc Add "reuse home" check box to .ui. 2016-07-22 16:36:26 +02:00
Teo Mrnjavac
45f6e6c55b Rearrange asynchronous scan in PartitionCoreModule a bit. 2016-07-19 13:04:00 +02:00
Teo Mrnjavac
2c68802446 Reapply the action choice instead. 2016-06-29 18:46:02 +02:00
Teo Mrnjavac
b2b202d190 Do a full revert. 2016-06-29 18:34:02 +02:00
Teo Mrnjavac
f1a29033a2 Revert PCM before applying Alongside operation. 2016-06-29 18:21:38 +02:00
Teo Mrnjavac
9d4a636a16 Revert "Improve debug output in PartitionBarsView."
This reverts commit 9e186190fc.
2016-06-24 17:38:52 +02:00
Teo Mrnjavac
59f0e9cc2d Revert "Improve debug output."
This reverts commit 3d5ccb2712.
2016-06-24 17:38:45 +02:00
Teo Mrnjavac
e96c7f95ef Improve debug output. 2016-06-24 17:15:26 +02:00
Teo Mrnjavac
9888a4e5d3 Only make it dirty if something changes. 2016-06-24 17:06:39 +02:00
Teo Mrnjavac
a96b7c1596 Reset previous spinBox value on resizer widget reset. 2016-06-24 17:00:55 +02:00
Teo Mrnjavac
1f664f1eec Keep track of previous spinbox value. 2016-06-24 16:58:23 +02:00
Teo Mrnjavac
cd94768850 Revert "Try to work around spinbox dirty status change on apply issue."
This reverts commit 9c90d54eda.
2016-06-24 16:46:56 +02:00
Teo Mrnjavac
9c90d54eda Try to work around spinbox dirty status change on apply issue. 2016-06-24 16:28:17 +02:00
Teo Mrnjavac
5450a18c85 Copyright. 2016-06-24 16:05:33 +02:00
Teo Mrnjavac
2e173c183f Do not align partition boundaries unless explicitly requested. 2016-06-24 16:04:48 +02:00
Teo Mrnjavac
9d995f3625 Use length instead of calculating sectors count. 2016-06-24 15:10:20 +02:00
Teo Mrnjavac
4f41cf54a9 Hook up PartitionLabelsView to model. 2016-06-23 10:01:13 +02:00
Teo Mrnjavac
3940e2b09d Add config option for always showing partition labels. 2016-06-23 10:00:55 +02:00
Teo Mrnjavac
5520972e5a Add labels view to manual partitioning page. 2016-06-23 10:00:00 +02:00
Teo Mrnjavac
3d5ccb2712 Improve debug output. 2016-06-23 09:48:03 +02:00
Teo Mrnjavac
9e186190fc Improve debug output in PartitionBarsView. 2016-06-22 18:18:53 +02:00
Teo Mrnjavac
bea6b5f17e Stupid compilers are stupid. 2016-06-13 15:13:26 +02:00
Teo Mrnjavac
8ff943e5b5 Improve check for encryption status. 2016-06-10 17:52:54 +02:00
Teo Mrnjavac
7a03dc102d Update fields when the default filesystem is chosen. 2016-06-10 16:05:34 +02:00
Teo Mrnjavac
fe107ac762 Obey default FS type setting in EditExistingPartitionDialog. 2016-06-10 15:41:53 +02:00
Teo Mrnjavac
395fb340b7 Make the Create Partition dialog obey the default FS type setting. 2016-06-10 15:37:11 +02:00
Teo Mrnjavac
a00ebc01e7 Use EncryptWidget for relevant partition types in CreatePartitionDialog. 2016-06-10 15:22:40 +02:00
Teo Mrnjavac
d75d5c76fe Add EncryptWidget to CreatePartitionDialog.ui. 2016-06-10 15:22:40 +02:00
Teo Mrnjavac
99e719882f Add setText/reset to EncryptWidget, and fix tooltip string. 2016-06-10 15:22:40 +02:00
Teo Mrnjavac
18742d2afd Ignore encrypt widget if the choice is Manual. 2016-06-10 15:22:40 +02:00
Teo Mrnjavac
f5ff716369 Make everything obey the default filesystem type setting. 2016-06-10 15:22:21 +02:00
Teo Mrnjavac
498af8deef Add defaultFileSystemType to settings. 2016-06-10 15:08:24 +02:00
Teo Mrnjavac
936e7fab7c Initial support for Alongside install with LUKS. 2016-06-07 17:35:39 +02:00
Teo Mrnjavac
fd2d24d650 Always show encrypt widget for Replace. 2016-06-03 17:56:31 +02:00
Teo Mrnjavac
4113207e00 Fix next status handling in alongside and replace. 2016-06-03 17:55:14 +02:00
Teo Mrnjavac
e84108e234 Add encryption support in PartitionActions::doReplacePartition. 2016-06-03 16:39:28 +02:00
Teo Mrnjavac
6cd1bf6b3d Initial work on having the Replace feature obey the encryption setting. 2016-06-02 18:29:17 +02:00
Teo Mrnjavac
c9fac9bc5c Manage PCM loading with QtConcurrent. 2016-05-26 15:35:24 +02:00
Teo Mrnjavac
0666fb4977 Defer PartitionCoreModule initialization so it doesn't block startup. 2016-05-26 15:08:37 +02:00
Teo Mrnjavac
a4ab8dad46 Hide encryption widget if not Erase. 2016-05-18 07:22:13 +02:00
Teo Mrnjavac
60dcba8735 Update next state slightly later. 2016-05-17 11:34:30 +02:00
Chantara Tith
a25a0ffa2c Update PartitionPage.cpp
increase readability.
2016-05-14 02:29:56 +07:00
Teo Mrnjavac
2050ce97d7 Merge pull request #241 from tctara/master
Disk selections in partitioner are not sticky[CAL-361]
2016-05-13 19:44:33 +02:00
Chantara Tith
625bbb6a4b Disk selections in partitioner are not sticky 2016-05-13 19:26:03 +07:00
Teo Mrnjavac
b792ea0216 Rebuild autopartition proposal when encryption choice changes. 2016-05-06 18:59:51 +02:00
Teo Mrnjavac
0cc9560a99 Hook up EncryptWidget in ChoicePage, plus improve next status handling. 2016-05-06 18:59:51 +02:00
Teo Mrnjavac
6e92a04320 Say hello to EncryptWidget. 2016-05-06 18:59:51 +02:00
Teo Mrnjavac
dacb8f2a94 Make sure we don't hide actions based on osprober. 2016-03-18 12:28:54 +01:00
Chantara Tith
fd8c131b26 implement free-space partition replace install 2016-03-18 17:09:50 +07:00
Teo Mrnjavac
83d440f37e Add note. 2016-03-10 13:16:18 +01:00
Teo Mrnjavac
055ff5533e Fixup strings. 2016-03-09 13:34:27 +01:00
Teo Mrnjavac
fb5b48528b Move ESP check to onLeave(). 2016-03-09 13:21:07 +01:00
Teo Mrnjavac
0c7b7ed089 Warn the user if going ahead from manual partitioning without ESP. 2016-03-09 12:54:59 +01:00
Teo Mrnjavac
49eea234ed Hide bootloader chooser on EFI. 2016-03-09 12:54:16 +01:00
Teo Mrnjavac
182ff03e04 Update createPartition call. 2016-03-08 16:26:20 +01:00
Teo Mrnjavac
3fa7318a37 Do set flags after showing dialog. 2016-03-08 12:50:45 +01:00
Teo Mrnjavac
5a134eb708 Copyright headers. 2016-03-08 12:50:45 +01:00
Teo Mrnjavac
ada0a080fc Add flags setting support when creating a partition. 2016-03-08 12:50:45 +01:00
Teo Mrnjavac
b83e91b951 Add flags ui to edit partition dialog. 2016-03-08 12:50:45 +01:00
Teo Mrnjavac
06ebf69afe Initialize all members (fix Coverity defect 98200). 2016-02-26 14:02:22 +01:00
Teo Mrnjavac
7e89e67059 Initialize all members (fix Coverity defect 98206). 2016-02-26 13:39:41 +01:00
Teo Mrnjavac
749a740ffa Ensure the resizing items aren't null (fix Coverity defect 121862). 2016-02-26 13:13:01 +01:00
Teo Mrnjavac
a0ac9d9f07 Don't dereference nullptr (fix Coverity defect 121863). 2016-02-26 13:00:58 +01:00
Teo Mrnjavac
53741f0d36 Initialize all members in ctor (fix Coverity defect 122658). 2016-02-26 13:00:58 +01:00
Teo Mrnjavac
1e3e1d22bb Fix build. 2016-02-23 14:43:12 +01:00
Teo Mrnjavac
3c8aee7b5e Add resizing state flag to Splitter items.
New iterator for Splitter items.
Use std::function instead of templates for type safety.
2016-02-23 10:50:48 +01:00
Teo Mrnjavac
bafaa6a225 Keep Splitter items on the stack. 2016-02-22 18:51:44 +01:00
Teo Mrnjavac
7bf0fa2575 Get better debug information. 2016-02-22 16:39:06 +01:00
Teo Mrnjavac
d6de5be8d0 Don't segfault on free space in Splitter widget. 2016-02-22 15:51:50 +01:00
Teo Mrnjavac
e91d213872 Improve setting ESP. 2016-02-19 16:57:49 +01:00
Teo Mrnjavac
e27b9fc295 Handle ESP selector visibility. 2016-02-19 16:51:24 +01:00
Teo Mrnjavac
a4831085fb Only override BIOS bootloader install path if there's no UI. 2016-02-19 16:42:51 +01:00
Teo Mrnjavac
7a89b53538 Refactor leave event of ChoicePage, add ESP mount point support.
PVS now calls ChoicePage::onLeave, which in turn runs ChoicePage::
doAlongsideApply and/or sets up the ESP mount point based on the UI
state if it's running in EFI mode and the action is Alongside or
Replace.
If setting up under BIOS, Alongside and Replace always install
the bootloader in the MBR of the current device.
2016-02-19 16:33:19 +01:00
Teo Mrnjavac
569f2d9d50 Use iterators instead. 2016-02-17 17:17:50 +01:00
Teo Mrnjavac
dc038dfe1e Useless code is useless. 2016-02-17 16:52:21 +01:00
Teo Mrnjavac
4781bc0f7a Use a QVector. 2016-02-17 16:46:51 +01:00
Teo Mrnjavac
c1b4320f5c Correctly handle free space in Splitter widget. 2016-02-17 16:41:05 +01:00
Teo Mrnjavac
7f6199ad37 Remember to update total. 2016-02-17 16:36:13 +01:00
Teo Mrnjavac
7bf918bfee Compensate for small partition visibility in Splitter widget. 2016-02-17 16:25:01 +01:00
Teo Mrnjavac
ea7b95e474 Maybe don't crash. 2016-02-16 14:50:01 +01:00
Teo Mrnjavac
9ecd23dfc7 In the labels view too. 2016-02-16 14:45:50 +01:00
Teo Mrnjavac
db69a860b0 Try to make it more responsive. 2016-02-16 14:27:54 +01:00
Teo Mrnjavac
9757de0d2c Restore the cursor. 2016-02-16 14:21:38 +01:00
Teo Mrnjavac
adbf0c7276 Try another approach. 2016-02-16 14:19:22 +01:00
Teo Mrnjavac
2c5d33839b Maybe we're restoring too much. 2016-02-16 14:14:35 +01:00
Teo Mrnjavac
eac6b4f983 Set an override cursor for the whole application. 2016-02-16 14:09:44 +01:00
Teo Mrnjavac
25a61d07a5 Don't uncolor partition. 2016-02-16 14:06:28 +01:00
Teo Mrnjavac
1aa8279cf8 Try the forbidden cursor when hovering an unselectable partition. 2016-02-16 13:56:07 +01:00
Teo Mrnjavac
5372245aed Copyright statements. 2016-02-12 17:19:30 +01:00
Teo Mrnjavac
485176d70d And always do that, please. 2016-02-12 16:48:29 +01:00
Teo Mrnjavac
12ec3bb74b Iterate over all partitions for canBeResized check, not just osprober. 2016-02-12 16:45:52 +01:00
Teo Mrnjavac
c3404769dc Use new check as selection filter in view. 2016-02-12 15:02:49 +01:00
Teo Mrnjavac
ffe419751c Use the new canBeResized in ChoicePage. 2016-02-11 17:04:36 +01:00
Teo Mrnjavac
984bc7ac08 Use it in summary. 2016-02-11 16:00:49 +01:00
Teo Mrnjavac
56e6509341 Use it in ChoicePage. 2016-02-11 16:00:36 +01:00
Teo Mrnjavac
b374404c6f Allow hiding extended partition in Labels view. 2016-02-11 16:00:07 +01:00
Teo Mrnjavac
61685cec86 Remove old count. 2016-02-10 17:39:42 +01:00
Teo Mrnjavac
fb4c22c274 Use correct count. 2016-02-10 17:31:00 +01:00
Teo Mrnjavac
0f756c7167 Use it in ChoicePage. 2016-02-10 17:02:42 +01:00
Teo Mrnjavac
65f5da5a8d Draw nested partition enable/disable support in Splitter widget. 2016-02-10 17:02:10 +01:00
Teo Mrnjavac
aaeb28e45e Don't round size estimate down to an int. 2016-02-10 16:00:24 +01:00
Teo Mrnjavac
5f3e5bf372 Consistent config item naming. 2016-02-10 15:41:32 +01:00
Teo Mrnjavac
3d5753e97c Better way to compute items in nested/non-nested partitions mode. 2016-02-10 15:33:31 +01:00
Teo Mrnjavac
d2600bc5dc Set the nested partitions mode in PartitionPage. 2016-02-10 15:00:02 +01:00
Teo Mrnjavac
7bb76c70ba Set the nested partitions mode in ChoicePage. 2016-02-10 15:00:02 +01:00
Teo Mrnjavac
1ed1841e89 Read the setting from partitions.conf and apply it in PVS. 2016-02-10 15:00:02 +01:00
Teo Mrnjavac
086634ae7b Nested partitions mode support in PartitionBarsView. 2016-02-10 15:00:02 +01:00
Teo Mrnjavac
b17b7a9c89 Asynchronous rescan on device change. 2016-02-09 13:23:23 +01:00
Teo Mrnjavac
877fa98ea6 Revert all devices if core dirty on device choice. 2016-02-09 13:03:14 +01:00
Teo Mrnjavac
ec5a464eda Make sure a default bootloader location is set. 2016-01-29 17:43:55 +01:00
Teo Mrnjavac
7f235525f2 Try slightly smaller action icons. 2016-01-29 17:10:28 +01:00
Teo Mrnjavac
30c38c4f4d Safer pointer. 2016-01-29 17:07:08 +01:00
Teo Mrnjavac
1bc6556b65 We don't need this any more... 2016-01-29 16:49:39 +01:00
Teo Mrnjavac
bef7444f47 ExpandableRadioButton is no more. 2016-01-28 18:44:27 +01:00
Teo Mrnjavac
5ccfc20258 Refactor bootloader picker into the bottom layout. 2016-01-28 18:43:35 +01:00
Teo Mrnjavac
e1a6085a1b Try different layout for first row in ChoicePage. 2016-01-28 13:04:44 +01:00
Teo Mrnjavac
619e82e5d3 Fixup string. 2016-01-28 13:03:22 +01:00
Teo Mrnjavac
2f9a45b3a7 Fixup strings. 2016-01-28 13:01:50 +01:00
Teo Mrnjavac
30351d125a Reduce spacing. 2016-01-28 12:53:54 +01:00
Teo Mrnjavac
1a11d8589a Fix layout. 2016-01-27 18:27:03 +01:00
Teo Mrnjavac
b6218272f3 Add BootInfoWidget to ChoicePage. 2016-01-27 18:23:56 +01:00
Teo Mrnjavac
6af0022e81 Yank boot stuff out from DeviceInfoWidget. 2016-01-27 17:55:38 +01:00
Teo Mrnjavac
4223e22f5b New BootInfoWidget. 2016-01-27 17:54:58 +01:00
Teo Mrnjavac
9dbdeb932d Improve strings in DeviceInfoWidget. 2016-01-27 16:46:47 +01:00
Teo Mrnjavac
b811f9e261 Fixup strings. 2016-01-25 16:59:05 +01:00
Teo Mrnjavac
051282d9bf Do the same in PartitionBarsView. 2016-01-15 18:40:59 +01:00
Teo Mrnjavac
69f488f07b Override mousePressEvent to correctly handle selection filter. 2016-01-15 18:40:59 +01:00
Teo Mrnjavac
16da0bd8d8 I guess this is a better spot. 2016-01-15 18:40:59 +01:00
Teo Mrnjavac
7c7c635d87 Set filter on both views. 2016-01-15 18:40:59 +01:00
Teo Mrnjavac
ba01022d42 Set the filter function in Labels view. 2016-01-15 18:40:59 +01:00
Teo Mrnjavac
65230c7954 Add a SelectionFilter lambda for Alongside. 2016-01-15 18:40:59 +01:00
Teo Mrnjavac
ddf4878ec7 Apply SelectionFilter in Partition{Labels,Bars}View. 2016-01-15 18:40:59 +01:00
Teo Mrnjavac
f7f19eb617 SelectionFilter function type. 2016-01-15 18:40:59 +01:00
Teo Mrnjavac
f958f69218 Fix weird issue with alongside failing to create new partition. 2016-01-14 18:47:02 +01:00
Teo Mrnjavac
423d2dfc5c Make sure we update the splitter widget after a rescan. 2016-01-14 16:14:57 +01:00
Teo Mrnjavac
601d67988d Fix shrink size computation.
I don't get how this could possibly ever have worked.
2016-01-13 18:23:50 +01:00
Teo Mrnjavac
983c16d991 Fix up views in summary. 2016-01-13 18:09:20 +01:00
Teo Mrnjavac
26c89e6806 Make sure Alongside operation is applied. 2016-01-13 18:02:03 +01:00
Teo Mrnjavac
8525cefb6b Fix next status handling. 2016-01-13 17:55:51 +01:00
Teo Mrnjavac
b5882a75d1 AlongsidePage is not used any more. 2016-01-13 17:50:05 +01:00
Teo Mrnjavac
5242536b2a Make doAlongsideApply public in ChoicePage. 2016-01-13 17:49:36 +01:00
Teo Mrnjavac
27d69502a3 Alongside apply slot. 2016-01-13 17:43:59 +01:00
Teo Mrnjavac
3f9aae9af6 Fix splitter handle placement on child partitions. 2016-01-13 16:23:12 +01:00
Teo Mrnjavac
9682520c61 Draw the handle when it matters. 2016-01-13 16:17:38 +01:00
Teo Mrnjavac
3238498e48 Don't crash. 2016-01-13 16:15:19 +01:00
Teo Mrnjavac
491e046824 Robust means not broken, please. 2016-01-13 16:12:51 +01:00
Teo Mrnjavac
5eb6f6799e Try to make it more robust. 2016-01-13 16:12:08 +01:00
Teo Mrnjavac
10c51528a9 Repaint viewport on selection change. 2016-01-13 15:16:01 +01:00
Teo Mrnjavac
ef0d46dd93 Years in header. 2016-01-13 15:16:01 +01:00
Teo Mrnjavac
110344e548 Actually set the selection model on the superclass. 2016-01-13 15:16:01 +01:00
Teo Mrnjavac
55c52e654a Try to force a repaint on selection changed. 2016-01-13 15:16:01 +01:00
Teo Mrnjavac
cb63d7d302 Draw the partitions in the alongside view even when not resizing. 2016-01-12 14:04:44 +01:00
Teo Mrnjavac
cad8845f12 Better name for alongside slot. 2016-01-12 14:04:25 +01:00
Teo Mrnjavac
b665b7192e Always repaint labels view on selection change, not just when hovering. 2016-01-12 13:45:32 +01:00
Teo Mrnjavac
1a48524a9a Repaint viewport on selection changed.
This issue wasn't noticeable earlier because every selection change
implied additional operations (in Replace) which used to trigger a
repaint at the right time for free. With this we make sure we get a
repaint.
2016-01-12 13:44:18 +01:00
Teo Mrnjavac
f2add6f2c2 Remove leftover return that was wrecking havoc. 2016-01-12 13:18:26 +01:00
Teo Mrnjavac
1bc0c41f02 Restore sizes. 2016-01-12 13:05:11 +01:00
Teo Mrnjavac
430a4feea9 Allow changing the to be resized partition without a reinit. 2016-01-12 12:48:39 +01:00
Teo Mrnjavac
4537103a43 Set up split widget when a partition is selected. 2016-01-12 11:43:02 +01:00
Teo Mrnjavac
d85bf01107 Initialized view is the best kind of view. 2016-01-11 19:26:14 +01:00
Teo Mrnjavac
37df381404 Proper parenting. 2016-01-11 19:07:48 +01:00
Teo Mrnjavac
80018e1d5b Signal-slot plumbing and splitter setup for Alongside. 2016-01-11 19:02:34 +01:00
Teo Mrnjavac
46ea8a484e Update year. 2016-01-11 17:30:33 +01:00
Teo Mrnjavac
92127e1abe Unbreak build. 2016-01-11 15:57:57 +01:00
Teo Mrnjavac
56292974a4 Bring PartitionSplitterWidget layout up to PartitionBarsView level. 2016-01-11 15:54:10 +01:00
Teo Mrnjavac
6a93f34c15 Move init logic into PartitionSplitterWidget. 2016-01-11 15:14:47 +01:00
Teo Mrnjavac
80d908e75b Document properly. 2016-01-08 18:09:19 +01:00
Teo Mrnjavac
08f9753aa2 Experimental: try to enforce a minimum partition size.
This breaks any hope of inline-resizing small partitions.
2016-01-08 17:55:04 +01:00
Teo Mrnjavac
b3f86925a8 Fix m_choice state. 2016-01-08 16:51:25 +01:00
Teo Mrnjavac
b422f646a6 Make sure the checked state change can happen. 2016-01-08 16:43:58 +01:00
Teo Mrnjavac
bc9ec8e5ba Fix build. 2016-01-08 16:37:45 +01:00
Teo Mrnjavac
3869338c39 Make the QButtonGroup a member in ChoicePage. 2016-01-08 16:35:50 +01:00
Teo Mrnjavac
85a6f2068a Refactor action choice handling with QButtonGroup.
This should improve the situation when unselecting an action without
selecting another one. Unselection can only happen when switching from
a device that supports the currently chosen action to a device that
doesn't support it, so the action gets hidden and unselected.
2016-01-08 15:38:01 +01:00
Teo Mrnjavac
53c27208f1 Also uncheck if hidden. 2016-01-08 14:50:09 +01:00
Teo Mrnjavac
f71ce22f3b Make sure to show all the relevant partitioning actions. 2016-01-08 14:45:58 +01:00
Teo Mrnjavac
0c05812c68 Update bootloader combobox when the selected device changes. 2016-01-07 17:24:01 +01:00
Teo Mrnjavac
64d296aa06 Sensible default to current device in bootloader picker. 2016-01-05 18:45:59 +01:00
Teo Mrnjavac
6ce932870f Clear selection on action change no matter what. 2015-12-31 16:58:50 +01:00
Teo Mrnjavac
74ba1df25f Try to manage preview visibility. 2015-12-31 16:55:18 +01:00
Teo Mrnjavac
38b90560cf Remove debug spam. 2015-12-31 16:36:24 +01:00
Teo Mrnjavac
22459c8fb8 Debug output. 2015-12-31 16:35:01 +01:00
Teo Mrnjavac
6dd639fd3c Try with rows. 2015-12-31 16:29:45 +01:00
Teo Mrnjavac
afef78d1af Don't enable next for replace by default. 2015-12-31 16:27:10 +01:00
Teo Mrnjavac
736d35840d Rely on item selection. 2015-12-31 16:24:46 +01:00
Teo Mrnjavac
59ec549617 Manage next button status. 2015-12-31 16:21:50 +01:00
Teo Mrnjavac
08d1c89f21 Don't forget to perform the autopartition operation when not resetting. 2015-12-31 16:12:52 +01:00
Teo Mrnjavac
73be443e22 And use it. 2015-12-31 15:39:32 +01:00
Teo Mrnjavac
5df78cc513 Add callback support to ScanningDialog statics. 2015-12-31 15:38:50 +01:00
Teo Mrnjavac
50ef1f1b70 Make sure we autopartition after the revert is over. 2015-12-31 15:18:34 +01:00
Teo Mrnjavac
f589e33fa5 Runtime signals, runtime errors. 2015-12-31 15:14:42 +01:00
Teo Mrnjavac
296bb412a8 Revert to runtime singal-slot syntax for easy disconnects. 2015-12-31 15:12:40 +01:00
Teo Mrnjavac
3cb293aa75 Avoid unnecessary casts. 2015-12-31 15:02:46 +01:00
Teo Mrnjavac
f01d802d40 No point in trying to reset and replace if nothing is selected. 2015-12-31 14:50:43 +01:00
Teo Mrnjavac
7e43c66661 Better order, probably. 2015-12-31 14:45:43 +01:00
Teo Mrnjavac
7dd669d997 Clear selection in before view. 2015-12-31 14:43:57 +01:00
Teo Mrnjavac
fbb92646d8 Asynchronous revert for Erase operation. 2015-12-31 14:40:40 +01:00
Teo Mrnjavac
5c0627a9d3 Remove debug spam. 2015-12-31 14:40:04 +01:00
Teo Mrnjavac
64655d92a1 Try to ensure the connection for the replace operation is unique. 2015-12-31 14:38:28 +01:00
Teo Mrnjavac
d6e773e220 Debug output. 2015-12-31 14:26:31 +01:00
Teo Mrnjavac
e061385f4b Avoid multiple connects. 2015-12-31 14:17:36 +01:00
Teo Mrnjavac
db36f18399 Don't overcomplicate. 2015-12-31 14:16:33 +01:00
Teo Mrnjavac
4039d8d4db Make on-action-select rescan also async. 2015-12-31 14:14:47 +01:00
Teo Mrnjavac
44bc06eb4c Use it in manual partitioning. 2015-12-31 14:14:25 +01:00
Teo Mrnjavac
427b930531 Add convenience overload for ScanningDialog::run 2015-12-31 14:13:43 +01:00
Teo Mrnjavac
2b862bf431 And in manual partitioning. 2015-12-31 13:56:19 +01:00
Teo Mrnjavac
093c7b042d Use it in ChoicePage. 2015-12-31 13:56:11 +01:00
Teo Mrnjavac
e1140b6fa8 Add static concurrent support to ScanningDialog. 2015-12-31 13:55:33 +01:00
Teo Mrnjavac
d28946040f Use ScanningDialog in replace operation. 2015-12-31 13:19:50 +01:00
Philip
91e1e4af6b [partition-module] fix 'QString::arg: Argument missing' issue 2015-12-31 00:56:46 +01:00
Teo Mrnjavac
c7ae18df4d Keep selection in sync between tree and bars view in manual partitioning 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
523c25f1e2 Make rescan asynchronous in manual partitioning, and use ScanningDialog 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
90e028a2b0 New ScanningDialog with a spinner. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
86399ece26 Trigger core reset when advancing to manual partitioning. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
f31a45e53a Clean up a bit. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
6db6dc0e08 Debug output. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
4f12aa8dd1 Critical to always have a fresh device. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
14f4335420 Lock the whole replace operation in a mutex. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
9847b8efa9 Try to invalidate whole PartitionModel on replace. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
2a61114d9e Make after partition views members in ChoicePage. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
8a44ffe462 Either revert or clear jobs, not both. 2015-12-30 17:27:13 +01:00
demmm
496d917d94 add strong in selectLabel 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
cd8b7619d0 Use asynchronous device revert. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
019faf730c Revert "Test out a way to make the rescan asynchronous."
This reverts commit e3f28189ced7aa22b3b7a6dc1506a17cbc1325b5.
2015-12-30 17:27:13 +01:00
Teo Mrnjavac
d742431ee9 Revert "Force a device state preview update after async rescan."
This reverts commit 717a3d47ca572c28f67757ddf96b63af66d97e14.
2015-12-30 17:27:13 +01:00
Teo Mrnjavac
95239af830 Force a device state preview update after async rescan. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
5f282d50dc Test out a way to make the rescan asynchronous. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
1a882758ca Revert Replace button to PrettyRadioButton. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
43c67310db Hide from labels view short instances of free space. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
3732f3e5b2 Trim /dev/ from visible partition paths. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
18755314fd Fix strings and use status text label. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
3009eee622 Add hline and status text label. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
ef411757af Improved string for Erase. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
c41820c000 Improved string for Replace. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
bf5d0d8862 Strings: s/volume/partition/ 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
071c02086a Update last page status. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
dcd48badae Try with a full revert. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
a8f06d00d0 Debug info. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
e2f9a5b93c Maybe not. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
6c614b946b A full view delete/recreate on partition selection :( 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
65278605fe clearJobs is enough on replace partition selection. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
15e409a107 Don't reparent model managed by PCM. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
275b68cf5c The PartitionModel should be owned by the PCM. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
dfededc4b4 Use revertDevice in ChoicePage, and always use a fresh Device*. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
b767f0b18f Select partition to replace from the current DeviceModel. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
2258c806ae Make the bars/labels views members in ChoicePage. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
1a4b6b1c9c Isolate painter in selection square. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
d164ec4d91 Remove ReplaceWidget. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
d0ee43172c Handle selection behavior on current state preview views. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
7102596729 Add Q_OBJECT macros. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
0c9d64878a Only enable selection when it makes sense 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
1c279dac24 Make bars and labels share the selection model. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
f2093be353 Full selection and hover support in labels view. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
fd33eb71ba Add some more string guesswork to labels view, with FS pretty names. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
6af901a675 Use BootloaderEntryName from Branding for target root partition id. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
0c840abdc5 Allow setting a custom new root name in Labels view. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
87a31a0514 Tweak labels view margin. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
f736ace996 Update Erase disk string. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
cda99a2a65 New Alongside strings. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
37634e1e5a New Replace strings. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
d27ac4c041 New Erase disk strings. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
48d0de2e08 Let's try with no main message. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
326e566927 String changes. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
fe4cf3c4ec Add some spacing between label view item rows. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
0af434bfc1 Factor out text building for label view items for proper sizeHint. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
0be736acf7 Improve information in labels view. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
0224811bf6 Move Osprober to PCM and add Osprober roles to PartitionModel. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
7b66514bf5 Clean up debug spam. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
333214f7ca Finally fix selection. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
f154a135d8 Test out awful hack to try to make selection work properly. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
3fc354284a Improve debug output. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
8acb70de5c Use currentIndex instead of selection. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
99a5ac8e4d Debug output. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
7fce08459b Don't skip extended partition. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
f64d210496 Enable selection behavior and add debug output to Labels view. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
fecb50779a Only paint selection and hover if selectionMode is not NoSelection. 2015-12-30 17:27:13 +01:00