Adriaan de Groot
0be88f1453
[partition] Use signed sizes
2022-02-08 16:42:31 +01:00
Adriaan de Groot
a59c45d869
[users] Rename macro to avoid reserved-to-the-implementation names
2022-02-08 16:35:50 +01:00
Adriaan de Groot
7f14aa6bf1
[libcalamares] Avoid warnings about KPMCore headers
2022-02-08 16:35:23 +01:00
Adriaan de Groot
c7cc599a19
[umount] Remove/mark unused parameters
2022-02-08 16:35:04 +01:00
Adriaan de Groot
cf097850de
CMake: apply gersemi styling
2022-02-08 16:18:47 +01:00
Adriaan de Groot
b167d8da03
[libcalamares,ui] Make KF5::CoreAddons explicit
...
- libcalamares doesn't need it anymore, because it ported away
from KPluginLoader,
- libcalamaresui does need it, because of KMacroExpander.
2022-02-08 16:13:40 +01:00
Adriaan de Groot
e507a23795
Modules: make use of KF5::CoreAddons explicit
2022-02-08 16:12:25 +01:00
Adriaan de Groot
5160fdc26a
[libcalamares] Port away from KPluginFactory
2022-02-08 15:50:17 +01:00
Adriaan de Groot
8f769006d6
Merge branch 'calamares' into work-3.3
2022-02-08 13:28:20 +01:00
Adriaan de Groot
9f6f82405b
[libcalamaresui] Avoid crash if modules-list is empty
...
If there are no modules at all before an exec: section is
reached (e.g. right now due to a bug in module-loading)
then the last() call would crash. Instead, use a nullptr
for the last-module-loaded.
While here, apply code-formatting.
2022-02-07 19:05:55 +01:00
Adriaan de Groot
932ab17c9a
[libcalamares] Avoid parameter name 'stdin'
2022-02-07 12:54:16 +01:00
Adriaan de Groot
ebdcb15703
[libcalamares] Don't use reserved identifiers
2022-02-07 12:51:22 +01:00
Adriaan de Groot
660b198da0
[libcalamares] Avoid more moc warnings with recent Clang
2022-02-07 12:51:06 +01:00
Adriaan de Groot
fa7394723c
[users] Don't mess up cursor position when typing hostname
...
If the hostname changes while the field has focus, that means
that the user is typing in the field, and we shouldn't mess
with the cursor position.
FIXES #1884
2022-02-07 11:51:48 +01:00
Adriaan de Groot
3ea25a901e
[libcalamares] Avoid compiler warnings when stdin is defined to something else
2022-02-07 11:32:22 +01:00
Adriaan de Groot
d5c6a70442
[libcalamares] Use signed sizes
2022-02-07 11:22:13 +01:00
Adriaan de Groot
0fff01e36e
[partition] Use signed sizes
...
Unfortunate effect of having ints in some parts of the API
is that signedness trickles down everywhere; either cast
all over, or stick to signed ints.
2022-02-07 11:21:53 +01:00
Adriaan de Groot
d98027ad2f
Merge pull request #1865 from dalto8/mount-mount
...
Changes to mount module for 3.3
2022-02-02 16:24:34 +01:00
Adriaan de Groot
2bf43ffbf2
[unpackfs] Fix test validation (and document what the test is for)
2022-02-02 16:19:51 +01:00
Adriaan de Groot
0c7f06137a
CMake: validate all the test-configurations as well
2022-02-02 15:57:49 +01:00
Adriaan de Groot
a352bd946e
[grubcfg] snake-case one configuration key
...
This makes all the keys in grubcfg consistently
snake-case (rather than one being a camel).
2022-02-02 15:02:58 +01:00
Adriaan de Groot
d1e4740e70
Merge branch 'calamares' into work-3.3
2022-02-02 14:41:58 +01:00
Philip Müller
3e130c3e36
Merge branch 'calamares' of https://github.com/calamares/calamares into development
2022-02-01 19:14:27 +01:00
Adriaan de Groot
9127b76e5f
[bootloader] Fix typo's
2022-02-01 16:49:18 +01:00
Adriaan de Groot
cf913b87ff
[partition] Apply coding style
...
This applies the new(er) style to the whole module,
rather than just the files that recently changed.
2022-02-01 16:35:19 +01:00
Adriaan de Groot
7f90b99388
[partition Simplify mountpoint-input
...
- if nothing is selected (index -1, which now shows the placeholder), the text is empty
- if something has been entered, return it (e.g. if the user is typing)
- if something is selected, the text gets set to that anyway
2022-02-01 16:01:04 +01:00
Adriaan de Groot
f4720ae02c
[partition] <pre> formatting is block-oriented
2022-02-01 14:54:49 +01:00
Adriaan de Groot
45fff23499
[partition] Move message closer to input field
...
The warning about the mount point -- that it was in-use or
invalid -- had been separated from the drop-down by the
FSLabel field. Move it back, rename the variable for
clarity while we're at it.
2022-02-01 14:50:53 +01:00
Adriaan de Groot
82dcc1b57b
[partition] Refactor common validate-the-mount-point logic
2022-02-01 14:42:18 +01:00
Adriaan de Groot
d8be9a9443
[partition] Mount points should start with a /
2022-02-01 14:07:38 +01:00
Adriaan de Groot
fbcd1ffbbe
[partition] Make the "no mount point" a placeholder
2022-02-01 14:06:30 +01:00
Adriaan de Groot
d8c875f351
[partition] UI-tweak mount-point and fs-label boxes
...
- make the boxes expand, rather than stick to a minimum
size that doesn't align with other boxes in the dialog,
and which may be too small to contain the text they display.
2022-02-01 13:13:29 +01:00
Adriaan de Groot
6f738813a6
[fstab] GS configuration for a btrfs setup
2022-02-01 12:15:49 +01:00
Adriaan de Groot
4a30aae9bb
[calamares] Tighten logging in 'loadmodule' test-executable
2022-02-01 12:15:49 +01:00
Adriaan de Groot
e9899d0345
[packagechooser,netinstall] Apply coding style
2022-01-31 23:42:20 +01:00
Adriaan de Groot
ffeab32403
[libcalamares] Apply coding style
2022-01-31 23:41:37 +01:00
Adriaan de Groot
80300e412c
[libcalamares] When logging extra lines to warning or error, suppress label
...
Avoid logs like
23:29:57 [2]: void Config::setConfigurationMap(const QVariantMap&)
WARNING: Configuration for *initialSwapChoice* is not one of the *userSwapChoices*
WARNING: .. Choice "small" added.
where the label is duplicated.
2022-01-31 23:27:35 +01:00
Adriaan de Groot
51f67f6c3e
[partition] If initialSwapChoice can't be satisfied, add it
...
There is a mismatch between how the configuration interprets
*initialSwapChoice* when it is not a valid choice, and how
the UI interprets it. If you e.g. do not have a *userSwapChoices*
setting at all, whatever *initialSwapChoice* is set is interpreted
by the UI as "suspend".
Avoid that by putting the choice in the configuration and
warning the user (which ought to be a warning to the distro).
FIXES #1881
2022-01-31 23:15:04 +01:00
Adriaan de Groot
cf2899b1e6
[netinstall] Avoid negative row indexes
2022-01-31 12:59:03 +01:00
Adriaan de Groot
c0f4b80cbe
[netinstall] Tighten up comments and code
...
- comment wandered away from the function it applies to
- use overloaded name for recursive helpers
- document this new feature
2022-01-31 12:55:54 +01:00
Adriaan de Groot
19afa46978
[netinstall] Match comment to code (casing of the identifier)
2022-01-31 12:51:56 +01:00
Adriaan de Groot
6a2e80a0b7
Merge pull request #1879 from dalto8/pkgchooser-netinstall
...
Allow the packagechooser module to modify the netinstall module
2022-01-31 12:44:02 +01:00
Adriaan de Groot
5b994f85c9
[grubcfg] Keep kernel_params as 'quiet' by default
...
- mark some TODO
- tighten up the YAML schema a little bit
- when unset, use 'quiet' rather than empty, to preserve compatibility
with existing configuration files.
SEE #1882
2022-01-31 12:38:20 +01:00
Adriaan de Groot
37e189992e
Merge pull request #1882 from dalto8/grub-defaults
...
[grubcfg] Add configuration for default kernel_params
2022-01-31 12:12:06 +01:00
dalto
e597998021
[packagechooser,netinstall] Clean up duplication and pruning logic for netinstall-add
2022-01-27 19:31:34 -06:00
dalto
f65feedcce
[grubcfg] Add configuration for default kernel_params
2022-01-27 15:53:34 -06:00
dalto
6be1208488
Document global storage keys
2022-01-25 17:52:45 -06:00
dalto
63ed2e5fb8
[packagechooser,netinstall] Change globalstorage keys to camel case
2022-01-25 17:43:19 -06:00
dalto
22c9d888b4
[packagechooser,netinstall] Proper implementation of source field
2022-01-24 17:01:16 -06:00
dalto
1db217931b
[netinstall] Minor changes from code review
2022-01-24 15:39:14 -06:00
dalto
a657d7388c
[packagechooser] Remove obsolete functionality from netinstall-add
2022-01-23 14:47:14 -06:00
dalto
f4c2db7f21
[packagechooser,netinstall] Fix issues where going back and forth between pkgchooser and netinstall produced unexpected behavior
2022-01-23 13:58:10 -06:00
Adriaan de Groot
95122fdcf5
[partition] Warn if the system won't support encryption in a useful way
...
This is the infrastructure bit; if someone can come up with a way
of **meaningfully** detecting support, the detection function can
be given a better implementation.
FIXES #1725
2022-01-22 22:52:50 +01:00
dalto
2aa8c2f0e0
[packagechooser] Ensure multiple instances don't override the GS values
2022-01-19 16:48:56 -06:00
Philip Müller
e3bf37c261
Merge upstream development
2022-01-18 15:13:19 +01:00
Adriaan de Groot
929496552e
[bootloader] Optionally generate unique suffix for bootloader
2022-01-18 15:09:44 +01:00
Adriaan de Groot
c9156d41b1
[bootloader] Extend tests and docs with a few more error cases
2022-01-18 14:31:13 +01:00
Adriaan de Groot
7a462f4522
[bootloader] Fix issues identified by tests
...
- expectation derp11 was wrong, there were only 10 calls to next()
- using whole name instead of the not-the-suffix-bit was wrong
- phrase generator wrong length
2022-01-18 13:32:24 +01:00
Adriaan de Groot
ed5c4c9c87
[bootloader] Add generators for various suffix-flavors
2022-01-18 13:32:24 +01:00
Adriaan de Groot
b4b7deac2d
[bootloader] Document intentions
...
It may be easiest to modify the efiBootloaderId, since that does not
normally show up in the UI. I cannot quickly come up with a way to
do the same kind of suffixing on the user-visible name.
SEE #1820
2022-01-18 13:32:24 +01:00
Adriaan de Groot
c587145bdd
[umount] Drop all mention of removed configuration keys
2022-01-18 13:25:58 +01:00
dalto
4d5ae96db6
[umount] Add support for umount to be an emergency module
2022-01-18 13:25:00 +01:00
Adriaan de Groot
6034feb69d
[umount] Complete C++ implementation
...
- as a design decision, the deprecated "save some files" functionality
has been dropped from this implementation.
2022-01-18 13:22:45 +01:00
Adriaan de Groot
afa5e75d76
[umount] Start C++ port
2022-01-18 13:22:42 +01:00
Adriaan de Groot
5e4866c439
[partition] Simplify ClearTempMounts
...
- use the shared function for reading mtab entries
2022-01-18 13:22:20 +01:00
Adriaan de Groot
0070dd2c01
[libcalamares] Add a convenience for reading mtab
...
- used by umount and cleartempmounts (in future)
2022-01-18 13:22:20 +01:00
Adriaan de Groot
546780d7a8
Merge branch 'issue-1864' into calamares
...
FIXES #1864
2022-01-18 12:39:46 +01:00
Adriaan de Groot
da2612d2d9
[locale] Update language even if there is a current location
...
- the first time we arrive at locale, there isn't a current location
and the setCurrentLocation(...) method ends up calling setLanguage(),
usually. The second time, this call is skipped (not called from
the overloaded setCurrentLocation() which is called from onActivate),
so the language didn't update.
- now call setLanguage() unless there has been one set explicitly.
2022-01-18 12:28:57 +01:00
dalto
4811c59e33
[packages] Make pacman output more verbose
2022-01-17 16:24:56 -06:00
Adriaan de Groot
11f3f938d8
Merge pull request #1875 from dalto8/pacman-logs
...
[packages] Ensure all pacman output is available in debug log
2022-01-17 15:20:55 +01:00
Adriaan de Groot
6101dd9079
[locale] Code style
2022-01-17 14:51:42 +01:00
tjpark88
79a91b486a
[locale] Update language always
...
onActivate of locale updates the language only when currentLocation changed
or when onActivate of locale is called for the first time.
However, It is irrelevant solution since the language is set by the welcome.
So language should be updated always.
The language is used by keyboard module to guessing a layout of keyboard.
Once you face the locale, you can't change language in the welcome
if you don't change the timezone.
2022-01-17 14:51:42 +01:00
Adriaan de Groot
2aaaabe152
[partition] Set bigtime on XFS filesystems
...
FIXES #1874
2022-01-17 14:50:43 +01:00
Adriaan de Groot
a93126a6d0
[libcalamares] More meaningful name for JobResult success
2022-01-17 14:19:28 +01:00
dalto
112d0b2e90
[packages] Ensure all pacman output is available in debug log
2022-01-17 07:07:09 -06:00
Adriaan de Groot
e6813949af
[libcalamares] Hook up Python's error() to error, rather than warning
2022-01-17 13:47:47 +01:00
Adriaan de Groot
4be932ff9d
[umount] Now mark deprecated use as an error
2022-01-17 13:42:36 +01:00
dalto
b4ac6b73c8
[packagechooser,netinstall] Add documentation for packagechooser/netinstall integration
2022-01-15 11:13:17 -06:00
dalto
2eda55d3af
[packagechooser,netinstall] Add support for packagechooser to drive netinstall
2022-01-15 09:41:23 -06:00
Adriaan de Groot
a8f6596d38
Merge branch 'issue-1870' into calamares
...
- Improve the error messages in general
- Warn specifically if there isn't an *unpack* key
FIXES #1870
2022-01-12 14:39:54 +01:00
Adriaan de Groot
b227419f01
Merge pull request #1871 from dalto8/zfsfix-initcpiocfg
...
[initcpiocfg] Only add zfs hook if zfs is enabled
2022-01-12 11:31:53 +01:00
Adriaan de Groot
da03e12b7b
Merge pull request #1869 from dalto8/initramfs-fix
...
[initramfs] Fix condition when call to uname fails
2022-01-12 11:31:13 +01:00
Adriaan de Groot
624bb13736
Merge pull request #1868 from dalto8/fix-initcpio
...
initcpio module fixes
2022-01-12 11:19:36 +01:00
Adriaan de Groot
94bca61491
Docs: be a little more explicit about emergency mode
2022-01-12 11:16:42 +01:00
Adriaan de Groot
ee2fea74df
Merge pull request #1866 from dalto8/umount-emergency
...
[umount] Add support for umount to be an emergency module
2022-01-12 11:11:20 +01:00
dalto
1f9ae6cae6
[initcpiocfg] Only add zfshook if zfs is enabled
2022-01-07 14:49:26 -06:00
Adriaan de Groot
e14fa5de75
[unpackfs] Improve error messages
...
- the module is 'unpackfs', not 'unsquash'
- add a warning + specific error if there is no unpack key in the config
- the 'doing nothing' part isn't true: the module errors out instead
of doing nothing.
SEE #1870
2022-01-06 23:51:18 +01:00
dalto
626ab98949
[initramfs] Fix condition when call to uname fails
2022-01-02 08:41:47 -06:00
dalto
3be6946d93
[initcpio] Minor documentation updates
2022-01-01 12:14:42 -06:00
dalto
475c0d21a1
[initcpio] Spell mkinitcpio properly
2022-01-01 10:48:48 -06:00
dalto
c2ae5fad96
[initcpio] Make implementation match config description and remove broken uname option
2022-01-01 10:05:00 -06:00
dalto
4fe5f1c06f
[umount] Add support for umount to be an emergency module
2021-12-31 08:06:13 -06:00
dalto
5b483ab26f
[mount] Fix typo in mount.conf comments
2021-12-30 10:01:03 -06:00
dalto
3e1bc6cb22
[partition] Revert change to partition.conf
2021-12-30 09:36:54 -06:00
dalto
bb1d3022e0
[mount] Add additional documentation in mount.conf and main.py
2021-12-30 09:07:51 -06:00
dalto
a50ffa74e1
[mount,fstab] Fix bugs in moving mount options to the mount module
2021-12-30 09:07:51 -06:00
dalto
03f2e45605
[mount,fstab] Move mounting logic to the mount module
2021-12-30 09:07:51 -06:00
Philip Müller
ba0bcc8cd2
Merge branch 'calamares' of https://github.com/calamares/calamares into development
2021-12-28 11:51:55 +01:00
Adriaan de Groot
4e61f24960
[partition] Tidy up iso9660 detection
2021-12-25 18:27:13 +01:00
Adriaan de Groot
24a881ad75
Merge branch 'calamares' into work-3.3
2021-12-24 17:01:08 +01:00
demmm
7cfa654a68
[luksopenswaphookcfg] set plugin name according to module name
...
either this, or have all distros adjust settings.conf from luksopenswaphookcfg to luksopenswaphook
2021-12-22 22:17:13 +01:00
dalto
f0aba5db96
Update modules readme for Python emergency modules support
2021-12-19 15:29:42 -06:00
Adriaan de Groot
da72e815dc
[luksopenswaphookcfg] Fix build, missing include
2021-12-18 00:43:30 +01:00
Adriaan de Groot
7fc2859f23
[luksopenswaphookcfg] Port to C++
...
Merge pull request #1845 from calamares/issue-1659
FIXES #1659
FIXES #1644
2021-12-17 20:31:05 +01:00
Adriaan de Groot
587a18a6fa
[partition] Use runCommand() for future-proofing
2021-12-14 12:50:27 +01:00
Adriaan de Groot
f04394d014
[partition] Improve rendering of KPMCore errors
2021-12-13 20:02:52 +01:00
Adriaan de Groot
07354a26a9
[partition] Simplify debug calls to executables
...
- Use the Calamares support-functions for running lsblk and mount
(these might need to have privilege support if Cala is not
running as root, so this is future-proofing)
2021-12-13 20:02:52 +01:00
Adriaan de Groot
fdf0f208f0
[partition] Use lvalue-overload of execute() convenience
...
- These jobs may take a long time, and report progress; we need
the operation around to be able to connect the signals and slots
2021-12-13 20:02:52 +01:00
Adriaan de Groot
6680584724
[partition] Use convenience function execute()
...
This job needs the lvalue-overload of execute() because it needs to
call a method on the operation after execute() finishes successfully.
2021-12-13 20:02:52 +01:00
Adriaan de Groot
c5573a1997
[partition] Add non-const lvalue overload for execute()
2021-12-13 20:02:52 +01:00
Adriaan de Groot
b8ce21d572
[partition] Use convenience function for running operations
2021-12-13 20:02:52 +01:00
Adriaan de Groot
1356012fb4
[partition] With rvalue, code becomes even more compact
2021-12-13 20:02:52 +01:00
Adriaan de Groot
8bb2c5fc6b
[partition] Use convenience-method for running operation
2021-12-13 20:02:52 +01:00
Adriaan de Groot
dc7a1e43b7
[partition] Add helper for running a KPMCore operation
...
Most *partition* module jobs run an operation and turn that into
a JobResult -- ok if it succeeds, and with the report text otherwise.
Factor it out into a separate method that can be used as shorthand.
2021-12-13 20:02:52 +01:00
Philip Müller
fb630d722e
Merge branch 'development' of ssh://gitlab.manjaro.org:22277/applications/calamares into development
2021-12-13 18:41:58 +01:00
Philip Müller
d557fdd6c8
Merge branch 'calamares' of https://github.com/calamares/calamares into development
2021-12-13 18:41:09 +01:00
Adriaan de Groot
d3ed5663d0
[preservefiles] Add a schema-file
2021-12-13 16:56:07 +01:00
Adriaan de Groot
778c2855f4
[preservefiles] Introduce the notion of optionally-preserved files
2021-12-13 16:34:38 +01:00
Adriaan de Groot
445ed870cc
[preservefiles] Simplify code to help gcc warnings
2021-12-13 15:53:42 +01:00
Adriaan de Groot
3be52f8b37
[preservefiles] Expand tests with reading some existing config-items
2021-12-13 15:53:42 +01:00
Adriaan de Groot
a1b7ba0dc5
[preservefiles] Accessor for item-type (needed for tests)
2021-12-13 15:44:07 +01:00
Adriaan de Groot
8b5e49d980
[preservefiles] Add (stub) tests
2021-12-13 15:07:24 +01:00
Adriaan de Groot
90f6ea1fc8
[preservefiles] polish the documentation
2021-12-13 15:07:24 +01:00
Adriaan de Groot
238672ef78
[preservefiles] Split file-items into separate header
...
Put the Item class in a separate header; give it functionality
to create itself from Variants (e.g. from the configuration data)
and to run itself (do whatever the item is supposed to do).
This makes the polymorphic approach unnecessary: we just have
items that are sufficiently smart.
This moves do-a-thing to the Item, while the Job now has one
job: be a loop around creating Items and running items.
2021-12-13 15:05:05 +01:00
Adriaan de Groot
b1ecbb4151
[preservefiles] Start cleanup of structure, polymorphism
2021-12-13 15:05:05 +01:00
Johannes Kamprad
becb1d5710
Update preservefiles.conf
2021-12-12 01:22:22 +01:00
arcolinuxz
5b225cf960
[preservefiles] Put the logs in /var/log
2021-12-11 23:58:23 +01:00
Adriaan de Groot
132ebd2c2d
[networkcfg] NetworkManager files are UTF-8 encoded
...
The filenames don't matter, but the contents of the file are also
UTF-8, and depending on the default encoding of the Python
interpreter, this can fail on non-ASCII characters in the
file. Set the encoding explicitly while reading and writing
the NetworkManager configuration files.
FIXES #1848
2021-12-11 15:12:51 +01:00
Artem Grinev
1a1c1eb6dd
[fstab] Remove additional ssd options for btrfs
2021-12-11 13:30:17 +00:00
Adriaan de Groot
03da766b39
[partition] Keep 64-bit integers for swap sizes
...
FIXES #1849
2021-12-11 13:19:08 +01:00
Adriaan de Groot
7ac42b5f40
[umount] Tests don't like an empty config
...
- modules with no configuration should be marked 'noconfig',
but umount is special: it has no **useful** configuration
(maybe no **non-deprecated** configuration), but isn't
marked 'noconfig' **yet**.
2021-12-10 16:44:01 +01:00
Adriaan de Groot
3870851074
[luksopenswaphookcfg] Remove Python implementation
2021-12-08 14:35:52 +01:00
Adriaan de Groot
046a228d62
[luksopenswaphookcfg] Expand tests with lines more-closely tailored to the actual file-format
2021-12-08 14:25:03 +01:00
Adriaan de Groot
2c20a00cc3
[luksopenswaphookcfg] Read GS for finding LUKS config
2021-12-08 14:12:25 +01:00
Adriaan de Groot
45d6eb36fb
[luksopenswaphookcfg] Extend info with btrfs subvol
...
This is a C++-ification of e8936392
from dalto8 . Add a line
for options to the empty-file-fallback.
2021-12-08 14:12:25 +01:00
Adriaan de Groot
7ea21663ca
[luksopenswaphookcfg] Partial implementation in C++
...
- Futz a bit with the string replacements -- do not assume #
will introduce a comment half-way through a line.
2021-12-08 14:12:20 +01:00
Adriaan de Groot
5ca029df25
[luksopenswaphookcfg] Start a C++ port
...
- this module needs work to handle BTRFS special-cases *anyway*
- limited in scope, few options: port it while doing the
special-cases
So far, this is just a C++ stub.
SEE #1659 #1644
2021-12-08 14:12:20 +01:00
Adriaan de Groot
bc2713ccbb
[libcalamares] Add string functions for lstrip() and rstrip()-like
2021-12-08 14:08:37 +01:00
Philip Müller
9a2fd457ba
Merge branch 'calamares' of https://github.com/calamares/calamares into development
2021-12-08 13:09:31 +01:00
Adriaan de Groot
bb948c47dc
[fstab] Cut the example btrfs flags to 'defaults'
...
Testing shows that the flags can influence -- maybe cause -- data
corruption when noatime is set.
FIXES #1846
2021-12-08 13:06:53 +01:00
Adriaan de Groot
f0eb7ffbda
[partition Untangle, Warnings--
...
The translations apply to labels and a tooltip, which depends on
the partition-table type. Move the strings together and make
the whole range of the switch explicitly.
2021-12-08 00:59:20 +01:00
Adriaan de Groot
e8ca298712
[partition] Reduce warnings
2021-12-08 00:15:01 +01:00
Adriaan de Groot
13700b18c8
[partition] Warnings--
...
- remove superfluous `break`
- massage types around partition sizes
2021-12-08 00:06:17 +01:00
Adriaan de Groot
1197d8c750
[interactiveterminal] Warnings-- with KF5 5.86-or-later
2021-12-07 18:19:32 +01:00
Adriaan de Groot
09f47b5762
[partition] Build tests with consistent flags (in particular, KPMCore4-API flags)
2021-12-07 15:51:45 +01:00
Adriaan de Groot
4611545f93
[libcalamares] Warnings-- on switch()
...
- some switch statements handle a bunch of items explicitly,
then default the rest. Clang complains about that. Turn off
the warning for these specific switches, since there's dozens
of values that simply do not need to be handled.
2021-12-07 15:42:14 +01:00
Adriaan de Groot
6e715205d7
[partition] Warnings-- by calling formatting consistently
2021-12-07 15:36:11 +01:00
Adriaan de Groot
09a03fbbc0
[partition] Warnings--: we don't care about one-byte-in-10^12
2021-12-07 15:31:49 +01:00
Adriaan de Groot
bb3f4442f5
[partition] Warnings-reduction
...
- use consistent size-formatting
- needs an out-of-line virtual function
2021-12-07 15:30:21 +01:00
Adriaan de Groot
5b05110351
[partition] Add convenience function formatByteSize
...
We want to use the KPMCore function consistently, but Calamares
uses a qint64 most of the time. Centralize the cast to double
in one place in the code.
2021-12-07 15:29:02 +01:00
Adriaan de Groot
eda85c176a
[tracking] Avoid unused-deprecated-methods warnings
...
- these are internal classes, with no real Qt machinery; remove
the Q_OBJECT macros.
- replace the tr() calls with calls with an explicit context,
so that translations do not change.
2021-12-07 15:07:07 +01:00
Adriaan de Groot
32da51b44c
[libcalamares] Avoid warnings in Boost::Python macros
2021-12-07 14:48:19 +01:00
Adriaan de Groot
0b6239a996
[libcalamaresui] Warnings-- : we know TCP ports are 16 bit
2021-12-07 14:28:55 +01:00
Adriaan de Groot
79ae3cd00f
Merge branch 'shuffle-error-dialog' into calamares
2021-12-07 14:27:13 +01:00
Adriaan de Groot
c2e63f4a6b
[libcalamaresui] Don't bother tagging nonexistent 3rdparty sources
2021-12-07 14:20:31 +01:00
Adriaan de Groot
8b804c4ae0
[libcalamaresui] Improve icon+heading layout
...
- Icon was too wide, heading and message placed off to the side
2021-12-07 14:15:43 +01:00
Adriaan de Groot
3030a710cc
[libcalamaresui] Simplify
2021-12-07 12:58:22 +01:00
Adriaan de Groot
b07c9bb4af
[libcalamaresui] Use meaningful type for Upload info
...
- use a struct with named fields instead of a tuple
- offer an operator bool() for the logic of does-it-make-sense-to-upload
2021-12-07 12:53:43 +01:00
Adriaan de Groot
3234de5753
[libcalamaresui] Make web-paste decision more readable
2021-12-07 12:48:17 +01:00
Adriaan de Groot
2f9edb3e08
[libcalamaresui] Code style
2021-12-07 12:44:19 +01:00
Adriaan de Groot
ca7f288488
[libcalamaresui] APIDOX for ErrorDialog
2021-12-07 12:40:05 +01:00
Adriaan de Groot
49890acd04
[libcalamaresui] Fix build after move
2021-12-07 12:39:50 +01:00
Adriaan de Groot
dc11dd2203
[libcalamaresui] Move ErrorDialog to the widgets/ part
2021-12-07 12:24:41 +01:00
Adriaan de Groot
6e59177f54
Merge pull request #1843 from LordTermor/calamares
...
Rework of error dialog
2021-12-07 12:06:01 +01:00
Adriaan de Groot
149f3ff3fe
[partition] Reduce warnings about shadowed variables
2021-12-06 14:52:33 +01:00
Adriaan de Groot
d89553a777
[partition] Avoid problems with MessageAndPath in containers (drop const)
2021-12-06 14:46:26 +01:00
Adriaan de Groot
890c17cd71
[libcalamares] Expand error-logging when creating files
2021-12-06 14:46:26 +01:00
Adriaan de Groot
6ef7acc108
[libcalamares] Add minor tests for new readTargetFile
2021-12-06 14:46:26 +01:00
Adriaan de Groot
baf8297cc4
[libcalamares] Reading a file from target system
2021-12-06 14:46:26 +01:00
Adriaan de Groot
47f2dd3c18
Merge pull request #1844 from dalto8/openswap
...
Add support for unlocking encrypted swap with root on a btrfs subvol
2021-12-06 10:42:44 +01:00
dalto
6e08da6c8d
[bootloader] Fix error with systemd-boot when path exists in the ESP
2021-12-06 10:31:58 +01:00
Artem Grinev
aa332477fd
[libcalamaresui] Run clang-format on TranslationFix.cpp
2021-12-06 03:11:16 +04:00
Artem Grinev
d9f7726f7d
[libcalamaresui] Add SPDX-header for Error Dialog files
2021-12-06 02:41:17 +04:00
Artem Grinev
2f2a418cc4
[libcalamaresui] Run clang-format
2021-12-06 02:37:11 +04:00
Artem Grinev
2dd77ee828
[libcalamaresui] Initialize Error Dialog field
2021-12-06 02:31:05 +04:00
Artem Grinev
bfa7b9a792
[libcalamaresui] Use translation fix for Error Dialog
2021-12-06 02:27:18 +04:00
Artem Grinev
32c5e18db0
[libcalamaresui] Add QDialogButtonBox translation fix
2021-12-06 02:26:13 +04:00
dalto
e8936392e3
[luksopenswaphookcfg] Add support unlocking swap with root on a btrfs subvol
2021-12-05 13:17:23 -06:00
Adriaan de Groot
c834a5066d
[umount] Make it much more clear that the logfiles-thing is going away.
2021-12-05 02:26:23 +01:00
Artem Grinev
6bf0da7230
[libcalamaresui] Initial rework of error dialog
2021-12-05 04:50:13 +04:00
Adriaan de Groot
1d96c5af46
[partition] Table type 'none' is a late addition.
2021-12-05 01:32:51 +01:00
dalto
6e8779cbce
[mount] Ensure path is available when creating nested btrfs subvolumes
2021-12-04 08:53:15 -06:00
Philip Müller
b7763f0427
Merge branch 'calamares' of https://github.com/calamares/calamares into development
2021-12-04 10:48:56 +01:00
Adriaan de Groot
ceb9ec4115
[fstab] Avoid KeyError when no subvol is set (from dalto8)
2021-12-04 02:15:33 +01:00
Adriaan de Groot
c22bbea528
[packages] Fix tests; YAML interpretation of 'yes' is not a bool
2021-12-04 02:04:24 +01:00
Adriaan de Groot
f26c81700d
[fstab] Suppress empty subvol= options in fstab
2021-12-02 22:08:17 +01:00
Adriaan de Groot
96ccf256b2
[mount] Add documentation to the config file
2021-12-02 22:02:14 +01:00
Adriaan de Groot
951ddfb72a
[mount] Experimental: accept 'no' for subvolumes
...
If there is no subvolume set, skip creation of that subvolume.
This allows root to be on a bare FS, without a tag or subvolume
name. To achieve this, use
subvolume: no
(no quotes there) in the YAML.
2021-12-01 23:06:02 +01:00
Adriaan de Groot
1667d75a70
CMake: WITH_KF5Crash -> BUILD_KF5Crash
...
ABI-changing flags are WITH_*, features and dependencies are BUILD_*
2021-11-30 11:49:43 +01:00
Adriaan de Groot
ce23efae99
Merge branch 'calamares' into work-3.3
2021-11-30 11:39:30 +01:00
Adriaan de Groot
3845e05834
[locale] Correct timezone 5.0 / 5.5
...
Timezones 5.0 and 5.5 have considerable overlap; clear up most
of it. Since a pixel is about 55x55km on the ground, and the
translation of latitude and longitude is sketchy at best,
accuracy on this timezone map is not very good.
FIXES #1832
2021-11-29 22:04:31 +01:00
Adriaan de Groot
cdc3a9aad2
Merge pull request #1834 from dalto8/btrfs-swap
...
[fstab] Use different options for the btrfs swap subvolume
2021-11-29 15:16:17 +01:00
Adriaan de Groot
dfd13b4948
[packages] Remove bad config-lines
...
- rootMountPoint is a global thing, not a job-configuration item
2021-11-29 15:02:05 +01:00
Adriaan de Groot
28bd737062
[packages] Validate test-configs, too
...
- The config-files has a typo, so didn't validate, so
the loaded data was wrong, leading to test-failures.
See 61e0d538e9
.
2021-11-29 14:59:43 +01:00
Adriaan de Groot
61e0d538e9
[packages] Be more explicit in test failures, fix test data
2021-11-29 14:44:12 +01:00
Adriaan de Groot
474aaf7603
[packages] Fix loading of the subkeys for pacman
2021-11-29 14:23:15 +01:00
Adriaan de Groot
65488ca174
[libcalamares] More verbose when loading YAML for Python
2021-11-29 14:19:06 +01:00
Adriaan de Groot
1260d3fcb9
[packages] Expand tests for PM-specifics more
2021-11-29 13:21:50 +01:00
Adriaan de Groot
3e0c9ba056
[packages] Expand tests with PM-specific bits
2021-11-29 13:04:44 +01:00
Adriaan de Groot
fcbe8d3a3e
[libcalamares] API for YAML-loading from Python
2021-11-29 12:59:30 +01:00
Adriaan de Groot
7f643010b2
[libcalamares] Expose error() and warn() to Python
2021-11-29 12:26:07 +01:00
Adriaan de Groot
e9970474f5
[libcalamares] Allow Python to log an Error as well
2021-11-29 12:22:02 +01:00
Adriaan de Groot
8a1e5d35fa
[packages] Move pacman-options into their own key with subkeys
2021-11-29 11:59:09 +01:00
Adriaan de Groot
90459e434f
Merge pull request #1833 from dalto8/pacman
...
[packages] Additional pacman options
2021-11-29 11:39:01 +01:00
dalto
bd07db544f
[packages] Update doumentation for run_pacman() to be more complete
2021-11-28 15:56:16 -06:00
dalto
6b838bbf3d
[fstab] Add comment explaining logic
2021-11-26 13:00:30 -06:00
dalto
df3e049e1c
[fstab] Use different options for the btrfs swap subvolume
2021-11-26 12:36:15 -06:00
dalto
bb24ee1b3b
[packages] Fix location of call to reset_progress()
2021-11-26 10:56:32 -06:00
dalto
c80b4ff4c2
[packages] Make callback logic more sensible
2021-11-26 08:30:18 -06:00
dalto
e1e29780f2
[packages] Change callbacks
2021-11-25 15:55:22 -06:00
dalto
fa10bb8dd3
[packages] Add support for more pacman options
2021-11-25 11:52:41 -06:00
Philip Müller
fe2d8f3262
Merge branch 'calamares' of https://github.com/calamares/calamares into development
2021-11-24 11:53:45 +01:00
dalto
ee032b43fe
[zfs] Fix spelling error in readme
2021-11-19 14:24:36 -06:00
dalto
f37a775977
[zfs] Update module documentation
2021-11-19 10:46:23 -06:00
Adriaan de Groot
8ca6a7caef
[displaymanager] Fix tests (don't overwrite developer host configuration)
2021-11-16 17:30:28 +01:00
Adriaan de Groot
b0d951d7e5
[grubcfg] Avoid UnboundLocal, always set zfs_root_path to something
2021-11-16 17:22:43 +01:00
Adriaan de Groot
8652fc5f6d
[zfs] Fix schema
...
- typo (canmount vs canMount)
- the canMount property is nominally a string, but YAML is 'special'
and interprets 'on' and 'off' and 'yes' and 'no' and other strings
as booleans unless quoted.
2021-11-16 17:14:12 +01:00
Adriaan de Groot
b00177bd65
[zfs] SPDX tag the documentation
2021-11-19 12:55:23 +01:00
Adriaan de Groot
bcd8ebd614
[displaymanager] SPDX tags for tests
2021-11-19 12:53:42 +01:00
Adriaan de Groot
2f2271aad6
[mount][bootloader] Communicate btrfs root subvolume
...
Ensure root subvolume is set correctly for systemd-boot.
FIXES #1821
2021-11-19 11:20:09 +01:00
dalto
f5b882a075
[partition] Remove setState call to resolve compat issue with older kpmcore
2021-11-18 13:36:23 -06:00
dalto
b0f6530a58
[mount][bootloader] Ensure root subvolume is set correctly for systemd-boot
2021-11-18 10:04:49 -06:00
Adriaan de Groot
ece1e338e0
Merge pull request #1822 from dalto8/zfs-wip
...
[zfs] Support for installing to root-on-ZFS
2021-11-17 12:20:34 +01:00
dalto8
e814920bca
[zfs] Fix typo in README
2021-11-17 00:17:59 +00:00
dalto
c70e31a919
[zfs] Add README.md with some implementation notes
2021-11-16 18:16:32 -06:00
dalto
7e17106f34
[bootloader] Cleanup zfs support from testing
2021-11-16 17:48:49 -06:00
dalto
9603cbef14
[grubcfg] Add zfs entry to kernel_params
2021-11-16 17:48:02 -06:00
dalto
87cca4053f
[zfs][mount] Refactor zfs dataset mounting logic
2021-11-16 13:59:24 -06:00
dalto
b65321d80b
[bootloader] Add zfs support for grub-install
2021-11-16 13:48:34 -06:00
dalto
3ee388526d
[zfs] Cleanup code based on review feedback
2021-11-16 09:06:42 -06:00
Adriaan de Groot
efe84bc6c0
[partition] Don't log private names
...
- log device node (/dev/sdb) instead of its name
- don't log job's prettyName() because that's translated, and also
contains user-visible private names (introducing a non-translated,
nicely redacted version of prettyName() seems like too much effort
for something that can be reconstructed from bits earlier in the log)
2021-11-16 15:31:35 +01:00
Adriaan de Groot
5a4e2b73ab
[libcalamares][partition] Give RedactedName a convert-to-QString
...
- use hex-trailer
- while here, convert DebugRow to use a copy rather than a reference,
to avoid dangling references when applied to temporaries
- convert *partition* module to use the RedactedNames
2021-11-16 15:22:04 +01:00
Adriaan de Groot
152b3c333b
[libcalamares] Introduce redaction-of-names class for logging
...
- redacted names are stable inside of one run of Calamares
- random, private displays of a given string for a context
SEE #1593
2021-11-16 14:47:13 +01:00
Adriaan de Groot
7b3c4db8f0
[libcalamares] Redacted -> RedactedCommand
...
- For logging (shell) commands where a password might become visible, use
RedactedCommand. Rename it to allow for other kinds of redaction, too.
2021-11-16 14:21:46 +01:00
Adriaan de Groot
7cc84b89be
[partition] Clarify the meaning of the various UUIDs in debug-output
2021-11-16 14:15:00 +01:00
Adriaan de Groot
4db4e983e3
[partition] Don't format tables of attributes in source
2021-11-16 14:04:00 +01:00
Adriaan de Groot
3aac4dea67
[partition] Remove logging-of-a-pointer during device detection
2021-11-16 13:52:10 +01:00
dalto
0a7262148e
[umount] Convert zfs export call to use host_env_process_output
2021-11-15 19:03:20 -06:00
dalto
4778d9b2dd
[mount] zfs changes from review feedback
2021-11-15 18:41:35 -06:00
dalto
3a90382699
[partition] zfs changes from review feedback
2021-11-15 18:41:35 -06:00
dalto
3ebe695a23
[fstab] Exclude zfs partitions from fstab
2021-11-15 18:41:35 -06:00
dalto
ebae698a6e
[mount] Move zfs code into a seperate function to improve readability
2021-11-15 18:41:35 -06:00
dalto
18ad188ef6
[zfs] Ensure overlapping datasets don't get created and code cleanup
2021-11-15 18:41:35 -06:00
dalto
6e440bf9bb
[umount] Export zpools after unmounting
2021-11-15 18:41:35 -06:00
dalto
490ac8d086
[partition] Ensure format is selected for existing zfs partitions
2021-11-15 18:41:35 -06:00
dalto
c48c91a5bd
[partition] Add support for zfs encryption when erase disk is selected
2021-11-15 18:41:35 -06:00
dalto
ee99ee48f6
Add support for multiple zpools
2021-11-15 18:41:35 -06:00
dalto
a5b21b2500
[zfs] Fix typo and add missing continue
2021-11-15 18:41:34 -06:00
dalto
75c947c5a3
[mount] Fix zfs code and add support for encryption
2021-11-15 18:41:34 -06:00
dalto
1ccabf1b13
[zfs] Export zpool so it can later be mounted at the correct location
2021-11-15 18:41:34 -06:00
dalto
6da9bad272
[partition][zfs] Add support for zfs encryption
2021-11-15 18:41:34 -06:00
dalto
074941e2bd
[bootloader] Add initial support for zfs
2021-11-15 18:41:34 -06:00
dalto
5d71723aec
[mount] Improve error handling for zfs
2021-11-15 18:41:34 -06:00
dalto
de0bbbe90a
[mount] Add support for zfs datasets
2021-11-15 18:41:34 -06:00
dalto
7f05096611
[zfs] Add delay before creating the zpool
2021-11-15 18:41:34 -06:00
dalto
7635b76352
[zfs] Add datasets to global storage for other modules
2021-11-15 18:41:34 -06:00
dalto
b9559a9d82
[zfs] Update to Calamares coding standards
2021-11-15 18:41:34 -06:00
dalto
76892136cf
[initcpiocfg] Add support for zfs
2021-11-15 18:41:34 -06:00
dalto
11bf84bac7
[zfs] Initial commit for zfs module
2021-11-15 18:41:34 -06:00
dalto
24a376493b
[partition] Add support for manually creating a partition for zfs
2021-11-15 18:41:34 -06:00
dalto
ca3f0e2892
[partition] Add zfs to the filesystem list if the zfs modules is enabled
2021-11-15 18:41:34 -06:00
Adriaan de Groot
3dd02edc78
[libcalamares] Document how to interpret percents
...
- use 0..1 in floats for percentages (I suppose you could
call that a perunage, but that would be weird).
2021-11-15 23:16:58 +01:00
Adriaan de Groot
d5bef9efb5
Python: document which exception is thrown on process failure
2021-11-15 21:48:17 +01:00
Adriaan de Groot
5f7b221e11
[displaymanager] Fix greetd commands
...
- since default_desktop_environment isn't a string, need
to pick the string -- the command -- out of the object first.
2021-11-15 13:38:46 +01:00
Adriaan de Groot
16a029abd2
[displaymanager] Adjust tests to match real runtime
...
- the default_desktop_environment isn't a string, but an
object; it is unusual for it to be used in set_autologin
2021-11-15 13:37:23 +01:00
Adriaan de Groot
f3e85efd41
[displaymanager] Add tests that run parts of the DM code
...
- load and set autologin for greetd (this was used to shake out
code bugs in load/save)
- load and set autologin for sddm
2021-11-15 13:00:40 +01:00
Adriaan de Groot
ce6aec158a
[displaymanager] Fix config loading-and-saving
...
- toml.dump() takes a file-like object
- toml.loads() takes a whole string to parse, (e.g. the TOML data),
not a pathname, so change to toml.load() which takes a file-like
object.
2021-11-15 12:23:17 +01:00
Adriaan de Groot
54fd81a87e
[displaymanager] Handle case where config file doesn't exist or has no key
...
- If the config file doesn't exist, the dictionary is empty
- If it **does** exist, it might not have key 'default_session' in it
Either case should avoid a KeyError by using get() (or setdefault,
in this context). Subsequent use of os.path.exists() is strange,
since the value is a **group** (e.g. a dictionary) in the config
file. Just check if it exists, and then fill something in.
2021-11-15 12:21:27 +01:00
Adriaan de Groot
11424195ef
[displaymanager] Missing method call
...
- Add `()` to call the config_path() method, because we need a path
to pass to os.path.exists().
2021-11-15 12:20:54 +01:00
Adriaan de Groot
fad2f6ea88
[displaymanager] Add simple test
2021-11-15 11:52:24 +01:00
Adriaan de Groot
58cf9ffeeb
[displaymanager] Import toml only for the DMs that actually need it
2021-11-15 11:43:47 +01:00
Adriaan de Groot
85f36c77b1
[displaymanager] Import configparser only for the DMs that actually need it
2021-11-15 11:42:25 +01:00
Adriaan de Groot
138db1c817
Merge branch 'feat/greetd-support' of git://github.com/boredland/calamares into boredland-feat/greetd-support
2021-11-15 11:40:18 +01:00
dalto
daa5731acf
[fstab] Improve comment about space_cache
2021-11-12 09:29:04 -06:00
dalto
9ef520f862
Add comment describing the situation with space_cache on btrfs
2021-11-12 08:58:43 -06:00
dalto
0bef2a91a1
[fstab] Remove space_cache from btrfs mount options
2021-11-10 17:16:09 -06:00
Adriaan de Groot
4fb8993a38
[finishedq] Add sample QML for mobile usage
...
This has a countdown-timer that automatically restarts;
the rest of the settings follow the finishedq.conf values.
FIXES #1601
2021-11-09 23:08:40 +01:00
Adriaan de Groot
8639c9a79f
[partition] Fix up tests
2021-11-09 16:37:25 +01:00
Adriaan de Groot
cd0785164b
[partition] Fix compatibility with Qt 5.12
2021-11-09 15:57:20 +01:00
Adriaan de Groot
bd4bed1438
Merge branch 'calamares' into work-3.3
2021-11-09 15:31:37 +01:00
Adriaan de Groot
2a86e86817
[packages] Make package-installation messages slightly less scary.
...
From a test with XeroLinux, at some point it says 'reinstalling linux...'
which is a message from pacman about the package called 'linux'.
2021-11-09 15:25:06 +01:00
Adriaan de Groot
e4b44b5f85
[packages] Look for other progress indicators
...
- the (n/m) lines are output of specific steps, not actual package-
installation. So look for "<action> <packagename> ..." lines instead.
This means we keep some state around, and need extra machinery to
report those lines rather than the generic progress reporting
that reports on groups.
2021-11-09 14:42:12 +01:00
Adriaan de Groot
4821f450f3
[packages] Report progress by scanning pacman output
...
- during install and remove, check for (n/m) output lines which
report progress of the pacman actions and turn those into progress
reports for the *packages* module.
2021-11-09 13:07:29 +01:00
Adriaan de Groot
575654941f
[partition] Move required partition table type to Config
...
- remove from GS
- remove duplication across Config and ChoicePage
- improve translations (presumably "msdos or gpt" is the most
complicated it will get)
FIXES #1735
2021-11-09 12:25:47 +01:00
Philip Müller
fad0503696
Merge branch 'calamares' of https://github.com/calamares/calamares into development
2021-11-09 01:59:17 +01:00
Philip Müller
21641bd2a2
[partition] offer /boot also when other EFI partition was specified
...
- it still makes sense to offer /boot in EFI
- example: /boot ext4, /boot/efi vfat
- this partly reverts 60f8a7c5fb
2021-11-09 01:59:06 +01:00
Philip Müller
0486e48c4e
[partition] offer /boot also when other EFI partition was specified
...
- it still makes sense to offer /boot in EFI
- example: /boot ext4, /boot/efi vfat
- this partly reverts 60f8a7c5fb
2021-11-09 01:51:49 +01:00
Adriaan de Groot
ead641c344
[summary] Prefer a step's widget over text
...
- the partition module makes a nice descriptive widget,
which includes the text it **also** has for the summary;
(the text is intended for the QML summary).
- In general, if a module has a widget for the summary, assume
that that is the **whole** summary and use it instead of text.
This resolves duplicate summaries -- showing the text of the
partitioning-step, followed by its widget -- introduced in July.
2021-11-08 14:44:12 +01:00
Adriaan de Groot
6130a9c51f
[unpackfs] Re-jig process-return-value in Python
...
- make the installation work,
- special case because rsync can return error 23 (which throws, from
inside the Python API) which still means "it was ok".
2021-11-05 16:52:18 +01:00
Adriaan de Groot
c79bb3cd10
[unpacks] PARTIAL conversion to newer API with callback
2021-11-05 16:33:10 +01:00
Adriaan de Groot
b9691c339e
S also docs
2021-11-05 16:32:40 +01:00
Adriaan de Groot
5e6d292235
FIXUP
2021-11-05 16:31:47 +01:00
Adriaan de Groot
faf1d68d32
[libcalamares] Tidy up processing of process output
...
- force C locale on processes
- split trailing output if output per-line-processing is active
2021-11-05 16:26:45 +01:00
Adriaan de Groot
94039c19bb
[unpackfs] Use callback instead of building giant string in memory
...
SEE #1740
By processing each line in turn (and just counting is) rather
than collecting all of the lines of output from the tools,
we end up with lower memory usage.
2021-11-03 16:09:11 +01:00
Adriaan de Groot
e8209089c6
Merge branch 'issue-1740' into calamares
...
FIXES #1740
2021-11-03 15:49:03 +01:00
Adriaan de Groot
fe582fb94d
Docs: document the Python APIs for modules
2021-11-03 15:48:26 +01:00
Adriaan de Groot
74d65d8338
Docs: touch-ups and typos
2021-11-03 13:51:17 +01:00
Adriaan de Groot
2800128a8d
[libcalamares] Expand the output-processing API
...
- support host and target runs
- add stdin and timeout values
- allow automatic output to list
2021-11-03 13:45:15 +01:00
Adriaan de Groot
3120abbce8
[libcalamares] Introduce host_env_process_output, too
...
- run commands consistently, with optional output-processing,
in host or target;
- raises exception on error, like the check_* functions.
2021-11-03 12:23:39 +01:00
Adriaan de Groot
e5323ec487
[libcalamares] Expand Runner documentation
...
- document a bit more of the methods
- provide convenience method enableOutputProcessing() alongside
an explicit setter; adjust tests to the changed API.
- add an executable() information method.
2021-11-03 12:20:36 +01:00
Adriaan de Groot
f2142bc4b3
[libcalamares] Move Python callback to utils submodule
...
- don't need the job to do the callback
- allow callable objects from Python
- doesn't actually run the process yet
2021-11-03 11:53:44 +01:00
Adriaan de Groot
a0cb4b63a8
[partition] Fix build for old Qt
2021-11-03 11:14:22 +01:00
Adriaan de Groot
344948b5ab
Modules: clean up QProcess (part 1)
2021-11-02 23:46:26 +01:00
Adriaan de Groot
2088502e57
[libcalamares] Don't use QProcess directly outside of Runner
2021-11-02 23:46:26 +01:00
Adriaan de Groot
57c174c37f
[libcalamares] Clean up QProcess includes
2021-11-02 23:46:26 +01:00
Adriaan de Groot
5c82cb32ab
[libcalamares] Expand tests to show last-output-line
2021-11-02 23:20:22 +01:00
Adriaan de Groot
aa315c0696
[libcalamares] Handle last-output-line without newline
2021-11-02 22:58:41 +01:00
Adriaan de Groot
0a339a5402
[libcalamares] Test Runner output-processing
2021-11-02 22:55:41 +01:00
Adriaan de Groot
953b899f75
[libcalamares] Allow Runner instances to collect output
2021-11-02 22:50:13 +01:00
Adriaan de Groot
870009e815
[libcalamares] Replace runCommand internals by Runner
2021-11-02 22:27:33 +01:00
Adriaan de Groot
89824a9e0d
[libcalamares] Fix up Runner (as a replacement for current system code)
2021-11-02 22:27:33 +01:00
Adriaan de Groot
24ca64deac
[libcalamares] Chase moved redacted-logging
2021-11-02 22:27:33 +01:00
Adriaan de Groot
85debfc69b
[libcalamares] Add Redacted logging
...
- this was an internal class for logging commands, let's lift
it up to the Logger framework where it might be more generally
useful (or not .. everything needs special-casing for actual
redaction).
2021-11-02 22:27:33 +01:00
Adriaan de Groot
f0104af1c3
[libcalamares] Expand tests on Runner internals
2021-11-02 22:27:33 +01:00
Adriaan de Groot
e5fa58b890
[libcalamares] Add tests for relativeCangeDirectory()
2021-11-02 22:27:32 +01:00
Adriaan de Groot
0b943e801c
[libcalamares] Begin implementing Runner
...
This copies a bunch of code from the System methods for running,
and then #if 0's them to get it to compile. Add some basic
directory-management.
2021-11-02 22:27:32 +01:00
Adriaan de Groot
b9dac6eef8
[libcalamares] Small step in implementation
2021-11-02 22:27:32 +01:00
Adriaan de Groot
e0fdde06c9
[libcalamares] Python API for callbacks from processes
...
This is an experiment in Python API that will allow a callback
function in the Python module to be called for each output line.
It builds on the run-a-process extensions that are being built
simultaneously.
2021-11-02 22:27:32 +01:00
Adriaan de Groot
2de09d4001
[libcalamares] Start refactor of running-a-process support
...
The background idea is that, while CalamaresUtils::System::runCommand()
is a useful general API, it is
- still missing flexibility
- lacking a way to process output from the command "as it happens"
Waiting until the process ends, and then reading all stdout, is
inconvenient for processes that produce a **lot** of output,
and also makes it impossible to report progress. One module
in calamares-extensions has its own run-a-process implementation
for reading output, and this branch aims to introduce something
similar into Calamares core.
2021-11-02 22:27:32 +01:00
Adriaan de Groot
b5dba9108c
[partition] Check for LVs that will be formatted, don't close them
...
- when (manually) using an existing LV, it shouldn't be closed
prior to formatting, since that kills the volume and then the
path (/dev/myvg/mylv) no longer exists. Then creating the
filesysytem on that device path fails.
2021-11-02 15:33:34 +01:00
Adriaan de Groot
7b45793b60
[partition] Allow exceptions when closing /dev/mapper
...
- some names should not be closed, like "control"
- allow a list of names to be added which should not be closed
2021-11-02 15:26:25 +01:00
Adriaan de Groot
1410157356
[partition] Simplify and document ClearMounts
...
- note that the job indiscriminately closes all LUKS and LV
- don't hang on to lists we don't need
2021-11-02 11:55:13 +01:00
Adriaan de Groot
0253977778
[partition] Coding style
2021-11-02 11:50:51 +01:00
Adriaan de Groot
ca4a187d1a
[partition] Extract the get-PV-groups code to its own function
...
- get the list (once)
- move the lambda to a named function for readability
2021-11-02 11:18:14 +01:00
Adriaan de Groot
7fa02fd41c
[partition] Extract the get-LVM-volumes code to its own function
2021-11-02 11:10:09 +01:00
Adriaan de Groot
2a1ec84c87
[partition] Don't hang on to pointer longer than needed
2021-11-02 11:03:10 +01:00
Adriaan de Groot
04b119b051
[partition] Crypto device-list needn't be a member, either
2021-11-02 00:25:37 +01:00
Adriaan de Groot
f49389a408
[partition] Fix logic errors in stringification of MessageAndPath
2021-11-02 00:09:52 +01:00
Adriaan de Groot
c322eaa430
[partition] Fix translation issues
...
- Strings were being used as logical values, and then logged
(which should be in English) and also used in the UI (which
should be localized). Replace with a MessageAndPath class,
used only locally, that defers the translation until called-
upon explicitly.
- Replace some VG stuff with similar calls to apply().
2021-11-01 23:59:39 +01:00
Adriaan de Groot
e56158f5b4
[partition] Generate partition paths with /dev/
...
Returning partition full-paths instead of only the block-device-name
simplifies later code -- which would prepend /dev/ to the block-
device-name and umount that.
2021-11-01 20:54:48 +01:00
Adriaan de Groot
6c2b2b0daa
[partition] Factor out loops, document return values
...
- the tryX() functions weirdly return a string that is used for
debug-logging. Document that. The untranslated string is
later used for user-facing messages. Mark that as FIXME.
- factor out the loop-over-names-and-append to news, because that
makes the overall story of what is happening hard to read.
- all calls to tryCryptoClose() called tryUnmount() first, so
put that call inside tryCryptoClose(), so the interface is simpler.
2021-11-01 20:54:18 +01:00
Adriaan de Groot
0c84a87c67
[partition] Make internal methods static
2021-11-01 20:28:47 +01:00
Adriaan de Groot
105517fed7
[partition] Coding style
2021-11-01 20:24:47 +01:00
Adriaan de Groot
ac34cfadea
[partition] Factor out finding the swap-partitions
2021-11-01 20:23:49 +01:00
Adriaan de Groot
3e58639a68
[partition] Improve logging in ClearMountsJob
...
- mark internal bits as static
- explain what is being looked-for
SEE #1817
SEE #1564
2021-11-01 16:44:28 +01:00
Adriaan de Groot
218c1d9344
[fstab] Weaken the prescription against / in crypttab
...
FIXES #1811
2021-11-01 14:52:04 +01:00
Adriaan de Groot
0df288f647
[welcome] Improve logging of unsatisfied requirements
...
- improve descriptive-strings in logging ("set?" is not very
meaningful)
- log only the unsatisfied entries, since the preceding
log-message suggests that that is what is happening.
2021-11-01 14:24:50 +01:00
Philip Müller
3fba6cf57e
[merge] with upstream
2021-10-31 16:02:33 +01:00
Adriaan de Groot
dde55471ba
Merge branch 'calamares' into work-3.3
2021-10-30 15:00:54 +02:00
Adriaan de Groot
cd56bab622
[partition] Merge pull request #1808 from dalto8/zfs-delete-fix
...
Fix for zfs partition deletion
2021-10-30 14:44:39 +02:00
dalto
13a2d25b24
Add separate functions for zfs
2021-10-29 16:54:09 -05:00
Adriaan de Groot
e9083ecabb
[services-systemd] Add a schema file for the configuration
2021-10-29 16:41:03 +02:00
Adriaan de Groot
7aaefa42d1
Merge pull request #1815 from dalto8/timer
...
[services-systemd] Add support for timers
2021-10-29 14:29:50 +02:00
Adriaan de Groot
9e1b8622f2
[packagechooser] Replace smartClip() with just-do-it
...
QLabel allows scaling of the Pixmap by itself, and we have a
FixedAspectRatioLabel that scales a pixmap nicely. Use that.
(The new label type needed to be introduced to designer)
The screenshot should expand more agressively, so that it
does not get margins -- that just leave space around the
name and description -- when the window expands. Adjust some
of the stretching and layout in the UI file.
2021-10-29 13:15:07 +02:00
Adriaan de Groot
d3d4690a81
[libcalamares] Move const to a better spot
2021-10-29 11:25:13 +02:00
Adriaan de Groot
ebf8d63669
Merge pull request #1809 from dalto8/ismoduleenabled
...
[libcalamares] Add isModuleEnabled function
2021-10-29 11:20:07 +02:00
Jonas Strassel
5701937883
fix(greetd): deal with no existing config
2021-10-29 00:02:16 +02:00
dalto
f7d8384bff
Use key().module() instead of key().first
2021-10-28 14:49:44 -05:00
dalto
be513813e6
Clean-up from initial review
2021-10-28 14:46:38 -05:00
dalto
24fbd3ab90
More doc changes for services-systemd module
2021-10-28 07:40:05 -05:00
dalto
96f3de12b3
Update documentation for services-systemd module
2021-10-28 07:33:32 -05:00
Philip Müller
e36df22323
[postcfg] we should also check for folders
2021-10-28 13:39:27 +02:00
Philip Müller
0fbdaa5756
Merge branch 'calamares' of https://github.com/calamares/calamares into development
2021-10-28 13:37:58 +02:00
Jonas Strassel
fbdb9e6779
feat(greetd): add more greeter fallbacks
2021-10-28 08:14:04 +02:00
Jonas Strassel
e5f5ef0d17
feat(greetd): add greetd to displaymanagers
2021-10-28 08:12:45 +02:00
dalto
a1699e28a2
Add support for timers
2021-10-26 16:05:49 -05:00
Adriaan de Groot
c90b9786c6
[packagechooser] Also resize the introductory image
...
- resize the intro image
- when an invalid index is selected, *still* update the
images, so it shows the intro image (resized) at the
right time.
2021-10-26 17:05:31 +02:00
Adriaan de Groot
b9a243028b
[packagechooser] Make scaled screenshots nicer
...
- patch suggested by flyingcakes85
- patch tested by killajoe
FIXES #1807
2021-10-26 16:08:20 +02:00
Adriaan de Groot
748b16ba7f
[packagechooser] Look for screenshots in more places.
...
It is easier to put screenshots somewhere where
they can be searched-for, rather than requiring either
absolute paths (inconvenient to try out someone's
settings) or relative paths (because who knows where
Calamares will be run during testing).
2021-10-26 16:08:20 +02:00
Adriaan de Groot
be398d7edb
[packagechooser] Log loading of screenshots
...
- start of indirection in loading, so that we can do a little more
work searching for the screenshot.
2021-10-26 15:23:14 +02:00
Adriaan de Groot
d10a952065
[keyboard] Make debug output more readable
2021-10-26 15:19:02 +02:00
dalto
5f55784137
Add getList function to Variant
2021-10-23 14:02:47 -05:00
dalto
e22efab1b3
Add isModuleEnabled function
2021-10-23 13:57:24 -05:00
dalto
be47b5e59c
Fix for zfs partition deletion
2021-10-23 13:40:47 -05:00
Philip Müller
682d3b087f
[postcfg] deal with symlinks
2021-10-17 17:10:56 +02:00
dalto
b5f8e30093
Change additionalInitrdFiles to an array
2021-10-13 15:09:27 -05:00
dalto
9d9cd44617
Changes from review comments
2021-10-13 12:12:16 -05:00
dalto
c1f7a2c855
Fix issue with absolute paths
2021-10-13 12:12:16 -05:00
dalto
e0f40cb4a4
Remove EOS-specific changes
2021-10-13 12:12:16 -05:00
dalto
04e927e67f
EndeavourOS customizations
2021-10-13 12:12:16 -05:00
Philip Müller
33643b5c6b
Merge branch 'calamares' of https://github.com/calamares/calamares into development
2021-10-08 09:54:21 +02:00
Adriaan de Groot
6b38985a5f
[summary] Start using the model
2021-10-04 14:52:23 +02:00
Adriaan de Groot
3bc90e6c06
[summary] Factor out widget creation
2021-10-04 14:29:54 +02:00
Adriaan de Groot
d951a9d317
[summary] Improve role names in SummaryModel
2021-10-04 12:59:50 +02:00
Adriaan de Groot
4731d79a4f
[summary] Reduce code-duplication
...
The summary page can rely on the Config object to create
lists of relevant steps; this code was declared but not
defined / implemented for Config (but also not called, so
it was ok). This is basically shuffling bits around in
preparation for using the model directly, rather than
re-implementing the widget-creation code.
While here, split off the page-resizing into a free function
so that the code reads nicer.
2021-10-04 12:48:16 +02:00
Adriaan de Groot
763f29e2b8
[summary] Improve naming, shuffle parameters
...
- the page doesn't need to remember what step it belongs to,
if the step tells it when creating widgets.
- detach naming from the viewstep API that calls it.
2021-10-04 12:23:17 +02:00
Adriaan de Groot
87af923638
[summary] Make widgets-use explicit
2021-10-04 12:15:15 +02:00
Adriaan de Groot
2fdb6fdf37
[summary] Clear model on leave
2021-10-04 12:10:17 +02:00
Adriaan de Groot
8f4ba8c21f
[summary] Tighten up scope of declarations, simplify
2021-10-04 11:27:10 +02:00
Adriaan de Groot
329f21093b
[libcalamaresui] More careful in unmarginLayout
2021-10-04 00:27:03 +02:00
Adriaan de Groot
605ad788d0
[partition] Fix build against Qt deprecations
...
setMargin() has been deprecated for a long time, and
Calamares has a utility function for it anyway.
2021-09-30 00:02:43 +02:00
Adriaan de Groot
bcde8b87b1
[partition] Remove unreachable break
statements
2021-09-29 23:55:40 +02:00
Adriaan de Groot
60cc8696e3
Remove PythonQt support -- C++ bits
2021-09-28 23:56:52 +02:00
Adriaan de Groot
ca4dbabf70
Remove PythonQt support
...
Nothing beyond the example module was ever built with the
PythonQt bindings, as far as I can tell. They have been
deprecated, defaulting OFF for over two years now.
QML modules fill the gap with customizable, run-time
interpreted UI and stronger support from the C++ side
of Calamares.
2021-09-28 23:49:08 +02:00
Adriaan de Groot
c1e1e6c3a4
Merge branch 'calamares' into work-3.3
2021-09-28 23:37:38 +02:00
Adriaan de Groot
d556dae415
[partition] Document how the configurable EFI size is coordinated
2021-09-28 21:31:12 +02:00
Adriaan de Groot
05f287ebbb
[partition] Use the configured EFI size
...
The `partition.conf` file contains an EFI-size. The default is 300MiB,
but distributions might like to use a bigger (or smaller) value.
Apply the configuration consistently everywhere where we need
"the size of the EFI partition". Extend the internal method
to look at the configured size.
2021-09-28 18:23:19 +02:00
Adriaan de Groot
90eb0cd844
[partition] Fix build
2021-09-28 18:16:34 +02:00
Adriaan de Groot
a72fc06502
[partition] Fix message (use MiB instead of bytes)
...
Reported by cfinnberg.
FIXES : #1796
2021-09-28 16:55:35 +02:00
Adriaan de Groot
6b460ce440
[partition] Compare size with the canonical source of "right EFI size"
...
While here, note that the canonical source returns bytes (not MiB).
2021-09-28 16:55:35 +02:00
Adriaan de Groot
51898ea32b
[unpackfs] Fix typo
...
Apparently everyone shipping a squashfs image also has the tools
installed, because the error message reporting that the tools-are-
missing contained a reference to an undefined variable.
Fix that, and while here improve the error message so you
don't get a whole path as a title in the error message.
The slightly weird error-message construction is so that no
messages change and no translation work is needed.
2021-09-27 21:04:26 +02:00
Adriaan de Groot
16f8243fb3
[unpackfs] Move to conventional python-libcalamares use
...
All **other** modules fully specify libcalamares; only unpackfs
was importing shortcuts. Change to conventional usage (partly
because that's easier on the pylint implementation, partly because
it's then consistent with the rest).
2021-09-27 21:04:26 +02:00
Adriaan de Groot
96c89fc080
[displaymanager] Fix Python errors
...
Apparently nobody ever hit the else-branch here (because
each DM has exactly one implementation -- that's what the
check is there for!) because the logging of the error
itself would raise IndexError or ValueError.
2021-09-27 21:04:26 +02:00
Philip Müller
abfda4fc57
Merge branch 'calamares' of https://github.com/calamares/calamares into development
2021-09-27 20:50:40 +02:00
Adriaan de Groot
96aa5b4532
Merge branch 'improve-loadmodule' into calamares
2021-09-27 14:27:50 +02:00
Adriaan de Groot
815bb62ae5
[calamares] Fix test-application command-line-args
...
- use C++11 uniform-initialization
- while here, remove space from name of --global option
2021-09-27 14:26:43 +02:00
Adriaan de Groot
7cda1d2edd
[calamares] Test-loader tries loading from install-dir, too
2021-09-27 13:39:27 +02:00
Adriaan de Groot
058e6cbcda
[calamares] Log failed module-load in test-application
2021-09-27 13:34:08 +02:00
Adriaan de Groot
de9e6a7d70
[calamares] Log module-searching in the test-application
2021-09-27 13:27:36 +02:00
Adriaan de Groot
657a36310b
[libcalamares] Log the Python pre-script a little better
...
- Make clear that the @ is a string-location, and how long the
pre-script is (although in practice, it will be either null
and 0, or the values set in the loadmodule executable).
2021-09-27 13:18:12 +02:00
corey lang
590f16370c
[networkcfg] fix replace_username() undefined variables
2021-09-27 01:24:05 -05:00
Philip Müller
b09fefc4a6
[fstab] remove double compress
2021-09-24 21:39:56 +02:00
Philip Müller
217780bec0
[merge] with upstream
2021-09-24 21:36:43 +02:00
demmm
65c1ef7cb5
[initcpiocfg] fix install failure due to extra s
2021-09-24 16:27:35 +02:00
Adriaan de Groot
ce5d42ce0f
[networkcfg] Refactor getting source-and-target paths of a file
2021-09-24 12:33:00 +02:00
Adriaan de Groot
13d69cb813
[networkcfg] Don't mindlessly PEP8
2021-09-24 12:30:11 +02:00
Adriaan de Groot
bf60d0576b
[networkcfg] Refactor username-replacement
...
Read, then write, the NM file. Add a note about how we might
handle this better. Rename live_user() function to give it
a verb (and avoid UnboundLocal when using a variable of the same name).
2021-09-24 12:25:33 +02:00
Adriaan de Groot
678e6f6d74
[networkcfg] Be more forgiving when getting the live username
...
- This function is intended to do whatever it takes to
get the live username.
2021-09-24 12:15:20 +02:00
Adriaan de Groot
88669a4079
Merge pull request #1777 from librewish/btrfs_additions
...
[fstab] Improve btrfs mount options
2021-09-24 11:26:41 +02:00
librewish
e5e9e14a9f
[initcpiocfg] add consolefont to hooks
2021-09-24 12:30:42 +05:30
librewish
3f890dfb8e
[fstab] Improve btrfs mount options
2021-09-24 12:24:58 +05:30
Shrinivas Vishnu Kumbhar
528a815307
[locale] Default to English in India
2021-09-23 11:10:09 +02:00
Shrinivas Vishnu Kumbhar
9b57f402da
[keyboard] Use US-English for India
2021-09-23 11:07:43 +02:00
Adriaan de Groot
cf6c930df5
Merge remote-tracking branch 'origin/calamares' into work-3.3
2021-09-22 11:51:14 +02:00
Adriaan de Groot
8f65a644a9
[libcalamares] Rename cPointerSetter
...
This class doesn't really set a pointer -- it is a scoped assignment
through a pointer, which **can** set a value on destruction (when
it leaves scope). Rename it.
While here, extend the API so that it can do an assignment to the
underlying object **now**, while also doing a scoped assignment
later when it leaves scope. This makes some code a bit easier
to read ("in this scope, X is now <v> and then it becomes <v'>")
2021-09-22 11:29:52 +02:00
Adriaan de Groot
bba5b21873
[libcalamares] Remove cBoolSetter
...
This class was used only once, and is confusing because
the assignment happens always, but to the opposite value
as what was visible. It can be replaced with other
scoped assignment, instead.
Removes the tests for it, too.
2021-09-22 11:29:52 +02:00
Adriaan de Groot
b0149c2712
[libcalamares] Log the Python language-search process just once
...
- log the list of search paths once
- log the found-language as if from Python
- warn always if none are found
2021-09-22 11:29:52 +02:00
Adriaan de Groot
db26df311d
[libcalamares] Reduce log-spam in emergencies
...
- when an emergency strikes, log the modules that are skipped
with a Once, but if an emergency module runs, refresh that
Once so that the function header is printed again -- to
distinguish JobQueue debugging from the logging from the
emergency module.
2021-09-22 01:44:00 +02:00
Adriaan de Groot
9be9431970
[libcalamares] Give Logger::Once more flexibility
2021-09-22 01:41:28 +02:00
Adriaan de Groot
049bccbdd8
[libcalamares] Cut down log-spam from KPMManager
2021-09-22 01:28:40 +02:00
Adriaan de Groot
cf1128b719
[partition] Cut down log-spam while checking for resize
2021-09-22 01:27:33 +02:00
Adriaan de Groot
857aaa6ca4
[partition] Cut down log spam about /etc/fstab
2021-09-22 01:15:37 +02:00
Adriaan de Groot
39915db988
[libcalamares] Reduce log spam when running commands
2021-09-22 00:58:31 +02:00
Adriaan de Groot
54385b7606
[libcalamares] Cut down config-file-loading log spam
2021-09-21 16:53:09 +02:00
Adriaan de Groot
cb92e49363
[initcpiocfg] Document this module
2021-09-21 15:16:08 +02:00
Adriaan de Groot
a4c714238f
[initcpio] Refactor file-writing
...
- iterate over the lines of the source file, rather
than over indexes, and make clear that the hooks, modules and files
lines are replaced, rather than merged.
- this calls write() more often, but it's only a few lines
2021-09-21 13:39:29 +02:00
Adriaan de Groot
12cd9dd5b2
[initcpiocfg] Refactor
...
- Read the host /etc/mkinitcpio.cfg in one function rather
than hiding it inside the writer
2021-09-21 13:18:01 +02:00
Adriaan de Groot
60e495bd8c
[initcpiocfg] Refactor, improve testability
...
- don't chain directly from modify_mkinitcpio_conf() to the
function that writes the file write_mkinitcpio_lines();
split into "figure out what needs to be written" and calling
that writing-function, so that we can test / check / log
if needed between the two.
2021-09-21 13:13:21 +02:00
Adriaan de Groot
118e18ac60
[initcpiocfg] Code-shuffle
...
- put the system-information and -detection functions at top
and the "do the actual work" things below
- don't mix the boolean do-we-use-this flags with the
lists of files and modules which are the important
parts of modify_mkinitcpio_conf
2021-09-21 13:03:13 +02:00
Adriaan de Groot
7c3c7c4ff7
[initcpiocfg] Use booleans for boolean values
...
(as previous) Use False/True rather than ""/"yes" for
keeping track of does-the-system-use-lvm2.
2021-09-21 12:54:18 +02:00
Adriaan de Groot
7f7dc04e8d
[initcpiocfg] Use bools for boolean values
...
Having "" and "yes" as values is a bit shell-script-ish.
Use a regular boolean value instead; simplify code
while we're at it.
2021-09-21 12:52:16 +02:00
Philip Müller
03d8e5e68c
Merge branch 'calamares' of https://github.com/calamares/calamares into development
2021-09-21 12:43:27 +02:00
Adriaan de Groot
45daebd989
[initcpiocfg] Refactor CPU-characteristics determination
...
The code is still over-wrought, but the API for cpuinfo
now exposes the interesting thing (is it Intel?) in
a useful -- more readable -- way.
2021-09-21 12:42:58 +02:00
Adriaan de Groot
1d812f88ce
[luksbootkeyfile] Bump timeout for adding LUKS keyfile
2021-09-21 12:12:07 +02:00
Adriaan de Groot
ada13c19fd
[libcalamares] Simplify filling the entropy buffer
2021-09-21 12:02:26 +02:00
Adriaan de Groot
a393ffe126
[luksbootkeyfile] Don't dd in the target to get entropy
2021-09-21 11:58:22 +02:00
Philip Müller
52ef084c31
[merge] upstream code
2021-09-17 21:18:36 +02:00
demmm
9c1e635804
[keyboardq] fix xml files, xml id has to be first
2021-09-17 15:01:27 +02:00
demmm
65b9bb0d6b
[keyboardq] set proper SPDX headers
...
rename wrongly named shift.license
2021-09-16 15:01:37 +02:00
Vitor Lopes
bd3f89fb57
[grubcfg] tidy code + pep8
2021-09-16 14:11:46 +02:00
Vitor Lopes
f9dc932f62
[initcpiocfg] fix english in human-visible string
2021-09-16 14:11:29 +02:00
Vitor Lopes
4b08aebe7f
[initcpiocfg] Use F strings, python3.6 only
2021-09-16 14:11:29 +02:00
Vitor Lopes
1fe27effe5
[initcpiocfg] rework swap_uuid statement and filesystem hook
2021-09-16 14:11:21 +02:00
Vitor Lopes
453e760709
[initcpiocfg] use format instead of %
2021-09-16 14:11:11 +02:00
Vitor Lopes
0ad9242ab7
[initcpiocfg] mkinitcpio.conf might not understand single quotes
2021-09-16 14:11:01 +02:00
Vitor Lopes
5da736466c
[initcpiocfg] rework is_intel_cpu
2021-09-16 14:10:56 +02:00
Vitor Lopes
df256b608a
[initcpiocfg] code tidy up
2021-09-16 14:10:45 +02:00
Adriaan de Groot
261c3587a5
[calamares] Use DBus activation instead of KDSAG
2021-09-16 13:48:56 +02:00
Adriaan de Groot
a6ba3dfce0
[license] Adjust to Qt 5.15 deprecations
2021-09-16 12:08:14 +02:00
Adriaan de Groot
1bd5628256
[libcalamaresui] Redundant call, not available in Qt 5.15 anyway
2021-09-16 12:04:50 +02:00
Adriaan de Groot
714605ebaa
[libcalamaresui] Missing header, needed in Qt 5.15
2021-09-16 12:04:29 +02:00
Adriaan de Groot
396746acc1
[libcalamares] Warnings-- for renamed enum value
...
Remove the before-Qt 5.15 ifdeffery and just keep the current
flags for NetworkManager.
2021-09-16 11:12:57 +02:00
Adriaan de Groot
2988f9a651
Merge pull request #1782 from killajoe/patch-1
...
[shellprocess] fix typo in conf
2021-09-15 14:27:13 +02:00
Adriaan de Groot
f49627f417
[libcalamaresui] Improve sizeLimit handling in log upload
...
The log sizeLimit can be 0 (disable log upload) but that's
not so clear in the code. While here, tidy up and add
some comments to surprising bits.
2021-09-15 13:30:06 +02:00
Johannes Kamprad
e189faabe5
Update branding.desc
...
hint on sizeLimit must be set to have the log option work.
2021-09-14 16:54:29 +02:00
Philip Müller
3966239635
[merge] upstream changes
2021-09-14 10:44:57 +02:00
Johannes Kamprad
e98bf0da72
Update shellprocess.conf
...
a minor typo
2021-09-12 13:47:38 +02:00
Adriaan de Groot
cefe3dd4ff
[tracking] Add Q_OBJECT, sanitize API
2021-09-08 13:31:17 +02:00
Adriaan de Groot
8d71e67a75
Add Q_OBJECT macro where it's missing
...
- Transifex tools complain about missing Q_OBJECT (which makes
some sense -- you end up with a different context for calls
to tr(), of the base class).
2021-09-08 13:23:20 +02:00
Adriaan de Groot
3380da638e
Merge pull request #1774 from demmm/calamares
...
[keyboardq] add interactive keyboard preview
2021-09-08 11:58:36 +02:00
Adriaan de Groot
87eb5300d2
Merge branch 'load-qtbase' into calamares
...
FIXES #1688
2021-09-08 11:29:15 +02:00
Adriaan de Groot
e47dc4aa78
[partition] Fix build with translated buttons
2021-09-08 11:28:38 +02:00
Adriaan de Groot
4a6753c867
[packagechooser] Restore (renamed) include that is needed after all
2021-09-08 11:26:21 +02:00
Adriaan de Groot
226419f794
[partition] Translate button texts in warning boxes
2021-09-08 11:15:12 +02:00
Adriaan de Groot
6e0a8d8ca1
[libcalamaresui] Translate button texts for paste-message
2021-09-08 11:15:12 +02:00
Adriaan de Groot
7516740bbf
[interactiveterminal] Fix up standard buttons
2021-09-08 11:15:12 +02:00
Adriaan de Groot
dcfbb766dc
[libcalamaresui] Use fixed standard-buttons labels
...
Move some of the texts to the new TranslationFix, from ViewManager,
and use them. Keep them in ViewManager, too, so that the translations
with context ViewManager are not removed just now.
2021-09-08 11:14:46 +02:00
Adriaan de Groot
8c84ae9ff6
[license] Remove unused header
2021-09-08 11:14:46 +02:00
Adriaan de Groot
683bad19fc
i18n: introduce a "TranslationFix"
...
This is intended to apply translations to some common Qt UI components.
Example: a QMessageBox with standard buttons OK and Cancel; the text
for that is determined at startup using the system locale, and later
changes to the current locale or the current translation catalog,
do not affect OK and Cancel. It might be possible to load a catalog
with the right translation strings, except that there is no way to
know what the context or catalog **is** for the strings that are
used to label standard buttons: they can come from Qt base, or
the platform, or the theme. Merely loading the Qt Base translations
for the correct language does not help, because those translations
do not contain an "OK" string with the context used for standard
buttons.
Do the translation by hand; then we have all of the Calamares
languages covered, too, which is more than the Qt translations do.
2021-09-08 11:14:46 +02:00
Adriaan de Groot
438302fcf5
i18n: Shuffle the build so that all the bits are in lang/
...
Move the CMake code responsible for building the translations from
the src/calamares directory (yeah, yeah, the translations need to
link into the executable) into lang/ (which is where the source
and other infrastructure lives).
2021-09-08 11:14:46 +02:00
Adriaan de Groot
06d12fc924
[packagechooser] Remove unneeded include
2021-09-08 11:04:35 +02:00
Adriaan de Groot
24162cb162
i18n: repair language names for Chinese
...
Prompted by Linlinger, I've reconsidered the names of languages
in the drop-down in the welcome page. We already have the
infrastructure for assigning specific names / locales to
"Calamares locale names" (which match Transifex names, not
necessarily Qt names). Use that to put exactly two Chinese-
language translations in the drop-down:
- Simplified Chinese (code zh_CN)
- Traditional Chinese (code zh_TW)
Drop zh (which is a peculiar locale name anyway) and zh_HK
(which is Traditional Chinese, but using the geographic
boundary is a bit weird; we're going to ignore the
minor orthographic differences with Traditional Chinese
written elsewhere for now).
Note that this makes the drop-down show "Chinese"
in the English column, twice; the difference is visible
only in the native-language representation.
SEE #1741
2021-09-07 15:47:30 +02:00
Adriaan de Groot
4e60f8af13
[libcalamares] Use strong types for locale Ids
...
Change the API to force strong type for more methods.
This cascades to a couple of consumers.
2021-09-07 12:51:57 +02:00
Adriaan de Groot
3ff5896dc6
[libcalamares] Remove unused method
2021-09-07 12:35:47 +02:00
Adriaan de Groot
5f4e65bc77
[libcalamares] Code-format Retranslator, hide internal symbols
2021-09-07 12:35:37 +02:00
Adriaan de Groot
ad1a4b6479
[libcalamares] APIdox on Translation
2021-09-07 11:42:32 +02:00
Adriaan de Groot
73bfc6ca32
[libcalamares] Use structured bindings to unpack a std::pair
2021-09-07 11:38:54 +02:00
demmm
79cc616de2
[keyboardq] add interactive keyboard preview
...
rewrite of keyboardq.qml, reduce stackview to 2, use a combobox for
keyboard models list
colors set to configurable
.xml files used for keyboard layouts, about a dozen added now
builds, runs, actions record as intended, GS filled correctly
2021-09-06 19:25:16 +02:00
Adriaan de Groot
5e7746668e
Merge branch 'calamares' into refactor-translation
2021-09-06 15:38:42 +02:00
Philip Müller
8ae76edd88
Merge branch 'calamares' of https://github.com/calamares/calamares into development
2021-09-06 15:32:40 +02:00
Adriaan de Groot
0aa2603a23
[libcalamares] Fix network-connectivity check on old Qt
...
With old Qt, Calamares could only run one check on a thread,
because the NAM would be switched to NotAccessible --
subsequent checks would fail because the NAM is already
hard-set to NotAccessible, so it could never be turned back
on by Calamares code.
Reset the accessible flag for the NAM while checking if
the internet is there.
2021-09-06 14:44:52 +02:00
Adriaan de Groot
0851a8a6a4
Merge branch 'issue-1769' into calamares
...
FIXES #1769
2021-09-06 13:23:59 +02:00
Adriaan de Groot
44e66c1318
[keyboard] Fix mapping for India + English
...
- India (when in English) should use the English variant, not Hindi
- While here, fix up minor items in code:
- Typo in comment
- Asturian doesn't need a special case (which didn't match, anyway)
- Don't debug-log a country-name that might be entirely wrong
(the layout is English, variant "in" but "in" interpreted as
a country is Indonesia, and the actually-desired name is eng_in
which isn't a QLocale name at all -- just like the Hausa and Igbo
special cases)
2021-09-06 13:18:12 +02:00
Adriaan de Groot
b237c73a04
[shellprocess] Fix test
...
The test was loading the config file (for testing) either from the
build directory or possibly the source directory; if the config
in the build-dir was edited (for other testing purposes) then
the test would fail. Load only the source-dir version of the file.
2021-09-06 12:49:49 +02:00
Adriaan de Groot
6017420dde
[welcome] Fix up and expand tests
...
- improve logging
- fix failing tests -- the observed and expected behavior is
to fill in a fallback check-URL, not change to an empty list,
- **except** if there's no requirements key in the config
at all; this is a bit weird, but let's make the tests
document existing behavior so we can notice if it changes.
2021-09-06 12:35:24 +02:00
Adriaan de Groot
4948f634ed
[keyboard] Code tidy
...
- complain just once (globally) if ckbcomp is not found, rather than
at every update to the layout.
- tighten up QStringList constructor.
2021-09-06 12:06:11 +02:00
Adriaan de Groot
42bc197f67
Merge branch 'fix-pckq' into calamares
2021-09-06 11:27:09 +02:00
Adriaan de Groot
5a6e033e82
[bootloader] Flags for root-on-BTRFS
...
This is directly derived from Anke Boersma's KaOS code in module
*bootldr*, which adds the same kernel parameter via a slightly
different route.
2021-09-05 13:34:38 +02:00
Adriaan de Groot
e311d7a893
[packagechooser] Remove 'id' configuration setting
...
- Setting 'id' (which changes the Global Storage key that
gets used) is a kludge when the existing module-instance
name can be used instead -- and **was** already used, as
a fallback when 'id' is not set. There's no point in having
two places to set a particular name.
- Rip out the docs for 'id' as well.
- Add documentation on the difference between single-selection
(the QML implementation) and model-selection (what the Widgets
version does).
2021-09-03 23:59:11 +02:00
Adriaan de Groot
6def41fab4
[packagechooserq] Remove debug-output in QML
2021-09-03 22:57:17 +02:00
Adriaan de Groot
33e7e8da58
[packagechooser] Massage API
...
- use updateGlobalStorage() for both single-selection and
model-based approaches, although the model-based one
needs extra parameters.
- complain about inconsistent settings and API calls (e.g.
setting a model and single-selection at the same time)
2021-09-03 22:41:13 +02:00
Adriaan de Groot
8a49fde016
[packagechooserq] Apply renaming also to distro-visible code
...
- The distro-visible key is renamed *pkgc* to *packageChoice*
- Read *packageChoice* only if there are no items to use
2021-09-03 21:21:44 +02:00
Adriaan de Groot
8b703ba6a3
[packagechooserq] More docs for the config file
2021-09-03 21:21:44 +02:00
Adriaan de Groot
c367731c42
[packagechooser] Rename internals
...
- pkgc -> packageChoice and similar for methods, variables
- document that this is the convenience value for one-selection
QML modules, not a full model
- use std::optional to keep track of which one is being used.
2021-09-03 21:21:44 +02:00
Adriaan de Groot
47c504df5d
[welcome] add SPDX-tags to test-data
2021-09-03 21:21:44 +02:00
Adriaan de Groot
1a1009a2a9
[summaryq] add SPDX-tags
2021-09-03 21:21:44 +02:00
dr460nf1r3
35156574b8
Dont set fsck check for BTRFS in fstab
2021-09-03 20:49:08 +02:00
Adriaan de Groot
2f88ba0d3f
[partition] Coding style
2021-08-31 14:03:04 +02:00
Adriaan de Groot
09491e4cbb
[partition] expect failures when kpm can't read the disk
2021-08-31 13:58:23 +02:00
Adriaan de Groot
1554c3a07c
[partition] Create KPM backend at start of test
2021-08-31 13:54:23 +02:00
Adriaan de Groot
3d0709c779
[partition] Avoid crash when there is no KPM backend
2021-08-31 13:46:25 +02:00
Adriaan de Groot
ede19c8a61
[partition] Fix build of devices test
2021-08-31 13:45:15 +02:00
Philip Müller
46b0a933c2
Merge branch 'calamares' of https://github.com/calamares/calamares into development
2021-08-09 11:13:13 +02:00
Philip Müller
25b2f89d31
[postcfg] fix copy_tree()
2021-08-09 09:06:58 +00:00
Philip Müller
7a4cd9cdcc
[postcfg] adopt to symlinks in copy_tree()
2021-08-09 07:57:37 +00:00
Adriaan de Groot
854eb845d2
[partition] Fix build of layoutstest
...
This test needs UI because the devicemodel uses GUI parts.
2021-08-05 15:49:29 +02:00
Adriaan de Groot
22ba21f937
[partition] Stub of a test of scandevice
2021-08-31 13:16:45 +02:00
Adriaan de Groot
e294221a2d
[partition] Rename test executables
...
- all partition tests are now named partition<thing>test
2021-08-31 13:08:54 +02:00
Adriaan de Groot
3519697d0e
[libcalamares] Slightly more memory-safe
...
Use unique_ptr to ensure Private is always deleted.
SEE #1758
2021-08-31 12:54:51 +02:00
Adriaan de Groot
0899eefde7
[packagechooserq] Fix build on Debian, openSUSE with AppStream
2021-08-31 11:33:05 +02:00
Adriaan de Groot
d7767afe1b
Merge branch 'extra_qml' into calamares
2021-08-30 23:17:36 +02:00
Adriaan de Groot
6f16d3db83
Merge remote-tracking branch 'origin/issue-1761' into calamares
...
FIXES #1761
2021-08-30 22:33:03 +02:00
Adriaan de Groot
b9a1d090ec
Merge pull request #1762 from demmm/calamares
...
[localeq] redo i18n.qml
2021-08-30 13:57:17 +02:00
waneon
4bf3afac48
[partition] Fix invalid variable name
2021-08-27 19:18:09 -04:00
Adriaan de Groot
da49becac3
[partition] Tailor warning message about ESP
...
- tell the user all the things that are wrong with the
(proposed) ESP; a missing one gets all the suggestions.
2021-08-27 17:28:07 +02:00
Adriaan de Groot
6324fa3eb9
[partition] Disentangle questions of suitability of ESP
...
- split into size, type, flags so the warning message can
be tailored to what is wrong.
2021-08-27 17:27:26 +02:00
Adriaan de Groot
7d08770806
[partition] Apply code style
2021-08-27 17:26:50 +02:00
Adriaan de Groot
52a82ea1e6
[partition] Improve warning message in log
2021-08-26 17:39:06 +02:00
Adriaan de Groot
46ca4d93e7
[partition] Improve constness, naming
2021-08-26 17:30:55 +02:00
Adriaan de Groot
ad9306d7bb
Merge pull request #1749 from LordTermor/calamares
...
[partition] Disable delete button for extended partition
2021-08-26 17:18:09 +02:00
Adriaan de Groot
51c18baedb
Merge branch 'issue-1669' into calamares
2021-08-26 17:15:03 +02:00
Adriaan de Groot
f376b42c31
[welcome] Add a handful of tests for different URL configs
2021-08-26 16:58:46 +02:00
Adriaan de Groot
ad76a2cbe8
[welcome] [welcomeq] Move requirements to Config
...
The Config object can hold all of the configuration information,
including also the requirements-checking parts. Move requirements-
checking configuration there, so it is shared and consistent
across welcome and welcomeq, regardless.
This repairs the test that expects the Config object to handle
**all** of the configuration, too.
2021-08-26 16:39:55 +02:00
Adriaan de Groot
67d2b5568d
[welcome] Fix test, check that the internet check URLs are loaded
2021-08-26 14:40:52 +02:00
Adriaan de Groot
0538881447
[libcalamares] Handle multiple invalid URLs at once
...
- expand tests with example where more than one URL is invalid
- fix the call to the wrong overload of QVector::erase()
2021-08-26 14:32:57 +02:00
Adriaan de Groot
653359d815
[libcalamares] Fix up multiple URLs for checkinternet
...
- was filtering out the wrong URLs
- was not actually removing the invalid URLs
- extend API to make it possible to count / confirm the settings
- extend tests to demonstrate that API and the issues
2021-08-26 12:57:40 +02:00
demmm
7bfb769288
[localeq] redo i18n.qml
...
set colors as vars, mostly kirigami colors, to make it work for boths dark & light themes
highlights now full width and on hover
currentindex still at -1, not implemented in cofig.cpp/h, possible to use js, or is
https://github.com/calamares/calamares/blob/calamares/src/modules/locale/LCLocaleDialog.cpp#L43 accessible to QML?
2021-08-26 12:05:38 +02:00
Adriaan de Groot
d5e6e1075d
[welcome] Expand stub tests to check that crashes are gone
2021-08-24 13:37:02 +02:00
Adriaan de Groot
e0ee2d9514
[welcome] Handle nullptrs nicely in Config
...
- Branding, Settings, and ModuleManager may all be nullptr,
in which case the corresponding code shouldn't call methods
of those instances -- this is demonstrated by just creating
a Config object
2021-08-24 12:50:03 +02:00
Adriaan de Groot
1e05e7996b
[libcalamares] Avoid cError + SubEntry
...
The combination of Error and SubEntry loses the indentation.
2021-08-24 12:32:48 +02:00
Adriaan de Groot
14c26d01af
[libcalamares] Warnings for nullptr Settings
2021-08-24 12:30:44 +02:00
Adriaan de Groot
e9a98f35ad
[welcome] Avoid crash when no Branding available
...
- don't install translators twice -- do it in setLocaleIndex only
- avoid crash if the branding instance is nullptr
2021-08-24 11:58:24 +02:00
Adriaan de Groot
38c65e80f3
[libcalamaresui] Warn when asking for nonexistent Branding instance
2021-08-24 11:57:37 +02:00
Adriaan de Groot
f1a47a9f0a
[welcome] Add (stub) test for the Config object
...
This crashes because there's no translations object yet,
but that is an internal issue.
2021-08-24 10:24:11 +02:00
Adriaan de Groot
c79fc2e6d9
[libcalamares] Add urls only if valid, add tests to check that
2021-08-24 10:00:42 +02:00
demmm
805fed559c
[networkcfg] use os.getlogin()
...
cala running as root returns root for live_user otherwise
2021-08-16 20:17:07 +02:00
demmm
8913317a44
[networkcfg] add setting the correct target user in copied file
...
see https://github.com/calamares/calamares/issues/1753
2021-08-16 14:06:13 +02:00
Artem Grinev
74a3a2da78
[partition] Fix Delete button for extended
...
Extended partition can't be removed when contains children. This commit
adds missing check.
2021-08-12 02:13:16 +04:00
Adriaan de Groot
b7a3f58df4
[partition] Update waiting widget only if it (still) exists
2021-08-05 14:51:31 +02:00
Adriaan de Groot
a1690ac2d6
[partition] Set up swap-choice texts correctly
2021-08-04 01:47:55 +02:00
Adriaan de Groot
0be4c38a87
[partition] Remove useless parameter
...
- previously, updateSwapChoicesTr() wanted to be a static free function,
but it needs QObject::tr() ; drop the unnecessary parameter (since it
is a member function).
2021-08-04 01:45:22 +02:00
Adriaan de Groot
390acd41b2
[partition] Factor out manual partitioning translation
...
- needs to be called when the button is created, too
2021-08-04 01:42:00 +02:00
Adriaan de Groot
c5fa6383d7
[welcome] Remove annoying debug message
2021-08-05 14:25:20 +02:00
Adriaan de Groot
2820316d16
Partition: don't set text if button doesn't exist
2021-08-05 14:23:11 +02:00
Adriaan de Groot
1452b74740
[welcome] Load potentially a list of URLs to check
2021-08-01 23:52:27 +02:00
Adriaan de Groot
2f3062f4c2
[libcalamares] Fix typo in comment
2021-08-01 23:49:33 +02:00
Adriaan de Groot
81fe8b1488
[libcalamares] Expand API for setting URLs to check
2021-08-01 22:37:13 +02:00
Adriaan de Groot
b8583a1e59
[libcalamares] Expand the number of URLs to check for connectivity
...
- introduce a list of URLs instead of just one
- ping each of them, in turn, until one responds
2021-08-01 22:07:51 +02:00
Adriaan de Groot
559c53b09c
[libcalamares]: stronger type for translation name
...
QString -> Id for translations in the external API, to avoid
accidentally converting a QLocale name (e.g. ca_ES) into a
Calamares translation name. This preserves special-cases
like ca@valencia and sr@latin.
2021-07-28 14:22:28 +02:00
Adriaan de Groot
bc9d8fb13a
[libcalamares] Rename files Label -> Translation
2021-07-28 14:22:28 +02:00