Adriaan de Groot
2c6ff26aaa
[partition] Reduce warnings
2019-02-06 04:08:21 -05:00
Adriaan de Groot
73c39adf9c
Merge branch 'improve-swap-ui'
2019-01-24 15:20:06 -05:00
Adriaan de Groot
b913753831
[partition] No need to re-query the current choice
2019-01-21 08:54:09 -05:00
Adriaan de Groot
aef61a42bc
[partition] Tidy up code
...
- avoid possible nullptr dereference on connect() if no swap choices
- group retranslations together
2019-01-21 08:22:17 -05:00
Adriaan de Groot
24422b19bd
[partition] Idiomatic connect() usage
2019-01-21 08:20:01 -05:00
Adriaan de Groot
fbef117fc8
[partition] Remove unused code
2019-01-21 07:52:23 -05:00
Adriaan de Groot
8ecae75dc8
[partition] Simplify code a little
...
- Document and make pickOne() more correct
- Reduce calls to globalStorage(), it doesn't change
2019-01-21 07:41:47 -05:00
Adriaan de Groot
e85fedfd41
[partition] Drop comment that doesn't apply anymore
2019-01-18 15:57:21 +01:00
Adriaan de Groot
a51a000681
Merge branch 'master' into improve-swap-ui
2019-01-14 15:57:22 +01:00
Arnaud Ferraris
5cacc0ddc6
Merge remote-tracking branch 'upstream/master' into partition-layout
2019-01-11 10:03:46 +01:00
Arnaud Ferraris
dfb5412c57
[partition] Preserve current device when going to manual partitioning
...
Fixes #1043
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.com>
2019-01-10 16:28:05 +01:00
Arnaud Ferraris
fcd0e8d362
[partition] Apply partition layout when replacing free space
...
When chosing the "Replace partition" option, free space is not handled
like any partition. In order to apply the custom partition layout in
that case too, we have to modify the code where "replace free space" is
handled.
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.com>
2019-01-07 17:28:02 +01:00
Arnaud Ferraris
ba673b17ee
[partition] Add configuration option to disable manual partitioning
...
In some cases where a custom partition layout is used, use of this
layout is mandatory (this can be the case when using a read-only rootfs
which is updated by block-cpying an image file to it).
For these cases, the user must not be able to change the partition
layout, therefore we have to disable manual partitioning.
In order to stay consistent with current behaviour, manual partitioning
is still enabled by default. It will only be disabled if the partition
module's config file contains the corresponding option set to "false".
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.com>
2019-01-07 17:27:40 +01:00
Arnaud Ferraris
2f14a21456
[partition] Apply custom layout when installing "Alongside"
...
When choosing "Install alongside another system", the custom partition
layout is applied to the space freed by resizing the selected partition.
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.com>
2019-01-07 17:27:12 +01:00
Adriaan de Groot
4973d00ace
[partition] Only create drop-down if there is something to select
...
- Swap choices may be 0 (then choose none), 1 (choose that one)
or more (currently undecided)
2018-12-11 13:52:23 +01:00
Adriaan de Groot
00df8a9fb1
[partition] Remove unused code
...
- Swap choice for replace and alongside will happen much, much later.
2018-12-04 12:21:02 +01:00
Adriaan de Groot
2998c27545
[partition] Use configured swap choices in choice page
2018-12-04 11:35:35 +01:00
Adriaan de Groot
edc6c64657
[partition] Create swap-combo from a set
...
- Alternate way to create swap-combobox, using configuration
values rather than an initializer list.
2018-12-04 11:01:16 +01:00
Adriaan de Groot
988a0a5388
[partition] Changing swap choice also changes preview
...
- When selecting *erase*, you may be able to change the swap
settings. If so, changing swap settings should change the
preview.
2018-12-04 10:34:02 +01:00
Adriaan de Groot
0231619c7c
[partition] Refactor slot for change in action
...
- Let's not go overboard on lambdas,
- Needed for others that also want to update the partitioning preview
2018-12-04 10:22:08 +01:00
Adriaan de Groot
c5d707399d
Merge branch 'fix-swap-ui'
2018-12-03 21:02:10 +01:00
Adriaan de Groot
8144295e98
[partition] Make new partition flags explicit
...
Suggested by aliveafter1000: having a default value, and then
filling in the default in one place it is used and not others,
is weird. Instead of dropping the one use, remove the default
value: partition flags are important enough to be explicit.
2018-11-09 08:25:26 -05:00
Adriaan de Groot
417eeedd9f
[partition] Calamares is spaced-out enough without extra's
2018-10-11 06:35:45 -04:00
Adriaan de Groot
2a61116b3c
[partition] Disable swap choice for replace & alongside
2018-10-08 15:32:02 -04:00
Adriaan de Groot
779542a5d1
Merge branch 'master' into fix-swap-ui
2018-10-08 13:56:28 -04:00
Adriaan de Groot
292bc57523
[partition] Fix build with suitable operator <<
2018-10-03 13:49:52 -04:00
Adriaan de Groot
b38316365e
[partition] Be more verbose about why UI buttons appear
2018-10-03 13:58:50 +02:00
Adriaan de Groot
29bae61610
Merge branch 'master' into fix-swap-ui
2018-10-01 03:21:06 -04:00
Adriaan de Groot
e3bf9fc220
[partition] Fix build with KPMCore <= 3.3.0
...
- Reported by Philip Mueller
2018-09-21 16:19:05 -04:00
Adriaan de Groot
d2f4079a18
[partition] Move partitioning options into a class
...
- As (auto) partitioning grows more options, the parameter
list becomes more unwieldy. Add some structure to it.
2018-09-17 06:42:14 -04:00
Adriaan de Groot
5136021416
[partition] Move SwapChoice to another namespace
...
- The choice of swap needs to be handled in more places,
so make the enum available in the partition module core instead
of just inside the choice page.
2018-09-13 06:29:59 -04:00
Adriaan de Groot
846e496d76
[partition] Tidy includes
2018-09-13 05:50:46 -04:00
Adriaan de Groot
959cd7b224
[partition] Simplify creation of comboboxes for swap choices
2018-09-13 04:45:36 -04:00
Adriaan de Groot
cfa940b35c
[partition] Support translations of swap choices
...
- Introduce enum to indicate what is selected
- Support translations
- Fill selections for erase
2018-09-12 11:18:17 -04:00
Adriaan de Groot
7d0451fe69
[partition] Rename Choice -> InstallChoice
...
- There are more choices to be made (or to come) when partitioning,
so don't take the most generic term for one enum.
2018-09-12 10:16:48 -04:00
Adriaan de Groot
dc492b301c
[partition] Drop label on swap-options box
2018-09-12 08:42:21 -04:00
Adriaan de Groot
a791818a65
[partition] Add swap drop-down
...
- This is WIP; the drop-down contents should be customised,
depending on configuration and the state of the device being
installed-to.
2018-09-12 08:18:45 -04:00
Caio Carvalho
b5a2a5bbdd
[partition] Don't show erase button for inactive RAID.
2018-08-13 12:26:00 -03:00
Adriaan de Groot
dd8e53dc22
Copyright: update copyright lines on files touched in 2018
...
Contributions from:
Adriaan de Groot <groot@kde.org>
Gabriel Craciunescu <crazy@frugalware.org>
AlmAck <gluca86@gmail.com>
Andrius Štikonas <andrius@stikonas.eu>
Caio Carvalho <caiojcarvalho@gmail.com>
Raul Rodrigo Segura <raurodse@gmail.com>
2018-06-15 05:59:11 -04:00
Adriaan de Groot
3315df5df1
[modules] Use new convenience logging methods across the board
2018-02-13 11:07:12 +01:00
Adriaan de Groot
05967311de
[partition] Be defensive against no device-device-available.
...
Scenario is this: you have no suitable installation devices on
your system (everything is mounted, or HDD has died), click through
to partition page, where you have all the buttons available, but no
devices in the list. The following actions then cause a crash:
- clicking "back"
- clicking any button
Prevent that:
- you can click "back", but if there is no device selected
nothing happens to the device state (no nullptr deref,
and no crash)
- button code is now more resilient to this scenario
- buttons are hidden until a device is available, so you
can't even click on them to trigger the code.
2018-01-09 06:58:46 -05:00
Adriaan de Groot
762ad54344
Documentation: change http links to GitHub to https
2017-12-20 08:39:09 -05:00
Adriaan de Groot
31fa9e4251
Clang: fix warnings on partition splitter
...
- initialize all the fields
- member-initialization order
- silence warnings about double<->int
- drop unused parameter to setSplitPartition
2017-09-10 06:17:28 -04:00
Adriaan de Groot
3e5916157f
A mounted partition cannot be resized or replaced
...
- add check for isMounted()
- a device with a mounted partition cannot be (entirely) erased
FIXES #639
2017-09-07 04:55:44 -04:00
Adriaan de Groot
851379628c
Reduce Qt runtime warnings.
...
- deleteLater() doesn't like nullptr (produces a warning, but is harmless)
- reparenting across threads doesn't work, comment on that but leave
it in, since this may be relevant for memory management.
2017-09-07 04:24:08 -04:00
Adriaan de Groot
7e66499f36
Refactor check for EFI system.
...
The TODO stands, to delegate this to KPMCore.
2017-08-28 05:36:45 -04:00
Adriaan de Groot
3c3c0f99f8
C++ trickery, part two: shorten code
2017-07-04 08:42:14 -04:00
Adriaan de Groot
ee4e4dfccc
C++ trickery to make the code shorter to read.
2017-07-03 18:07:18 -04:00
Teo Mrnjavac
6545443b24
Documentation++
2017-03-03 12:32:44 +01:00
Teo Mrnjavac
f4732de975
Always write bootloader path.
2017-01-18 19:38:12 +01:00