Commit Graph

133 Commits

Author SHA1 Message Date
Philip Müller
87726c641e [displaymanager] fix desktop_environment_setup ldm 2018-08-26 21:16:20 +02:00
Philip Müller
83c397620c Merge branch 'master' of https://github.com/calamares/calamares into development 2018-08-22 10:28:04 +02:00
Adriaan de Groot
c3219a4905 [displaymanager] Fix call in LightDM code
- The parameter list was wrong, and could never have worked
   (apparently noone mixes LightDM with basic setup, even though
   it's one of the few with basic_setup()).
 - Shorten some lines.
2018-08-21 07:31:46 -04:00
Philip Müller
a1af1655b4 Merge branch 'master' of https://github.com/calamares/calamares into development 2018-08-21 09:45:33 +02:00
root
fa45e21e15 Fix default desktop environment variable in displaymanager. Closes #1016. 2018-08-20 22:21:39 -07:00
Adriaan de Groot
858c959285 Merge branch 'master' into refactor-dm 2018-08-20 17:25:26 -04:00
Adriaan de Groot
a83ee4984d [displaymanager] Enable translation for user-visible messages
See also #991
2018-08-20 12:30:44 -04:00
Adriaan de Groot
5191400d89 [displaymanager] Fix LightDM error message
- Error tuple was not being constructed properly
 - Fix capitalization consistency
2018-08-20 12:30:44 -04:00
Adriaan de Groot
ebae7e1f47 [displaymanager] Re-arrange initializations
- Move variable initializations closer to where they are first used
 - Also warn if no implementations are available
 - Handle sysconfig as any other DM; there's no real reason
   to treat it specially.
2018-08-20 12:30:44 -04:00
Adriaan de Groot
229cc241fa [displaymanager] Massage do_autologin
- Move getting the global setting closer to where it is used
 - Initialize variable
2018-08-20 12:30:44 -04:00
Adriaan de Groot
59a003a41f [displaymanager] Expand check for no-DMs
- The message refers to an empty list or unset variable,
   but the if only checked for unset. Also bail out if
   the list is empty.
2018-08-20 12:30:44 -04:00
Adriaan de Groot
2d0660a54a [displaymanager] Fix up missing methods
- Add (empty) implementations of all the abstract methods that
   are not needed (or supported) by various DMs.
 - Order the abstract methods by calling order
 - Fix up have_dm
2018-08-20 12:30:44 -04:00
Adriaan de Groot
155e212616 [displaymanager] Call all configuration methods through instance
- Make root_mount_point a parameter of the DM classes
 - Create instances as needed, then check if they're available
 - Keep instances that actually need to be configured
 - Clean up remaining cruft from removing old setup_autologin()
   with all the string-comparison magic.
2018-08-20 12:30:44 -04:00
Adriaan de Groot
18392cb216 [displaymanager] Refactor greeter setup
- Only lightdm has support for dynamically configuring the
   greeter based on what is installed. Still, refactory that
   to something general.
2018-08-20 12:30:44 -04:00
Adriaan de Groot
383e0e4f25 [displaymanager] Refactor setting up default DE
- Some DMs allow setting up the default DE. Factor that
   out into a method like basic_setup() and setup_autologin()
   and add it to the configuration chain.
2018-08-20 12:30:44 -04:00
Adriaan de Groot
1c0b9e6a2a [displaymanager] Call basic_setup through instance
- Now that basic_setup is factored out into the classes,
   call it via an instance before doing set_autologin.
2018-08-20 12:30:44 -04:00
Adriaan de Groot
cd0cdfc9af [displaymanager] Move basic setup to DM classes
- For all the DMs that have some kind of basic setup,
   introduce a method in the DM class for doing just that.
 - The Python code now doesn't call basic setup anywhere,
   so this specific revision isn't going to work properly.
2018-08-20 12:30:44 -04:00
Adriaan de Groot
47b58083f7 [displaymanager] Move setup_autologin to individual classes
- Split the entire body of setup_autologin() to a method
   per implementation class.
 - Make the check for presence of a DM a class-method,
   since if it fails, instantiation is going to be useless.
2018-08-20 12:30:44 -04:00
Adriaan de Groot
e1f7dbdbb9 [displaymanager] Simplify do_autologin initialization 2018-08-20 12:30:44 -04:00
Adriaan de Groot
7f47b2f9ca [displaymanager] Introduce class for DM configuration
- Much like PackageManager, this is where the actual
   implementation of configuration methods will end up,
   for each supported DM.
2018-08-20 12:30:44 -04:00
Adriaan de Groot
f188c6f71b [displaymanager] Simplify DE class
- The DE isn't being configured, and isn't where the complexity
   lies. Drop the ABC from it.
2018-08-20 08:14:52 -04:00
Adriaan de Groot
76a7c439c1 [displaymanager] Begin refactoring DM
- Introduce a base-class to "do the stuff" for one specific
   display manager / desktop environment.
2018-08-20 07:37:46 -04:00
Philip Müller
46e53997a8 Merge branch 'master' of https://github.com/calamares/calamares into development 2018-08-20 12:32:10 +02:00
Adriaan de Groot
c3cef4d919 [displaymanager] Avoid unassigned variable
If displaymanagers is not set in the job config or globally,
it wasn't set at all, leading to a runtime error. Set to
None, so that the regular error message will be triggered.

FIXES #1002
2018-08-20 06:17:05 -04:00
Philip Müller
62e065c52f [merge] sync with upstream 2018-06-29 08:25:08 +02:00
Adriaan de Groot
52f09f7f46 [modules] Minor documentation work on modules a-g 2018-06-26 05:47:23 -04:00
Philip
c1ffc18738 [merge] with upstream 2017-12-23 07:30:07 -05:00
Adriaan de Groot
762ad54344 Documentation: change http links to GitHub to https 2017-12-20 08:39:09 -05:00
Philip
de81e06efc Merge branch 'master' of https://github.com/calamares/calamares into development 2017-09-26 05:13:08 -04:00
Philip
28931b32b5 [Merge] add some fixes 2017-09-21 02:40:54 -04:00
Philip
d20285d4f2 [modules] displaymanager: try to fix regression introduced with c8fd11b 2017-09-21 13:08:13 -04:00
Adriaan de Groot
13807ceabf Licensing: add self
- to all the files I've touched recently
 - to (very incomplete) AUTHORS list

Licensing: add license info to top-level CMakeLists.txt
2017-09-19 15:57:25 +02:00
Adriaan de Groot
c8fd11b103 Replace scandir with listdir, simplify loop
FIXES: ??
2017-09-16 07:01:55 -04:00
Philip
da24829bba [unpackfs] fix merge 2017-07-11 11:16:51 +02:00
Adriaan de Groot
ce11c7ab6d LightDM: fix type (thanks Kevin Kofler) 2017-07-10 14:43:13 -04:00
Adriaan de Groot
9561bac1c8 SUSE DM: add special case configuring autologin in sysconfig (openSUSE)
FIXES #582
2017-07-10 10:14:28 -04:00
Adriaan de Groot
984a83deb9 LightDM: if lightdm.conf doesn't exist (for autologin), create it
FIXES #568
2017-07-10 09:27:56 -04:00
Philip
2a327a91e3 Merge branch 'master' of https://github.com/calamares/calamares into development 2017-06-29 09:45:17 +02:00
Philip Müller
f64266a294 Merge pull request #758 from manjaro/lightdm-greeters
[displaymanager] check for installed lightdm greeter and configure accordingly
2017-06-28 17:04:40 +02:00
Bernhard Landauer
a1173bccc2 [displaymanager] check for installed lightdm greeter and configure accordingly
- no matter if for example slick-greeter is installed as "lightdm-slick-greeter" or whatever.
  tested with lightdm-deepin-greeter and slick-greeter.
- plus some little simplifications
- added Copyright
https://github.com/calamares/calamares/issues/756
2017-06-28 16:43:07 +02:00
Philip
07e84bf315 Merge branch 'master' of https://github.com/calamares/calamares into development 2017-06-28 11:04:27 +02:00
Adriaan de Groot
2905a9969d SDDM-config: allow poorly formatted SDDM config
SDDM itself doesn't trip over duplicate sections or keys, but
the Python config-parser does (in strict mode). Relax a bit.

FIXES #579
2017-06-28 03:57:01 -04:00
Philip
c2aed163bc Merge branch 'master' of https://github.com/calamares/calamares into development 2017-06-27 21:05:09 +02:00
Bernhard Landauer
72cfb83873 fix https://github.com/calamares/calamares/issues/756 2017-06-27 14:50:53 +02:00
Philip
1d737d0ff8 [displaymanager] PEP8 modifications 2017-06-23 11:20:25 +02:00
Philip
b3143d057c Merge branch 'master' of https://github.com/calamares/calamares into development 2017-06-20 00:28:59 +02:00
Adriaan de Groot
4405790253 Displaymanager: simplify gdm configuration.
Replace calling out to shell to run echo redirected to a file by
opening the file and writing to it.
2017-06-19 18:20:24 -04:00
Adriaan de Groot
70af29672d Displaymanager: check alternative locations for kdmrc.
FIXES #578
2017-06-19 18:05:34 -04:00
Adriaan de Groot
582e4354a7 Displaymanager: refactor a little, don't bail out at the first DM that doesn't configure 2017-06-19 18:00:10 -04:00
Philip
0ad9ae9432 [services] adjust merge 2017-06-07 09:49:57 +02:00