napcok/calamares
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

libcalamares: don't bind to temporaries

Browse Source 
Clang warns about range-for-loop binding a reference
to temporaries, and these are pybind11 handles anyway
so are cheap to copy.
This commit is contained in:
Adriaan de Groot 2023-10-24 22:18:10 +02:00
parent d435ddd955
commit 1c0559affa
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/libcalamares/python/Api.cpp
View File

@ -173,9 +173,9 @@ QVariantList
variantListFromPyList( const Calamares::Python::List& list ) variantListFromPyList( const Calamares::Python::List& list )
{ {
QVariantList l; QVariantList l;
for ( const auto& h : list ) for ( const auto item : list )
{ {
l.append( variantFromPyObject( h ) ); l.append( variantFromPyObject( item ) );
} }
return l; return l;
} }
@ -184,7 +184,7 @@ QVariantMap
variantMapFromPyDict( const Calamares::Python::Dictionary& dict ) variantMapFromPyDict( const Calamares::Python::Dictionary& dict )
{ {
QVariantMap m; QVariantMap m;
for ( const auto& item : dict ) for ( const auto item : dict )
{ {
m.insert( Calamares::Python::asQString( item.first ), variantFromPyObject( ( item.second ) ) ); m.insert( Calamares::Python::asQString( item.first ), variantFromPyObject( ( item.second ) ) );
} }
@ -195,9 +195,9 @@ QStringList
stringListFromPyList( const Calamares::Python::List& list ) stringListFromPyList( const Calamares::Python::List& list )
{ {
QStringList l; QStringList l;
for ( const auto& h : list ) for ( const auto item : list )
{ {
l.append( Calamares::Python::asQString( h ) ); l.append( Calamares::Python::asQString( item ) );
} }
return l; return l;
} }