From 1c0559affa10e130688e05f63eb4b7f4a61cfb30 Mon Sep 17 00:00:00 2001
From: Adriaan de Groot <groot@kde.org>
Date: Tue, 24 Oct 2023 22:18:10 +0200
Subject: [PATCH] libcalamares: don't bind to temporaries

Clang warns about range-for-loop binding a reference
to temporaries, and these are pybind11 handles anyway
so are cheap to copy.
---
 src/libcalamares/python/Api.cpp | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/libcalamares/python/Api.cpp b/src/libcalamares/python/Api.cpp
index 3864af58b..077677911 100644
--- a/src/libcalamares/python/Api.cpp
+++ b/src/libcalamares/python/Api.cpp
@@ -173,9 +173,9 @@ QVariantList
 variantListFromPyList( const Calamares::Python::List& list )
 {
     QVariantList l;
-    for ( const auto& h : list )
+    for ( const auto item : list )
     {
-        l.append( variantFromPyObject( h ) );
+        l.append( variantFromPyObject( item ) );
     }
     return l;
 }
@@ -184,7 +184,7 @@ QVariantMap
 variantMapFromPyDict( const Calamares::Python::Dictionary& dict )
 {
     QVariantMap m;
-    for ( const auto& item : dict )
+    for ( const auto item : dict )
     {
         m.insert( Calamares::Python::asQString( item.first ), variantFromPyObject( ( item.second ) ) );
     }
@@ -195,9 +195,9 @@ QStringList
 stringListFromPyList( const Calamares::Python::List& list )
 {
     QStringList l;
-    for ( const auto& h : list )
+    for ( const auto item : list )
     {
-        l.append( Calamares::Python::asQString( h ) );
+        l.append( Calamares::Python::asQString( item ) );
     }
     return l;
 }