napcok/calamares
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[netinstall] Simplify getItemPackages

Browse Source 
- Use convenience predicate isPackage()
- Name child->item(i) for brevity
This commit is contained in:
Adriaan de Groot 2020-03-27 20:36:34 +01:00
parent 464561b420
commit 14a3e10cc2
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/modules/netinstall/PackageModel.cpp
View File

@ -203,18 +203,19 @@ PackageModel::getItemPackages( PackageTreeItem* item ) const
PackageTreeItem::List selectedPackages; PackageTreeItem::List selectedPackages;
for ( int i = 0; i < item->childCount(); i++ ) for ( int i = 0; i < item->childCount(); i++ )
{ {
if ( item->child( i )->isSelected() == Qt::Unchecked ) auto* child = item->child( i );
if ( child->isSelected() == Qt::Unchecked )
{ {
continue; continue;
} }
if ( !item->child( i )->childCount() ) // package if ( child->isPackage() ) // package
{ {
selectedPackages.append( item->child( i ) ); selectedPackages.append( child );
} }
else else
{ {
selectedPackages.append( getItemPackages( item->child( i ) ) ); selectedPackages.append( getItemPackages( child ) );
} }
} }
return selectedPackages; return selectedPackages;