From 14a3e10cc2850bd1405fcb0e7f8820c5b3868681 Mon Sep 17 00:00:00 2001
From: Adriaan de Groot <groot@kde.org>
Date: Fri, 27 Mar 2020 20:36:34 +0100
Subject: [PATCH] [netinstall] Simplify getItemPackages

- Use convenience predicate isPackage()
- Name child->item(i) for brevity
---
 src/modules/netinstall/PackageModel.cpp | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/src/modules/netinstall/PackageModel.cpp b/src/modules/netinstall/PackageModel.cpp
index 0698d4cfb..dad2207b2 100644
--- a/src/modules/netinstall/PackageModel.cpp
+++ b/src/modules/netinstall/PackageModel.cpp
@@ -203,18 +203,19 @@ PackageModel::getItemPackages( PackageTreeItem* item ) const
     PackageTreeItem::List selectedPackages;
     for ( int i = 0; i < item->childCount(); i++ )
     {
-        if ( item->child( i )->isSelected() == Qt::Unchecked )
+        auto* child = item->child( i );
+        if ( child->isSelected() == Qt::Unchecked )
         {
             continue;
         }
 
-        if ( !item->child( i )->childCount() )  // package
+        if ( child->isPackage() )  // package
         {
-            selectedPackages.append( item->child( i ) );
+            selectedPackages.append( child );
         }
         else
         {
-            selectedPackages.append( getItemPackages( item->child( i ) ) );
+            selectedPackages.append( getItemPackages( child ) );
         }
     }
     return selectedPackages;