e9e4be1c60
The root mount-point can end with a / while the mount-point read from the file /etc/mtab does not end with a /. This leads to skip the unmounting of the root mount-point and causes the removal of the root mountpoint directory to fail with EBUSY because it is still mounted. This uses the python functions os.path.normpath() to normalize the root mount-point (i.e. to drop the trailing /) and os.path.commonprefix() to determine the longest common prefix between the two mount-points. If the returned prefix is identical to the normalized root mount-point then the mount-point must be added to the list of the mount-points to unmount. More generally, the python modules should rely on the os.path functions to compare for paths instead of using strings. It covers this way lots of corner cases (path with "//", "/../", "/./", ...).
100 lines
3.2 KiB
Python
100 lines
3.2 KiB
Python
#!/usr/bin/env python3
|
|
# -*- coding: utf-8 -*-
|
|
#
|
|
# === This file is part of Calamares - <https://calamares.io> ===
|
|
#
|
|
# SPDX-FileCopyrightText: 2014 Aurélien Gâteau <agateau@kde.org>
|
|
# SPDX-FileCopyrightText: 2016 Anke Boersma <demm@kaosx.us>
|
|
# SPDX-FileCopyrightText: 2018 Adriaan de Groot <groot@kde.org>
|
|
# SPDX-License-Identifier: GPL-3.0-or-later
|
|
#
|
|
# Calamares is Free Software: see the License-Identifier above.
|
|
#
|
|
|
|
import os
|
|
import subprocess
|
|
import shutil
|
|
|
|
import libcalamares
|
|
from libcalamares.utils import gettext_path, gettext_languages
|
|
|
|
import gettext
|
|
_translation = gettext.translation("calamares-python",
|
|
localedir=gettext_path(),
|
|
languages=gettext_languages(),
|
|
fallback=True)
|
|
_ = _translation.gettext
|
|
_n = _translation.ngettext
|
|
|
|
|
|
def pretty_name():
|
|
return _( "Unmount file systems." )
|
|
|
|
|
|
def list_mounts(root_mount_point):
|
|
""" List mount points.
|
|
|
|
:param root_mount_point:
|
|
:return:
|
|
"""
|
|
lst = []
|
|
|
|
root_mount_point = os.path.normpath(root_mount_point)
|
|
for line in open("/etc/mtab").readlines():
|
|
device, mount_point, _ = line.split(" ", 2)
|
|
|
|
if os.path.commonprefix([root_mount_point, mount_point]) == root_mount_point:
|
|
lst.append((device, mount_point))
|
|
|
|
return lst
|
|
|
|
|
|
def run():
|
|
""" Unmounts given mountpoints in decreasing order.
|
|
|
|
:return:
|
|
"""
|
|
root_mount_point = libcalamares.globalstorage.value("rootMountPoint")
|
|
|
|
if(libcalamares.job.configuration and
|
|
"srcLog" in libcalamares.job.configuration and
|
|
"destLog" in libcalamares.job.configuration):
|
|
log_source = libcalamares.job.configuration["srcLog"]
|
|
log_destination = libcalamares.job.configuration["destLog"]
|
|
# Relocate log_destination into target system
|
|
log_destination = '{!s}/{!s}'.format(root_mount_point, log_destination)
|
|
# Make sure source is a string
|
|
log_source = '{!s}'.format(log_source)
|
|
|
|
# copy installation log before umount
|
|
if os.path.exists(log_source):
|
|
try:
|
|
shutil.copy2(log_source, log_destination)
|
|
except Exception as e:
|
|
libcalamares.utils.warning("Could not preserve file {!s}, "
|
|
"error {!s}".format(log_source, e))
|
|
|
|
if not root_mount_point:
|
|
return ("No mount point for root partition in globalstorage",
|
|
"globalstorage does not contain a \"rootMountPoint\" key, "
|
|
"doing nothing")
|
|
|
|
if not os.path.exists(root_mount_point):
|
|
return ("Bad mount point for root partition in globalstorage",
|
|
"globalstorage[\"rootMountPoint\"] is \"{}\", which does not "
|
|
"exist, doing nothing".format(root_mount_point))
|
|
|
|
lst = list_mounts(root_mount_point)
|
|
# Sort the list by mount point in decreasing order. This way we can be sure
|
|
# we unmount deeper dirs first.
|
|
lst.sort(key=lambda x: x[1], reverse=True)
|
|
|
|
for device, mount_point in lst:
|
|
# On success, no output; if the command fails, its output is
|
|
# in the exception object.
|
|
subprocess.check_output(["umount", "-lv", mount_point], stderr=subprocess.STDOUT)
|
|
|
|
os.rmdir(root_mount_point)
|
|
|
|
return None
|