0eb1f002db
Both the KPMCore and the ChoicePage -- asynchronously -- were connected to the nextStatusChanged() signal. So if the core said next was true, that could end up communicated to the ViewManager, enabling the *next* button in the UI. Changing to the *erase* page generally triggers a KPMCore reload, which later emits a `hasRootMountPointChanged()` signal, once the layout is applied and the disk gets a root mount point. So we'd get a `true` from KPMCore, which -- because it was connected directly to the signal to the VM -- would override any other considerations. Hook up both signals to an intermediate slot that just recalculates whether the next button should be enabled, based on the state both of the Choice page and whatever else.
100 lines
2.8 KiB
C++
100 lines
2.8 KiB
C++
/* === This file is part of Calamares - <https://github.com/calamares> ===
|
|
*
|
|
* Copyright 2014, Aurélien Gâteau <agateau@kde.org>
|
|
* Copyright 2014-2016, Teo Mrnjavac <teo@kde.org>
|
|
* Copyright 2017, Adriaan de Groot <groot@kde.org>
|
|
*
|
|
* Calamares is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation, either version 3 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* Calamares is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with Calamares. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#ifndef PARTITIONVIEWSTEP_H
|
|
#define PARTITIONVIEWSTEP_H
|
|
|
|
#include "utils/PluginFactory.h"
|
|
#include "viewpages/ViewStep.h"
|
|
|
|
#include "DllMacro.h"
|
|
|
|
#include "core/PartitionActions.h"
|
|
|
|
#include <QObject>
|
|
#include <QSet>
|
|
|
|
class ChoicePage;
|
|
class PartitionPage;
|
|
class PartitionCoreModule;
|
|
class QStackedWidget;
|
|
class WaitingWidget;
|
|
|
|
template<typename T> class QFutureWatcher;
|
|
|
|
/**
|
|
* The starting point of the module. Instantiates PartitionCoreModule,
|
|
* ChoicePage and PartitionPage, then connects them.
|
|
*/
|
|
class PLUGINDLLEXPORT PartitionViewStep : public Calamares::ViewStep
|
|
{
|
|
Q_OBJECT
|
|
|
|
public:
|
|
explicit PartitionViewStep( QObject* parent = nullptr );
|
|
virtual ~PartitionViewStep() override;
|
|
|
|
QString prettyName() const override;
|
|
QWidget* createSummaryWidget() const override;
|
|
|
|
QWidget* widget() override;
|
|
|
|
void next() override;
|
|
void back() override;
|
|
|
|
bool isNextEnabled() const override;
|
|
bool isBackEnabled() const override;
|
|
|
|
bool isAtBeginning() const override;
|
|
bool isAtEnd() const override;
|
|
|
|
void onActivate() override;
|
|
void onLeave() override;
|
|
|
|
void setConfigurationMap( const QVariantMap& configurationMap ) override;
|
|
|
|
Calamares::JobList jobs() const override;
|
|
|
|
Calamares::RequirementsList checkRequirements() override;
|
|
|
|
private:
|
|
void initPartitionCoreModule();
|
|
void continueLoading();
|
|
|
|
/// "slot" for changes to next-status from the KPMCore and ChoicePage
|
|
void nextPossiblyChanged( bool );
|
|
|
|
PartitionCoreModule* m_core;
|
|
QStackedWidget* m_widget;
|
|
ChoicePage* m_choicePage;
|
|
PartitionPage* m_manualPartitionPage;
|
|
|
|
WaitingWidget* m_waitingWidget;
|
|
QFutureWatcher<void>* m_future;
|
|
|
|
QSet< PartitionActions::Choices::SwapChoice > m_swapChoices;
|
|
|
|
qreal m_requiredStorageGiB; // May duplicate setting in the welcome module
|
|
};
|
|
|
|
CALAMARES_PLUGIN_FACTORY_DECLARATION( PartitionViewStepFactory )
|
|
|
|
#endif // PARTITIONVIEWSTEP_H
|