Adriaan de Groot
9a7465bfd5
[users] Refactor writing-hostname and writing-hosts
...
- Move to separate functions, as prep-work for making the actions
configurable (and optional).
2020-02-17 10:42:54 +01:00
Adriaan de Groot
214f9a308e
Merge branch 'improve-tests'
2020-02-16 20:29:24 +01:00
Adriaan de Groot
d5f3e2e7d4
Merge pull request #1318 from yurchor/patch-2
...
[partition] Fix typo: partitons -> partitions
2020-02-16 20:26:43 +01:00
Yuri Chornoivan
ea82a26dae
Fix typo:; partitons -> partitions
...
Many thanks in advance for reviewing.
2020-02-16 14:12:48 +02:00
Yuri Chornoivan
b582c27bf4
Fix minor typo
...
Many thanks in advance for reviewing.
2020-02-16 14:09:30 +02:00
Adriaan de Groot
90f79b0692
[users] Restore error-checking to set-hostname code
...
- Use the new CreationResult code for compact results
2020-02-14 13:27:49 +01:00
Adriaan de Groot
781322ab41
[libcalamares] Use more descriptive variable name
...
- If the test failed, you'd get a cryptic message like
FAIL! : NetworkTests::testPing() 'r' returned FALSE. ()
So rename the variable so the failure mode is more obvious.
(Could have used QVERIFY2() instead, this is simpler)
2020-02-14 13:23:19 +01:00
Adriaan de Groot
f6526f7d9f
[libcalamares] Add some tests for CreationResult
...
- More important is the compiler warning that will show up
if we add more failure states.
2020-02-14 13:21:16 +01:00
Adriaan de Groot
274115c727
[libcalamares] Update tests to reflect changed API
2020-02-14 13:07:29 +01:00
Adriaan de Groot
2d7398161d
[libcalamares] More detail for createTargetFile()
...
- Return a result-object with statrus information and the path
which was previously used (empty for "failures").
2020-02-14 13:03:51 +01:00
Adriaan de Groot
695b88b8a7
[users] Tidy up hostname creation
...
- Use the createTargetFile() convenience functions to do the
actual work.
- This probably involves more copying around of buffers, since it's
creating one big QString and sending that off, rather than writing
little chunks to a file, but I feel this is worth the code simplification.
- Drops all the error checking for creation, though, because the API for
createTargetFile() lousy.
2020-02-14 12:31:53 +01:00
Adriaan de Groot
b337a6b3f5
[user] Apply coding style
2020-02-14 11:46:35 +01:00
Adriaan de Groot
2bb4dd8e22
[users] Refactor hostname-guessing
2020-02-14 11:45:45 +01:00
Gabriel Craciunescu
7c323bdcdc
[users] Try to guess suggested hostname from dmi
...
- nothing compicated for now, just try to get something
from /sys/devices/virtual/dmi/id/product_name and fallback
to -pc thingy if we can't
2020-02-14 11:36:53 +01:00
Adriaan de Groot
7f295d9565
[partition] Apply coding style to core/ subdir
...
Because this is a giant code change, with no functional effect,
I've been saving this until the end of the kpmcore-manager branch.
2020-02-14 11:15:57 +01:00
Adriaan de Groot
2bc296b468
[unpackfs] Fix typo's introduced in june
2020-02-13 16:23:49 +01:00
Adriaan de Groot
45a31a3022
[partition] Tidy includes
...
- sort includes a little
- remove superfluous includes
- update copyright
2020-02-13 13:54:04 +01:00
Adriaan de Groot
d931b146e3
[partition] Shuffle new conveniences into partition service
...
- the general stuff from KPMHelpers ends up in the partition
service; that only gets compiled when KPMCore is available anyway.
2020-02-13 13:48:12 +01:00
Adriaan de Groot
e72ecaafd3
Merge branch 'kpmcore-manager'
...
Introduces a "partitioning service" into libcalamares,
shuffles a bunch of things into it, tries to help out
with settling the system between partitioning actions.
2020-02-13 13:41:53 +01:00
Adriaan de Groot
5a50a3a40c
[partition] Consistent FS name usage
...
- explicit use of user-visible names in EditExistingPartitionDialog
- consistent conversion of config-values to FS names (user-visible).
The GS value comes from the ViewStep, and should always match
something -- it's already converted to the canonical un-translated
so the type should be good.
2020-02-13 13:24:53 +01:00
Adriaan de Groot
57b608083e
[partition] Fix build - missing )
2020-02-13 13:24:09 +01:00
Adriaan de Groot
ca67534cd2
[partition] Improve logging of bad configs
2020-02-13 13:15:06 +01:00
Adriaan de Groot
472ec32617
[partition] Be explicit about user-visible FS names, ReplaceWidget
2020-02-13 11:49:20 +01:00
Adriaan de Groot
05dfc24af6
[partition] Be explicit about user-visible FS names, CreatePartitionDialog
2020-02-13 11:45:04 +01:00
Adriaan de Groot
88cff387c3
[partition] Be explicit about user-visible FS names, FormatPartitionJob
2020-02-13 11:33:40 +01:00
Adriaan de Groot
bacca04695
[partition] Be explicit about what's user visible in SetPartitionFlagsJob
2020-02-13 11:29:45 +01:00
Adriaan de Groot
29894cec6a
[partition] Convenience userVisibleFS()
...
- Mark uses of filesystem-name where it's intentional that they
are user-visible, with a new convenience function.
2020-02-13 11:22:09 +01:00
Adriaan de Groot
dac5516b2c
[partition] Update copyright, coding style
2020-02-13 11:12:22 +01:00
Adriaan de Groot
a0449abab9
[partition] Do not translate filesystem names
...
- Move contents of FSName to KPMHelpers
- Use the new functions from FillGlobalStorage
Needs more use in the rest of the partition module.
2020-02-13 11:06:53 +01:00
Adriaan de Groot
f410a4bb68
[libcalamares] Convenience function for FS names
...
Because getting the untranslated name of a FileSystem is something
that needs doing consistently, add some functions for that;
it makes it easier to spot places where that isn't done.
Probably doesn't compile, and needs extra documentation.
2020-02-13 10:12:02 +01:00
Adriaan de Groot
c055e1da49
[partition] Use untranslated name of filesystem
...
- Patch from Gabriel Craciunescu
2020-02-13 09:32:06 +01:00
Adriaan de Groot
aa0a799492
[welcomeq] QML warnings--
...
The config bits are all constant, so avoid NOTIFY warnings.
2020-02-12 22:47:11 +01:00
Adriaan de Groot
f094cb543b
[libcalamaresui] Set config object earlier
...
- The config context object should be set earlier, otherwise
QML code will try binding to a non-existent config already
- Document that QMLViewStep::setConfigurationMap() parent implementation
should be called **last**, at the end of the subclass implementation.
2020-02-12 22:33:49 +01:00
Adriaan de Groot
7e0cc7af41
[welcomeq] Add configuration file
...
- copy the buttons-config part from welcome.conf
- create buttons in the QML part
2020-02-12 18:24:07 +01:00
Adriaan de Groot
85b873a1a2
[libcalamaresui] Log QML error message
...
- When loading fails, log a useful error message from the QML
engine (to help debug the QML)
2020-02-12 17:58:21 +01:00
Adriaan de Groot
49ed97cb77
[libcalamares] Allow QML ViewSteps to expose a config object
2020-02-12 17:51:10 +01:00
Adriaan de Groot
f0134aab71
[welcomeq] Add more fields to Config
...
- getters as slots, for later access from QML
2020-02-12 17:37:06 +01:00
Adriaan de Groot
86bf9287ab
[notesqml] Use Branding strings
2020-02-12 16:23:34 +01:00
Adriaan de Groot
ae35256177
[welcomeq] Add top-text
...
- Fix QML indentation to the canonical 4-spaces
- Add a header at the top of the page
- Force the image to load from the filesystem
2020-02-12 16:20:53 +01:00
Adriaan de Groot
18942f835f
[libcalamares] Remove confusing name-qualifiers
...
- Using Branding::ImageEntry, when ImageEntry is an enum class
defined *in* Branding, is superfluous, and it also confuses
moc; the enum type isn't recognized from QML.
2020-02-12 15:35:11 +01:00
Camilo Higuita
15d8503726
[libcalamaresui] Expose the branding strings & urls to qml
2020-02-12 15:18:24 +01:00
Adriaan de Groot
152c3352c2
[welcomeq] Compile the QML into the module
...
- Default implementation is in the QRC
- Register Branding for QML modules (just once)
2020-02-12 15:08:18 +01:00
Camilo Higuita
b5e17b7ea5
[welcomeq] Add full-featured QML for welcome page
...
This is a merge of several commits by Camilo.
2020-02-12 14:31:15 +01:00
Adriaan de Groot
7bf0fded1b
[welcomeq] Port to newer QmlViewStep
2020-02-12 14:25:30 +01:00
Adriaan de Groot
adb312bdd2
[welcomeq] Coding style
...
- a R/W property isn't CONSTANT
- apply calamaresstyle
2020-02-12 14:19:33 +01:00
Adriaan de Groot
c7780db07a
Merge branch 'model-q'
...
- Make models of some things previously held as lists, as
prep-work for QML modules.
2020-02-12 14:08:07 +01:00
Camilo Higuita
1f2f1a657e
[libcalamaresui] Expose Branding strings to QML
2020-02-12 13:57:26 +01:00
Adriaan de Groot
ca13d1670e
[libcalamares] Merge more from Camilo
...
- Complete the model for locales
2020-02-12 13:40:59 +01:00
Adriaan de Groot
59ddda6225
Merge branch 'wrangle-boost'
2020-02-12 12:44:09 +01:00
Adriaan de Groot
9408601074
[libcalamares] Move Python wrapper
...
- Take the Python wrapper for GlobalStorage out of the GlobalStorage.h
header and add it to PythonHelper instead, saving some work in
all the cases that only GS is interesting, not the Python bits.
2020-02-12 12:37:43 +01:00
Adriaan de Groot
ad725b671e
[hostinfo] Warnings--
...
- Physical memory can't be negative, so it is reported as
an unsigned long, but the bytes-to-MiB functions do accept
negative amounts. As long as no machine has more than 2**62
bytes of memory, we're good though.
2020-02-12 12:26:55 +01:00
Adriaan de Groot
a11280b427
[libcalamares] Expand tests for printable entropy
2020-02-12 12:22:02 +01:00
Adriaan de Groot
090716ba4f
[libcalamares] Warnings-- in Entropy
...
- reading a file yields a qint64
- need to mash the unsigned data from twister to signed char data.
2020-02-12 12:15:13 +01:00
Adriaan de Groot
7efed8226c
[libcalamares] Warnings--, update copyright
2020-02-12 12:10:58 +01:00
Adriaan de Groot
c1151cbcfa
[libcalamares] Update copyright info
2020-02-12 12:08:46 +01:00
Adriaan de Groot
8181808bec
[libcalamares] Fix build
...
- drop now-obsolete boost-warnings.h
- add missing namespace alias to GlobalStorage.h (removed accidentally
in previous commit)
2020-02-12 11:25:10 +01:00
Adriaan de Groot
3b35ca7bb9
[libcalamares] Simplify includes
...
- PythonHelper.h already pulls in all the Python machinery
2020-02-12 11:04:15 +01:00
Adriaan de Groot
95722541d0
[libcalamares] Untangle Python includes
...
- Use BoostPython.h to manage overall includes
- Remove local home-grown variations
2020-02-12 11:02:38 +01:00
Adriaan de Groot
f8998834cf
[libcalamares] Simplify includes (no Python used in JobQueue)
2020-02-12 10:55:36 +01:00
Adriaan de Groot
d42e757576
[libcalamares] Simplify includes
...
- CalamaresVersion used by the job, not the API presented to Python.
- Untangle Qt includes from there.
2020-02-12 10:48:19 +01:00
Adriaan de Groot
f3e7fe5eb4
[libcalamares] Use more specific include
2020-02-12 10:32:10 +01:00
Adriaan de Groot
96580e5c40
[libcalamares] Convenience header for Boost and its warnings
2020-02-12 10:28:48 +01:00
Adriaan de Groot
6432b7f42a
[libcalamares] Hit Boost warnings with a hammer
...
- Tons of warnings from Clang 9 in Boost::Python code, so
turn of most of those warnings in the Boost-support code.
2020-02-11 16:46:44 +01:00
Adriaan de Groot
684c5f477c
[libcalamares] Moc warnings--
...
- don't have a NOTIFY CONSTANT property
- the data is constant, so drop NOTIFY
- remove redundant signals
- remove setLabels() now it's only needed from one constructor
2020-02-11 16:40:36 +01:00
Adriaan de Groot
b4b1bf5de2
[libcalamares] Call delegated constructor
2020-02-11 16:39:39 +01:00
Adriaan de Groot
df5a0d25bc
[libcalamares] Handle empty locale names quickly
2020-02-11 16:37:49 +01:00
Adriaan de Groot
27bc64e63f
[libcalamares] C++ style, warnings--
2020-02-11 15:36:30 +01:00
Adriaan de Groot
241cb04f06
[libcalamares] Coding style
2020-02-11 15:25:28 +01:00
Camilo Higuita
1b3d32ca79
make label item from LabelModel qobject based and expose properties
2020-02-11 15:24:29 +01:00
Adriaan de Groot
6c0fecd40d
[notesqml] Don't use a fixed width
2020-02-11 12:55:26 +01:00
Adriaan de Groot
c3c845e9d7
[notesqml] Add some more module documentation
2020-02-11 12:29:18 +01:00
Adriaan de Groot
4f60a6340e
[dummyqml] Drop module; it makes more sense to just be notesqml
2020-02-11 12:20:39 +01:00
demmm
c0e1ebb72a
adding notesqml, copy of dummyqml
...
included in settings.conf, commented out
2020-02-09 01:03:52 +01:00
Adriaan de Groot
39a5453904
[libcalamaresui] Add QML onActivate() and onLeave() calls.
...
- This comes from the ExecutionViewStep, V2 loading, which
notifies the QML that the QML is now active.
2020-02-07 22:18:23 +01:00
Adriaan de Groot
1f34c2834e
[libcalamaresui] Move definitions inside namespace {}
...
- Remove the extra Calamares:: namespace specifier from half the
definitions.
2020-02-07 21:33:34 +01:00
Adriaan de Groot
12675be516
[libcalamaresui] Factor out "simple" QML method calls
2020-02-07 21:25:55 +01:00
Adriaan de Groot
bf675d971b
Merge branch 'qml'
2020-02-07 21:08:29 +01:00
Adriaan de Groot
faa88afc88
Merge branch 'issue-1314'
...
FIXES #1314
2020-02-07 20:33:05 +01:00
Adriaan de Groot
229d09927e
Changes: for 2020, new fake Linux distro name
2020-02-07 20:32:20 +01:00
Adriaan de Groot
3e2908ea16
[machineid] Follow Manjaro flags
...
- add -f to ln(1) flags
2020-02-07 20:31:15 +01:00
Adriaan de Groot
110a84344b
[machineid] Test job function
...
- Create a job and ask it to create dbus files -- either directly,
or as a symlink. Since the target chroot isn't viable, this will
fail but we can at least see that directories are created, etc.
2020-02-07 20:29:42 +01:00
Adriaan de Groot
4cdcb48de6
[machineid] Functionality moved to libcalamares
2020-02-07 16:12:17 +01:00
Adriaan de Groot
b62004aae9
[machineid] Create the DBus data directory
...
- before running dbus-uuidgen or linking to systemd's UUID,
create /var/lib/dbus; some distro's don't create that
beforehand.
FIXES #1314
2020-02-07 16:10:13 +01:00
Adriaan de Groot
240fe2a564
[libcalamares] Add convenience createTargetParentDirs()
2020-02-07 16:09:02 +01:00
Adriaan de Groot
6ede9f2c7c
[libcalamares] Test QFileInfo::dir() for completeness
2020-02-07 16:08:38 +01:00
Adriaan de Groot
e65969d587
[libcalamares] Re-do createTargetDirs()
...
- Drop the basedirs idea, replace return with just bool
- Use QDir::mkpath, with some extra validation
- Test it a bit
2020-02-07 15:51:46 +01:00
Adriaan de Groot
8b8ecf7b7b
[libcalamars] Improve test init and cleanup
...
- Test createTargetFile and removeTargetFile
- Clean up afterwards
- Ensure /tmp is the RMP for each test
2020-02-07 15:23:02 +01:00
Adriaan de Groot
b502d78984
[libcalamares] Fix warning message
...
- "create" was when this function was used elsewhere
2020-02-07 13:58:44 +01:00
Adriaan de Groot
394eee3954
[libcalamares] Test more targetPath() scenario's
2020-02-07 13:57:14 +01:00
Adriaan de Groot
8d23e665ea
[libcalamares] Fix targetPath() tests
...
- there is less simplification done than you might think
2020-02-07 13:53:49 +01:00
Adriaan de Groot
daa5b804b3
[libcalamares] Split paths-tests into own test executable
...
- Since these tests all want a system object, and a GS
with a sensible setup, give them one with its own initTestCase().
This could have been done with one executable, running tests from
multiple classes, but there's not much overall benefit there.
2020-02-07 13:49:06 +01:00
Adriaan de Groot
31878dd43b
[libcalamares] Avoid double / between root and path in targetPath()
2020-02-07 13:29:35 +01:00
Adriaan de Groot
15bca702c1
[libcalamares] Add tests for path functions (part 1)
2020-02-07 11:51:13 +01:00
Adriaan de Groot
95936549e2
[libcalamares] Add a createTargetBasedirs()
...
- Used to ensure that the directories leading up to a given path
exist. Implementation is incomplete and broken for now.
- While here, avoid removing an empty pathname in removeTargetFile()
(the empty pathname indicates a broken configuration).
2020-02-07 11:30:37 +01:00
Adriaan de Groot
4af68365c9
[machineid] Remove obsolete implementation
2020-02-07 11:16:40 +01:00
Adriaan de Groot
bf882cec1d
[machineid] Migrate removeFile() to libcalamares
...
- Becomes removeTargetFile()
2020-02-07 11:16:01 +01:00
Adriaan de Groot
9ef04192db
[libcalamares] Simplify returns in targetPath()
2020-02-07 11:03:40 +01:00
Philip Müller
97ddd30af4
[machineid] folder needs to be created when not exists
...
- See #1314
2020-02-07 10:46:26 +01:00
Philip Müller
72d742e2f4
[machineid] Use same approach as we do in Manjaro
...
- See also https://gitlab.manjaro.org/applications/calamares/commit/da8f45ae
- Fixes #1314
2020-02-07 10:34:01 +01:00
Philip Müller
c766a0f10f
[machineid] create dbus var-lib folder when not existing
...
See also #1314
2020-02-07 10:26:36 +01:00
Adriaan de Groot
53b6113c75
[welcome] Fix QML tests
2020-02-05 18:38:46 +01:00
Adriaan de Groot
eaea262449
Merge branch 'master' into qml
2020-02-05 18:03:31 +01:00
Adriaan de Groot
4b3f7eb209
[calamares] Local translations can be a separate setting
...
- Don't stick this in Settings, though, it becomes overly complicated.
2020-02-05 17:48:39 +01:00
Adriaan de Groot
24c2c435a0
[libcalamares] Try repairing tests
...
- Fail on FreeBSD with an instant timeout
2020-02-05 17:08:47 +01:00
Adriaan de Groot
4525060c26
[calamares] Refactor Settings initialization
...
- add a Settings::init() to do actual work
- remove the same kind of code from CalamaresApplication
- make constructor of Settings private
- initialize settings before the application
2020-02-05 16:48:49 +01:00
Adriaan de Groot
68e8b0695d
[calamares] Make declaration order match calling order
2020-02-05 16:14:56 +01:00
Adriaan de Groot
db80a34aca
[calamares] Remove intermediate debug-settings
...
- There's a multi-stage setup for debug-mode, where the application
object also knows that debugging is set. Remove it.
- Break debug mode (because now the settings don't get debug-mode set).
- Refactor so that parameter handing is only done if this Calamares
is the unique (first) Calamares.
2020-02-05 16:10:41 +01:00
Adriaan de Groot
50b6801d35
[calamares] Install translator after loading settings
...
- means that also the *initial* translation can take settings
into account, like -d loading local translations.
2020-02-05 14:33:42 +01:00
Adriaan de Groot
f233cac7a1
[calamares] Refactor debug-logging settings
2020-02-05 14:23:55 +01:00
Adriaan de Groot
ea8adc3de7
[calamares] Simplify return from main
2020-02-05 14:04:52 +01:00
Adriaan de Groot
af862336a8
[calamares] Initialize settings before QML
2020-02-05 13:50:18 +01:00
Adriaan de Groot
91625c8ba8
[libcalamares] Tidy up boolean options in Settings
...
- The const getters for a single boolean value have moved
to the header, for inlining.
- Document the getters and what their settings mean.
2020-02-05 13:35:26 +01:00
Calamares CI
8c0ef5798d
i18n: [dummypythonqt] Automatic merge of Transifex translations
2020-02-04 22:19:48 +01:00
Adriaan de Groot
d956c79291
[libcalamares] Load translations from more places
...
- To support translation testing, without needing to recompile
Calamares, load files from the local directory when debugging,
or from /usr/share/calamares/lang/ in general.
- This allows updating translations and testing them with just
lrelease (a translation build tool) installed, without rebuilding
Calamares.
- This allows distro's to ship updated or modified translations without
rebuilding Calamares.
2020-01-30 19:06:33 +01:00
Adriaan de Groot
02e5e0de5e
[users] Use entropy service.
...
FIXES #1254
2020-01-30 10:32:34 +01:00
Adriaan de Groot
5b987d4f33
[machineid] Use entropy service
...
- Most of the code was error-checking, just replace the open-read
with a call to the service instead.
- It's not an error if /dev/urandom doesn't exist in the source system
(there may be other good random sources, and otherwise we have the
low-quality random fallback).
2020-01-30 10:32:27 +01:00
Adriaan de Groot
c971127b17
[machineid] Fix entropy-file return
...
- If the file was created and written, it would drop out of the
if() and return an error anyway.
2020-01-30 10:08:55 +01:00
Adriaan de Groot
e56948cefa
[libcalamares] Fix tests (cell is the lower unicode byte)
2020-01-29 16:41:17 +01:00
Adriaan de Groot
be0831ee11
[libcalamares] Add printable-entropy (e.g. for password salt)
2020-01-29 16:39:25 +01:00
Adriaan de Groot
8947f9c00c
[libcalamares] Test the Entropy service
2020-01-29 16:16:12 +01:00
Adriaan de Groot
a574b43eb8
[libcalamares] Also report empty buffer as no-entropy
2020-01-29 16:08:33 +01:00
Adriaan de Groot
842a90e026
[libcalamares] Add an Entropy service for getting random data
...
- Tries to get the "best" random data
- Reports the quality of the random data it got
2020-01-29 16:03:50 +01:00
Adriaan de Groot
94083edf9c
Merge branch 'master' into kpmcore-manager
2020-01-29 12:55:46 +01:00
Adriaan de Groot
252ce70203
i18n: updated (English) source files
2020-01-29 11:42:04 +01:00
Adriaan de Groot
b38ae75bef
Merge branch 'translate-checks'
2020-01-29 11:11:32 +01:00
Adriaan de Groot
8f581ca861
[welcome] Coding style
...
- apply coding style, add {}
- remove unneeded includes (moved to the widgets)
- update copyright
2020-01-29 11:10:30 +01:00
Adriaan de Groot
a09593e4a2
[locale] Tighten up language-matching
...
- Drop plain startsWith() matching, since we now have "as" and "ast"
as supported languages, where one name is a prefix of the other.
2020-01-28 17:35:54 +01:00
Adriaan de Groot
49690fc681
[locale] Remove superfluous code
...
- the list is already filtered for UTF-8, so this is redundant
- this *incidentally* fixes the problem with Assamese and Asturian,
since Assamese (as_IN) was having its only entry removed,
after which it would match Asturian (ast_ES)
2020-01-28 16:41:15 +01:00
Adriaan de Groot
97f622e094
[locale] Use standard algorithms
2020-01-28 15:50:08 +01:00
Adriaan de Groot
6b77d5db4a
[welcome] Add detail messages for root and screen checks
...
- these were empty, so the widgets were hidden in the details
dialog of the requirements check; which looks really strange
if the reason the check fails is because root is required,
and you can't see that in the details.
This commit is on a branch because it changes strings, and I want
to do a release Real Soon and not annoy the translators.
2020-01-28 15:24:29 +01:00
Adriaan de Groot
ad4ac1d25c
[welcome] Update copyrights
2020-01-28 14:23:38 +01:00
Adriaan de Groot
9d69d0a893
[welcome] Remove unused variables
2020-01-28 14:21:02 +01:00
Adriaan de Groot
1ac4786365
[welcome] Move all the translation work to the slot
...
- this needs to (re)check the satisfaction states to figure out the
message, but that's useful if the state of the checks changes
(e.g. in #1106 )
2020-01-28 14:15:57 +01:00
Adriaan de Groot
221a79b64c
[welcome] Simplify logic
...
- \not mandatorySatisfied \implies \not requirementsSatisfied,
so the ifs can be combined and simplified
2020-01-28 13:58:08 +01:00
Adriaan de Groot
28d91979c3
[welcome] Make resultWidgets less error-prone
...
- instead of counting and needing to keep track of the predicate
applied while creating the widgets, push nullptrs to the widget
list instead reflecting "this entry did not satisfy the predicate
for widget creation".
2020-01-28 13:50:23 +01:00
Adriaan de Groot
39534325e6
[welcome] Re-use widget creation code
...
- for the list, the code can be the same as for the dialog,
only the predicate is different.
- while here, implement retranslate() since there's no text on
the list widgets otherwise.
2020-01-28 13:39:27 +01:00
Adriaan de Groot
38d58e5b16
[welcome] Hoist explanatory-label code
...
- Create the label once, and it's ok for it to respond to links
even if there's none in the code.
- Turn into a member variable in preparation for retranslation-refactor.
2020-01-28 13:32:53 +01:00
Adriaan de Groot
b476e4b386
[welcome] Refactor link-clicking
...
- remove intermediate lambda
- rename dialog slot to one handling links in general (which now
**only** does the dialog link)
2020-01-28 13:24:01 +01:00
Adriaan de Groot
ecc7719abd
[welcome] Hoist checking for requirements-satisfied
...
- lift it out of the loop that creates the widgets
- some lambda-wankery, but the compiler hammers this down to
simple loops and you can read the resulting code as
none_of [the list] isUnSatisfied
none_of [the list] isMandatoryAndUnSatisfied
2020-01-28 13:13:09 +01:00
Adriaan de Groot
f5c0e57f17
[welcome] Improve variable naming
...
- these two are about whether all the checkEntries are satisfied
(in general, and the mandatory ones) so make the names reflect that.
2020-01-28 13:02:39 +01:00
Adriaan de Groot
5795801be5
[welcome] Remove unneeded member variables.
...
- local to the constructor, only needed to be members because
of the weird split between constructor and init()
2020-01-28 13:00:21 +01:00
Adriaan de Groot
5aae736ced
[welcome] Create ResultWidget in separate method
2020-01-28 12:53:19 +01:00
Adriaan de Groot
bede280f91
[welcome] Refactor ResultsListWidget
...
- no point in having init() called immediately after the constructor,
if it only makes sense to have one call to init() ever to create
the widget.
- while here, give it the same kind of structure as the dialog,
holding on to a reference to the list.
2020-01-28 12:41:36 +01:00
Adriaan de Groot
320dcac946
[welcome] Drop unneeded member variable
2020-01-28 12:23:53 +01:00
Adriaan de Groot
ed1b3b576f
[welcome] Refactor ResultsListDialog
...
- drop useless debugging
- add documentation
- move to its own spot in the file (not mixed in with ResultsListWidget)
2020-01-28 12:21:22 +01:00
Adriaan de Groot
41ac21bdcd
[welcome] Refactor results-details dialog
...
- Factor out the "details" dialog into a separate class
with a translation slot. This resolves the crash reported in #1307 .
2020-01-27 19:35:41 +01:00
Calamares CI
a017451607
i18n: [dummypythonqt] Automatic merge of Transifex translations
2020-01-27 16:40:04 +01:00
Calamares CI
ae2536a9c3
i18n: [dummypythonqt] Automatic merge of Transifex translations
2020-01-25 23:26:40 +01:00
Adriaan de Groot
39cc13cb25
[shellprocess] Tidy code
...
- resolve TODO, use a unique_ptr to hang onto the command-list
- sort the #includes, use correct quoting
2020-01-25 15:23:10 +01:00
Adriaan de Groot
71a73ee1a1
[libcalamares] PythonJob created with InstanceKey
2020-01-25 15:15:32 +01:00
Adriaan de Groot
96946a8447
Merge branch 'fix-unpackfs-progress'
...
This is an ugly hack, using Bill Auger's support for Job weights.
The unpackfs job is arbitrarily awarded a weight of 12. That makes it
(in a Netrunner install) use progress from 12% to 40% or so, overall,
as all the files are unpacked.
Also fixes bug reported by Kevin Kofler that unpackfs was only reporting
progress when it hit an exact multiple of 100 (instead of over 100).
SEE #1176
2020-01-25 11:53:31 +01:00
Adriaan de Groot
9976e92659
[libcalamares] Enlarge unpackfs to 12x
2020-01-25 03:06:20 +01:00
Adriaan de Groot
d4b24894cb
[libcalamares] Weigh unpackfs extra heavy
...
- This is a gross hack, which hard-codes unpackfs as much-heavier
than other Python modules.
2020-01-25 02:45:52 +01:00
Adriaan de Groot
0c9188ee83
[libcalamares] Document JobWeight
2020-01-25 02:45:52 +01:00
Adriaan de Groot
cdd2b9cc79
Modules: set noconfig:true on Python modules
...
- hwclock, initramfs, localecfg and networkcfg don't have any
config file to work with, so set that explicitly in the module.desc
2020-01-24 23:10:41 +01:00
Adriaan de Groot
8d47751cb2
[libcalamares] Beautify debug output for InstanceKey
2020-01-24 22:53:14 +01:00
Adriaan de Groot
83ffbd5126
[libcalamaresui] Only load config file if there is one
...
- finally, no more warnings for modules that are NO_CONFIG
(or noconfig: true) and don't have a config file.
2020-01-24 21:47:54 +01:00
Adriaan de Groot
f366e3840f
[libcalamaresui] Chase stronger typing of ModuleDescriptor
2020-01-24 21:46:18 +01:00
Adriaan de Groot
00deeec8c8
[libcalamaresui] Use InstanceKey instead of strings
...
- Replace return type of Module::instanceKey() by the structured
ModuleSystem::InstanceKey type
- Chase API breakage
2020-01-24 17:47:06 +01:00
Adriaan de Groot
abdeb07bd3
[dummyqml] Minor polishing in Qml module
...
- document the default filename better
- mark TODO actually loading the instance-id file
2020-01-24 17:14:45 +01:00
demmm
b20a957c6e
restore includes in header file to amke it build
2020-01-24 15:52:59 +01:00
demmm
538d8d5497
address qmlLabel changes too
2020-01-24 15:14:51 +01:00
demmm
9f55cf4cf4
part of the changes requested
...
others fail to build, or no idea how to fix
2020-01-24 15:12:10 +01:00
Adriaan de Groot
b5d0acdf81
[luksbootkeyfile] Set NO_CONFIG
2020-01-24 13:13:50 +01:00
Adriaan de Groot
40f64f0c11
[hostinfo] Set NO_CONFIG and remove unused configuration methods
2020-01-24 13:12:25 +01:00
Adriaan de Groot
fd058302b8
[dracutlukscfg] set NO_CONFIG and coding style
2020-01-24 13:08:25 +01:00
Adriaan de Groot
6530c889f0
Merge remote-tracking branch 'origin/use-idkey' into no-config
...
- Join to a single branch that does a bunch of tidying
in the type-strictness of module interfaces.
2020-01-24 13:05:22 +01:00
Adriaan de Groot
155db29ccf
[libcalamares] Add a ModuleSystem::Descriptor
...
- this is currently just an alias for QVariantMap, which is
the type already in use.
- future plan is to tighten this up and have an actual
Descriptor class that carries only the information
actually needed for the module descriptor.
2020-01-24 12:59:35 +01:00
Adriaan de Groot
974d795390
[libcalamares] Shuffle module-loading logic
...
- group ifs by the state of thisModule
2020-01-21 19:57:16 +01:00
Adriaan de Groot
58931d99fa
[libcalamaresui] Support noconfig setting
...
- look up the descriptor and use its noconfig value
- return empty QString if noconfig is set; this does not
apply to custom instances
2020-01-21 19:57:16 +01:00
Adriaan de Groot
649eb94d24
[libcalamaresui] Type-alias for module descriptors
2020-01-21 19:29:47 +01:00
Adriaan de Groot
8fbe676280
[libcalamaresui] Refactor finding config file name
...
- check for broken custom instances earlier in the loop
- make free function for finding the config file name
2020-01-21 19:22:13 +01:00
Adriaan de Groot
d1f162f92a
Docs: describe *noconfig* module option
2020-01-21 18:31:13 +01:00
Adriaan de Groot
10d1c4cf5b
[unpackfs] Improve progress reporting
...
- don't rely on exactly 100 files being copied (thanks to Kevin Kofler)
2020-01-20 19:39:05 +01:00
Adriaan de Groot
fbb452f9bf
CMake: add support for NO_CONFIG
...
- A C++ module should set NO_CONFIG to flag that it doesn't have a
config file (this is an error if it secretly **does** have one)
2020-01-20 19:27:34 +01:00
Adriaan de Groot
fed0c46612
[libcalamaresui] Change return type of loadedInstanceKeys()
...
- Replace stringlist with a stronger-typed list of InstanceKey objects
- Move smashing-that-to-stringlist into consumers of the list
(just one, the debug window)
2020-01-19 18:07:27 +01:00
demmm
32eee82744
clean-up dummyqml.conf
2020-01-14 13:08:54 +01:00
demmm
f2e68ddcf4
adding configure option dummyqml
...
sidebar entry can be configured and translated
adding a more elaborate qml example
keeping this in dummyqml for now, another commit will follow with
continuation of dummyqml in a more aptly named module
2020-01-14 12:30:22 +01:00
Adriaan de Groot
750465153f
[dummyqml] Improve QML searching
...
- if the filename is an absolute path, use that
- support searching in branding directory
2020-01-13 22:28:21 +01:00
Adriaan de Groot
7f8a31007a
[dummyqml] Search for files
...
- start implementation of searching-for-qml
- add a *filename* configuration item, so that the filename
can be set per-instance (via the config file)
2020-01-13 22:04:27 +01:00
Adriaan de Groot
ed4127f661
[libcalamaresui] Shuffle the module interface
...
- introduce NamedEnum lookup tables for interface and type
- drop "final" and "virtual" from methods that don't make
sense as virtual
- shuffle declaration order so the virtual API for modules
sits together
2020-01-12 12:18:13 +01:00
Adriaan de Groot
f89c137c90
[libcalamaresui] Migrate module to using InstanceKey
...
- Trying to get away from untyped strings with special meaning.
- The "split identifier" branch tried the same thing, but
was duplicating the existing InstanceKey.h work.
2020-01-12 11:49:10 +01:00
Adriaan de Groot
a7e1a1f9fc
[libcalamaresui] Refactor Module::initFrom()
...
- generic initFrom() also sets the instance id
- subclass-specific initFrom() now pure virtual in base
- chase changes in subclasses
2020-01-12 11:37:22 +01:00
Adriaan de Groot
04615b251c
[dummyqml] Make prettyName() return a sentence with .
2020-01-10 17:47:02 +01:00
Adriaan de Groot
ce6d54ad95
[libcalamaresui] Improve failure message, unbreak loading
...
- example loading had an X inserted in filename (to test failure)
- add a space between name and failure
2020-01-10 17:45:09 +01:00
Adriaan de Groot
fed298b179
[libcalamaresui] Defer QML loading
...
- need a configuration before we can start loading (to support
the variable search paths)
- refactor showing a failure in the spinner widget. On failure,
the spinner will never go away, so a message for the user is good.
- stop clang-format from messing up the table of names.
2020-01-10 17:41:20 +01:00
Adriaan de Groot
e7e66497d2
[libcalamaresui] Introduce search method for QML UI modules
...
- add a sample config and documentation in dummyqml/
2020-01-10 17:19:15 +01:00
Adriaan de Groot
23a957e783
[libcalamares] Chase API change (timeouts)
...
- The new mount service needed adjustment for the independent
change of timeouts: int -> chrono::seconds.
2020-01-10 15:22:26 +01:00
Adriaan de Groot
f6d89354a1
Merge branch 'master' into kpmcore-manager
2020-01-10 14:54:13 +01:00
Adriaan de Groot
e6713d456c
[libcalamaresui] Need explicit qrc: scheme
2020-01-10 13:44:26 +01:00
Adriaan de Groot
c03c6fc8ed
[libcalamaresui] Qml loading
...
- this is mostly copied from ExecutionViewStep (only the V2 QML
loading), which does the same kind of thing.
- loading from QRC does not work yet
2020-01-10 13:39:03 +01:00
Adriaan de Groot
44b250809f
[libcalamaresui] Add spinner to QmlViewStep
...
- view step now has a widget, doesn't load QML yet
2020-01-10 13:10:55 +01:00
Adriaan de Groot
60c1d40b20
[libcalamaresui] Log which ViewStep is broken
...
- a ViewStep with no widget will crash the application;
print out its name before doing so.
2020-01-10 12:56:46 +01:00
Adriaan de Groot
1cc40bda83
[dummyqml] Stub of a QML module
2020-01-10 12:41:00 +01:00
Adriaan de Groot
4924839217
[libcalamaresui] Start QmlViewStep
2020-01-10 12:13:40 +01:00
Adriaan de Groot
16a460adff
[libcalamaresui] Move ExecutionViewStep where it belongs
...
- viewpages/ collects the ViewStep implementations
- chase header moving and tidy some #includes
2020-01-10 12:07:35 +01:00
Adriaan de Groot
970702daa0
[libcalamaresui] Tidy up includes
2020-01-09 21:39:34 +01:00
Adriaan de Groot
537c257acf
Merge branch 'master' into qml
2020-01-09 15:17:23 +01:00
Adriaan de Groot
56f926094e
[welcomeq] Update comments
...
- Copyright years
- Purpose of this module
2020-01-09 15:11:36 +01:00
Adriaan de Groot
1a8926181e
[locale] Warnings-- (initialization-order)
2020-01-07 10:46:26 +01:00
Adriaan de Groot
2dff2d9d70
[libcalamares] TZRegion is hard to copy
...
- delete the copy and move constructors
- adjust tests (which were just interested in simple tr() behavior) to use TZZone instead
2020-01-07 10:41:14 +01:00
Adriaan de Groot
5fbd0169ca
[libcalamares] Reduce clang warnings (only-inline-virtual, unused parameters)
2020-01-07 10:33:21 +01:00
Adriaan de Groot
1b62b2f66c
[libcalamares] Reduce warnings (extra ;, empty statement ..)
2020-01-07 10:19:22 +01:00
Adriaan de Groot
b4c0ebe8ab
[calamares] Use screen and window sizes, not position
2020-01-07 10:04:10 +01:00
Adriaan de Groot
fcb0109b7b
[calamares] Refactor center-placement
...
- Just move it to its own function where it can have more documentation
- Tested on multi-screen setups
SEE #1293
2020-01-07 09:56:13 +01:00
Adriaan de Groot
121013fd96
[calamares] Avoid deprecated desktop()
...
- Put Calamares on the first screen where it fits
- This is wordy and weird
2020-01-07 01:06:26 +01:00
Adriaan de Groot
43caf7b46a
[calamares] Restore functionality for 'center window'
2020-01-07 00:34:15 +01:00
Adriaan de Groot
17d09342e9
[libcalamaresui] Add a setting for window placement
2020-01-07 00:27:11 +01:00
Adriaan de Groot
1625bb1dae
[locale] Support Qt 5.9
...
FIXES #1296
2020-01-07 00:09:04 +01:00
Adriaan de Groot
d21ed0cc7f
[packagechooser] Coding style
2020-01-06 17:55:13 +01:00
Adriaan de Groot
cefb66ab5b
Merge pull request #1276 from bill-auger/patch-packagechooser-default-selection
...
[packagechooser] pre-select default item in packagechooser
2020-01-06 17:49:10 +01:00
Adriaan de Groot
dd5adc153f
Merge pull request #1291 from calamares/initcpiocfg-usr
...
[initcpiocfg] add usr hook if partition is separate
2020-01-06 14:41:24 +01:00
Adriaan de Groot
fe64903d2f
[initcpiocfg] Polish PR #1290
...
- List discrete years in copyright
- Add docstrings
- Massage detect_plymouth() to return bool (easier in if() context)
2020-01-06 14:34:47 +01:00
Philip Müller
85d3f9e9b9
[initcpiocfg] add usr hook if partition is separate
2019-12-16 09:40:54 +01:00
Philip Müller
a3da47cd9c
[initcpiocfg] update plymouth check
2019-12-16 09:34:21 +01:00
Adriaan de Groot
8e2d257040
[welcomeq] Add QML machinery (uninitialized)
2019-12-14 13:11:14 +01:00
Adriaan de Groot
53b208e891
[welcomeq] Start new ViewStep for QML-based welcome
2019-12-14 12:48:09 +01:00
Adriaan de Groot
6c4efc1f9c
[welcome] Add Branding object to QML demo
2019-12-13 18:23:01 +01:00
Adriaan de Groot
55f61fda35
[welcome] Create branding and settings objects
2019-12-13 18:18:02 +01:00
Adriaan de Groot
03ed308bd9
[welcome] Add QML model for translations
2019-12-13 14:31:42 +01:00
Adriaan de Groot
d41d8df2a5
[welcome] Put Config object into context
2019-12-13 13:19:38 +01:00
Adriaan de Groot
c59678594b
[welcome] More QML support
...
- start of a class to hold configuration information; this can
later be substituted into the WelcomeViewStep and filled from
setConfigurationMap()
In the example application:
- register the Config type
2019-12-13 12:37:09 +01:00
Adriaan de Groot
156d78feb3
[welcome] Add QML support
...
- test application to display the QML (this will be extended
with adding the locale model to it)
- sample QML that does nothing useful yet (will display the locale
model once it's there)
2019-12-13 11:50:12 +01:00
Adriaan de Groot
0e7982ec37
[libcalamares] Don't force Hindi on India.
...
FIXES #1284
2019-12-11 18:33:24 +01:00
Adriaan de Groot
58786388d6
Merge branch 'zone-data'
2019-12-11 15:34:35 +01:00
Adriaan de Groot
7bea19a62c
[locale] Fix build with debugging enabled (API changes)
2019-12-11 08:45:35 -05:00
Adriaan de Groot
242b79e2e1
[locale] Remove old Location information
...
- all the TZ location information now lives in the Calamares
locale service and the TZ list
- replace the Location class that was local to the timezone
widget by the TZZone class
- chase a bunch of small API changes that this needs
2019-12-11 08:45:35 -05:00
Adriaan de Groot
4945408911
[libcalamares] Remove debugging cruft
2019-12-11 08:45:35 -05:00
Adriaan de Groot
daa76080f1
[libcalamares] Add meaningful aliases for key()
2019-12-11 07:00:42 -05:00
Adriaan de Groot
0ed2a3e35f
[libcalamares] Refactor translation-setting
...
- Split the actual loading of translations into classes
to encapsulate the loading logic,
- Build a collection of classes to do the different kinds
of translation loading,
- Build a generic function to load something and update a
static pointer to the translation.
This makes installTranslator() much easier to read, and encapsulates
the type-specific loading somewhere else. While here, add a timezone-
translations loader so that the split-out TZ translations also work.
2019-12-11 06:40:22 -05:00
Adriaan de Groot
93ae44e214
[libcalamares] Split translatable timezone data
...
- Hide the one file from lupdate by giving it a weird suffix
- Call lupdate a second time for the timezone translations
- While here, adjust so that the options precede the directories
they are supposed to affect
I don't want to give the translation teams 444 new strings all
at once (about 90% of which don't need translation).
2019-12-10 22:44:10 +00:00
Adriaan de Groot
e164f8d63a
[locale] Fix build with DEBUG_TIMEZONE
...
- all the API changes were not reflected in the debugging code
2019-12-10 16:19:06 -01:00
Adriaan de Groot
fb9d53909e
[locale] Drop ZONES #define
...
- this was a "cheap" way to write a list, but going through
QStringList::split() is just a long-way-around for static
initialization
2019-12-10 16:09:48 -01:00
Adriaan de Groot
2dfbed40c5
[locale] Move defines
...
- Used in only one place, move to .cpp
- Drop useless scaling all the images *are* that size already
- Add debugging check that the images match expected size
2019-12-10 10:00:16 -07:00
Adriaan de Groot
9d9d9c361d
[locale] Clean up constants
...
- move LOCALESDIR to the one place it's used
- remove file with only unused #defines
2019-12-10 17:46:09 +01:00
Adriaan de Groot
7354d35faf
[locale] Apply coding style to timezonewidget/
2019-12-10 17:42:58 +01:00
Adriaan de Groot
1e04924224
[locale] Drop the TZ-widget's timezone database
...
- use the global TZ service instead
- contains hacks to keep some of the API unchanged, which will be
removed shortly
2019-12-10 17:29:35 +01:00
Adriaan de Groot
08dc9011d6
[libcalamares] Off-by-one folded the world in half
...
- Dropped the sign from longitudes, wrapping the west onto the east
2019-12-10 17:11:10 +01:00
Adriaan de Groot
1880eb5148
[libcalamares] Add accessors for TZZone
2019-12-10 16:10:16 +00:00
Adriaan de Groot
3f57b929ee
[libcalamares] Make the zoneTab region list static
...
- there's only one zone.tab, it won't change during a run,
load it only once (this allows for a single global list).
2019-12-11 01:43:53 +10:00
Adriaan de Groot
4089a01cb1
[locale] Create TZ model earlier
2019-12-11 01:31:56 +10:00
Adriaan de Groot
a39c77dfaf
[libcalamares] Store region name in each zone as well
2019-12-11 01:11:51 +10:00
Adriaan de Groot
226530cf6f
[locale] Use model functions from locale service
...
- drop the home-grown combo-box filling, use model
2019-12-11 01:04:09 +10:00
Adriaan de Groot
c75e870073
[libcalamares] CStringList::find() convenience function
...
- search for a key and return a type-cast pointer to the result
- while here, simplify some other code
- the find() function could be done with std::find_if but doesn't
get any shorter or more elegant
2019-12-10 15:54:43 +01:00
Adriaan de Groot
6092172f8d
[libcalamares] Regions and zones change to QList<Base*>
...
- By using QList< CStringPair* > consistently, we can save
a bunch of model code at the cost of an occasional dynamic_cast;
it's fairly rare for there to be a need for the derived pointer.
2019-12-10 15:32:15 +01:00
Adriaan de Groot
fc8364ea54
[libcalamares] Store zones with each region
...
- move operator< to base class
- add each zone to the list held by the region
- sort zones at the end
2019-12-10 14:06:22 +00:00
Adriaan de Groot
1a8439069e
[libcalamares] Extend TZ with location and country
2019-12-10 15:36:53 +02:00
Adriaan de Groot
f4509f3380
[libcalamares] Move loading to TZRegion
...
- don't make the model load files, provide convenience functions
for loading in the value classes
- create model from lists of value pointers
2019-12-10 10:48:39 -01:00
Adriaan de Groot
da277fa7ba
[libcalamares] Drop superfluous enum
2019-12-10 17:42:32 +06:30
Adriaan de Groot
9a5e614172
[libcalamares] Build the TZRegion list in one pass
...
- read the file and create the regions on-the-fly, then sort the
resulting list (instead of building a string list and then
building the regions afterwards)
2019-12-10 17:24:33 +06:30