Adriaan de Groot
f04394d014
[partition] Improve rendering of KPMCore errors
2021-12-13 20:02:52 +01:00
Adriaan de Groot
07354a26a9
[partition] Simplify debug calls to executables
...
- Use the Calamares support-functions for running lsblk and mount
(these might need to have privilege support if Cala is not
running as root, so this is future-proofing)
2021-12-13 20:02:52 +01:00
Adriaan de Groot
fdf0f208f0
[partition] Use lvalue-overload of execute() convenience
...
- These jobs may take a long time, and report progress; we need
the operation around to be able to connect the signals and slots
2021-12-13 20:02:52 +01:00
Adriaan de Groot
6680584724
[partition] Use convenience function execute()
...
This job needs the lvalue-overload of execute() because it needs to
call a method on the operation after execute() finishes successfully.
2021-12-13 20:02:52 +01:00
Adriaan de Groot
c5573a1997
[partition] Add non-const lvalue overload for execute()
2021-12-13 20:02:52 +01:00
Adriaan de Groot
b8ce21d572
[partition] Use convenience function for running operations
2021-12-13 20:02:52 +01:00
Adriaan de Groot
1356012fb4
[partition] With rvalue, code becomes even more compact
2021-12-13 20:02:52 +01:00
Adriaan de Groot
8bb2c5fc6b
[partition] Use convenience-method for running operation
2021-12-13 20:02:52 +01:00
Adriaan de Groot
dc7a1e43b7
[partition] Add helper for running a KPMCore operation
...
Most *partition* module jobs run an operation and turn that into
a JobResult -- ok if it succeeds, and with the report text otherwise.
Factor it out into a separate method that can be used as shorthand.
2021-12-13 20:02:52 +01:00
Adriaan de Groot
03da766b39
[partition] Keep 64-bit integers for swap sizes
...
FIXES #1849
2021-12-11 13:19:08 +01:00
Adriaan de Groot
1d96c5af46
[partition] Table type 'none' is a late addition.
2021-12-05 01:32:51 +01:00
Adriaan de Groot
f0eb7ffbda
[partition Untangle, Warnings--
...
The translations apply to labels and a tooltip, which depends on
the partition-table type. Move the strings together and make
the whole range of the switch explicitly.
2021-12-08 00:59:20 +01:00
Adriaan de Groot
e8ca298712
[partition] Reduce warnings
2021-12-08 00:15:01 +01:00
Adriaan de Groot
13700b18c8
[partition] Warnings--
...
- remove superfluous `break`
- massage types around partition sizes
2021-12-08 00:06:17 +01:00
Adriaan de Groot
09f47b5762
[partition] Build tests with consistent flags (in particular, KPMCore4-API flags)
2021-12-07 15:51:45 +01:00
Adriaan de Groot
6e715205d7
[partition] Warnings-- by calling formatting consistently
2021-12-07 15:36:11 +01:00
Adriaan de Groot
09a03fbbc0
[partition] Warnings--: we don't care about one-byte-in-10^12
2021-12-07 15:31:49 +01:00
Adriaan de Groot
bb3f4442f5
[partition] Warnings-reduction
...
- use consistent size-formatting
- needs an out-of-line virtual function
2021-12-07 15:30:21 +01:00
Adriaan de Groot
5b05110351
[partition] Add convenience function formatByteSize
...
We want to use the KPMCore function consistently, but Calamares
uses a qint64 most of the time. Centralize the cast to double
in one place in the code.
2021-12-07 15:29:02 +01:00
Adriaan de Groot
149f3ff3fe
[partition] Reduce warnings about shadowed variables
2021-12-06 14:52:33 +01:00
Adriaan de Groot
d89553a777
[partition] Avoid problems with MessageAndPath in containers (drop const)
2021-12-06 14:46:26 +01:00
dalto
f5b882a075
[partition] Remove setState call to resolve compat issue with older kpmcore
2021-11-18 13:36:23 -06:00
Adriaan de Groot
ece1e338e0
Merge pull request #1822 from dalto8/zfs-wip
...
[zfs] Support for installing to root-on-ZFS
2021-11-17 12:20:34 +01:00
Adriaan de Groot
efe84bc6c0
[partition] Don't log private names
...
- log device node (/dev/sdb) instead of its name
- don't log job's prettyName() because that's translated, and also
contains user-visible private names (introducing a non-translated,
nicely redacted version of prettyName() seems like too much effort
for something that can be reconstructed from bits earlier in the log)
2021-11-16 15:31:35 +01:00
Adriaan de Groot
5a4e2b73ab
[libcalamares][partition] Give RedactedName a convert-to-QString
...
- use hex-trailer
- while here, convert DebugRow to use a copy rather than a reference,
to avoid dangling references when applied to temporaries
- convert *partition* module to use the RedactedNames
2021-11-16 15:22:04 +01:00
Adriaan de Groot
7cc84b89be
[partition] Clarify the meaning of the various UUIDs in debug-output
2021-11-16 14:15:00 +01:00
Adriaan de Groot
4db4e983e3
[partition] Don't format tables of attributes in source
2021-11-16 14:04:00 +01:00
Adriaan de Groot
3aac4dea67
[partition] Remove logging-of-a-pointer during device detection
2021-11-16 13:52:10 +01:00
dalto
490ac8d086
[partition] Ensure format is selected for existing zfs partitions
2021-11-15 18:41:35 -06:00
dalto
c48c91a5bd
[partition] Add support for zfs encryption when erase disk is selected
2021-11-15 18:41:35 -06:00
dalto
ee99ee48f6
Add support for multiple zpools
2021-11-15 18:41:35 -06:00
dalto
6da9bad272
[partition][zfs] Add support for zfs encryption
2021-11-15 18:41:34 -06:00
dalto
24a376493b
[partition] Add support for manually creating a partition for zfs
2021-11-15 18:41:34 -06:00
dalto
ca3f0e2892
[partition] Add zfs to the filesystem list if the zfs modules is enabled
2021-11-15 18:41:34 -06:00
Adriaan de Groot
8639c9a79f
[partition] Fix up tests
2021-11-09 16:37:25 +01:00
Adriaan de Groot
cd0785164b
[partition] Fix compatibility with Qt 5.12
2021-11-09 15:57:20 +01:00
Adriaan de Groot
575654941f
[partition] Move required partition table type to Config
...
- remove from GS
- remove duplication across Config and ChoicePage
- improve translations (presumably "msdos or gpt" is the most
complicated it will get)
FIXES #1735
2021-11-09 12:25:47 +01:00
Philip Müller
0486e48c4e
[partition] offer /boot also when other EFI partition was specified
...
- it still makes sense to offer /boot in EFI
- example: /boot ext4, /boot/efi vfat
- this partly reverts 60f8a7c5fb
2021-11-09 01:51:49 +01:00
Adriaan de Groot
e8209089c6
Merge branch 'issue-1740' into calamares
...
FIXES #1740
2021-11-03 15:49:03 +01:00
Adriaan de Groot
a0cb4b63a8
[partition] Fix build for old Qt
2021-11-03 11:14:22 +01:00
Adriaan de Groot
344948b5ab
Modules: clean up QProcess (part 1)
2021-11-02 23:46:26 +01:00
Adriaan de Groot
b5dba9108c
[partition] Check for LVs that will be formatted, don't close them
...
- when (manually) using an existing LV, it shouldn't be closed
prior to formatting, since that kills the volume and then the
path (/dev/myvg/mylv) no longer exists. Then creating the
filesysytem on that device path fails.
2021-11-02 15:33:34 +01:00
Adriaan de Groot
7b45793b60
[partition] Allow exceptions when closing /dev/mapper
...
- some names should not be closed, like "control"
- allow a list of names to be added which should not be closed
2021-11-02 15:26:25 +01:00
Adriaan de Groot
1410157356
[partition] Simplify and document ClearMounts
...
- note that the job indiscriminately closes all LUKS and LV
- don't hang on to lists we don't need
2021-11-02 11:55:13 +01:00
Adriaan de Groot
0253977778
[partition] Coding style
2021-11-02 11:50:51 +01:00
Adriaan de Groot
ca4a187d1a
[partition] Extract the get-PV-groups code to its own function
...
- get the list (once)
- move the lambda to a named function for readability
2021-11-02 11:18:14 +01:00
Adriaan de Groot
7fa02fd41c
[partition] Extract the get-LVM-volumes code to its own function
2021-11-02 11:10:09 +01:00
Adriaan de Groot
2a1ec84c87
[partition] Don't hang on to pointer longer than needed
2021-11-02 11:03:10 +01:00
Adriaan de Groot
04b119b051
[partition] Crypto device-list needn't be a member, either
2021-11-02 00:25:37 +01:00
Adriaan de Groot
f49389a408
[partition] Fix logic errors in stringification of MessageAndPath
2021-11-02 00:09:52 +01:00