Adriaan de Groot
83f5f9e1a7
[libcalamares] Introduce generic delete-later class
...
Don't bother with QScopeGuard just right now, since I can't
find a use-case in the Calamares codebase.
FIXES #1358
2020-03-28 11:49:23 +01:00
Adriaan de Groot
7c56a50632
[netinstall] Expand documentation of groups format
2020-03-28 11:18:31 +01:00
Adriaan de Groot
33a4b08ac0
Merge branch 'issue-1343'
...
- Also add documentation to CHANGES
FIXES #1343
FIXES #1319
2020-03-27 21:14:47 +01:00
Adriaan de Groot
433ed8384f
[netinstall] Inherit criticalness in groups
...
- Groups inherit slightly differently: if a subgroup **explicitly**
configures criticalness, use that. It would be weird, but possibly,
to have a non-critical subgroup of a critical group.
2020-03-27 20:53:13 +01:00
Adriaan de Groot
83a89c144c
[netinstall] Packages should inherit critical-ness from parent
2020-03-27 20:45:04 +01:00
Adriaan de Groot
14a3e10cc2
[netinstall] Simplify getItemPackages
...
- Use convenience predicate isPackage()
- Name child->item(i) for brevity
2020-03-27 20:37:36 +01:00
Adriaan de Groot
464561b420
[netinstall] Update subgroup-checkedness based on children
...
- An unselected group with (some) selected subgroups was not
displayed as (semi)checked -- it was unchecked, because
its checked-ness was not updated based on the children.
2020-03-27 17:28:32 +01:00
Adriaan de Groot
63b940a623
[netinstall] Implement immutable groups
...
- An immutable group doesn't show a checkbox at all
2020-03-27 16:47:33 +01:00
Adriaan de Groot
7a42a4d71f
[netinstall] Add example section that is immutable
...
- The section can't be changed, but is selected (it doesn't
make sense otherwise)
2020-03-27 16:47:07 +01:00
Adriaan de Groot
85551f0fdb
[netinstall] Various refactoring
...
- move ready-indication to Config
- don't check pointers that can't be null
- hand the whole Config to the page
2020-03-27 16:12:48 +01:00
Adriaan de Groot
4cdfe1276a
[netinstall] Rip loading out of the UI page
...
- Create a config object in the ViewStep
- Model lives in the config object and loads there
- Give model to the UI page for display
2020-03-27 15:51:03 +01:00
Adriaan de Groot
9a35427113
[netinstall] Remove unused m_jobs
...
- Netinstall doesn't make any jobs itself, so drop the member variable
- Use type alias, and simplify jobs()
2020-03-27 15:14:37 +01:00
Adriaan de Groot
1a74a713b6
[netinstall] Make status an enum
...
- Since we might change translations after loading, display
the message based on the status enum, rather than
setting it once at load-time.
2020-03-27 14:54:06 +01:00
Adriaan de Groot
1eec1a9fe7
[libcalamares] Fix typo in API
...
- "asynchronouse" is not a thing
2020-03-24 13:43:19 +01:00
Adriaan de Groot
f5b4e5d5e1
[netinstall] Add data-loading to the Config object
...
- Mostly copied from NetInstallPage
2020-03-24 13:13:18 +01:00
Adriaan de Groot
938536c0c3
[netinstall] Allow post-creation loading of model data
...
- Instead of loading all in the constructor, provide a public
setupModelData().
- This allows creating the model and setting it for UI, before
the load completes.
2020-03-24 12:36:31 +01:00
Adriaan de Groot
5e03df723c
[netinstall] Add a (stub) Config object
...
- Add initial definition of Config object, which will extract the model-
setting and loading code from the page, and which is also prep-work
for a QML version of this module.
- While here, remove superfluous code
2020-03-24 12:05:48 +01:00
Adriaan de Groot
1a5c916923
[netinstall] Implement local
loading of packages
...
- For a static list of selectable packages (e.g. what you might otherwise
use file:/// for with a static file on the ISO) you can now stick the
list in the config file itself, simplifying some setups.
- Also saves faffing about with network.
SEE #1319
2020-03-24 11:35:58 +01:00
Adriaan de Groot
f59cae2dbb
[netinstall] Document local
URL
...
- `local` is supposed to read from the config-file, rather than
externally; this simplifies examples, makes it easier to have
multiple netinstalls, and condenses the documentation.
2020-03-23 17:20:14 +01:00
Adriaan de Groot
fa28788f78
[netinstall] Build the model from QVariantList always
2020-03-23 17:20:14 +01:00
Adriaan de Groot
ebc1db6a7b
[netinstall] Test loading of a whole (example) file
2020-03-23 17:20:14 +01:00
Adriaan de Groot
f592a3f373
[netinstall] Expand tests to include group-checking
...
- Check groups
- Check whole treemodels recursively (this is not in PackageTreeItem,
because that explicitly ignores the tree structure).
- Also a stub of checking example files (from the src dir)
2020-03-23 17:19:32 +01:00
Adriaan de Groot
025ab8b524
[netinstall] Be explicit about checkedness-to-bool conversions
2020-03-23 17:19:32 +01:00
Adriaan de Groot
0e2b3986b9
[netinstall] Use explicit accessor for the type-of-item
2020-03-23 17:19:32 +01:00
Adriaan de Groot
f7191ac29e
[netinstall] Compare two PackageTreeItems
...
- Packages and groups check different fields for equality.
- Selected-state is **not** part of equality.
- Also operator !=
2020-03-23 17:19:15 +01:00
Adriaan de Groot
52d3f4417f
[netinstall] Add explicit isGroup()
...
- Previously you would either need to know where in the tree a
PackageTreeItem was, or guess that an empty packageName() means that
it's a group.
2020-03-23 17:19:14 +01:00
Adriaan de Groot
bca316299e
[netinstall] Add tests
...
- Just some simple tests for the Items
- Test creation of package group from variant
- This needs Qt5::Gui to link because QStandardItem is a GUI class,
although we can run the tests without a GUI.
2020-03-23 17:19:00 +01:00
Adriaan de Groot
dc403237f2
[netinstall] Build model from QVariantList
...
- As an alternative to the YAML-wranging, build the model from
a QVariantList instead.
- Expose this as a constructor, too.
2020-03-23 17:18:44 +01:00
Adriaan de Groot
4143ad67af
[netinstall] Remove superfluous code
...
- The constructor for PackageTreeItem now takes over the selected
state from the parent.
2020-03-23 17:18:44 +01:00
Adriaan de Groot
c7b646315a
[netinstall] Add immutable to groups settings
2020-03-23 17:18:44 +01:00
Adriaan de Groot
4cb2ed9552
[netinstall] Chase removal of ItemData
...
- Simplify creation of PackageTreeItems by interpreting the
YAML directly (instead of via ItemData),
- Simplify list types,
- Drop superfluous API.
2020-03-23 17:18:44 +01:00
Adriaan de Groot
c66ef5a201
[netinstall] Refactor: kill ItemData
...
- This doesn't compile right now.
- The nested class ItemData doesn't do anything useful or
meaningful that having model items with the right data wouldn't.
2020-03-23 17:18:44 +01:00
Adriaan de Groot
8825c9c995
[netinstall] Apply coding style
2020-03-23 17:18:44 +01:00
Adriaan de Groot
e2d9ce737c
[netinstall] Implement pre-expanded groups
...
- Return relevant data
- Document code
- Add to README.md documentation about new key
2020-03-10 12:59:41 -05:00
Adriaan de Groot
b9b48cfbb1
[netinstall] Apply coding style
...
- Some missing {} were not noticed by astyle
2020-03-10 12:49:12 -05:00
Adriaan de Groot
4f216b0394
[netinstall] Refactor model-data setting
...
- Introduce convenience methods getString(), getBool() to pick
out an entry from item definitions in YAML format.
- Apply coding style.
- Pick up the "expanded" property as well.
2020-03-10 12:46:49 -05:00
Adriaan de Groot
0f7f5216ee
[netinstall] isHidden is const after construction
2020-03-10 12:39:35 -05:00
Adriaan de Groot
b074696ac1
[netinstall] isCritical is const after construction
2020-03-10 12:38:11 -05:00
Adriaan de Groot
09006a936d
[netinstall] Expand groups if requested
2020-03-10 12:37:57 -05:00
Adriaan de Groot
4f22a70b08
[netinstall] Restructure model-method data()
2020-03-10 12:30:33 -05:00
Adriaan de Groot
df86972ea7
[netinstall] Introduce constexpr names for columns and roles
2020-03-10 12:22:56 -05:00
Adriaan de Groot
3d68c74a19
[netinstall] Sanitize PackageTreeItem::data()
...
- Use of != nullptr for QString just a bad idea
- Massage code so structure for packages resembles that of groups
2020-03-09 22:46:59 -05:00
Adriaan de Groot
201c5ddfe1
[netinstall] Add some debug-logging
...
- Also, prepare for a start-expanded setting
2020-03-09 22:44:16 -05:00
Adriaan de Groot
4cf3ec8663
[netinstall] Resolve TODO (changes translations)
2020-03-09 22:01:39 -05:00
Adriaan de Groot
3302fe319b
[netinstall] Fix typo's in README
2020-03-09 21:58:30 -05:00
Adriaan de Groot
bfe45aea18
[netinstall] Warnings--, unused parameter
2020-02-27 23:19:55 +01:00
Adriaan de Groot
7cbc43616e
[netinstall] Some more "standard" alternative labels
...
- Hide the labels from the compiler to avoid warnings
- Add some more labels proposed by ArcoLinux
2020-02-19 17:21:12 +01:00
Adriaan de Groot
51ad7df31c
[netinstall] Don't give the translators a bogus string
2020-02-19 17:13:01 +01:00
Adriaan de Groot
538779991e
[netinstall] Add some "standard" sidebar labels for the module
2020-02-19 14:37:47 +01:00
Adriaan de Groot
81752b6f7c
[libcalamares] Document how TranslatedString context works
...
- Support re-using class-specific tr() calls in a standard way
- Document this in the netinstall.conf which uses it
2020-02-19 14:23:34 +01:00