Adriaan de Groot
d2404851cd
[partition] Reduce warnings (shadow, ;, types)
2019-04-15 10:06:21 -04:00
Adriaan de Groot
1a4a265262
[partition] Refactor check for ISO9660
2019-04-15 10:06:03 -04:00
Adriaan de Groot
75f1a05fec
[partition] No copy-constructor for CDebug
2019-04-15 10:05:29 -04:00
Adriaan de Groot
009dfd7de5
[locale] Reduce warnings (shadowed global)
2019-04-15 10:03:12 -04:00
Adriaan de Groot
ef3b4c387c
[libcalamaresui] Remove unused AbstractPage
2019-04-15 09:20:08 -04:00
Adriaan de Groot
4fec6731ba
[calamares] [libcalamaresui] Improve includes
...
- avoid useless ../
- sort alphabetically and by kind
2019-04-15 09:20:08 -04:00
Adriaan de Groot
520478847c
Make logging more consistent.
...
- Across all the C++ modules, use Logger::SubEntry for sub/continues
log lines, instead of somewhat-random indent strings.
2019-04-15 09:02:21 -04:00
Adriaan de Groot
d6cf0617f6
[libcalamaresui] Make logging more consistent
2019-04-15 09:02:21 -04:00
Adriaan de Groot
aaeea16871
[libcalamares] Make logging more consistent
2019-04-15 09:02:21 -04:00
Adriaan de Groot
8bb07528e2
[calamares] Make logging output more consistent
...
- Use Logger::SubEntry instead of various indents
- Improve wording of message
2019-04-15 09:02:21 -04:00
Adriaan de Groot
5677a4bb28
[finished] Fix up string arguments
...
- The "set up" message only uses one argument.
2019-04-15 08:42:06 -04:00
Adriaan de Groot
63b317902d
[libcalamares] [partition] Adjust to logging changes
...
- Use the un-paren'ed Continuation and SubEntry
2019-04-15 08:27:43 -04:00
Adriaan de Groot
d72e3b3c22
[libcalamares] Simplify writing of logging continuations
...
- Instead of Continuation(), write just Continuation
- All that futzing with overloads and tag-classes isn't needed
since the whole point is to output some constant string. Leave
cleverness for later, if it's needed.
2019-04-15 08:27:29 -04:00
Adriaan de Groot
198acadd23
[partition] [fsresizer] Fix KPMCore API versions
...
- tests need the defines as well
- scandevices API changed with API 3.3.1
2019-04-12 13:17:38 +02:00
Adriaan de Groot
c844188907
[partition] Fix build w/ "3.3.1" API
...
- Need older-style scanning, but new-style iteration
2019-04-12 12:54:13 +02:00
Adriaan de Groot
4e24ea29e2
[partition] [fsresizer] Adjust to post-3.3.0 API
...
- KDE neon ships a post-3.3.0 KPMCore, with deprecations, but not yet
the KPMCore 4 API, so add another API-version check to handle the
deprecations. Keeps warnings down.
2019-04-12 12:44:59 +02:00
Adriaan de Groot
c0710cabe4
[partition] [fsresizer] Adjust to new #define
...
- Using KPMCORE4API is clearer than just relying on a version number
2019-04-12 12:16:55 +02:00
Adriaan de Groot
9159761171
[partition] [fsresizer] Fix KPMCore API detection
...
- There will be a 3.3.1 which still has the "old" API,
so look at 3.3.80 (pre-4.0) instead. Make the way
compile flags are passed consistent.
2019-04-12 12:16:55 +02:00
Adriaan de Groot
9917bc27fc
Merge pull request #1119 from cjlcarvalho/master
...
[partition] Fixing LVM scanning according to new kpmcore API
2019-04-12 11:03:03 +02:00
Adriaan de Groot
1a063a9b5d
[partition] Use modern tr() annotation
2019-04-11 10:28:35 -04:00
Adriaan de Groot
e664370b28
[libcalamaresui] Use modern tr() annotation
2019-04-11 10:28:09 -04:00
Adriaan de Groot
b6cd1c576a
[plasmalnf] Don't translate placeholder text
2019-04-11 10:06:10 -04:00
Adriaan de Groot
78d6b51c3c
[partition] Don't translate placeholder ---
2019-04-11 10:01:34 -04:00
Adriaan de Groot
369c5f4619
[tracking] Don't translate placeholder text
2019-04-11 09:59:58 -04:00
Adriaan de Groot
d0e1e46df2
[users] Don't translate CSS
2019-04-11 09:54:42 -04:00
Adriaan de Groot
95897bf83b
[users] Mark as not-translated
2019-04-11 09:49:38 -04:00
Adriaan de Groot
5a95bf507f
[libcalamaresui] Improve WindowDimensions class
...
- Make sure the class knows its own suffixes
2019-04-11 15:14:31 +02:00
Adriaan de Groot
6560c194ad
[libcalamaresui] Reduce 0-for-nullptr warnings in 3rd party code
...
- replace = 0 with = nullptr to reduce warnings; not a meaningful
or copyrightable change.
2019-04-11 15:14:31 +02:00
Adriaan de Groot
1008a91eba
[libcalamaresui] Reduce warnings
...
- getting a (sensible) uint from an int is tougher than you might think
2019-04-11 15:14:31 +02:00
Adriaan de Groot
8dd22dcbbf
[libcalamaresui] bail() is a [[noreturn]] function
2019-04-11 15:14:31 +02:00
Adriaan de Groot
365f83b789
[libcalamares] Reduce warnings in KDAB code
...
- Use nullptr and suitable include guards
2019-04-11 15:14:31 +02:00
Adriaan de Groot
2777b5dd30
[libcalamares] Reduce copying and warnings
2019-04-11 15:14:31 +02:00
Adriaan de Groot
5279e78c9f
[libcalamares] Reduce warnings
...
- improve variable names, don't shadow
2019-04-11 15:14:31 +02:00
Adriaan de Groot
c13c7c4891
[libcalamares] Don't use (bare) endl
...
- Use '\n' instead of endl (which should have been std::endl).
2019-04-11 15:14:31 +02:00
Adriaan de Groot
d2941d335e
[libcalamares] Reduce unused-parameter warnings
...
- The tag-class "parameters" are empty anyway
2019-04-11 15:14:31 +02:00
Adriaan de Groot
b416842c20
[calamares] Reduce compile warnings in tests
...
- Switch debug-level to unsigned
- Don't shadow usings; the first TR type is enough
- The (bogus) return values were commented as // NOTREACHED,
but still yield unreachable code warnings. Drop them
instead, and rely on the compiler understanding [[noreturn]]
on parser.usage().
2019-04-11 15:14:31 +02:00
Adriaan de Groot
b10c7ad9c6
[locale] Reduce warnings for gcount()
...
- The read is at most sizeof(arr), so int is fine. Do
the cast explicitly.
2019-04-11 15:14:31 +02:00
Adriaan de Groot
620d2a769a
[users] Reduce compile warnings
...
- Avoid C-style casts
- Unfortunately needs some verbose casting machinery to do
it "right" wrt. C++ type system.
2019-04-11 15:14:31 +02:00
Adriaan de Groot
189e192c83
[shellprocess] Reduce warnings
...
- The old-style cast still causes a warning, but do the
more idiomatic (void) rather then casting to (void*)
2019-04-11 12:29:53 +02:00
Adriaan de Groot
6cfb5a9c88
[welcome] Reduce unused-parameter warnings
...
- Don't use this if we don't need it (QObject::tr is static).
- C++14 allows (copy) binding to arbitrary expresstions in lambda's,
so detach from this.
2019-04-11 12:29:17 +02:00
Adriaan de Groot
713370da55
Merge remote-tracking branch 'origin/issue-1100'
2019-04-11 11:47:00 +02:00
Adriaan de Groot
547dc7d334
Merge pull request #1117 from a-wai/partition-layout-add-maxsize
...
[partition] Add max size parameter
2019-04-11 11:39:44 +02:00
Caio Carvalho
2c33535ee8
[partition] Using std::find_if to search in container for elements according to a condition
2019-04-09 23:14:34 -06:00
Caio Carvalho
34e091833d
[partition] Fixing LVM scanning according to new kpmcore API
2019-04-09 23:12:31 -06:00
Arnaud Ferraris
6463e5f83c
[users] Adjust messages to setup mode
...
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.com>
2019-04-08 18:02:23 +02:00
Arnaud Ferraris
dddebc98b5
[finished] Adjust messages to setup mode
...
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.com>
2019-04-08 17:55:03 +02:00
Arnaud Ferraris
e3cebd9da9
[plasmalnf] Adjust explanation message to setup mode
...
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.com>
2019-04-08 13:44:41 +02:00
Arnaud Ferraris
9b77e5b17d
[summary] Adjust summary text to setup mode
...
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.com>
2019-04-08 13:43:38 +02:00
Arnaud Ferraris
866afcfe47
[welcome] Adjust checker-messages for setup mode
...
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.com>
2019-04-08 13:42:15 +02:00
Arnaud Ferraris
cbf7f4fb17
[calamares] Adjust window title for setup mode
...
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.com>
2019-04-08 13:41:21 +02:00
Arnaud Ferraris
5358e2314d
[partition] Add max size parameter
...
When using a custom partition layout with partition sizes in %, it can
be useful to set an upper limit to the partition size.
For instance, using a 20% size for the `/` partition will create a 24G
partition on a 120GB drive, but a 200GB partition on a 1TB drive, which
is not useful, and could be avoided by setting a maximum partition size.
This commit adds the `maxSize` parameter (with a default value of 100%).
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.com>
2019-04-08 12:19:35 +02:00
Adriaan de Groot
4caa401a07
[partition] Use structured logging
...
- Structured logging
- Reduce chattiness
- Use helper functions
- Some TODO were done a while ago
2019-04-04 17:58:03 +02:00
Adriaan de Groot
04146df36b
[partition] Reduce logging for mounted partitions
...
- The other log entries say when something is possible,
not when something is **not** possible.
2019-04-04 17:46:48 +02:00
Adriaan de Groot
6bccbcd1f5
[partition] Improve logging of status of choice buttons
2019-04-04 17:37:37 +02:00
Adriaan de Groot
b5a997d11e
[partition] Use structured logging
2019-04-04 17:13:57 +02:00
Adriaan de Groot
01f5ac22a0
CMake: use conventional method for setting version
...
- Using project() to set up the version is idiomatic for CMake
and more standardised than doing it by hand. Do retain the
RC flag, because that's used in other parts of versioning.
2019-04-04 15:58:07 +02:00
Adriaan de Groot
b18e0a0bd8
[libcalamares] Use structured logging tags
2019-04-04 14:44:44 +02:00
Adriaan de Groot
09ae721038
[libcalamares] Structure continuations and sub-entries
2019-04-04 14:44:44 +02:00
Adriaan de Groot
b6ea171365
[libcalamares] Reduce chatty logging
...
- Only log module-search entries when they are bad.
2019-04-04 14:14:59 +02:00
Adriaan de Groot
53cdf0b054
[calamares] Log version and supported languages
...
- These logging statements happened before logging was configured,
so never ended up in the session log. Move them to be executed later.
2019-04-04 14:10:50 +02:00
Adriaan de Groot
caba74438e
[libcalamares] Improve XDG handling
...
- When environment is empty, use default values from spec
- Search in application-named subdirs first (but keep previous
behavior of also searching directly in the named dirs)
- Don't consider empty XDG_* elements
- Settings XDG_DATA_DIRS=":" would yield an empty list of extra
directories to check; don't bother setting haveExtraDirs for that.
2019-04-02 10:32:55 -04:00
Adriaan de Groot
3248aba899
[libcalamares] Make oem-setup independent of dont-chroot
...
- At least for testing purposes it makes sense to decouple dont-chroot
from the OEM-setup wording, so introduce a separate setting for it.
2019-04-01 06:26:42 -04:00
Adriaan de Groot
3a0bd254c0
[libcalamaresui] Adjust quit-messages to setup-mode
2019-04-01 06:16:37 -04:00
Adriaan de Groot
8ee2375ee6
[welcome] Adjust welcome message to setup-mode
2019-04-01 06:16:37 -04:00
Adriaan de Groot
57ccefa1e5
[libcalamares] Distinguish "install" and "setup" modes.
...
- This initial bit of code re-uses the *dont-chroot* setting;
it may need to be made independent.
- This branch will use `isSetupMode()` to adjust user-visible
strings to match the intended use.
SEE #1100
2019-04-01 05:37:34 -04:00
Calamares CI
7259ddd3d8
i18n: [dummypythonqt] Automatic merge of Transifex translations
2019-04-01 05:02:12 -04:00
Adriaan de Groot
fb412c177c
[unpackfs] Improve human-readable name
2019-03-29 17:32:52 -04:00
Adriaan de Groot
5c4f2423f8
[unpackfs] Fix error in error-handling (warn -> warning)
2019-03-29 17:27:26 -04:00
Adriaan de Groot
d87badbf45
[unpackfs] Add test with too-small destination FS
2019-03-29 17:22:47 -04:00
Adriaan de Groot
2a6bf50621
[unpackfs] Don't let ir-phase reduce total number of files
2019-03-29 16:53:02 -04:00
Adriaan de Groot
fae0b8c2f8
[unpackfs] Re-jig progress reporting
...
- rsync reports its own progress, and reports on files that
find -type f doesn't. This meant that the numbers didn't
match what was stored in entry.total
- The ir-phase adds files to be handled; to-phase happens once
ir-phase is over and the remaining files are processed.
By adding the to-phase files, percentages over 100% were
reported (in part because the number of files doesn't match).
- Update expected entries total from rsync output.
- Re-jig computation of how done everything is: tally it
up in integers, and do only one global progress percentage.
2019-03-29 16:48:46 -04:00
Adriaan de Groot
6d85fd3586
[unpackfs] One last progress call afterwards
2019-03-29 16:24:22 -04:00
Adriaan de Groot
9ce34782ee
[unpackfs] Avoid double / at end
2019-03-29 16:09:11 -04:00
Adriaan de Groot
dc2fafe324
[unpackfs] to-chk is also progress information
...
- ir-chk happens first, and then there's a phase with to-chk
messages; use those as well.
2019-03-29 12:51:00 -04:00
Adriaan de Groot
38821f47ba
[unpackfs] Make comment match code
...
- The mismatch between "ir-chk" and the comment "to-check" led me
to check (ha!) the output of rsync, and it outputs "to-chk"
during small transfers; make sure the comment reflects what
is actually being used to track progress (which is "ir-chk").
2019-03-29 12:39:45 -04:00
Adriaan de Groot
273c32705d
[partition] Restore selected bootloader
...
- After the BootLoader model is reset, if a bootloader location
has been selected before, try to find it in the (now-reset)
model to preserve the selection.
2019-03-29 12:00:27 -04:00
Adriaan de Groot
3eae445ead
[partition] Don't signal changes from model before they're done
...
- clear() signals modelReset(), which is true, but inconvenient
when we do a bunch of changes afterwards. Block signals,
and rely on own signaling when all of the changes are done.
- Keep blocking signals while updating the model, since the row
appends otherwise trigger a change in the connected combo box.
2019-03-29 11:59:51 -04:00
Adriaan de Groot
dc04aa999d
[partition] Introduce post-reset slot for boot loader selection
2019-03-29 11:34:07 -04:00
Adriaan de Groot
17aeaa134a
[partition] Simplify display-role code for bootloader
2019-03-29 10:54:04 -04:00
Calamares CI
bab2e2ca2f
i18n: [dummypythonqt] Automatic merge of Transifex translations
2019-03-29 05:25:54 -04:00
Adriaan de Groot
affc73d3d2
[fsresizer] Avoid KPMCore warnings about scanDevices()
2019-03-20 18:20:56 +01:00
Adriaan de Groot
478168c841
[fsresizer] Make sure KPMCore version definitions are consistent
...
- Duplicate setting from partition module to fsresizer
2019-03-20 18:16:54 +01:00
Adriaan de Groot
e8c18c0b5c
[partition] Prepare scanDevices for post-KPMCore 3.3.0
2019-03-20 18:13:39 +01:00
Adriaan de Groot
68f29ebf20
[partition] Handle partition flag FlagEsp post KPMCore 3.3.0
2019-03-20 18:13:39 +01:00
Adriaan de Groot
2a2795c54c
[partition] Avoid KPMCore warnings
...
- Get ready for KPMCore post-3.3.0, which deprecates a bunch of
Flag<foo> and State<foo> in preparation of enum classes.
2019-03-20 18:13:39 +01:00
Adriaan de Groot
5d6d2b8078
[partition] Make convenienceName() available for debugging
...
- Function for human-readable names is useful in more parts of
the partition module.
2019-03-20 11:26:02 +01:00
Adriaan de Groot
1ffc0bf77d
[partition] Allow all the unsafe options
...
- If the unsafe actions are enabled, but won't be executed,
allow more unsafe actions like erasing mounted partitions
and everything.
2019-03-20 11:26:02 +01:00
Adriaan de Groot
cd545e51b0
[partition] Reduce superfluous logging
2019-03-20 11:26:02 +01:00
Adriaan de Groot
8db004ce45
[partition] Use the FailJob to stop installation
...
- For unsafe installations (compile-time option), make sure
things fail before partitions are actually written, unless
the other option is also turned off.
2019-03-20 11:26:02 +01:00
Adriaan de Groot
62f03d8aad
[partition] Allow unsafe partitioning decisions
...
- This is a compile-time choice, and off by default. This may be useful
for developers that need to get through installation to a different
partition on their root drive.
- Add an option to avoid actually doing unsafe things. This is an extra
safeguard; you need to turn on one and turn off the other option to
really be unsafe.
2019-03-20 11:26:02 +01:00
Adriaan de Groot
2caefce3cb
[locale] Add a CMake option for debugging
2019-03-20 11:26:02 +01:00
Adriaan de Groot
3db708dd04
[keyboard] qDebug -> cDebug
2019-03-20 11:26:02 +01:00
Adriaan de Groot
826453aa65
[calamares] Note that qDebug() is sometimes ok
2019-03-20 11:26:02 +01:00
Adriaan de Groot
4b486cfe82
[libcalamares] Add some debugging Jobs
...
- FailJob always fails, and GoodJob always succeeds, both without doing
anything. These aren't particularly useful, except for debugging.
2019-03-20 11:26:02 +01:00
Adriaan de Groot
2b7832857c
[libcalamaresui] Simplify checking dependencies
...
- Avoid crash due to invalid iterator, when modules
are removed due to missing requirements.
- Simplify code, factor out the determination of
which required modules are missing.
2019-03-19 11:11:43 -04:00
Adriaan de Groot
5f308e8e17
[calamares] Check that a sequence has been set
2019-03-19 11:11:43 -04:00
Adriaan de Groot
7515f36b96
[libcalamares] Refactor settings-loading some more
...
- Load instances list in a separate method
- Load sequence list in a separate method
- Don't rely on QASSERT, explicitly throw if something is missing.
2019-03-19 11:11:43 -04:00
Adriaan de Groot
5a8ed8583f
[libcalamaresui] Complain about missing config files
...
- When no config file is found, tell where it wasn't.
2019-03-19 05:42:28 -04:00
Adriaan de Groot
e18e4e3d6f
[libcalamares] Refactor module-search path
...
- Refactor code that fills up the module search path from
the *modules-search* configuration key.
- Improve debug logging while here.
2019-03-18 17:48:39 -04:00
Adriaan de Groot
540d27d0c3
[libcalamares] Convenience function YAML->QStringList
...
- operator>> already existed, but here's a version that
can be used in function-call context.
2019-03-18 17:38:44 -04:00