Adriaan de Groot
4602b30264
[libcalamaresui] Use PYTHONQT_INCLUDE_DIRS
...
- document new variable from the CMake module
- use it in libcalamaresui to simplify #include'ing the
header for the "all" extension.
Suggested by Denis Proskurin.
2018-09-03 06:26:26 -04:00
Adriaan de Groot
ae7700f2d7
[libcalamares] Refactor searching for module configurations
...
- Similar to the refactorings in Calamares proper, just split out
collecting the search paths into a static function. This makes
it a little easier to find places that will need expansion for
more-than-one-config-directory.
2018-07-10 04:12:24 -04:00
Adriaan de Groot
d66393f1ae
[libcalamares] Fix early failure mode
...
- There is more to failing out of loadModules() than just
emitting modulesFailed, so instead share the failure
code with the code after loading modules -- but don't load any.
2018-06-26 08:43:23 -04:00
Adriaan de Groot
08966ff933
[libcalamaresui] Check module dependencies
...
- Module dependency-checking is done in two phases:
first, catch any unknown modules that are listed
in *requiredModules* and bail out before loading
anything. Second, check that the modules required
by X occur before X in the sequence.
2018-06-26 08:32:36 -04:00
Adriaan de Groot
731594fb40
[libcalamaresui] Remove the requiredModules setting
...
- The value set in module.desc was never stored for use,
but isn't an attribute of the instance, either. It belongs
with the descriptor, in ModuleManager.
2018-06-26 08:18:00 -04:00
Adriaan de Groot
1a097f8c49
Style: run modulesystem through the style guide
2018-06-18 10:56:10 -04:00
Adriaan de Groot
58121abf06
[libcalamaresui] Wasted spaces
2018-06-18 10:44:28 -04:00
Adriaan de Groot
a64de3dbfe
[libcalamaresui] Assign the index to found
...
- Previous code assigns the result of the comparison to found,
instead of the index, resulting in the wrong configuration
map sent to each module.
2018-06-18 10:29:30 -04:00
Adriaan de Groot
374a9bdca6
Merge branch 'emergency-modules'
...
Introduce the notion of emergency modules and emergency jobs.
Initial use will probably center around the preservefiles module,
and possibly umount.
FIXES #928
2018-06-15 12:04:55 -04:00
Adriaan de Groot
3ed6f13fa8
[libcalamaresui] Adjust the emergency-ness of modules
...
A potentially emergency module is one that has EMERGENCY
(in CMake) or emergency: true (in module.desc) set.
Any such module must also set emergency: true in the
configuration of the module. This is to allow for
instances of a module that **don't** run as emergency
modules, alongside actual emergency ones.
2018-06-15 09:32:19 -04:00
Adriaan de Groot
def459a29d
[libcalamaresui] Read emergency setting from module.desc
...
- Read setting from the module descriptor
- Document optional settings
- Add EMERGENCY keyword to the CMake helper functions
2018-06-15 07:11:17 -04:00
Adriaan de Groot
dd8e53dc22
Copyright: update copyright lines on files touched in 2018
...
Contributions from:
Adriaan de Groot <groot@kde.org>
Gabriel Craciunescu <crazy@frugalware.org>
AlmAck <gluca86@gmail.com>
Andrius Štikonas <andrius@stikonas.eu>
Caio Carvalho <caiojcarvalho@gmail.com>
Raul Rodrigo Segura <raurodse@gmail.com>
2018-06-15 05:59:11 -04:00
Adriaan de Groot
2d7eea6d73
Merge branch 'master' into emergency-modules
2018-06-14 17:15:40 -04:00
Adriaan de Groot
290559f8c1
Merge pull request #986 from raurodse/configurationPythonQt
...
Add configuration values into pythonqt modules
2018-06-14 13:19:42 -04:00
Raul Rodrigo Segura
448c5eae16
style code
2018-06-14 16:33:58 +02:00
Adriaan de Groot
9918dfb95f
[libcalamaresui] Reporting on failures
...
- Provide information on failed modules
- Disallow further progress when configuration is borked
2018-06-13 13:41:38 -04:00
Adriaan de Groot
8b406cac9b
[libcalamaresui] Improve module loading
...
- Add a TODO for allowing modules to come from somewhere other
than the module loader (this would allow "internal" modules
that are always present)
- Warnings are warnings
2018-06-13 04:37:52 -04:00
Raul Rodrigo Segura
d61b32aba6
Add configuration values into pythonqt modules
2018-06-12 13:44:28 +02:00
Adriaan de Groot
35124c149e
[libcalamaresui] Drop the 'goodbye' message
2018-06-11 13:35:12 -04:00
Adriaan de Groot
a40c36ef49
[libcalamaresui] Report on failed module loading
...
- Collect the failed modules, instead of bailing out on the first one
(this also prevents crashes caused by quit() called from a timer).
- Introduce a slot to report on failed module loading (no UI yet).
2018-06-11 05:59:56 -04:00
Adriaan de Groot
1999e4e5c2
[libcalamaresui] Error out consistently when module loading fails
...
- Some module-loading failures were ignored and produce only a
warning, instead of erroring out.
2018-06-08 18:14:51 -04:00
Adriaan de Groot
dccf6f16f5
[libcalamaresui] Lambdas are fun, but not always the solution
2018-06-08 17:56:23 -04:00
Adriaan de Groot
a626e52bf3
[libcalamares] Introduce more descriptive type name
2018-06-08 17:36:29 -04:00
Adriaan de Groot
b66d4856e7
[libcalamaresui] Use modern C++ for (auto)deleting failed modules
2018-05-30 07:51:23 -04:00
Adriaan de Groot
eddee7d76a
[libcalamaresui] No point in isLoaded() being virtual.
2018-05-29 03:38:17 -04:00
Adriaan de Groot
a04915e6fa
[libcalamaresui] Add 'emergency' concept to modules.
2018-05-29 03:37:37 -04:00
Adriaan de Groot
cdadc2f003
[libcalamares] Improve error logging during module loading
2018-05-24 06:47:13 -04:00
Adriaan de Groot
e5ca8e091f
[libcalamaresui] Use refactored loadYaml
2018-05-24 06:46:11 -04:00
Adriaan de Groot
f26ac63c07
[libcalamaresui] Make Python code const
...
- This is always loaded into the Python context, so it may as well
be done only once.
2018-05-24 06:46:02 -04:00
bill auger
b6673f6324
move thisModule->isLoaded assert to after it's warning message
2018-05-22 03:39:16 -04:00
Adriaan de Groot
032b33f56f
[libcalamaresui] Improve logging.
...
- Put the (constant) 'Calamares will now quit' on its own debug line.
- Tell the user what the search paths are if a module is not found
(prompted by a mis-configuration in a Neon live image).
2018-04-04 11:25:28 -04:00
Adriaan de Groot
3e30bb682e
[libcalamaresui] Use cError() for logging errors, not cLog()
2018-03-28 09:22:37 -04:00
Adriaan de Groot
60f440f72b
[libcalamaresui] Use new convenience logging methods
...
- Remove a few confusing Q_FUNCINFO
2018-02-12 11:58:34 -05:00
Adriaan de Groot
845986d48f
[libcalamaresui] Mark virtual QObject destructors override
2018-01-17 09:17:40 -05:00
Adriaan de Groot
762ad54344
Documentation: change http links to GitHub to https
2017-12-20 08:39:09 -05:00
Adriaan de Groot
2d31e987c0
[libcalamaresui] Unrelated typedef for JobList
2017-11-03 11:02:06 -04:00
Adriaan de Groot
866d338894
Clang: warnings--
2017-09-25 16:28:08 +02:00
Adriaan de Groot
337903db09
Clang: reduce warnings about overriden destructors
2017-09-20 09:11:18 -04:00
Adriaan de Groot
13807ceabf
Licensing: add self
...
- to all the files I've touched recently
- to (very incomplete) AUTHORS list
Licensing: add license info to top-level CMakeLists.txt
2017-09-19 15:57:25 +02:00
Adriaan de Groot
ddb6455365
Revert be2338ff0
(intended just to reduce warnings)
...
- keep the calamaresstyle formatting changes,
- drop shadowing and nullptr changes.
FIXES #805
2017-09-18 15:11:18 +02:00
Adriaan de Groot
be2338ff08
Clang: reduce warnings
2017-09-13 08:03:18 -04:00
Adriaan de Groot
463615a1c0
Clang: don't shadow local variable names
2017-09-10 13:22:54 -04:00
Adriaan de Groot
764fb742ba
Clang: clean up documentation markup
2017-09-10 13:22:54 -04:00
Adriaan de Groot
e26d5ab206
Don't leak memory for allocated modules
2017-08-31 04:13:52 -04:00
Adriaan de Groot
2fdccdf090
Merge branch 'simplify-module-desc'
2017-08-02 11:29:58 -04:00
Adriaan de Groot
e3008657c4
Modules: accept 'viewmodule' as alias of 'view', improve logging on error.
2017-08-02 11:05:32 -04:00
Adriaan de Groot
10eaf06f60
Python: Be more descriptive when modules can't be loaded.
2017-07-05 06:30:23 -04:00
Adriaan de Groot
8ea14d7957
Release: add copyright to files I've touched
2017-06-21 08:27:10 -04:00
Adriaan de Groot
14cba59ab3
Logging: distinguish different failures in module instantiation.
2017-06-06 09:10:13 -04:00
Adriaan de Groot
367fe716b3
Configs: empty config files are ok.
...
The default umount.conf contains no keys -- so it isn't a map,
but it is a valid config file. Avoid the warning by accepting
empty files.
FIX 707
2017-06-02 16:10:08 +02:00