Adriaan de Groot
d464e98e89
[keyboard] Move remaining variables to Config
...
- Config already *has* everythind, but drop the useless copies
and duplicated code from the Page
- Plug the models model into the Page
- While here, document the model / layout / variant distinctions
The code doesn't fill the UI properly, and the drop-down
for the models combobox is not right, but at least the data
is shared.
2020-10-28 01:25:42 +01:00
Adriaan de Groot
fe5757c7d1
[keyboard] Matching of layouts is very suspect
2020-10-28 01:07:49 +01:00
Adriaan de Groot
4f0d6a8f25
Merge branch 'calamares' into fix-keyboardq
2020-10-28 00:04:40 +01:00
Adriaan de Groot
dca9ae0c93
Merge pull request #1553 from LordTermor/calamares
...
Initial additional layout support for non-ASCII layouts
2020-10-27 22:11:23 +01:00
Artem Grinev
4434e85d4d
[keyboard] Simplified variable name
2020-10-27 20:53:20 +03:00
Artem Grinev
3552233bf1
[keyboard] Minor logic rework
2020-10-27 20:48:18 +03:00
Artem Grinev
6667ea834f
[keyboard] Adjusted indents
2020-10-27 20:42:49 +03:00
Artem Grinev
996c82160e
[keyboard] fixed typo
2020-10-27 20:38:04 +03:00
Adriaan de Groot
4a3273d634
[keyboard] Remove superfluous variable (set to true, never changed)
2020-10-27 16:59:22 +01:00
Artem Grinev
bfc60ad2cf
[keyboard] Implemented X11 config writing for additional layout
2020-10-27 18:59:10 +03:00
Artem Grinev
0dd027af90
[keyboard] Fixed condition bug
2020-10-27 18:59:10 +03:00
Artem Grinev
19b1fb3358
[keyboard] Added explanatory comment for xkbmap_query_grp_option
2020-10-27 18:59:10 +03:00
Artem Grinev
384b1ba8c6
[keyboard] Swapped primary and additional layouts in selection
2020-10-27 18:59:10 +03:00
Artem Grinev
354dc1613a
[keyboard] Removed unnecessary repacking in xkbmap_layout_args
2020-10-27 18:59:10 +03:00
Artem Grinev
09b5e42734
[keyboard] Minor additional layout info rework
2020-10-27 18:59:10 +03:00
Artem Grinev
17b9647016
[keyboard] Support for additional layout if current layout is not ASCII-
...
capable in live system
2020-10-27 18:59:10 +03:00
Adriaan de Groot
8cf3bd23b9
[keyboardq] Remove superfluous variable (set to true, never changed)
2020-10-27 16:55:02 +01:00
Adriaan de Groot
734dbece8a
[keyboardq] Fix include style, remove unnecessary declarations
2020-10-27 16:47:47 +01:00
Adriaan de Groot
0947cd8354
[keyboard] Migrate to Config::onActivate() which is badly-named
2020-10-27 16:12:36 +01:00
Adriaan de Groot
0ffa500432
[keyboard] Remove unused code
...
- this has already migrated to Config but had not been removed locally
2020-10-27 15:56:50 +01:00
Adriaan de Groot
35a2bd3f0f
[keyboard] Use Config's own finalize()
2020-10-27 15:55:29 +01:00
Adriaan de Groot
14c079d1d6
[keyboard] Replace own copy of status by the one from Config
2020-10-27 15:53:59 +01:00
Adriaan de Groot
acb5190217
[keyboard] Use Config methods rather than own copy
...
- this continues the port of the keyboard module to use the Config
object, which was horribly botched earlier.
2020-10-27 15:51:48 +01:00
Adriaan de Groot
679f613955
[keyboard] Rename mysterious Config::init() to descriptive name
2020-10-27 15:48:51 +01:00
Adriaan de Groot
a940be2bb4
[keyboardq] Load configuration into Config object
2020-10-27 15:46:18 +01:00
Adriaan de Groot
8142d6f86c
[keyboardq] Drop unnecessary variable -- just use the Config status
2020-10-27 15:42:27 +01:00
Adriaan de Groot
83b06fe3cb
Changes: credits for this round
2020-10-27 15:38:38 +01:00
Adriaan de Groot
98c7cec732
CMake: restore NOTREACHED, without the macro-mess
...
- gcc (up to at least version 10) is worse at recognizing that all
cases have been handled, so it complains about all the switches
that cover enum values.
2020-10-25 18:52:38 +01:00
demmm
f6e6774f92
[keyboardq] fix build
2020-10-25 18:35:03 +01:00
Adriaan de Groot
fea403186f
[libcalamares] Search for balance between warnings and annotations
...
- CI's gcc is too old to analyse a switch() for completeness,
so the CI build fails.
2020-10-25 17:49:26 +01:00
Adriaan de Groot
478c394d99
[partition] Don't needlessly expose a test symbol
2020-10-25 17:49:26 +01:00
Andrius Štikonas
f629826d40
README: switch to C++17.
2020-10-25 11:54:27 +00:00
Adriaan de Groot
2b9fa0f982
CMake: drop the NOTREACHED macro
...
- both clang and g++ support __builtin_unreachable(); (as Kevin
Kofler pointed out) so we don't need the macro to do different things;
- the compilers have gotten better at detecting unreachable code,
so instead of inserting macros or fiddly bits, just drop them
and the unreachable code they comment.
2020-10-25 12:49:49 +01:00
Adriaan de Groot
9a2fca7f5b
CMake: prefer normal C++17 [[fallthrough]] annotation
2020-10-25 12:49:49 +01:00
Adriaan de Groot
364d50679f
CMake: don't put linker flags in compile-flags variables
2020-10-25 12:49:49 +01:00
Adriaan de Groot
7fa1c1b787
[libcalamares] Avoid object-slice
...
g++ warns that error_already_set is polymorphic, and we're catching
by-value (although we don't use that value). Avoid that.
2020-10-25 12:49:49 +01:00
Adriaan de Groot
84936a95fc
[libcalamaresui] Warnings-- for Qt 5.15 deprecations
...
Introduce a GUI-oriented compatibility header that introduces aliases
for some enum values that are deprecated in Qt 5.15
2020-10-24 13:00:48 +02:00
Adriaan de Groot
b28a50de6f
[libcalamares] Remove useless variable
...
- describe() is for debugging purposes, doesn't need to calculate
whether the requirements are accepted.
2020-10-24 12:35:19 +02:00
Adriaan de Groot
6c7d295712
CMake: simplify C and C++ flags
...
- reduce the difference between clang and g++ builds, factor
common flags out of the CMake-if
- drop special boost-warning-suppression, we do that differently
most of the time in the affected source files
2020-10-24 12:32:07 +02:00
Adriaan de Groot
00fa911f72
CMake: switch to C++17
2020-10-24 02:31:38 +02:00
Adriaan de Groot
27f6eaaf75
[partition] Remove unused variables
2020-10-24 02:24:37 +02:00
Adriaan de Groot
89b1f8d96b
[partition] Warnings-- in tests related to virtual destructors
2020-10-24 02:21:32 +02:00
Adriaan de Groot
01b75ef4b5
[partition] Use C++-style cast
2020-10-24 02:19:05 +02:00
Adriaan de Groot
6605e11394
[partition] Warnings-- in test: don't expose internal variable
2020-10-24 02:05:14 +02:00
Adriaan de Groot
cb2b53ebf3
Merge remote-tracking branch 'origin/issue-1515' into calamares
2020-10-23 23:51:25 +02:00
Adriaan de Groot
d7e64de24a
[partition] Adjust docs to function
...
- @params referring to things that don't exist
- @brief that is 3 lines long
2020-10-23 23:14:00 +02:00
Adriaan de Groot
eb8e95bb87
[partition] Warnings--, explain why we're using a void*
2020-10-23 22:39:05 +02:00
Adriaan de Groot
9910b23152
[partition] Avoid uninitialized variable
...
- if the partition size is invalid, then warn about it but do
not print the (uninitialized) size of the partition.
- shuffle code to continue earlier, allowing the "good path"
code to be out-dented.
2020-10-23 22:34:53 +02:00
Adriaan de Groot
687a795b71
[partition] Warnings-- by initialization order
2020-10-23 22:31:22 +02:00
Adriaan de Groot
44a11bd93b
[partition] Initialize in the initializer list, if possible
2020-10-23 22:27:30 +02:00