Adriaan de Groot
7d0451fe69
[partition] Rename Choice -> InstallChoice
...
- There are more choices to be made (or to come) when partitioning,
so don't take the most generic term for one enum.
2018-09-12 10:16:48 -04:00
Adriaan de Groot
10f7bac2df
[partition] Reorder initialization
2018-09-12 10:05:14 -04:00
Adriaan de Groot
c3f3276188
[partition] Improve presentation of swap options
2018-09-12 09:20:44 -04:00
Adriaan de Groot
dc492b301c
[partition] Drop label on swap-options box
2018-09-12 08:42:21 -04:00
Adriaan de Groot
a791818a65
[partition] Add swap drop-down
...
- This is WIP; the drop-down contents should be customised,
depending on configuration and the state of the device being
installed-to.
2018-09-12 08:18:45 -04:00
Adriaan de Groot
c813375908
[partition] Prepare for swap options
...
- Extend PrettyRadioButton with options (combo-boxes which may
be added later).
2018-09-12 08:09:01 -04:00
Adriaan de Groot
e0cd90cab1
Update the documentation and implementation of swap calculation.
...
Make the ramps consistent between suspend-to-disk and not,
and don't do the weird drop from 8GiB swap down to 4GiB for
large-memory systems.
2018-09-11 11:30:01 -04:00
Adriaan de Groot
c104d14086
[partition] Call the helpers in the right order.
...
This fixes the crash by calling the model-reset first, then
refreshing. Previously, the destructors that do the work
were still being called in the wrong order.
FIXES #1019
2018-09-03 15:21:30 -04:00
Adriaan de Groot
fe662345bd
[partition] Extra helper classes for doing reset and refresh
...
- The ResetHelper only finalized changes to the module on
destruction, but calls to refresh() assumed it was already
done. This leads to crashes when refresh() uses an intermediate
state of the model.
Introduce extra helpers, and rename refresh() to avoid calling the
old implementation from any code. The new helper just creates and
destroys a ResetHelper, before creating and destroying an object
that calls the new refreshAfterModelChange().
FIXES #1019
2018-09-03 10:57:20 -04:00
Adriaan de Groot
42d606171d
Merge pull request #1020 from apachelogger/esp-eq-boot
...
do not set boot flag on ESP (thanks @philmmanjaro for testing)
2018-09-03 10:28:59 +02:00
Harald Sitter
84ad2852bf
do not set boot flag on ESP
...
ESP == boot. at best this is duplicated information, at worst kpmcore may
implode if you try to set a boot flag since that is technically an MBR
type flag and means nothing within the context of GPT where ESP is the flag
to set.
2018-08-22 10:14:49 +02:00
Harald Sitter
81cab43701
do not set active flags on the to-be ESP
...
having ESP as active flag AND then trying to set ESP means nothing is
set since kpmcore will think ESP is already set (it is listed as active
after all). this ultimately meant that nothing was set since there was
no delta between the requested flags and the already active flags.
2018-08-22 10:12:36 +02:00
Adriaan de Groot
08d41f745b
[partition] Remove superfluous null check
...
delete is specified to handle nullptr gracefully.
FIXES #1012
2018-08-20 06:09:30 -04:00
Caio Carvalho
01a972c6ea
[partition] Fixing LVM LV name line edit visibility.
2018-08-13 13:05:41 -03:00
Caio Carvalho
b5a2a5bbdd
[partition] Don't show erase button for inactive RAID.
2018-08-13 12:26:00 -03:00
Caio Carvalho
7fd0ad5795
[partition] Disabling partition buttons for inactive RAID.
2018-08-13 09:51:35 -03:00
Andrius Štikonas
22aa6dc132
[partition] fix build with latest kpmcore.
2018-08-12 14:26:43 +01:00
Simon Quigley
5c50587f89
Fix LUKS deployment link.
2018-08-10 13:23:31 -05:00
Adriaan de Groot
3b82e655d7
Merge remote-tracking branch 'origin/update-lvm-support'
2018-08-08 15:28:11 -04:00
Adriaan de Groot
238a1e812f
[partition] Reduce the fudge-factor for swap size
...
- Reported by Bill Auger (I think), a 15GiB disk wouldn't hold
a 8.9GiB root plus 4GiB swap -- due to 10% overprovisioning
of swap, plus the 2.1GiB fudge factor.
2018-08-08 05:58:41 -04:00
Adriaan de Groot
f10bab8a3a
[partition] Minor code-styling
2018-08-08 05:29:19 -04:00
Adriaan de Groot
8ed26e537f
[partition] Fix swap maximum size
...
- The existing calculation comment says "maximum 10% of disk"
but the calculation itself uses 110%.
2018-08-08 05:26:55 -04:00
Adriaan de Groot
59fea041b6
[partition] Fix up calculations of sectors in auto-partition
...
- Calculating first free sector had an off-by-one so that
partitioning would start at 2049.
- EFI boot partition grew 1 sector larger than desired.
- While here, align everything to 1MiB boundaries as well.
FIXES #1008
2018-08-08 05:19:09 -04:00
Adriaan de Groot
1cbfa9d693
[partition] Simplify code for sizing
2018-08-08 04:49:13 -04:00
Adriaan de Groot
5d5feeb0ab
Merge branch 'master' of https://github.com/cjlcarvalho/calamares into lvm-update
2018-06-28 23:48:13 +02:00
Caio Carvalho
589628bb9a
[partition] Removing unnecessary horizontal spacer on Partition Page.
2018-06-26 01:44:35 -03:00
Caio Carvalho
67d9ebbfc0
[partition] Setting revertButton enabled after deactivating VG.
2018-06-26 01:29:57 -03:00
Caio Carvalho
295e14530e
[partition] Adding resizing, deactivating and removing procedures for LVM VGs.
2018-06-26 00:38:52 -03:00
Adriaan de Groot
9d17e7210a
[partition] Change shortcut for "Create" to 'a'
...
Untangle the shortcuts; Create and Cancel had an overlap.
Skip 'r' (Revert all changes) and 'e' (Edit) and settle on
'a' (which might also mean "Add").
FIXES #977
2018-06-18 13:28:35 +02:00
Adriaan de Groot
5643ee4b8f
Merge branch 'master' into secureboot
2018-06-15 13:14:58 -04:00
Adriaan de Groot
fa08e0ad73
Copyright: fix bad email address
2018-06-15 06:15:43 -04:00
Adriaan de Groot
dd8e53dc22
Copyright: update copyright lines on files touched in 2018
...
Contributions from:
Adriaan de Groot <groot@kde.org>
Gabriel Craciunescu <crazy@frugalware.org>
AlmAck <gluca86@gmail.com>
Andrius Štikonas <andrius@stikonas.eu>
Caio Carvalho <caiojcarvalho@gmail.com>
Raul Rodrigo Segura <raurodse@gmail.com>
2018-06-15 05:59:11 -04:00
Caio Carvalho
98a158c6e5
[partition] kpmcore latest release doesn't support FileSystem::Type::Luks2
2018-06-14 15:37:00 -03:00
Caio Carvalho
3b6c764f75
[partition] Fixing revert device loop error in PartitionCoreModule::revertAllDevices.
2018-06-11 18:38:57 -03:00
Caio
0465cc4214
[partition] Including revert on creation of LVM VGs.
2018-06-08 20:20:05 -03:00
Caio
f8897e0e0b
[partition] Including new LVM PVs in LVM VG creation GUI.
2018-06-08 18:52:53 -03:00
Caio
e5351cdf3c
[partition] Don't show capacity of new LVM VGs in DeviceModel.
2018-06-07 17:49:25 -03:00
Caio
208d58bcd9
[partition] Including CreateVolumeGroupDialog and fixing some of its GUI issues.
2018-06-07 17:22:22 -03:00
Caio
d15ce56c97
[partition] Initial implementation of VolumeGroupBaseDialog.
2018-06-04 16:31:58 -03:00
Adriaan de Groot
cbd62fbeb1
Merge branch 'master' into secureboot
2018-05-28 05:04:03 -04:00
Adriaan de Groot
5bcd6eaef8
[partition] Reduce warnings by removing unused code
2018-05-21 06:30:54 -04:00
Adriaan de Groot
90a2e482be
[partition] Check for available partition type before creating
...
- Avoid situation where you make 5 or more primaries in an
MSDOS partition table.
FIXES #953
2018-05-16 10:56:06 -04:00
Adriaan de Groot
bd57f1f2f1
[partition] Fix re-editing a newly created partition
...
- If there is a partition already (newly) created, then pass that
to the dialog so that it can use the setings previously applied
(e.g. mount point and flags).
- This avoids the case where you create or format a partition,
then click on it again to edit it and the previous settings are lost.
2018-05-16 09:14:50 -04:00
Adriaan de Groot
ca03dad67b
[partition] Refactor setting the flags UI
...
- Setup the lsit of flags consistently, by providing the available
and to-be-checked flags.
- In CreatePartitionDialog, assume that ~0 is all the flags.
2018-05-16 09:07:45 -04:00
Adriaan de Groot
4f451eece5
[partition] Refactor getting the checked flags
2018-05-16 08:41:47 -04:00
Adriaan de Groot
950cc9070d
[partition] Rename MountPoints to PartitionDialogHelpers
...
This file is full of helper functions for the partition-editing
dialogs. At first it was just mount-point helper functions,
but there is other functionality that can be refactored.
2018-05-16 08:34:33 -04:00
Adriaan de Groot
336b8c758a
[partition] Consider the future flags when checking EFI bootability
...
- If we're changing the flags to enable EFI boot, then that's
enough to satisfy the (future) EFI bootability check.
This is for issue #622 as well. Fixes #884 .
2018-05-16 07:33:04 -04:00
Adriaan de Groot
0df304b206
[partition] Preserve desired partition flags
...
- Use the desired (future) flags, if set, to initialize the
flags checkboxes. If there are no future flags set, this
returns active flags as before.
- This fixes the situation where editing a partition, changing
flags, then editing it *again* re-starts with the original
flags instead of the modified flags.
2018-05-16 07:19:34 -04:00
Adriaan de Groot
6739b81c2a
[partition] Tell PartitionInfo about desired flags
...
- When creating a partition, or changing flags, tell
the PartitionInfo about those desired flags.
2018-05-16 07:13:35 -04:00
Adriaan de Groot
7df143f64a
[partition] Add flags to PartitionInfo
...
- PartitionInfo maintains information on "what is desired" for
a given Partition. Now we can set desired flags, alongside
the flags already supported by Partition (where activeFlags()
gives you the flags currently set on that partition).
2018-05-16 06:53:35 -04:00
Adriaan de Groot
5b4668822d
[partition] Also update combo box index when setting up
...
- Avoids case where you edit a partition with a mountpoint
set; previously, calling setText() would update the text
but leave the selected index unchanged (usually 0), so that
later calling selectedMountPoint() would return empty.
2018-05-16 06:15:33 -04:00
Adriaan de Groot
323d20d1a5
[partition] Avoid sneaking an empty string into the mount points combo
2018-05-15 08:26:01 -04:00
Adriaan de Groot
255a99d714
[partition] Drop now-unneeded debugging
2018-05-15 08:13:15 -04:00
Adriaan de Groot
310555f16b
[partition] Add /srv to standard mount-points list.
2018-05-15 08:06:45 -04:00
Adriaan de Groot
4402198b37
[partition] Centralize setting-of-mountpoint
...
- map empty to the 0'th index
- add new entries as needed
This avoids having selected index 0, but a different text.
2018-05-15 08:01:18 -04:00
Adriaan de Groot
a49c39bb53
[partition] Unmap mount-point special strings
...
- Reverse "(no mount point)" to the empty string
- Provide convenience pointer-taking function
2018-05-15 06:30:18 -04:00
Adriaan de Groot
a4997c4be8
[partition] Convenience for selecting default mount point
...
- map blank to the "(no mount point)" string for UI purposes
2018-05-15 06:13:19 -04:00
Adriaan de Groot
fda2e54e0f
[partition] Refactor filling combobox with moint points
...
- Move to one place which handles the standard mount points
- While here, introduce explicit "(no mount point)" string
into the combo box. This is prep-work for issue #951 .
2018-05-15 05:40:52 -04:00
Caio Carvalho
f72f7bd8fe
[partition] Only bootloader model should ignore devices that are not of Disk_Device type.
2018-05-10 18:37:37 -03:00
Caio Carvalho
77d2667b53
[partition] Checking if there is LUKS creation support and if partition is not Extended before enabling encryption in CreatePartitionDialog.
2018-05-08 01:30:41 -03:00
Caio Carvalho
f561f04591
[partition] Changing PartUtils::getDevices to ignore devices that aren't of Disk_Device type.
2018-05-03 14:50:13 -03:00
Caio Carvalho
8726b70574
[partition] Ignoring LVM devices in PartUtils::getDevices to prevent installing bootloader in LVM VG.
2018-04-30 00:40:54 -03:00
Andrius Štikonas
1b21668bff
[partition] Switch to scoped Device enums.
2018-04-18 23:59:15 +03:00
Adriaan de Groot
6bb72d173d
[libcalamares] Drop generic cLog()
...
- Use cWarning or cError() for errors
- Use cDebug(level) for other uses (but there aren't any)
2018-03-28 09:31:45 -04:00
Adriaan de Groot
092529da45
[partition] WIP: EFI partition search
...
- Add some logging (not even sure it compiles) because
my openSUSE Krypton Secureboot-enabled VM says
"no EFI system partitions found".
2018-02-19 10:25:00 -05:00
Adriaan de Groot
3ae126f589
[modules] Use cError() as well
...
- Switch KPMHelpers to using Calamares logging instead of qDebug()
2018-02-13 11:59:38 +01:00
Adriaan de Groot
3315df5df1
[modules] Use new convenience logging methods across the board
2018-02-13 11:07:12 +01:00
Adriaan de Groot
0b03d56a40
i18n: Massage code to help lupdate understand
2018-02-07 17:43:26 +01:00
Adriaan de Groot
58252fc16d
[partition] Handle missing requirements by disabling the module
2018-01-10 09:05:15 -05:00
Adriaan de Groot
e3b7a2884b
[partition] Relax check with UI-level warning message, too
2018-01-09 11:15:30 -05:00
Adriaan de Groot
637d6ad752
[partition] Find Esp partition with modern flags.
2018-01-09 11:12:13 -05:00
Adriaan de Groot
94b6c95c44
[partition] Introduce function for checking various flag-combinations for ESP boot.
2018-01-09 10:53:33 -05:00
Adriaan de Groot
05967311de
[partition] Be defensive against no device-device-available.
...
Scenario is this: you have no suitable installation devices on
your system (everything is mounted, or HDD has died), click through
to partition page, where you have all the buttons available, but no
devices in the list. The following actions then cause a crash:
- clicking "back"
- clicking any button
Prevent that:
- you can click "back", but if there is no device selected
nothing happens to the device state (no nullptr deref,
and no crash)
- button code is now more resilient to this scenario
- buttons are hidden until a device is available, so you
can't even click on them to trigger the code.
2018-01-09 06:58:46 -05:00
Adriaan de Groot
1a42b8af41
Merge branch 'kpmcore-3.2'
...
- Bumps requireed KPMCore to 3.3 (in spite of the branch name)
- Cleans up some dependencies
Thanks to Andrius Stikonas.
2018-01-02 13:25:11 +01:00
Andrius Štikonas
2027a5538e
Fix propagation of new partition table to global storage.
2017-12-27 14:11:11 +00:00
Philip
1cffa9fafc
[partition] Rename slots, to avoid recursion
...
- see also https://github.com/calamares/calamares/issues/880
- missed within 7ce52ecda7
2017-12-25 15:50:37 -05:00
Philip
8f32aad3fa
[partition] Rename slots, to avoid recursion
...
- see also https://github.com/calamares/calamares/issues/880
- missed within 7ce52ecda7
2017-12-25 15:48:55 -05:00
Adriaan de Groot
dc255e161e
[partition] Rename slots, to avoid recursion
2017-12-24 03:34:34 -05:00
Andrius Štikonas
806b84973a
Convert CreatePartitionTableJob to KPMcore operation.
2017-12-22 15:25:39 +00:00
Andrius Štikonas
1b3ce39ffb
Convert FormatPartitionJob to KPMcore's CreateFileSystemOperation.
2017-12-22 15:25:39 +00:00
Andrius Štikonas
638117efa0
Cleanup unnecessary kpmcore includes.
2017-12-22 15:25:39 +00:00
Adriaan de Groot
7ce52ecda7
[partition] Rename slots, to avoid recursion
2017-12-22 16:20:35 +01:00
Adriaan de Groot
762ad54344
Documentation: change http links to GitHub to https
2017-12-20 08:39:09 -05:00
Adriaan de Groot
cc15dd9ec7
Merge branch 'master' into kpmcore-3.2
...
- Pull in Master, merge README, to simplify merging this
branch into master (soon-ish, once kpmcore 3.3 becomes available
in builders)
2017-12-15 07:18:05 -05:00
Andrius Štikonas
a2e3af2b3d
Require KPMcore 3.3
2017-12-15 11:38:38 +00:00
Adriaan de Groot
55ed2ba4c0
[partition] Introduce convenience translation for progress.
2017-12-14 16:11:46 -05:00
Adriaan de Groot
5c4286eebf
[partition] Switch to convenience function for MiB
2017-12-14 16:11:46 -05:00
Adriaan de Groot
38688bab47
[partition] code style (minor followup to #872 )
2017-12-14 15:55:23 -05:00
Adriaan de Groot
0729bdd0be
Merge pull request #872 from stikonas/3.1.x-stable
...
Use KPMcore SetPartFlags operation.
2017-12-14 15:53:35 -05:00
Andrius Štikonas
139f5a9e86
Use KPMcore SetPartFlags operation.
2017-12-06 14:51:54 +00:00
Chantara Tith
2a785bdf89
Disable newPartitionTableButton for LVM device.
2017-11-11 21:47:30 +00:00
Andrius Štikonas
652ffaedd5
Remove unnecessary kpmcore includes.
2017-11-11 21:34:10 +00:00
Andrius Štikonas
1620f6a668
Merge branch 'master' into lvm2
2017-11-11 21:30:49 +00:00
Adriaan de Groot
105e06798e
CMake: look for ECM at top-level, add to search path if found.
2017-11-01 05:50:04 -04:00
Adriaan de Groot
b303acf12a
Merge branch '3.1.x-stable'
...
- KPMCore code moved
- Small fixes
2017-10-31 06:44:14 -04:00
Adriaan de Groot
5474dc6d2b
[partition] allow KPMcore 3.0.2 (with warning)
2017-10-30 11:43:37 -04:00
Andrius Štikonas
fb1522f6ca
Use KPMcore Resize Operation.
2017-10-27 14:00:32 +01:00
Andrius Štikonas
274025d04e
Fix reported partition size.
2017-10-27 02:51:44 +01:00
Adriaan de Groot
5e101bcbf9
Document KPMCore versions that make sense
...
- KPMCore 3.0.2 works, but contains specific bugs
2017-10-24 12:53:55 -04:00
Adriaan de Groot
e7c51aa00b
Document defaultFileSystemType
...
- this applies to new partitions; existing documentation erroneously
said this happens with Replace as well,
- follow up on Andrius manual-partition PR with documentation that
manual mode doesn't switch to this FS when editing existing partitions.
2017-10-23 06:23:19 -04:00