Adriaan de Groot
1c853f2348
Merge pull request #1266 from bill-auger/patch-8
...
housekeeping - calamares style (those lambdas are always a thing)
2019-11-19 14:59:16 +01:00
Adriaan de Groot
0d7e19d5e9
[users] Do not log the password in plain text
2019-11-08 13:23:24 +01:00
Adriaan de Groot
445d8501a7
[users] Different disambiguation for pwd-empty check
...
- all the other checks use "PWQ" as a tag, so use that here too
2019-11-08 13:22:37 +01:00
Adriaan de Groot
e11c9a049f
[users] Sort the password checks before applying them
2019-11-08 13:21:37 +01:00
Adriaan de Groot
dec0cfb7d3
[users] Give password-checks a weight, to sort them later
2019-11-08 13:16:19 +01:00
bill-auger
6c6dcfe1cd
housekeeping - calamares style
2019-11-08 05:17:40 -05:00
Adriaan de Groot
b3e7c3f294
[users] Run checks more often
...
- check password warnings when the page is entered
- re-check (and translate) on language change
2019-11-02 19:26:40 +01:00
Adriaan de Groot
cc66903678
[users] Allow an explicit check for non-emptiness of passwords
...
- move the explicit checking for non-empty into a specific
(normal) password check
- leave only the-two-fields-are-equal outside of the password-
requirements framework
- having non-empty is the same as minLength 1, but gives a different
error message
2019-11-02 19:23:04 +01:00
Adriaan de Groot
196a358493
[users] Flag password problems even when weak-passwords are ok
...
- when you allow weak passwords, flag problems as warnings (yellow)
- when weak passwords aren't allowed, they are fatal errors (red)
2019-11-01 14:48:46 +01:00
Adriaan de Groot
a4e3ea2a86
[users] Refactor retranslation
...
- move retranslation to a method so that code-formatting doesn't
get confused by it.
2019-11-01 13:55:32 +01:00
Adriaan de Groot
28c9da414b
[users] Apply coding style
2019-11-01 13:55:32 +01:00
Adriaan de Groot
9fa817a244
[users] Refactor password-validation
...
- add a method that does the work and sets UI strings for a
generic double-field password entry
- use that for user and root passwords
2019-11-01 13:55:32 +01:00
Adriaan de Groot
7d25173afb
[users] Remove TODO since it doesn't make sense
...
- the two explicit checks are the ones that handle *two*
strings as special cases; all the other checks from
the password-requirements system only handle the one string.
2019-11-01 13:17:31 +01:00
Adriaan de Groot
93eb169ea5
[users] Improve error messages
...
- distinguish beginning of username from the rest
- must start with a letter or _
- tighten message for bad username and bad hostname
FIXES #1261
2019-11-01 13:05:58 +01:00
Adriaan de Groot
8232ca626c
[users] Refactor constants
2019-10-29 16:21:26 +01:00
Adriaan de Groot
9cd1ef93bd
[users] Apply coding style
2019-10-29 16:20:52 +01:00
Adriaan de Groot
9ee0609b72
[users] Use tooltips
...
- the explanations under and around the boxes is noisy,
hard to size correctly (viz. issue #1202 )
- use tooltips in almost-all fields instead
- add placeholder text to be more suggestive
2019-10-29 14:37:26 +01:00
Adriaan de Groot
b3765bc144
[users] Massage the weak-passwords settings
...
- since the wording of the checkbox itself (and the functionality)
is to enforce strong passwords, need to switch out some
logic and fix the wording of the documentation.
2019-10-22 16:08:21 +02:00
Adriaan de Groot
3e4e492305
[users] Polish the documentation for the various checkboxes
2019-10-22 15:32:42 +02:00
Adriaan de Groot
ede50756a1
[users] Simplify config-logic for weak-passwords
...
- Use the convenience methods for config-reading.
- Always set the value (to the default if nog explicitly
set in the config-file).
2019-10-21 17:29:35 +02:00
Adriaan de Groot
21bcd560b1
[users] Use API to change weak-checkbox visibility
2019-10-21 17:26:06 +02:00
Adriaan de Groot
eb90757063
[users] Apply coding style (lots of churn)
2019-10-21 17:21:33 +02:00
Adriaan de Groot
799f1131a9
Merge branch 'patch-6' of https://github.com/bill-auger/calamares into bill-auger-patch-6
2019-10-21 17:20:34 +02:00
Andrius Štikonas
490c14d93d
QLatin1Literal->QLatin1String.
2019-09-21 20:44:33 +01:00
bill-auger
1513934a57
add checkbox to disable password validations
2019-08-30 08:13:33 -04:00
Adriaan de Groot
a0854a999e
Modules: chase API change, use std::chrono::seconds
2019-08-01 22:59:06 +02:00
Adriaan de Groot
9331a25905
[libcalamares] Remove Typedefs.h
...
- This small header file contained a few unrelated typedefs.
Move those typedefs to the classes they relate to. This
**does** mean that some consumers need to #include something
else instead.
- Use type names more consistently.
Editorial: why are **pages** responsible for creating the jobs?
2019-05-07 09:51:23 -04:00
Adriaan de Groot
8d0f076591
[libcalamares] Rename CalamaresUtils -> String
...
- The only remaining functions in the file are string-related, so
rename to match their purpose.
- Drop this include file from most places, since they don't actually
use the string functionality at all.
2019-04-29 06:49:16 -04:00
Adriaan de Groot
090aee9196
Modules: adjust to split-out utils/Variant.h
...
- Most modules only needed the variant support, not the "whole"
CalamaresUtils header.
- While here improve ordering of headers as well.
2019-04-29 06:14:21 -04:00
Adriaan de Groot
123c774a47
Use new automoc options
2019-04-18 12:06:16 +02:00
Adriaan de Groot
520478847c
Make logging more consistent.
...
- Across all the C++ modules, use Logger::SubEntry for sub/continues
log lines, instead of somewhat-random indent strings.
2019-04-15 09:02:21 -04:00
Adriaan de Groot
d0e1e46df2
[users] Don't translate CSS
2019-04-11 09:54:42 -04:00
Adriaan de Groot
95897bf83b
[users] Mark as not-translated
2019-04-11 09:49:38 -04:00
Adriaan de Groot
620d2a769a
[users] Reduce compile warnings
...
- Avoid C-style casts
- Unfortunately needs some verbose casting machinery to do
it "right" wrt. C++ type system.
2019-04-11 15:14:31 +02:00
Arnaud Ferraris
6463e5f83c
[users] Adjust messages to setup mode
...
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.com>
2019-04-08 18:02:23 +02:00
Adriaan de Groot
6071489788
[libcalamaresui] Provide default implementations of next() and back()
...
- These methods are used for multi-page view-steps, which are rare.
For all the others, just drop the empty implementation and defer
to the base class.
2019-02-25 07:49:10 -05:00
Adriaan de Groot
08565b5f17
[libcalamaresui] Remove the signal done() from ViewStep
...
- The signal is emitted, generally from next(), but not actually used.
2019-02-25 07:34:40 -05:00
Adriaan de Groot
3ea6c6cfbe
[users] Rename badly-named variable
2019-02-21 06:40:49 -05:00
Adriaan de Groot
ebc9a00bcf
[users] Massage text widths
...
- Make the explanations about 3 times as wide as the text-boxes
that they are explaining. This is partly moot because the
text-boxes have fixed pixel sizes in the designer file, but keep
it flexible for now.
2019-02-11 18:18:34 -05:00
Adriaan de Groot
1adf4da736
[users] Small space between password explanation and checkboxes
2019-02-11 18:07:27 -05:00
Adriaan de Groot
7515386cf8
CMake: clean up test setup
...
- Remove redundant searches for ECM and Qt::Test, move
them to top-level.
2018-10-05 09:41:37 -04:00
Adriaan de Groot
dd8e53dc22
Copyright: update copyright lines on files touched in 2018
...
Contributions from:
Adriaan de Groot <groot@kde.org>
Gabriel Craciunescu <crazy@frugalware.org>
AlmAck <gluca86@gmail.com>
Andrius Štikonas <andrius@stikonas.eu>
Caio Carvalho <caiojcarvalho@gmail.com>
Raul Rodrigo Segura <raurodse@gmail.com>
2018-06-15 05:59:11 -04:00
Adriaan de Groot
dae84d3bb1
[users] Improve explanation of other steps of adding a user
2018-05-23 08:11:49 -04:00
Adriaan de Groot
01ff1efc5d
[users] Improve explanation when useradd fails
2018-05-23 07:03:59 -04:00
Adriaan de Groot
0d24c1db6c
[users] Introduce userShell setting
...
- Add a *userShell* key, which can be left out (default, backwards-
compatible) to retain the old /bin/bash behavior, or explicitly
set to empty to defer to useradd-configuration, or explicitly
set to something non-empty to use that shell.
2018-05-23 05:23:46 -04:00
Adriaan de Groot
ed15edabf9
[users] Document passwordRequirements and code
2018-05-23 04:37:18 -04:00
Adriaan de Groot
3a59574128
[users] Factor out command-line to useradd
...
- This is prep-work for #964 , which was caused by #955
- Original assumption was that distro's would have a working
useradd configuration; @abucodonosor already pointed out that
this was probably not the case, but I ignored that.
2018-05-22 11:45:39 -04:00
Frede H
f2677b0879
Update CreateUserJob.cpp
...
Removal of the hardcoded shell, letting the `/etc/default/useradd` be responsible for the shell.
2018-05-17 12:52:09 +02:00
Adriaan de Groot
6bb72d173d
[libcalamares] Drop generic cLog()
...
- Use cWarning or cError() for errors
- Use cDebug(level) for other uses (but there aren't any)
2018-03-28 09:31:45 -04:00
Adriaan de Groot
a9e751bb31
[users] Compile warnings--
2018-03-06 16:10:31 +01:00