Adriaan de Groot
94fe4d2fda
[libcalamares] Avoid weak vtables in string-pair implementation
2019-11-26 12:30:59 +01:00
Adriaan de Groot
fc7f49b610
[libcalamares] Expand tests for TimeZone translations
2019-11-26 12:28:41 +01:00
Adriaan de Groot
71f3614eb7
[libcalamares] Add TimeZone support to build
...
- Add to CMakeLists.txt
- Test basic scenarios
2019-11-26 11:20:33 +01:00
Adriaan de Groot
3af2754022
[libcalamares] Implement translatable-pair-of-char*
...
- This is base functionality for a translatable model of
TimeZone names that is scraped from zone.tab
2019-11-26 11:18:35 +01:00
Adriaan de Groot
abd3c4171b
[libcalamares] Prevent CI coding-style fixes to generated code
2019-11-26 11:08:21 +01:00
Adriaan de Groot
733fb43b5e
[libcalamares] Sort the dummy zone names
2019-11-26 10:45:36 +01:00
Adriaan de Groot
c3fdb38097
[libcalamares] Stub of class for TimeZone model management
...
- Intent is to move out of locale module
2019-11-25 20:51:45 +01:00
Adriaan de Groot
2034dd62a4
[libcalamares]: Timezone information for translation/extraction
...
SEE #1259
2019-11-19 18:07:13 +01:00
Adriaan de Groot
3ee384f36c
[libcalamares] Extract zone.tab data for translations
2019-11-19 18:07:13 +01:00
Adriaan de Groot
c8229733b0
[libcalamares] Document the pseudo-constructors for JobResult
2019-10-01 16:05:03 +02:00
Adriaan de Groot
3a8d543c72
[libcalamares] Document operator bool() of JobResult
...
- this could be named isValid() instead, but basically the idea
is that this code makes sense:
JobResult r = do_thing();
if ( !r ) { /* Error happened! */ return r; }
/* Carry on .. */
2019-10-01 15:58:02 +02:00
Adriaan de Groot
4970c328fa
[libcalamares] Fix stringification of broken instance keys
2019-10-01 10:50:12 +02:00
Adriaan de Groot
70fc480c56
[libcalamares] If test is going to fail, be more verbose on failure
2019-10-01 10:50:12 +02:00
Adriaan de Groot
5d0a5c035d
Merge pull request #1243 from stikonas/master
...
QLatin1Literal->QLatin1String.
2019-09-30 10:30:02 +02:00
Adriaan de Groot
bb9cca643f
[libcalamares] Avoid warnings from MOC-generated code
...
- Moc generates Q_UNUSED(_a); which in turn (with clang) issues
a superfluous-semicolon warning. Existing code with automoc
uses utils/moc-warnings.h to turn off warnings that are issued
on moc code. Include it explicitly here because automoc isn't
applied.
2019-09-23 11:50:06 +02:00
Adriaan de Groot
3c387a11c9
[libcalamares] class/struct mismatch
...
- Manager::Private is a class, not just a struct. Needed for
hypothetical MSVC compatibility.
2019-09-23 11:26:53 +02:00
Andrius Štikonas
490c14d93d
QLatin1Literal->QLatin1String.
2019-09-21 20:44:33 +01:00
Adriaan de Groot
ce6f6592d4
[libcalamares] Drop parts of InstanceKey API
...
- Drop the 1-argument QString constructor, it is suprising
- Drop the conversion to QString
- Add a toString() instead
- Drop tests for the removed API
- While here, apply code formatting to the tests
This is done to force consumers to update to strongly-typed
InstanceKeys.
2019-09-15 20:38:16 +02:00
Adriaan de Groot
7dcc6e8e07
[libcalamares] Fix bug in InstanceKey::QString
2019-09-15 20:38:16 +02:00
Adriaan de Groot
57e4b66af2
[libcalamares] Test QString() operator
...
- An invalid InstanceKey should give an empty string
- Test remaining QString() cases
- Edge cases for 2-string constructor
2019-09-15 20:38:16 +02:00
Adriaan de Groot
ba7e96c5e1
[libcalamares] Add test for InstanceKey
...
- cover all the constructors
- Start with some tests that fail, showing bugs in the implementation
- Fix bug that "derp@derp" was creating a valid instance-key with
a bad module and id (need to use ::fromString() to get that
functionality).
- Extend tests with more bad cases.
- Refactor tests to simplify "this is bad" assertions.
2019-09-15 20:38:16 +02:00
Adriaan de Groot
2f99004041
[libcalamares] Move the module instance-key
...
- Split out of the UI library and into (header-only) libcalamares.
2019-09-15 20:38:16 +02:00
Adriaan de Groot
666462651b
[libcalamares] Namespace consistently
...
- Things in libcalamares/ subdirectories are namespaced
according to that subdirectory (sometimes in namespace
Calamares, sometimes CalamaresUtils). Do that in modulesystem/ too.
2019-09-15 20:38:16 +02:00
Adriaan de Groot
57a942d155
[libcalamares] Make a NAM per thread
...
- To avoid warnings about creating requests and replies, parented
by the NAM but from another thread, make a NAM per thread.
2019-09-14 07:21:24 -04:00
Adriaan de Groot
ca351ff7b6
[libcalamares] Apply (some) options to request earlier
2019-09-10 14:26:46 +02:00
Adriaan de Groot
88fc6685ba
[libcalamares] Apply coding style to geoip/
2019-09-05 03:23:28 -04:00
Adriaan de Groot
badbdf59ee
[libcalamares] Build synchronous get w/ async-get
2019-09-02 13:43:10 +02:00
Adriaan de Groot
f8356a6dcc
[libcalamares] Add an async get method
...
- Mostly a "cheap" wrapper for a half-dozen boilerplate lines
of Qt NAM code.
2019-09-02 12:21:33 +02:00
Adriaan de Groot
543e2d34fc
[libcalamares] [locale] Remove unused includes
2019-09-02 12:02:43 +02:00
Adriaan de Groot
66ee6ac673
[libcalamares] Fix tests for umask != 022
...
- My usual test environment has umask set to 022, but on one dev
box it is 002, leading to test failures (which show the test
was bad, not that the umask-setting code is bad)
2019-08-30 06:35:53 -04:00
Adriaan de Groot
9053b9cecf
[libcalamares] Fix Qt 5.9 compatibility
...
- not really sure why I went for the Qt 5.10 STL-style iterators
FIXES #1236
2019-08-30 06:20:45 -04:00
Adriaan de Groot
f1971eed86
[libcalamares] Support calling a slot on retranslation
...
- sometimes a slot is easier than a lambda. Introduce
a macro CALAMARES_RETRANSLATE_SLOT that calls a given
slot in an object on language change.
- extend the retranslator with support for calling slots:
- use Qt's signal/slot mechanism alongside the private
list of functions to call
- provide convenience for obtaining the retranslator of
an object.
2019-08-29 14:53:03 +02:00
Adriaan de Groot
eb21c90861
[libcalamares] Avoid implicit 0-to-flags conversion
...
- clang complains about using 0 as a Flags value, so make the
default (empty) initialization explicit.
2019-08-26 21:42:27 +02:00
Adriaan de Groot
6fb909a799
Merge branch 'networking-service'
2019-08-26 15:49:09 +02:00
Adriaan de Groot
a1b0049bbf
[libcalamares] Use more readable names
2019-08-26 15:41:30 +02:00
Adriaan de Groot
e2c6591a77
[libcalamares] Refactor request internals
...
- distinguish timeouts from other failures
- git synchronousPing() a more detailed result, which is
still bool-compatible.
2019-08-26 15:24:58 +02:00
Adriaan de Groot
f0be7fd4aa
[libcalamares] Make failures in the internal methods obvious
...
- internally, timeout and error will return nullptr
2019-08-26 14:43:41 +02:00
Adriaan de Groot
87ea14f68a
[libcalamares] Drop INTERFACES again
...
- The compile failure came from bad #include paths, so restoring
this interface declaration wasn't a fix.
- Reported to cause runtime failures on both KaOS and Manjaro.
2019-08-26 10:15:22 +02:00
Adriaan de Groot
ededebbc6c
[libcalamares] Return reply early if the request is bad
2019-08-24 15:23:07 +02:00
Adriaan de Groot
d422c782ba
[libcalamares] Correct include path
...
- no need for the subdirectories, and this confuses MOC
Reported-by: Jonathan Riddell
Fix-by: Harald Sitter
2019-08-23 17:15:51 +02:00
Adriaan de Groot
85f0d38698
[libcalamares] Refactor synchronous get
...
- Add timeout support
- Refactor into a static helper method
2019-08-23 14:59:35 +02:00
Adriaan de Groot
1f2b3b734d
[libcalamares] Extend synchronous API with options
2019-08-23 12:18:59 +02:00
Adriaan de Groot
af1aa701bc
[libcalamares] Shuffle namespace lines around
...
- put all the definitions inside namespace {} to avoid
needlessly long source lines.
2019-08-23 12:09:30 +02:00
Adriaan de Groot
8ea1ea6662
[libcalamares] Add synchronousGet() to network service
...
- Synchronous download of a given URL; not something to
do from the GUI thread.
- Use it from the GeoIP service, which downloads in a
separate thread to do GeoIP lookups.
- Drop now-unused headers.
- Adjust tests for GeoIP to use network service
2019-08-22 16:11:26 +02:00
Adriaan de Groot
0b2855d6e0
[libcalamares] Fix build (bad class name)
2019-08-22 10:29:39 +02:00
Adriaan de Groot
9aae9b2f02
[libcalamares] Restore Q_DELCARE_INTERFACE
...
- This **may** be the cause of build failures on aarch64.
2019-08-22 10:26:15 +02:00
Adriaan de Groot
310a1d76cf
[calamares] Reduce warnings now that getInteger is qint64
2019-08-22 10:25:16 +02:00
Adriaan de Groot
eae931f2ed
[libcalamares] Ping only when accessibility is unknown
...
- Restores exact functionality of previous version
(noted by Kevin Kofler)
- Short-circuit ping if the URL is bad.
2019-08-21 03:43:51 -04:00
Adriaan de Groot
4389c254df
[libcalamares] Rely directly on QNAM's networkAccessible()
2019-08-20 10:57:34 -04:00
Adriaan de Groot
11d52df04c
[libcalamares] Add API docs to network service
2019-08-20 10:57:34 -04:00