Commit Graph

285 Commits

Author SHA1 Message Date
Chantara Tith
aa10fe982a API Changes, logicalSectorSize -> logicalSize, totalSectors -> totalLogical. 2016-09-09 11:28:39 +02:00
Andrius Štikonas
9f0ca042fe Port away from most cases of Q_FOREACH to C++11 ranged for loop.
In order to avoid deep copies, Qt containers over which we iterate must be const
The remaining unported cases require qAsConst (Qt 5.7) or std::as_const (C++17)
2016-09-01 16:46:14 +01:00
Teo Mrnjavac
edeee85cd3 Write reuse Home check box string. 2016-07-22 16:36:26 +02:00
Teo Mrnjavac
e6f9714f84 Avoid homePartitionPath going out of scope. 2016-07-22 16:36:26 +02:00
Teo Mrnjavac
90bb64fb17 Pass current index by value. 2016-07-22 16:36:26 +02:00
Teo Mrnjavac
aaf85407fb Only look for a separate /home partition if a partition was found. 2016-07-22 16:36:26 +02:00
Teo Mrnjavac
6c6e4a1f88 Write reuseHome to GlobalStorage. 2016-07-22 16:36:26 +02:00
Teo Mrnjavac
8b0b4c73de Add Q_UNUSED where relevant. 2016-07-22 16:36:26 +02:00
Teo Mrnjavac
d44a3d831b Warning fixes: avoid C-style casts. 2016-07-22 16:36:26 +02:00
Teo Mrnjavac
30ff216dea Warning fix: implicit cast. 2016-07-22 16:36:26 +02:00
Teo Mrnjavac
90c06bd733 Warning fixage (init list order, lossy cast, Q_UNUSED). 2016-07-22 16:36:26 +02:00
Teo Mrnjavac
c1e535a8e8 Hide reuse checkbox on action selection change. 2016-07-22 16:36:26 +02:00
Teo Mrnjavac
a17f369cee React to reuse home checkbox by setting /home mount point.
Rearranged Replace workflow a bit: onPartitionReplaceSelected is now
the on choice slot, which in turn calls doReplaceSelectedPartition.
onHomeCheckBoxStateChanged also calls doReplaceSelectedPartition if we
need to redo the Replace task with/without a separate home to keep.
m_reuseHomeCheckBox is hidden by default.
2016-07-22 16:36:26 +02:00
Teo Mrnjavac
2c68802446 Reapply the action choice instead. 2016-06-29 18:46:02 +02:00
Teo Mrnjavac
b2b202d190 Do a full revert. 2016-06-29 18:34:02 +02:00
Teo Mrnjavac
f1a29033a2 Revert PCM before applying Alongside operation. 2016-06-29 18:21:38 +02:00
Teo Mrnjavac
18742d2afd Ignore encrypt widget if the choice is Manual. 2016-06-10 15:22:40 +02:00
Teo Mrnjavac
f5ff716369 Make everything obey the default filesystem type setting. 2016-06-10 15:22:21 +02:00
Teo Mrnjavac
936e7fab7c Initial support for Alongside install with LUKS. 2016-06-07 17:35:39 +02:00
Teo Mrnjavac
fd2d24d650 Always show encrypt widget for Replace. 2016-06-03 17:56:31 +02:00
Teo Mrnjavac
4113207e00 Fix next status handling in alongside and replace. 2016-06-03 17:55:14 +02:00
Teo Mrnjavac
e84108e234 Add encryption support in PartitionActions::doReplacePartition. 2016-06-03 16:39:28 +02:00
Teo Mrnjavac
6cd1bf6b3d Initial work on having the Replace feature obey the encryption setting. 2016-06-02 18:29:17 +02:00
Teo Mrnjavac
a4ab8dad46 Hide encryption widget if not Erase. 2016-05-18 07:22:13 +02:00
Teo Mrnjavac
60dcba8735 Update next state slightly later. 2016-05-17 11:34:30 +02:00
Teo Mrnjavac
b792ea0216 Rebuild autopartition proposal when encryption choice changes. 2016-05-06 18:59:51 +02:00
Teo Mrnjavac
0cc9560a99 Hook up EncryptWidget in ChoicePage, plus improve next status handling. 2016-05-06 18:59:51 +02:00
Teo Mrnjavac
dacb8f2a94 Make sure we don't hide actions based on osprober. 2016-03-18 12:28:54 +01:00
Chantara Tith
fd8c131b26 implement free-space partition replace install 2016-03-18 17:09:50 +07:00
Teo Mrnjavac
83d440f37e Add note. 2016-03-10 13:16:18 +01:00
Teo Mrnjavac
06ebf69afe Initialize all members (fix Coverity defect 98200). 2016-02-26 14:02:22 +01:00
Teo Mrnjavac
a0ac9d9f07 Don't dereference nullptr (fix Coverity defect 121863). 2016-02-26 13:00:58 +01:00
Teo Mrnjavac
e91d213872 Improve setting ESP. 2016-02-19 16:57:49 +01:00
Teo Mrnjavac
e27b9fc295 Handle ESP selector visibility. 2016-02-19 16:51:24 +01:00
Teo Mrnjavac
a4831085fb Only override BIOS bootloader install path if there's no UI. 2016-02-19 16:42:51 +01:00
Teo Mrnjavac
7a89b53538 Refactor leave event of ChoicePage, add ESP mount point support.
PVS now calls ChoicePage::onLeave, which in turn runs ChoicePage::
doAlongsideApply and/or sets up the ESP mount point based on the UI
state if it's running in EFI mode and the action is Alongside or
Replace.
If setting up under BIOS, Alongside and Replace always install
the bootloader in the MBR of the current device.
2016-02-19 16:33:19 +01:00
Teo Mrnjavac
485176d70d And always do that, please. 2016-02-12 16:48:29 +01:00
Teo Mrnjavac
12ec3bb74b Iterate over all partitions for canBeResized check, not just osprober. 2016-02-12 16:45:52 +01:00
Teo Mrnjavac
c3404769dc Use new check as selection filter in view. 2016-02-12 15:02:49 +01:00
Teo Mrnjavac
ffe419751c Use the new canBeResized in ChoicePage. 2016-02-11 17:04:36 +01:00
Teo Mrnjavac
56e6509341 Use it in ChoicePage. 2016-02-11 16:00:36 +01:00
Teo Mrnjavac
0f756c7167 Use it in ChoicePage. 2016-02-10 17:02:42 +01:00
Teo Mrnjavac
7bb76c70ba Set the nested partitions mode in ChoicePage. 2016-02-10 15:00:02 +01:00
Teo Mrnjavac
b17b7a9c89 Asynchronous rescan on device change. 2016-02-09 13:23:23 +01:00
Teo Mrnjavac
877fa98ea6 Revert all devices if core dirty on device choice. 2016-02-09 13:03:14 +01:00
Teo Mrnjavac
ec5a464eda Make sure a default bootloader location is set. 2016-01-29 17:43:55 +01:00
Teo Mrnjavac
7f235525f2 Try slightly smaller action icons. 2016-01-29 17:10:28 +01:00
Teo Mrnjavac
30c38c4f4d Safer pointer. 2016-01-29 17:07:08 +01:00
Teo Mrnjavac
1bc6556b65 We don't need this any more... 2016-01-29 16:49:39 +01:00
Teo Mrnjavac
5ccfc20258 Refactor bootloader picker into the bottom layout. 2016-01-28 18:43:35 +01:00
Teo Mrnjavac
e1a6085a1b Try different layout for first row in ChoicePage. 2016-01-28 13:04:44 +01:00
Teo Mrnjavac
30351d125a Reduce spacing. 2016-01-28 12:53:54 +01:00
Teo Mrnjavac
1a11d8589a Fix layout. 2016-01-27 18:27:03 +01:00
Teo Mrnjavac
b6218272f3 Add BootInfoWidget to ChoicePage. 2016-01-27 18:23:56 +01:00
Teo Mrnjavac
b811f9e261 Fixup strings. 2016-01-25 16:59:05 +01:00
Teo Mrnjavac
16da0bd8d8 I guess this is a better spot. 2016-01-15 18:40:59 +01:00
Teo Mrnjavac
7c7c635d87 Set filter on both views. 2016-01-15 18:40:59 +01:00
Teo Mrnjavac
65230c7954 Add a SelectionFilter lambda for Alongside. 2016-01-15 18:40:59 +01:00
Teo Mrnjavac
f958f69218 Fix weird issue with alongside failing to create new partition. 2016-01-14 18:47:02 +01:00
Teo Mrnjavac
423d2dfc5c Make sure we update the splitter widget after a rescan. 2016-01-14 16:14:57 +01:00
Teo Mrnjavac
601d67988d Fix shrink size computation.
I don't get how this could possibly ever have worked.
2016-01-13 18:23:50 +01:00
Teo Mrnjavac
8525cefb6b Fix next status handling. 2016-01-13 17:55:51 +01:00
Teo Mrnjavac
27d69502a3 Alongside apply slot. 2016-01-13 17:43:59 +01:00
Teo Mrnjavac
cad8845f12 Better name for alongside slot. 2016-01-12 14:04:25 +01:00
Teo Mrnjavac
4537103a43 Set up split widget when a partition is selected. 2016-01-12 11:43:02 +01:00
Teo Mrnjavac
d85bf01107 Initialized view is the best kind of view. 2016-01-11 19:26:14 +01:00
Teo Mrnjavac
37df381404 Proper parenting. 2016-01-11 19:07:48 +01:00
Teo Mrnjavac
80018e1d5b Signal-slot plumbing and splitter setup for Alongside. 2016-01-11 19:02:34 +01:00
Teo Mrnjavac
b3f86925a8 Fix m_choice state. 2016-01-08 16:51:25 +01:00
Teo Mrnjavac
b422f646a6 Make sure the checked state change can happen. 2016-01-08 16:43:58 +01:00
Teo Mrnjavac
bc9ec8e5ba Fix build. 2016-01-08 16:37:45 +01:00
Teo Mrnjavac
3869338c39 Make the QButtonGroup a member in ChoicePage. 2016-01-08 16:35:50 +01:00
Teo Mrnjavac
85a6f2068a Refactor action choice handling with QButtonGroup.
This should improve the situation when unselecting an action without
selecting another one. Unselection can only happen when switching from
a device that supports the currently chosen action to a device that
doesn't support it, so the action gets hidden and unselected.
2016-01-08 15:38:01 +01:00
Teo Mrnjavac
53c27208f1 Also uncheck if hidden. 2016-01-08 14:50:09 +01:00
Teo Mrnjavac
f71ce22f3b Make sure to show all the relevant partitioning actions. 2016-01-08 14:45:58 +01:00
Teo Mrnjavac
0c05812c68 Update bootloader combobox when the selected device changes. 2016-01-07 17:24:01 +01:00
Teo Mrnjavac
64d296aa06 Sensible default to current device in bootloader picker. 2016-01-05 18:45:59 +01:00
Teo Mrnjavac
6ce932870f Clear selection on action change no matter what. 2015-12-31 16:58:50 +01:00
Teo Mrnjavac
74ba1df25f Try to manage preview visibility. 2015-12-31 16:55:18 +01:00
Teo Mrnjavac
38b90560cf Remove debug spam. 2015-12-31 16:36:24 +01:00
Teo Mrnjavac
22459c8fb8 Debug output. 2015-12-31 16:35:01 +01:00
Teo Mrnjavac
6dd639fd3c Try with rows. 2015-12-31 16:29:45 +01:00
Teo Mrnjavac
afef78d1af Don't enable next for replace by default. 2015-12-31 16:27:10 +01:00
Teo Mrnjavac
736d35840d Rely on item selection. 2015-12-31 16:24:46 +01:00
Teo Mrnjavac
59ec549617 Manage next button status. 2015-12-31 16:21:50 +01:00
Teo Mrnjavac
08d1c89f21 Don't forget to perform the autopartition operation when not resetting. 2015-12-31 16:12:52 +01:00
Teo Mrnjavac
73be443e22 And use it. 2015-12-31 15:39:32 +01:00
Teo Mrnjavac
50ef1f1b70 Make sure we autopartition after the revert is over. 2015-12-31 15:18:34 +01:00
Teo Mrnjavac
f589e33fa5 Runtime signals, runtime errors. 2015-12-31 15:14:42 +01:00
Teo Mrnjavac
296bb412a8 Revert to runtime singal-slot syntax for easy disconnects. 2015-12-31 15:12:40 +01:00
Teo Mrnjavac
3cb293aa75 Avoid unnecessary casts. 2015-12-31 15:02:46 +01:00
Teo Mrnjavac
f01d802d40 No point in trying to reset and replace if nothing is selected. 2015-12-31 14:50:43 +01:00
Teo Mrnjavac
7e43c66661 Better order, probably. 2015-12-31 14:45:43 +01:00
Teo Mrnjavac
7dd669d997 Clear selection in before view. 2015-12-31 14:43:57 +01:00
Teo Mrnjavac
fbb92646d8 Asynchronous revert for Erase operation. 2015-12-31 14:40:40 +01:00
Teo Mrnjavac
5c0627a9d3 Remove debug spam. 2015-12-31 14:40:04 +01:00
Teo Mrnjavac
64655d92a1 Try to ensure the connection for the replace operation is unique. 2015-12-31 14:38:28 +01:00
Teo Mrnjavac
d6e773e220 Debug output. 2015-12-31 14:26:31 +01:00
Teo Mrnjavac
e061385f4b Avoid multiple connects. 2015-12-31 14:17:36 +01:00
Teo Mrnjavac
4039d8d4db Make on-action-select rescan also async. 2015-12-31 14:14:47 +01:00
Teo Mrnjavac
093c7b042d Use it in ChoicePage. 2015-12-31 13:56:11 +01:00
Teo Mrnjavac
d28946040f Use ScanningDialog in replace operation. 2015-12-31 13:19:50 +01:00
Philip
91e1e4af6b [partition-module] fix 'QString::arg: Argument missing' issue 2015-12-31 00:56:46 +01:00
Teo Mrnjavac
f31a45e53a Clean up a bit. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
6db6dc0e08 Debug output. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
4f12aa8dd1 Critical to always have a fresh device. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
14f4335420 Lock the whole replace operation in a mutex. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
9847b8efa9 Try to invalidate whole PartitionModel on replace. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
2a61114d9e Make after partition views members in ChoicePage. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
8a44ffe462 Either revert or clear jobs, not both. 2015-12-30 17:27:13 +01:00
demmm
496d917d94 add strong in selectLabel 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
cd8b7619d0 Use asynchronous device revert. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
019faf730c Revert "Test out a way to make the rescan asynchronous."
This reverts commit e3f28189ced7aa22b3b7a6dc1506a17cbc1325b5.
2015-12-30 17:27:13 +01:00
Teo Mrnjavac
d742431ee9 Revert "Force a device state preview update after async rescan."
This reverts commit 717a3d47ca572c28f67757ddf96b63af66d97e14.
2015-12-30 17:27:13 +01:00
Teo Mrnjavac
95239af830 Force a device state preview update after async rescan. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
5f282d50dc Test out a way to make the rescan asynchronous. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
1a882758ca Revert Replace button to PrettyRadioButton. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
18755314fd Fix strings and use status text label. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
ef411757af Improved string for Erase. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
c41820c000 Improved string for Replace. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
bf5d0d8862 Strings: s/volume/partition/ 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
dcd48badae Try with a full revert. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
a8f06d00d0 Debug info. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
e2f9a5b93c Maybe not. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
6c614b946b A full view delete/recreate on partition selection :( 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
65278605fe clearJobs is enough on replace partition selection. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
15e409a107 Don't reparent model managed by PCM. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
275b68cf5c The PartitionModel should be owned by the PCM. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
dfededc4b4 Use revertDevice in ChoicePage, and always use a fresh Device*. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
b767f0b18f Select partition to replace from the current DeviceModel. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
2258c806ae Make the bars/labels views members in ChoicePage. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
d164ec4d91 Remove ReplaceWidget. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
d0ee43172c Handle selection behavior on current state preview views. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
0c9d64878a Only enable selection when it makes sense 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
1c279dac24 Make bars and labels share the selection model. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
6af901a675 Use BootloaderEntryName from Branding for target root partition id. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
0c840abdc5 Allow setting a custom new root name in Labels view. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
f736ace996 Update Erase disk string. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
cda99a2a65 New Alongside strings. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
37634e1e5a New Replace strings. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
d27ac4c041 New Erase disk strings. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
48d0de2e08 Let's try with no main message. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
326e566927 String changes. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
0224811bf6 Move Osprober to PCM and add Osprober roles to PartitionModel. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
a9e241d288 Fix strings. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
1ad6c7e8ac Use new Labels view. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
b65fe87503 PartitionPreview is now PartitionBarsView. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
3beebf4137 String improvement. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
84c254ced2 Use DeviceInfoWidget in ChoicePage. 2015-12-30 17:27:13 +01:00
Teo Mrnjavac
4c90a68241 Make choice text refer to the currently selected device. 2015-12-30 17:27:13 +01:00