Adriaan de Groot
ed4127f661
[libcalamaresui] Shuffle the module interface
...
- introduce NamedEnum lookup tables for interface and type
- drop "final" and "virtual" from methods that don't make
sense as virtual
- shuffle declaration order so the virtual API for modules
sits together
2020-01-12 12:18:13 +01:00
Adriaan de Groot
f89c137c90
[libcalamaresui] Migrate module to using InstanceKey
...
- Trying to get away from untyped strings with special meaning.
- The "split identifier" branch tried the same thing, but
was duplicating the existing InstanceKey.h work.
2020-01-12 11:49:10 +01:00
Adriaan de Groot
a7e1a1f9fc
[libcalamaresui] Refactor Module::initFrom()
...
- generic initFrom() also sets the instance id
- subclass-specific initFrom() now pure virtual in base
- chase changes in subclasses
2020-01-12 11:37:22 +01:00
Adriaan de Groot
23a957e783
[libcalamares] Chase API change (timeouts)
...
- The new mount service needed adjustment for the independent
change of timeouts: int -> chrono::seconds.
2020-01-10 15:22:26 +01:00
Adriaan de Groot
f6d89354a1
Merge branch 'master' into kpmcore-manager
2020-01-10 14:54:13 +01:00
Adriaan de Groot
1a8926181e
[locale] Warnings-- (initialization-order)
2020-01-07 10:46:26 +01:00
Adriaan de Groot
2dff2d9d70
[libcalamares] TZRegion is hard to copy
...
- delete the copy and move constructors
- adjust tests (which were just interested in simple tr() behavior) to use TZZone instead
2020-01-07 10:41:14 +01:00
Adriaan de Groot
5fbd0169ca
[libcalamares] Reduce clang warnings (only-inline-virtual, unused parameters)
2020-01-07 10:33:21 +01:00
Adriaan de Groot
1b62b2f66c
[libcalamares] Reduce warnings (extra ;, empty statement ..)
2020-01-07 10:19:22 +01:00
Adriaan de Groot
b4c0ebe8ab
[calamares] Use screen and window sizes, not position
2020-01-07 10:04:10 +01:00
Adriaan de Groot
fcb0109b7b
[calamares] Refactor center-placement
...
- Just move it to its own function where it can have more documentation
- Tested on multi-screen setups
SEE #1293
2020-01-07 09:56:13 +01:00
Adriaan de Groot
121013fd96
[calamares] Avoid deprecated desktop()
...
- Put Calamares on the first screen where it fits
- This is wordy and weird
2020-01-07 01:06:26 +01:00
Adriaan de Groot
43caf7b46a
[calamares] Restore functionality for 'center window'
2020-01-07 00:34:15 +01:00
Adriaan de Groot
17d09342e9
[libcalamaresui] Add a setting for window placement
2020-01-07 00:27:11 +01:00
Adriaan de Groot
1625bb1dae
[locale] Support Qt 5.9
...
FIXES #1296
2020-01-07 00:09:04 +01:00
Adriaan de Groot
d21ed0cc7f
[packagechooser] Coding style
2020-01-06 17:55:13 +01:00
Adriaan de Groot
cefb66ab5b
Merge pull request #1276 from bill-auger/patch-packagechooser-default-selection
...
[packagechooser] pre-select default item in packagechooser
2020-01-06 17:49:10 +01:00
Adriaan de Groot
dd5adc153f
Merge pull request #1291 from calamares/initcpiocfg-usr
...
[initcpiocfg] add usr hook if partition is separate
2020-01-06 14:41:24 +01:00
Adriaan de Groot
fe64903d2f
[initcpiocfg] Polish PR #1290
...
- List discrete years in copyright
- Add docstrings
- Massage detect_plymouth() to return bool (easier in if() context)
2020-01-06 14:34:47 +01:00
Philip Müller
85d3f9e9b9
[initcpiocfg] add usr hook if partition is separate
2019-12-16 09:40:54 +01:00
Philip Müller
a3da47cd9c
[initcpiocfg] update plymouth check
2019-12-16 09:34:21 +01:00
Adriaan de Groot
0e7982ec37
[libcalamares] Don't force Hindi on India.
...
FIXES #1284
2019-12-11 18:33:24 +01:00
Adriaan de Groot
58786388d6
Merge branch 'zone-data'
2019-12-11 15:34:35 +01:00
Adriaan de Groot
7bea19a62c
[locale] Fix build with debugging enabled (API changes)
2019-12-11 08:45:35 -05:00
Adriaan de Groot
242b79e2e1
[locale] Remove old Location information
...
- all the TZ location information now lives in the Calamares
locale service and the TZ list
- replace the Location class that was local to the timezone
widget by the TZZone class
- chase a bunch of small API changes that this needs
2019-12-11 08:45:35 -05:00
Adriaan de Groot
4945408911
[libcalamares] Remove debugging cruft
2019-12-11 08:45:35 -05:00
Adriaan de Groot
daa76080f1
[libcalamares] Add meaningful aliases for key()
2019-12-11 07:00:42 -05:00
Adriaan de Groot
0ed2a3e35f
[libcalamares] Refactor translation-setting
...
- Split the actual loading of translations into classes
to encapsulate the loading logic,
- Build a collection of classes to do the different kinds
of translation loading,
- Build a generic function to load something and update a
static pointer to the translation.
This makes installTranslator() much easier to read, and encapsulates
the type-specific loading somewhere else. While here, add a timezone-
translations loader so that the split-out TZ translations also work.
2019-12-11 06:40:22 -05:00
Adriaan de Groot
93ae44e214
[libcalamares] Split translatable timezone data
...
- Hide the one file from lupdate by giving it a weird suffix
- Call lupdate a second time for the timezone translations
- While here, adjust so that the options precede the directories
they are supposed to affect
I don't want to give the translation teams 444 new strings all
at once (about 90% of which don't need translation).
2019-12-10 22:44:10 +00:00
Adriaan de Groot
e164f8d63a
[locale] Fix build with DEBUG_TIMEZONE
...
- all the API changes were not reflected in the debugging code
2019-12-10 16:19:06 -01:00
Adriaan de Groot
fb9d53909e
[locale] Drop ZONES #define
...
- this was a "cheap" way to write a list, but going through
QStringList::split() is just a long-way-around for static
initialization
2019-12-10 16:09:48 -01:00
Adriaan de Groot
2dfbed40c5
[locale] Move defines
...
- Used in only one place, move to .cpp
- Drop useless scaling all the images *are* that size already
- Add debugging check that the images match expected size
2019-12-10 10:00:16 -07:00
Adriaan de Groot
9d9d9c361d
[locale] Clean up constants
...
- move LOCALESDIR to the one place it's used
- remove file with only unused #defines
2019-12-10 17:46:09 +01:00
Adriaan de Groot
7354d35faf
[locale] Apply coding style to timezonewidget/
2019-12-10 17:42:58 +01:00
Adriaan de Groot
1e04924224
[locale] Drop the TZ-widget's timezone database
...
- use the global TZ service instead
- contains hacks to keep some of the API unchanged, which will be
removed shortly
2019-12-10 17:29:35 +01:00
Adriaan de Groot
08dc9011d6
[libcalamares] Off-by-one folded the world in half
...
- Dropped the sign from longitudes, wrapping the west onto the east
2019-12-10 17:11:10 +01:00
Adriaan de Groot
1880eb5148
[libcalamares] Add accessors for TZZone
2019-12-10 16:10:16 +00:00
Adriaan de Groot
3f57b929ee
[libcalamares] Make the zoneTab region list static
...
- there's only one zone.tab, it won't change during a run,
load it only once (this allows for a single global list).
2019-12-11 01:43:53 +10:00
Adriaan de Groot
4089a01cb1
[locale] Create TZ model earlier
2019-12-11 01:31:56 +10:00
Adriaan de Groot
a39c77dfaf
[libcalamares] Store region name in each zone as well
2019-12-11 01:11:51 +10:00
Adriaan de Groot
226530cf6f
[locale] Use model functions from locale service
...
- drop the home-grown combo-box filling, use model
2019-12-11 01:04:09 +10:00
Adriaan de Groot
c75e870073
[libcalamares] CStringList::find() convenience function
...
- search for a key and return a type-cast pointer to the result
- while here, simplify some other code
- the find() function could be done with std::find_if but doesn't
get any shorter or more elegant
2019-12-10 15:54:43 +01:00
Adriaan de Groot
6092172f8d
[libcalamares] Regions and zones change to QList<Base*>
...
- By using QList< CStringPair* > consistently, we can save
a bunch of model code at the cost of an occasional dynamic_cast;
it's fairly rare for there to be a need for the derived pointer.
2019-12-10 15:32:15 +01:00
Adriaan de Groot
fc8364ea54
[libcalamares] Store zones with each region
...
- move operator< to base class
- add each zone to the list held by the region
- sort zones at the end
2019-12-10 14:06:22 +00:00
Adriaan de Groot
1a8439069e
[libcalamares] Extend TZ with location and country
2019-12-10 15:36:53 +02:00
Adriaan de Groot
f4509f3380
[libcalamares] Move loading to TZRegion
...
- don't make the model load files, provide convenience functions
for loading in the value classes
- create model from lists of value pointers
2019-12-10 10:48:39 -01:00
Adriaan de Groot
da277fa7ba
[libcalamares] Drop superfluous enum
2019-12-10 17:42:32 +06:30
Adriaan de Groot
9a5e614172
[libcalamares] Build the TZRegion list in one pass
...
- read the file and create the regions on-the-fly, then sort the
resulting list (instead of building a string list and then
building the regions afterwards)
2019-12-10 17:24:33 +06:30
Adriaan de Groot
9f06903115
[local] Chase API change in TZRegionModel
2019-12-09 23:36:32 -11:00
Adriaan de Groot
01bba7b466
[libcalamares] Make explicit when a model comes from a file
2019-12-09 23:36:05 -11:00
Adriaan de Groot
afb5430c42
[locale] Use TZRegionModel
...
- instead of populating combo box with texts, use the model
read in from zone.tab
- this **partly** deprecates the LocaleGlobal stuff
2019-12-10 11:30:48 +02:00
Adriaan de Groot
2625bb18df
[libcalamares] TZRegionModel gets a data role
2019-12-10 11:27:02 +02:00
Adriaan de Groot
97235e9b3d
[libcalamares] Switch CStringPair key to QString
...
- the key is used in various places as a key for Qt data structures,
so it's more convenient to have QString than a bare char*
2019-12-10 10:11:08 +01:00
Adriaan de Groot
1d17cf5c77
[libcalamares] Accessors for key and complete region data
2019-12-09 17:20:46 -04:00
Adriaan de Groot
b29b89579e
[libcalamares] Present TZ regions in consistent order
2019-12-09 15:55:04 -05:00
Adriaan de Groot
b2c2255f6a
[libcalamares] Add a model of timezone regions
2019-12-09 21:46:10 +01:00
Adriaan de Groot
7d88b6d0cd
[license] Show filenames as filenames
...
- Use File: to display filenames, rather than URL: plus a file:-scheme
- Document the change in CHANGES
2019-12-09 20:47:32 +01:00
Adriaan de Groot
ddc2f60768
Merge branch 'master' into zone-data
2019-12-09 17:44:32 +01:00
Adriaan de Groot
ac1c0d97d2
[license] Prevent single item from expanding
...
- the last item would expand vertically to fill the scroll area;
add a spacer that pushes against it
2019-12-09 17:34:46 +01:00
Adriaan de Groot
59ea0417fc
[license] Move a less-useful message to tooltip
...
- the message about setup continuing can be a tooltip
2019-12-09 17:25:07 +01:00
Adriaan de Groot
c220220563
[license] Give stylesheets meaningful names
2019-12-09 17:14:35 +01:00
Adriaan de Groot
8a912e6ca1
[license] Fix the height of each item
...
- needs a qwidget to put the top-items (license name, button) in
- fixes issue where the gap between the button and the hrule would
change depending on what is expanded
2019-12-09 17:08:35 +01:00
Adriaan de Groot
7330afd96a
[license] Massage display of buttons
...
- try to keep them the same height
- show the URL that will be opened
2019-12-09 16:57:18 +01:00
Adriaan de Groot
6e1504fafc
[license] Use just one button
...
- replace the text plus toolbutton (which has an ambiguous arrow in it)
by a single button with text saying what it will do.
2019-12-09 14:52:54 +01:00
Adriaan de Groot
2d02290b91
Merge branch 'issue-1268'
...
FIXES #1268
2019-12-03 13:01:41 +01:00
Adriaan de Groot
9fa021e3c6
[license] Reduce margins hugely
...
- Move layouting code into the .ui file
- Reduce margins hugely -- atop the title block, around the
scroll area, etc -- so that more license is visible at once.
2019-12-03 13:00:12 +01:00
Adriaan de Groot
0b126b2c62
[license] Massage the messages some more
...
- split shared <h1> message off
- do some string-concatenation, but only of whole sentences
- shave off some vertical space by dropping the mainsubtext item
2019-12-03 12:49:11 +01:00
Adriaan de Groot
72ee9742f3
[tracking] Correct the example URLs
2019-12-03 12:24:47 +01:00
Calamares CI
a034b1a9ab
i18n: [dummypythonqt] Automatic merge of Transifex translations
2019-12-03 11:17:52 +01:00
Adriaan de Groot
5cb0ee6cc5
[welcome] Simplify code
...
- Kevin Kofler pointed out there was a redundant else-if
- Only use size for comparison if it's valid
2019-12-02 11:42:32 +01:00
Adriaan de Groot
7029c427f1
Merge pull request #1275 from bill-auger/patch-createusers-logging
...
housekeeping - logging for CreateUser Job
2019-12-02 11:38:34 +01:00
Adriaan de Groot
1a13704c71
[grubcfg] HOTFIX typo in function call
2019-11-30 21:46:45 +01:00
bill-auger
7510e883b8
pre-select default item in packagechooser
2019-11-30 02:23:05 -05:00
Adriaan de Groot
8b4bd52a26
[machineid][hostinfo] Reduce warnings
...
- stray ;
- clang-tidy had re-ordered the moc-warnings.h header, needs to go
**before** the .moc so split into its own group
2019-11-29 00:17:26 +01:00
Adriaan de Groot
bd5b63b02e
[summary][calamares] Chase deprecations in Qt (QWidget::background())
2019-11-29 00:17:02 +01:00
Adriaan de Groot
a70b7ad89e
[welcome] Chase deprecations in Qt (screen geometry)
2019-11-29 00:17:02 +01:00
Adriaan de Groot
c2ebfbf6ae
[users] Remove unused parameter (reduces warnings)
2019-11-29 00:17:02 +01:00
Adriaan de Groot
3c1b0e6730
[libcalamares] Reduce warnings with Clang 9 (yaml.h)
2019-11-29 00:17:02 +01:00
Adriaan de Groot
ac75c63001
[libcalamares] Reduce warnings with Clang 9 (Boost::Python)
...
- The boost headers fall foul of tons of Clang warnings, so introduce
a mechanism like moc-headers for turning off most of those warnings.
2019-11-29 00:17:02 +01:00
bill-auger
344445b437
housekeeping - logging for CreateUser Job
2019-11-28 14:26:06 -05:00
Adriaan de Groot
2e22bdd7dc
i18n: update the english translation files for once
2019-11-28 16:51:57 +01:00
Adriaan de Groot
b4e9ec7eb1
[hostinfo] There is no config file for this module
...
- the empty config file would fail in tests
- move the documentation part of it to CMakeLists.txt
2019-11-28 16:10:01 +01:00
Adriaan de Groot
1de6062233
[license] Add should-be-expanded display option to license entries
...
- In code, add the necessary bool
- document meaning in the config file
- actually expand the full text if the entry is local and set to expanding-
by-default. This implementation is a bit lazy since it just pretends
to click on the toggle button.
- While here, reduce scope for UB by initializing POD members
2019-11-28 13:42:26 +01:00
Adriaan de Groot
c870fca787
[license] Use more meaningful names for arrows
...
- The arrows Up, Down, Right are used on toolbuttons, but
in the context of this module, those are directions with
meaning; give them better names.
- Because of #1268 , the meaning of up- and down- may be swapped;
I'm not sure of which look makes the most sense. This is prep-
work for easily swapping the looks by using the meaningful names
instead.
SEE #1268
2019-11-28 13:23:11 +01:00
Adriaan de Groot
d322d783ea
[license] Chase deprecations in Qt
2019-11-28 13:17:15 +01:00
Adriaan de Groot
d8020e3574
[license] Tidy up setting-of-entries
...
- we loop over all the entries anyway, so calculate allLicensesOptional
along the way (debatable whether std::none_of is clearer)
- always un-check the accept-box when resetting entries.
2019-11-28 12:03:22 +01:00
Adriaan de Groot
5ed8ec9990
[license] Reduce translation overhead.
2019-11-28 11:28:02 +01:00
Adriaan de Groot
2a0716bf43
[license] Move the 'please review' text to the top.
2019-11-28 11:24:56 +01:00
Adriaan de Groot
2a45765b93
[license] Next depends not just on the checked box
...
- Toggling the checkbox could disable the next button
because only the checked-state was used, instead of
the next-is-enabled-if-everything-is-optional member variable.
FIXES #1271
2019-11-27 12:17:33 +01:00
Adriaan de Groot
ec605adf3f
[license] Tidy code
...
- Move retranslation to a separate slot to allow it to be
formatted nicely.
- Use calculated m_allLicensesOptional in retranslation.
- Untangle determining if all licenses are optional; std::none_of
returns true on an empty list.
2019-11-26 22:37:25 +01:00
Adriaan de Groot
6dfcbd757b
[welcome] Remove superfluous call to QColor::value()
2019-11-26 17:34:25 +01:00
Adriaan de Groot
7fd218d7bf
[partition] Chase deprecations in Qt
2019-11-26 16:56:45 +01:00
Adriaan de Groot
ad868033f3
[locale] Chase deprecations in Qt
2019-11-26 16:56:12 +01:00
Adriaan de Groot
fc7ea80d99
[calamares] Do not attempt to center Calamares window
...
- this isn't really a Calamares thing to decide, and anyway centering
on the desktop is kind of weird in multi-monitor setups and the
DesktopWidget is deprecated as well.
2019-11-26 16:46:47 +01:00
Adriaan de Groot
94fe4d2fda
[libcalamares] Avoid weak vtables in string-pair implementation
2019-11-26 12:30:59 +01:00
Adriaan de Groot
fc7f49b610
[libcalamares] Expand tests for TimeZone translations
2019-11-26 12:28:41 +01:00
Adriaan de Groot
71f3614eb7
[libcalamares] Add TimeZone support to build
...
- Add to CMakeLists.txt
- Test basic scenarios
2019-11-26 11:20:33 +01:00
Adriaan de Groot
3af2754022
[libcalamares] Implement translatable-pair-of-char*
...
- This is base functionality for a translatable model of
TimeZone names that is scraped from zone.tab
2019-11-26 11:18:35 +01:00
Adriaan de Groot
abd3c4171b
[libcalamares] Prevent CI coding-style fixes to generated code
2019-11-26 11:08:21 +01:00
Adriaan de Groot
733fb43b5e
[libcalamares] Sort the dummy zone names
2019-11-26 10:45:36 +01:00