Adriaan de Groot
59255c7a57
Changes: apply coding style
2020-11-05 00:00:29 +01:00
Adriaan de Groot
fea403186f
[libcalamares] Search for balance between warnings and annotations
...
- CI's gcc is too old to analyse a switch() for completeness,
so the CI build fails.
2020-10-25 17:49:26 +01:00
Adriaan de Groot
2b9fa0f982
CMake: drop the NOTREACHED macro
...
- both clang and g++ support __builtin_unreachable(); (as Kevin
Kofler pointed out) so we don't need the macro to do different things;
- the compilers have gotten better at detecting unreachable code,
so instead of inserting macros or fiddly bits, just drop them
and the unreachable code they comment.
2020-10-25 12:49:49 +01:00
Adriaan de Groot
81f12cb230
[libcalamares] Do GeoIP lookups with a fake User-Agent
2020-10-16 13:55:31 +02:00
Adriaan de Groot
436e1de820
[libcalamares] Be more chatty in GeoIP test application
2020-10-16 12:36:03 +02:00
Adriaan de Groot
a2180936ef
CI: apply coding style across the entire codebase again
2020-08-26 02:28:43 +02:00
Adriaan de Groot
1cd9b93a22
REUSE: Giant boilerplate cleanup
...
- point to main Calamares site in the 'part of' headers instead
of to github (this is the "this file is part of Calamares"
opening line for most files).
- remove boilerplate from all source files, CMake modules and completions,
this is the 3-paragraph summary of the GPL-3.0-or-later, which has
a meaning entirely covered by the SPDX tag.
2020-08-26 02:28:38 +02:00
Adriaan de Groot
ad3c0de936
[libcalamares] Reduce logging in POD manipulation
2020-08-06 14:27:55 +02:00
Adriaan de Groot
192263cf9d
[libcalamares][modules] Use compatibility for QString::split()
...
- Use the compatibility value, which has an enum value suitable
for the Qt version in use.
2020-06-23 11:13:55 +02:00
Adriaan de Groot
881187de8d
Merge pull request #1423 from Cal8031/t1
...
Update and add SPDX identifiers
2020-06-03 15:32:07 +02:00
Adriaan de Groot
ac2a9c569e
[libcalamares] Allow "fixed" as a GeoIP lookup type
2020-06-03 15:03:19 +02:00
Adriaan de Groot
672f506e72
[libcalamares] Add unittests for GeoIPFixed
...
- Ignores the data, just returns selector
2020-06-03 14:55:01 +02:00
Adriaan de Groot
d9effb4ba7
[libcalamares] Add GeoIPFixed to the test-tool for GeoIP lookup
...
- Allow format "fixed"
- Allow specifying the selector in the test-tool
2020-06-03 14:34:45 +02:00
Adriaan de Groot
d37ec35592
[libcalamares] GeoIP that always returns a fixed value
...
- Value is configurable (through the "selector" which is passed
to GeoIP lookups). This is convenient for tests so you can "fix"
the value that the lookup will return.
2020-06-03 14:26:14 +02:00
Callum Farmer
0c4dc71d5c
[libcalamares] Update SPDX identifiers.
...
Update CppJob.h
Update CalamaresConfig.h.in
Update DllMacro.h
Update GlobalStorage.cpp
Update GlobalStorage.h
Update Job.cpp
Update Job.h
Update JobExample.cpp
Update JobExample.h
Update JobQueue.cpp
Update CalamaresConfig.h.in
Update CppJob.cpp
Update CppJob.h
Update DllMacro.h
Update GlobalStorage.cpp
Update GlobalStorage.h
Update Job.cpp
Update Job.h
Update JobExample.cpp
Update JobExample.h
Update JobQueue.h
Update ProcessJob.cpp
Update ProcessJob.h
Update PythonHelper.cpp
Update PythonJob.cpp
Update PythonJob.h
Update PythonHelper.h
Update PythonJobApi.cpp
Update PythonJobApi.h
Update Settings.cpp
Update Settings.h
Update GeoIPJSON.cpp
Update GeoIPJSON.h
Update GeoIPTests.cpp
Update GeoIPTests.h
Update GeoIPXML.cpp
Update GeoIPXML.h
Update Handler.cpp
Update Handler.h
Update Interface.cpp
Update Interface.h
Update test_geoip.cpp
Update CountryData_p.cpp
Update Label.cpp
Update Label.h
Update LabelModel.cpp
Update LabelModel.h
Update CountryData_p.cpp
Update CountryData_p.cpp
Update Lookup.cpp
Update Lookup.h
Update Tests.cpp
Update Tests.h
Update TimeZone.cpp
Update TimeZone.h
Update TranslatableConfiguration.cpp
Update TranslatableConfiguration.h
Update ZoneData_p.cxxtr
Update cldr-extractor.py
Update zone-extractor.py
Update Actions.h
Update Actions.h
Update Descriptor.h
Update InstanceKey.cpp
Update Module.cpp
Update Module.h
Update Requirement.cpp
Update RequirementsChecker.h
Update RequirementsModel.cpp
Update RequirementsModel.h
Update Tests.cpp
Update Manager.cpp
Update Manager.h
Update Tests.cpp
Update FileSystem.cpp
Update FileSystem.h
Update KPMManager.cpp
Update KPMManager.h
Update KPMTests.cpp
Update FileSystem.cpp
Update FileSystem.cpp
Update FileSystem.h
Update KPMManager.cpp
Update KPMManager.h
Update Mount.cpp
Update Mount.h
Update PartitionIterator.cpp
Update PartitionIterator.h
Update PartitionIterator.h
Update PartitionQuery.cpp
Update PartitionQuery.h
Update PartitionSize.cpp
Update PartitionSize.h
Update Sync.cpp
Update Sync.h
Update Tests.cpp
Update Tests.h
Update BoostPython.h
Update CalamaresUtilsSystem.cpp
Update CalamaresUtilsSystem.h
Update CommandList.cpp
Update CommandList.h
Update Dirs.cpp
Update Dirs.h
Update Entropy.cpp
Update Entropy.h
Update Entropy.cpp
Update Logger.cpp
Update Logger.h
Update NamedEnum.h
Update NamedSuffix.h
Update PluginFactory.cpp
Update PluginFactory.h
Update RAII.h
Update RAII.h
Update Retranslator.cpp
Update Retranslator.h
Update String.cpp
Update String.h
Update TestPaths.cpp
Update Tests.cpp
Update Tests.h
Update UMask.cpp
Update UMask.h
Update Units.h
Update Variant.cpp
Update Variant.h
Update Yaml.cpp
Update Yaml.h
Update moc-warnings.h
2020-06-03 12:52:53 +01:00
Adriaan de Groot
88fc6685ba
[libcalamares] Apply coding style to geoip/
2019-09-05 03:23:28 -04:00
Adriaan de Groot
543e2d34fc
[libcalamares] [locale] Remove unused includes
2019-09-02 12:02:43 +02:00
Adriaan de Groot
8ea1ea6662
[libcalamares] Add synchronousGet() to network service
...
- Synchronous download of a given URL; not something to
do from the GUI thread.
- Use it from the GeoIP service, which downloads in a
separate thread to do GeoIP lookups.
- Drop now-unused headers.
- Adjust tests for GeoIP to use network service
2019-08-22 16:11:26 +02:00
Adriaan de Groot
115f5bfd82
[libcalamares] Apply coding style to remainder of geoip/
2019-08-08 12:41:41 +02:00
Adriaan de Groot
ec073ee188
[libcalamares] Apply coding style to geoip/
2019-08-08 12:32:21 +02:00
Adriaan de Groot
6e9f1be9e9
[libcalamares] Don't reformat string tables in GeoIP
2019-08-08 11:56:20 +02:00
Adriaan de Groot
68dc1f5e31
[libcalamares] Warn about badly-configured GeoIP
...
- Warn when type will be none
- Re-order warnings from general to specific
2019-06-18 12:33:56 +02:00
Adriaan de Groot
6183c4e2f4
[libcalamares] Add accessors for GeoIP handler attributes
2019-06-18 12:17:25 +02:00
Adriaan de Groot
10ba468748
[libcalamares] Avoid warnings / errors on both gcc and clang
...
- Clang 8 can detect that there is no need for a return if all
previous paths already return. GCC 8 does not. Clang warns if
the unreachable return is there, GCC errors out if it isn't.
- Introduce a hack NOTREACHED that comments-out on Clang, and
marks as unreachable (but still present) on GCC.
- This might go away with an [[unreachable]] annotation or
similar.
2019-05-14 05:29:18 -04:00
Adriaan de Groot
d048975f15
[libcalamares] One more nested namespace
2019-05-13 13:06:28 +02:00
Adriaan de Groot
0b0fb93e75
[libcalamares] Remove redundant default: in case
...
- the switch handles all values of the enum and the compiler should
be smart enough to know that (therefore default isn't needed,
nor the return afterwards).
2019-05-13 12:34:19 +02:00
Adriaan de Groot
2c94cbdb14
[libcalamares] namespace A::B is a C++17 extension
2019-05-13 12:34:19 +02:00
Adriaan de Groot
44559d24bd
[libcalamares] Selector wasn't saved for later queries
2019-05-09 15:09:58 -04:00
Adriaan de Groot
4ea29b1cf1
[libcalamares] Implement "raw" handling
2019-05-09 10:40:51 -04:00
Adriaan de Groot
9931b2df44
[libcalamares] Add "raw" support for extracting data from GeoIP
...
- This is prep-work for getting something other than the
timezone (e.g. most extended formats also support Country).
2019-05-09 10:15:53 -04:00
Adriaan de Groot
7899ab83f9
[libcalamares] Remove convenience API
2019-05-03 11:35:13 -04:00
Adriaan de Groot
44cbb0d374
[libcalamares] Drop alternate-config handling for GeoIP
...
- Dealing with legacy formats and alternate configurations
is something that consumers should do (and then hand off
to the 3-string constructor) instead.
2019-05-03 11:21:01 -04:00
Adriaan de Groot
fc76313ea6
[libcalamares] Implement GeoIP Handler config from map
...
- read map entries with alternate keys
- delegate to other constructor
2019-05-03 11:06:36 -04:00
Adriaan de Groot
d5fe86c394
[libcalamares] Use NamedEnum for named-enum wrangling
2019-05-03 11:00:57 -04:00
Adriaan de Groot
2f2adb3623
[libcalamares] Implement async GeoIP::Handler::query()
...
- do this the cheap way by splitting the synchronous API into a
free function and then calling that through QtConcurrent.
2019-05-02 11:17:55 -04:00
Adriaan de Groot
84a759a591
[libcalamares] Emphasise that GeoIP::Handler::get() is synchronous
...
- prep-work for also having an async API
2019-05-02 11:06:08 -04:00
Adriaan de Groot
ee6e8de31a
[libcalamares] Disable broken GeoIP providers
...
- The tests were querying broken or disabled GeoIP providers,
so remove them (this leaves only very few reliable free providers).
2019-05-02 08:38:31 -04:00
Adriaan de Groot
1da580f43d
[libcalamares] Implement Handler's synchronous query()
...
- Steal code from existing tests for a synchronous HTTP get,
then hand it off to the handler.
- Extend tests with Handler interpreting the same data.
2019-05-02 08:33:29 -04:00
Adriaan de Groot
9bc8d28800
[libcalamares] Shuffle GeoIP into a namespace
...
- Use CalamaresUtils::GeoIP for GeoIP code
- Name the public interface parts generically, while the
implementation details retain GeoIP<foo> names.
2019-05-02 07:25:48 -04:00
Adriaan de Groot
16413e7bdb
[libcalamares] Stub GeoIPHandler
...
- The handler class should deal with configuration and query
2019-05-02 06:55:41 -04:00
Adriaan de Groot
26b61a4ddb
[libcalamares] Make RegionZonePair type stronger
...
- Derive from QPair instead of being QPair
- Add isValid() for checking
- Convenience constructors
2019-05-02 06:16:08 -04:00
Adriaan de Groot
73a5e7dd62
[libcalamares] Put GeoIP in namespace
...
- Use consistent include-guard style
- Put things in namespace CalamaresUtils
2019-05-02 05:58:52 -04:00
Adriaan de Groot
ce909f00cc
[libcalamares] Drop unnecessary HAVE_XML
...
- Linking to QtXml gives us a -DQT_XML_LIB already, so use that.
2019-05-01 06:39:20 -04:00
Adriaan de Groot
7ec7278fd3
[libcalamares] [locale] Move GeoIP code to the library
2019-04-30 16:52:31 -04:00