dalto
152f99fb07
Remove useless emits
2022-05-13 17:24:07 -05:00
Adriaan de Groot
9e4b2d14cb
[libcalamares] Add a path parameter when creating descriptors
...
This allows us to print the path of a descriptor file in
error messages, which in turn makes it easier to find
problems with the descriptor files.
2022-03-28 12:29:47 +02:00
Adriaan de Groot
54385b7606
[libcalamares] Cut down config-file-loading log spam
2021-09-21 16:53:09 +02:00
Adriaan de Groot
a3a1350dc7
[libcalamares] Don't complain if there isn't a preset
...
- If the module knows about a preset, then it should be registered
even if there is not a value set for it specifically; this avoids
complaints from isEditable() for fields that are known, but
do not have a preset. (Reported by Anke)
2021-03-15 21:18:10 +01:00
Adriaan de Groot
a4c1f07521
[libcalamares] Reduce indentation-depth in apply() through early-return
2021-03-15 21:11:01 +01:00
Adriaan de Groot
33fec86ef6
[welcome] Improve logging of requirements-checking
...
- less chatty when 0-results come in
- compress the welcome debug to one output chunk
2021-03-15 20:53:59 +01:00
Adriaan de Groot
b4a21d7aca
[libcalamares] Add macro CONFIG_PREVENT_EDITING to handle uneditable fields
...
Boilerplate code for avoiding accidental setting of an internal
field when the UI is editable and the underlying data isn't.
2021-03-14 13:30:26 +01:00
Adriaan de Groot
2e90a8d829
[libcalamares] Report preset mis-configurations
...
- warn about fields applied twice (program error)
- warn about fields not used (configuration error)
- add operator<< for "clean" looking preset application
2021-03-14 12:14:33 +01:00
Adriaan de Groot
d8dff3dc65
[libcalamares] Replace loadPresets() with an applicative style
...
Build up the list of known presets by what the Config-object
expects, not by what the Config file provides. This allows
early detection of mis-matched configurations.
Presets can only apply to Q_PROPERTY properties, and the
preset must match the property name.
2021-03-14 12:14:33 +01:00
Adriaan de Groot
8b10a9cfc2
[libcalamares] Add isEditable() check
...
This adds support for checking whether a field is editable;
Config objects should reject changes if the field is not
editable. There is an "unlock" setting to override the
check, although this is currently always locked.
2021-03-14 12:14:33 +01:00
Adriaan de Groot
0be5e04c2e
[libcalamares] Add a base class for Config-objects
...
This is an optional (until 3.3) base class, which can handle
Presets consistently for configurations.
2021-03-12 13:49:37 +01:00
Adriaan de Groot
d9f2f5e988
[libcalamares] Start a 'presets' configuration datastructure
2021-03-12 13:16:36 +01:00
Adriaan de Groot
59255c7a57
Changes: apply coding style
2020-11-05 00:00:29 +01:00
Adriaan de Groot
b28a50de6f
[libcalamares] Remove useless variable
...
- describe() is for debugging purposes, doesn't need to calculate
whether the requirements are accepted.
2020-10-24 12:35:19 +02:00
Adriaan de Groot
2878c474c5
Warnings-- (~T() override)
...
Change all the places that had
virtual ~T() override
to the less redundant form without override.
2020-09-22 22:49:30 +02:00
Adriaan de Groot
8b66009d59
[libcalamares] Warnings-- in tests (~T() override)
2020-09-22 22:37:29 +02:00
Adriaan de Groot
a2180936ef
CI: apply coding style across the entire codebase again
2020-08-26 02:28:43 +02:00
Adriaan de Groot
1cd9b93a22
REUSE: Giant boilerplate cleanup
...
- point to main Calamares site in the 'part of' headers instead
of to github (this is the "this file is part of Calamares"
opening line for most files).
- remove boilerplate from all source files, CMake modules and completions,
this is the 3-paragraph summary of the GPL-3.0-or-later, which has
a meaning entirely covered by the SPDX tag.
2020-08-26 02:28:38 +02:00
Adriaan de Groot
c19866f887
[libcalamares] Add a module-weight to the module descriptor
2020-08-12 16:00:27 +02:00
Adriaan de Groot
efd7145f76
[libcalamares] Implement the interface-specific fields for descriptor
2020-08-12 09:06:47 +02:00
Adriaan de Groot
c8b96c278b
[libcalamares] Complete the generic module descriptor
...
- loads emergency, noconfig, requiredModules keys
- warns (and marks descriptor invalid) if there are unused / unknown
keys left over in the descriptor data.
2020-08-12 08:42:52 +02:00
Adriaan de Groot
e406ae1967
[libcalamares] Add name to module descriptor
...
- introduce basic tests of the data structure
- interpret name when passed in as descriptor data
2020-08-12 00:52:54 +02:00
Adriaan de Groot
65273a262b
[libcalamares] Start putting data into the module Descriptor
2020-08-12 00:33:08 +02:00
Adriaan de Groot
ee834a7abb
[libcalamares] Define interface for Module descriptor
...
- add fields -- all const, all bogus -- to the descriptor,
introduce a stub method to load the descriptor from
YAML data (e.g. read from module.desc)
- lighten the type-naming in Module a little, with usings
2020-08-11 22:26:12 +02:00
Adriaan de Groot
bdd6bdc3b2
[libcalamares] Migrate module type and interface to descriptor
...
- move the enums
- expose the named-enum functions for them
- **start** replacing Descriptor with something stronger; this fails
zero tests so it obviously wasn't tested at all
2020-08-11 22:26:12 +02:00
Adriaan de Groot
253e5610af
[libcalamares] Better type for the list of InstanceKeys
...
- *sequence* lists module instance keys; make the stored type of
those keys InstanceKey instead of QString
2020-08-11 16:32:44 +02:00
Adriaan de Groot
483c0a84f8
[libcalamares] Update SPDX in modulesystem/
2020-08-10 09:53:05 +02:00
Adriaan de Groot
21b4a36a91
[libcalamares] Remove empty .cpp file
...
- Requirement.cpp was there "just in case" the header grew
functions that need an implementation, but that seems
unlikely (the header is just a struct of POD).
2020-08-10 09:50:27 +02:00
Adriaan de Groot
88e5e98d29
[libcalamares] Use consistent type alias (Descriptor)
2020-08-04 10:19:40 +02:00
Adriaan de Groot
abe558f127
[libcalamares] Be more verbose when the requirements check is done
2020-06-08 08:33:48 -04:00
Callum Farmer
0c4dc71d5c
[libcalamares] Update SPDX identifiers.
...
Update CppJob.h
Update CalamaresConfig.h.in
Update DllMacro.h
Update GlobalStorage.cpp
Update GlobalStorage.h
Update Job.cpp
Update Job.h
Update JobExample.cpp
Update JobExample.h
Update JobQueue.cpp
Update CalamaresConfig.h.in
Update CppJob.cpp
Update CppJob.h
Update DllMacro.h
Update GlobalStorage.cpp
Update GlobalStorage.h
Update Job.cpp
Update Job.h
Update JobExample.cpp
Update JobExample.h
Update JobQueue.h
Update ProcessJob.cpp
Update ProcessJob.h
Update PythonHelper.cpp
Update PythonJob.cpp
Update PythonJob.h
Update PythonHelper.h
Update PythonJobApi.cpp
Update PythonJobApi.h
Update Settings.cpp
Update Settings.h
Update GeoIPJSON.cpp
Update GeoIPJSON.h
Update GeoIPTests.cpp
Update GeoIPTests.h
Update GeoIPXML.cpp
Update GeoIPXML.h
Update Handler.cpp
Update Handler.h
Update Interface.cpp
Update Interface.h
Update test_geoip.cpp
Update CountryData_p.cpp
Update Label.cpp
Update Label.h
Update LabelModel.cpp
Update LabelModel.h
Update CountryData_p.cpp
Update CountryData_p.cpp
Update Lookup.cpp
Update Lookup.h
Update Tests.cpp
Update Tests.h
Update TimeZone.cpp
Update TimeZone.h
Update TranslatableConfiguration.cpp
Update TranslatableConfiguration.h
Update ZoneData_p.cxxtr
Update cldr-extractor.py
Update zone-extractor.py
Update Actions.h
Update Actions.h
Update Descriptor.h
Update InstanceKey.cpp
Update Module.cpp
Update Module.h
Update Requirement.cpp
Update RequirementsChecker.h
Update RequirementsModel.cpp
Update RequirementsModel.h
Update Tests.cpp
Update Manager.cpp
Update Manager.h
Update Tests.cpp
Update FileSystem.cpp
Update FileSystem.h
Update KPMManager.cpp
Update KPMManager.h
Update KPMTests.cpp
Update FileSystem.cpp
Update FileSystem.cpp
Update FileSystem.h
Update KPMManager.cpp
Update KPMManager.h
Update Mount.cpp
Update Mount.h
Update PartitionIterator.cpp
Update PartitionIterator.h
Update PartitionIterator.h
Update PartitionQuery.cpp
Update PartitionQuery.h
Update PartitionSize.cpp
Update PartitionSize.h
Update Sync.cpp
Update Sync.h
Update Tests.cpp
Update Tests.h
Update BoostPython.h
Update CalamaresUtilsSystem.cpp
Update CalamaresUtilsSystem.h
Update CommandList.cpp
Update CommandList.h
Update Dirs.cpp
Update Dirs.h
Update Entropy.cpp
Update Entropy.h
Update Entropy.cpp
Update Logger.cpp
Update Logger.h
Update NamedEnum.h
Update NamedSuffix.h
Update PluginFactory.cpp
Update PluginFactory.h
Update RAII.h
Update RAII.h
Update Retranslator.cpp
Update Retranslator.h
Update String.cpp
Update String.h
Update TestPaths.cpp
Update Tests.cpp
Update Tests.h
Update UMask.cpp
Update UMask.h
Update Units.h
Update Variant.cpp
Update Variant.h
Update Yaml.cpp
Update Yaml.h
Update moc-warnings.h
2020-06-03 12:52:53 +01:00
Adriaan de Groot
5c8a99c77b
[libcalamares] After running the checker, re-compute satisfaction
...
- If nothing is added to the model (e.g. it is empty) then the satisfaction
still needs to be re-calculated (to true).
2020-05-12 17:06:16 +02:00
Adriaan de Groot
f856c07b04
[libcalamares] Move progress signal to RequirementsModel
...
- It is the requirements model (checking) that reports progress, and now
the model is accessible (ask for it with requirementsModel(), make the
messages come from there.
2020-05-12 16:09:13 +02:00
Adriaan de Groot
09b73dce06
[libcalamares] Implement the HasDetails role
2020-05-11 17:10:03 +02:00
Adriaan de Groot
153757933a
[libcalamares] Stop emitting signals with RequirementsList
...
- The architecture of letting someone build up a list of requirements
from data emitted by the ModuleManager is broken: if it gets loaded
later, it will miss data; passing around complicated objects is
no fun anyway. Get rid of it, on the way to "ModuleManager has
its own model of requirements".
2020-05-11 16:30:26 +02:00
Adriaan de Groot
9b0ea3f63d
[libcalamares] Remove runaround through free function
...
- Call into a method directly to do the work of adding
results from a single module.
2020-05-11 16:30:26 +02:00
Adriaan de Groot
b7c60cec66
[libcalamares] Re-vamp RequirementsChecker
...
- Give the ModuleManager a RequirementsModel -- that is the source
of truth about the module-requirements of the modules managed
by that particular ModuleManager.
- Let the RequirementsChecker operate on a given RequirementsModel.
2020-05-11 16:30:26 +02:00
Adriaan de Groot
039065ee4a
[libcalamares] Minor debugging support in RequirementsModel
2020-05-11 16:30:26 +02:00
Adriaan de Groot
d87d714b8d
[libcalamares] Make the requirements model more adaptable
...
- Either replace the list of results, or add to them
- Lock model while adding rows
2020-05-11 16:30:26 +02:00
Adriaan de Groot
0f5db0ba5e
[libcalamares] Remove direct access to model internals
...
- This was just for the ResultsListWidget, which can also use
normal role-based model access.
2020-05-11 16:30:26 +02:00
Adriaan de Groot
616fbb08f3
[libcalamares] Improve docs of RequirementsModel
2020-05-11 11:19:08 +02:00
Adriaan de Groot
e756cc8720
[libcalamares] Tidy RequirementsModel some more
...
- put signals in conventional place
- remove const int& parameter, that can just be int
- drop oddly-guarded code (that leaks memory); if the index (row)
being passed in, it's probably best to just crash
- remove unused signal warningMessageChanged
2020-04-02 22:14:27 +02:00
Adriaan de Groot
4e7020d030
[libcalamares] Polish model
...
- make signals consistent in carrying a parameter
- explain why there's no Q_ENUM
2020-04-02 22:04:34 +02:00
Adriaan de Groot
e5562a5069
[libcalamares] Move RequirementsModel to libcalamares (1/2)
...
- Add the model and support code to libcalamares. The model still
has some cruft that should be in the Welcome config.
2020-04-02 21:33:07 +02:00
Adriaan de Groot
d8ecd302e1
[libcalamares] Apply coding style
...
- minor space issues
- drop a blank line after moc-warnings.h to avoid if being sorted
downwards, after the MOC file it's protecting
2020-03-31 23:19:51 +02:00
Adriaan de Groot
1765412b61
[libcalamaresui] Move RequirementsChecker to libcalamares
...
- the checker only collects and calls requirements; it has no
UI component, and only manages data (and a thread to do the
checking). Move it out of the UI library.
2020-03-31 23:13:13 +02:00
Adriaan de Groot
7655584022
[libcalamaresui] Move Module to libcalamares
...
- The Module class has no UI-specific code in it; it's all about
loading and data-management. Move it out of the UI library.
2020-03-31 22:56:42 +02:00
Adriaan de Groot
4ddd1ecceb
[libcalamares] Move Requirement to libcalamares
...
- This isn't a UI component: a requirement can be checked and
reported-on without a UI entirely.
2020-03-31 22:13:30 +02:00
Adriaan de Groot
8d47751cb2
[libcalamares] Beautify debug output for InstanceKey
2020-01-24 22:53:14 +01:00
Adriaan de Groot
155db29ccf
[libcalamares] Add a ModuleSystem::Descriptor
...
- this is currently just an alias for QVariantMap, which is
the type already in use.
- future plan is to tighten this up and have an actual
Descriptor class that carries only the information
actually needed for the module descriptor.
2020-01-24 12:59:35 +01:00