Adriaan de Groot
6b659b6f48
[libcalamares] Apply current coding standard to locale/
2019-08-07 23:42:33 +02:00
Adriaan de Groot
8636689cea
[packagechooser] Fix tests when run from in-source build
2019-08-07 12:58:22 +02:00
Adriaan de Groot
251e16e72c
[libcalamares] Allow en_US locale for tests as well
2019-08-07 12:31:52 +02:00
Adriaan de Groot
20f43225b5
[packagechooser] Adjust AppData path for tests
...
- running tests by hand or from "make test" uses different paths.
2019-08-07 12:02:03 +02:00
Adriaan de Groot
781be3368e
[packagechooser] Remove bogus images
...
- KDE and GNOME selection images were drawn by me for the bogus
package model, and should not be used.
- Keep Calamares logo though, even if it doesn't make much sense
to use it in package selection.
- Keep the no-selection image since it might be used more often,
but it's not very good.
2019-08-07 11:57:02 +02:00
Adriaan de Groot
f3de320288
[packagechooser] Drop hard-coded data
...
- Now that the configuration can do all the things, we don't need
a hard-coded model with bogus entries.
2019-08-07 11:51:56 +02:00
Adriaan de Groot
194a562727
[packagechooser] Expand tests with override features
2019-08-06 22:51:14 +02:00
Adriaan de Groot
a4362dac65
[packagechooser] Change tests for modified API
2019-08-06 22:48:04 +02:00
Adriaan de Groot
5d4c3ea92c
[packagechooser] Don't give a default pixmap
2019-08-06 22:48:04 +02:00
Adriaan de Groot
0b72006ffb
[packagechooser] Use overrides on AppData for example
2019-08-06 22:48:04 +02:00
Adriaan de Groot
6ddae94628
[packagechooser] Allow to override some of AppData
...
- The ID and Screenshot entries might be weird in AppData (in particular,
a remove URL) so put those back under the control of Calamares even
when using AppData as the source of descriptions.
2019-08-06 22:48:04 +02:00
Adriaan de Groot
d72391942f
[packagechooser] Implement AppData loading
...
- An item can refer to *appdata* and load that, or provide
the data in the config file itself.
- Fix documentation about translations.
2019-08-06 15:55:27 +02:00
Adriaan de Groot
9a8b2c5a1e
[packagechooser] CHeck that AppData load was succesful
2019-08-06 15:45:14 +02:00
Adriaan de Groot
fb547364c7
[packagechooser] Complete parsing of AppData
...
- Document all the static inline methods that do the work
- Fill up a QVariantMap from <name>, <summary> and <description><p>
elements, and use that to initialize the PackageItem.
2019-08-06 15:36:34 +02:00
Adriaan de Groot
431c4de77f
[packagechooser] Use GUI for tests
...
- Because we'll be creating Pixmaps, we need to have a GUI main.
2019-08-06 15:19:20 +02:00
Adriaan de Groot
6821b14d00
[packagechooser] Enable logging in tests
2019-08-06 14:50:04 +02:00
Adriaan de Groot
beb5896fa2
[packagechooser] Start implementation of AppData loading
...
- Doing a manual read of the XML, since existing appdata libraries
don't seem to have a convenient entry for what I need.
- Expand tests to loading AppData (currently, they fail).
2019-08-06 14:50:04 +02:00
Adriaan de Groot
6c41151f80
[packagechooser] Just one screenshot, and mark package unused
2019-08-06 12:38:28 +02:00
Adriaan de Groot
6e05a1ef05
[packagechooser] Load translated strings as well
...
- This makes it possible to put the translations into the config
file, and have them displayed when the Calamares language changes.
2019-08-06 12:02:29 +02:00
Adriaan de Groot
4febe477cf
[libcalamares] Add isEmpty() to TranslatedString
...
- Massage the implementation a bit, don't insert a meaningless
copy of the key as the untranslated message.
- Add isEmpty() to check for presence of the untranslated message.
- Document API.
- Update tests.
2019-08-06 11:53:35 +02:00
Adriaan de Groot
8d3546f0b3
[packagechooser] Expand the example config with translated entries
2019-08-06 00:31:05 +02:00
Adriaan de Groot
6a8e10837d
[libcalamares] Drop unneeded debugging
2019-08-06 00:26:04 +02:00
Adriaan de Groot
fee2297e67
[packagechooser] Fix fallthrough situation
...
- Add a FALLTHRU macro to annotate fallthrough situations in both
Clang and GCC,
- Annotate intentional fallthroughs.
- Add missing break which meant that the selection mode was
always multiple-selection.
2019-08-06 00:24:53 +02:00
Adriaan de Groot
56db9e9341
[packagechooser] Use translated strings
2019-08-06 00:17:50 +02:00
Adriaan de Groot
fd75b33784
[libcalamares] Add default constructor to TranslatedString
2019-08-06 00:17:30 +02:00
Adriaan de Groot
3560ea6622
Merge branch 'master' into software-chooser
2019-08-06 00:08:21 +02:00
Adriaan de Groot
39b7e4c55f
Merge branch 'translatable-configuration'
2019-08-06 00:07:48 +02:00
Adriaan de Groot
764c775f08
[libcalamares] Tighten tests, add special case
...
- The tests should be run in C locale, otherwise the plain get()
function uses the current locale, which will fail (e.g. running
LANG=nl ./libcalamareslocaletest returns the Dutch strings for
plain get, which isn't what we expect).
- sr@latin is still special.
2019-08-06 00:05:24 +02:00
Adriaan de Groot
a9292d0c75
[libcalamares] Implement getting the string
2019-08-05 23:54:53 +02:00
Adriaan de Groot
50d74c4eca
[libcalamares] Add get() to the string
...
- Look up the translation of the requested string with the current
or a specific locale. This implementation is a stub.
- Add tests for the getter.
2019-08-05 23:37:25 +02:00
Adriaan de Groot
e0edd1f3e2
[libcalamares] Fix misleading comment, add accessor
...
- the sort order is not English-at-the-top
- add accessor for the locale ID.
2019-08-05 23:32:13 +02:00
Adriaan de Groot
28293ef77a
[libcalamares] Expand tests of TranslatableString
2019-08-05 23:30:51 +02:00
Adriaan de Groot
5d6ccfe8fc
[libcalamares] Adjust tests for new Esperanto support
2019-08-05 18:30:50 +02:00
Adriaan de Groot
18e2f2ae52
[libcalamares] Add tests for new TranslatedString
...
- Test that construction works as expected
- Add count() method to TranslatedString for testing purposes.
2019-08-05 17:57:32 +02:00
Adriaan de Groot
19ca1b3c30
[libcalamares] One missing bit of coding style
2019-08-04 23:00:03 +02:00
Adriaan de Groot
8ea4091c7b
[libcalamares] Add a TranslatedString class to locale/
...
- While QObject::tr and gettext give us translations **most** of the
time via the translation mechanism, we sometimes have strings
embedded in configuration files that need to be shown to people
as well. Follow the .desktop style in handling this.
- A key's value **might** be translated; use `key[lang]` for the
translation into one of the languages that Calamares understands.
Code that expects a translated (human-readable) string in a configuration
file can use TranslatedString to collect all the translations of a
given key, so that it displays the right string from the configuration
when needed.
2019-08-04 22:56:41 +02:00
Adriaan de Groot
1afa9c4d08
[libcalamares] Apply current coding style to all of libcalamares/
2019-08-04 22:24:55 +02:00
Adriaan de Groot
7fcb7be1e4
[libcalamares] Apply current coding style to libcalamares/locale/
2019-08-04 22:17:12 +02:00
Adriaan de Groot
43ba59361b
[libcalamares] Don't format generated files of CLDR data
2019-08-04 22:16:33 +02:00
Adriaan de Groot
fa2b94d931
[libcalamares] Apply current coding style to libcalamares/partition/
2019-08-04 22:13:58 +02:00
Adriaan de Groot
312865cdd9
[libcalamares] Fix build on FreeBSD
2019-08-04 22:09:53 +02:00
Adriaan de Groot
b8a74657f4
[libcalamares] Apply current coding style to libcalamares/utils/
...
- String.cpp needs special handling since part of it should
remain unchanged, the formatting is "special" there.
2019-08-04 22:01:56 +02:00
Adriaan de Groot
29b9a21f59
[libcalamares] Don't format files copied from KCoreAddons
2019-08-04 22:01:31 +02:00
Adriaan de Groot
b7f54a3866
[libcalamares] Don't break string tables by reformatting
2019-08-04 22:01:31 +02:00
Adriaan de Groot
b16354133d
[packagechooser] Switch to a list form
...
- Using id's as keys in a map orders them indeterminately -- in
practice, alphabetically by key. Switch to a list form so that
the products stick to the order they have in the config file
(which means distro's can list "preferred" versions at top).
2019-08-04 20:19:56 +02:00
Adriaan de Groot
9a52430e74
[packagechooser] Too many 'o's in test name
2019-08-04 20:04:32 +02:00
Adriaan de Groot
89dcae393e
Merge remote-tracking branch 'origin/master' into software-chooser
...
- Pull in build fix
2019-08-04 16:02:16 +02:00
Adriaan de Groot
791f9cbccb
[packagechooser] Read packages model from config
...
- add key *items* which will be used to fill up the model for
software products.
TODO: needs translation support
2019-08-04 16:00:55 +02:00
Adriaan de Groot
beeda24423
[libcalamaresui] Fix build of the PythonQt bindings
...
- Change to std::chrono::seconds wasn't tried against the (optional)
PythonQt bindings, leading to build failure. Reported by Phil (Manjaro).
FIXES #1210
2019-08-04 08:52:33 -04:00
Adriaan de Groot
adb939b2e8
[packagechooser] Word-wrap package descriptions
2019-08-04 00:11:50 +02:00
Adriaan de Groot
d5275d5e10
[packagechooser] Allow the model to set the introductory text
2019-08-04 00:08:41 +02:00
Adriaan de Groot
047a300a51
[packagechooser] Remove unneeded debug
2019-08-03 23:55:29 +02:00
Adriaan de Groot
140c0db7a4
[packagechooser] Set GlobalStorage packagechooser_<id>
2019-08-03 23:51:00 +02:00
Adriaan de Groot
c59ffc7765
[packagechooser] Set default ID as documented
2019-08-03 23:33:34 +02:00
Adriaan de Groot
b711c791bd
[packagechooser] Fix build, tidy code
2019-08-03 23:28:55 +02:00
Adriaan de Groot
87d7b2a5c0
[packagechooser] Allow setting an ID for the module's GS key
2019-08-03 23:24:30 +02:00
Adriaan de Groot
2f2080727d
Merge branch 'master' into software-chooser
2019-08-03 23:16:38 +02:00
Adriaan de Groot
ff6c6a360b
[calamares] Make UI work for test-loader
...
- Need to create just one QApplication (subclass) with the right
parameters for the UI to work.
- If the UI is enabled and it's a View module, then show the widget
rather than running the jobs.
2019-08-03 23:06:39 +02:00
Adriaan de Groot
f2fb49ce26
[calamares] Fix test-loader runtime
...
- Some view steps expect the module manager to be there, avoid
startup warnings by creating one.
2019-08-03 22:27:06 +02:00
Adriaan de Groot
e8f342c0a5
[calamares] Add test-loader option for UI
2019-08-03 22:22:21 +02:00
Adriaan de Groot
f53aaa8bf3
[calamares] Fix module loader for ViewModules
...
- The ViewManager needs branding information, which wasn't
initialized -- leading to crashes. Add -b option to give
a specific branding, and default to something take makes
sense when testing modules from the build directory.
- Allows the module to load; doesn't show the UI though.
2019-08-03 21:56:06 +02:00
Adriaan de Groot
2fd2e90bf0
[calamares] Always run module tester with verbose logging
2019-08-03 21:29:28 +02:00
Adriaan de Groot
76077743af
[packagechooser] Add configuration setting for selection mode
...
- Add a *mode* key to the configuration file
- Change some names around to be more consistent (not user-visible)
2019-08-03 15:45:00 +02:00
Adriaan de Groot
042852218f
[license] Apply current coding style
2019-08-03 14:52:38 +02:00
Adriaan de Groot
fb3204262c
[packagechooser] Remove unneeded forward declaration
2019-08-02 23:24:35 +02:00
Adriaan de Groot
9d026862a8
[packagechooser] Provide names for selection mode
2019-08-02 23:20:45 +02:00
Adriaan de Groot
ab7374628b
[packagechooser] Use sample screenshots
2019-08-02 17:17:53 +02:00
Adriaan de Groot
86d8db6bbf
[packagechooser] Enforce selection mode on the next-button
2019-08-02 17:13:35 +02:00
Adriaan de Groot
7609546d8b
[packagechooser] Add screenshots for example
2019-08-02 17:02:02 +02:00
Adriaan de Groot
2272d2ab43
[packagechooser] Add selection modes
...
- Introduce different selection modes (most don't work yet)
- Use model data in the main widget
2019-08-02 16:43:10 +02:00
Adriaan de Groot
86e2e6242f
[packagechooser] Warn about weird calling orders
2019-08-02 16:26:10 +02:00
Adriaan de Groot
a32dcdad86
[packagechooser] Support multiple selection modes
2019-08-02 16:25:26 +02:00
Adriaan de Groot
dc5cdbb38c
[packagechooser] Update other parts of the window on selection
2019-08-02 16:07:47 +02:00
Adriaan de Groot
f8d159dfa4
[packagechooser] Massage layout a bit
2019-08-02 15:32:14 +02:00
Adriaan de Groot
d1a85ba5ca
[packagechooser] Add a model for the list to use
...
- Model contents currently hard-coded
2019-08-02 13:05:46 +02:00
Adriaan de Groot
727290f75e
[packagechooser] Handle translation events (stub)
2019-08-02 11:09:12 +02:00
Adriaan de Groot
735d5d2683
[packagechooser] Add stub of module
...
Package chooser is a **low density** package selector -- unlike
netinstall which offers a high density tree view -- for picking
zero, one, or more items from a small collection of packages.
This can be used, e.g., for "pick exactly one desktop environment",
"pick zero or more text editors" which can then be installed
by another module. The UI is big and shiny (rather than netinstall's
text-based tree view) and isn't suitable for more than a dozen or
so items.
2019-08-02 10:57:12 +02:00
Adriaan de Groot
dab841df02
[fstab] Tighten up the *efiMountOptions* documentation
2019-08-02 09:27:54 +02:00
Adriaan de Groot
d76c33bd3a
[tracking] Tidy code some more
2019-08-02 09:19:15 +02:00
Adriaan de Groot
8186d5730a
[contextualprocess] Apply current coding style
2019-08-01 23:10:49 +02:00
Adriaan de Groot
a0430f76b7
[shellprocess] Apply current coding style
2019-08-01 23:10:20 +02:00
Adriaan de Groot
d363732302
[tracking] Use std::chrono where appropriate
2019-08-01 23:07:45 +02:00
Adriaan de Groot
5183200515
[tracking] Apply current coding style
2019-08-01 23:05:42 +02:00
Adriaan de Groot
e3ecb083a0
Merge branch 'strictly-typed-timeout'
2019-08-01 23:00:28 +02:00
Adriaan de Groot
a0854a999e
Modules: chase API change, use std::chrono::seconds
2019-08-01 22:59:06 +02:00
Adriaan de Groot
e2504627aa
[libcalamaresui] Chase timeout-type into the UI library
...
(TODO: move ProcessJobModule to libcalamares, it has no UI dependency)
2019-08-01 22:51:52 +02:00
Adriaan de Groot
cac07c1472
[libcalamares] Use std::chrono::seconds for timeouts
...
- Distinguish just-an-int from seconds all across the API
2019-08-01 22:47:42 +02:00
Adriaan de Groot
626fd8828a
Merge pull request #1206 from apt-ghetto/espMount
...
[fatab] Esp mount options
2019-08-01 19:15:36 +02:00
Adriaan de Groot
abd7ce2886
Merge branch 'master' into strictly-typed-timeout
2019-08-01 15:55:53 +02:00
Adriaan de Groot
bedff6b252
[netinstall] Log immediate failures
...
- If the request is immediately bad (e.g. because of a botched
url) then log that fact; in this case no finished() is ever
emitted.
2019-08-01 15:17:24 +02:00
Adriaan de Groot
82055f6854
[netinstall] Logging; code duplication
...
- If there was an error, the network reply was never deleted
- Improve logging to show where data is coming from
2019-08-01 14:31:25 +02:00
Adriaan de Groot
2bb66b8b9b
[preservefiles] Example with REQUIRES
...
- preservefiles generally needs to have the target filesystems
mounted, so that it can preserve to them; but you can also
configure it such that there is no need for mounted filesystems
(e.g. in OEM setup).
- Add an example line in CMakeLists.txt to show how that would be done.
2019-08-01 12:37:23 +02:00
Adriaan de Groot
b0bcdba867
[unpackfs] Needs mount before it
...
- The mount module must happen before unpackfs because that (mount)
module sets up the root mount point (in /tmp) and some other
variables needed later.
2019-08-01 12:37:03 +02:00
Adriaan de Groot
c19ce26e5f
[libcalamares] Expand GlobalStorage with load()
...
- Counterpart to save(), for JSON-style dumps
2019-08-01 12:25:42 +02:00
Adriaan de Groot
20cf0c8f3d
[libcalamaresui] Remove unused code
...
- This operator is declared, yet never defined or used. The definition
was removed in fb44fb97b6
.
2019-08-01 11:32:32 +02:00
Adriaan de Groot
58de7cea94
[calamares] Allow test-loading of View modules
...
The view modules need a QApplication, not just a core application,
and a ViewManager instance, so create those before really loading
the module.
2019-08-01 11:30:40 +02:00
Adriaan de Groot
566be48f16
libcalamaresui: rename and document pastebin method
2019-07-30 15:47:44 +02:00
Adriaan de Groot
2aae30f517
libcalamaresui: don't rely on translations to interpret button
...
- Keep the debug-failure-call in the code, but commented out
- Check ButtonRole, rather than the button's text, to see
which one it is.
2019-07-30 15:43:20 +02:00
Adriaan de Groot
675a35bb2e
libcalamaresui: when displaying pasted URL, don't be fancy
...
- Just call the static method and then quit, rather
than being careful about allocations.
2019-07-30 15:28:17 +02:00
Adriaan de Groot
fac9ccde88
libcalamaresui: document magic constants in question()
2019-07-30 15:15:41 +02:00