Commit Graph

2636 Commits

Author SHA1 Message Date
Adriaan de Groot
34761c4214 Clang: reduce 0-as-nullptr warnings 2017-09-20 09:24:22 -04:00
Adriaan de Groot
337903db09 Clang: reduce warnings about overriden destructors 2017-09-20 09:11:18 -04:00
Adriaan de Groot
9693d7a5bd Memory: clean up interface used to get memory (RAM) size 2017-09-20 09:11:02 -04:00
Adriaan de Groot
0c129f2460 Reduce third-part warnings a better way.
Thanks to Kevin Kofler for pointing out what I'd forgotten about
source-file flags. While at it, introduce a generic mechanism for
suppressing warnings in third-party code.

Mostly reverts 4930484931
2017-09-19 16:49:14 +02:00
Adriaan de Groot
b04a890798 Fix code using re-imported imageregistry 2017-09-19 16:49:14 +02:00
Adriaan de Groot
6010805935 Licensing: add header to imageregistry copyright
- mention that this is shipped as part of Calamares
         - SPDX info
2017-09-19 16:26:26 +02:00
Adriaan de Groot
a65bc7d756 Licensing: re-import ImageRegistry
- include full license headers,
 - copied from
   - repo: https://github.com/tomahawk-player/tomahawk/
   - rev:  00f602e10203b76fc28b4615868c567e6bd4ced4
   - path: src/libtomahawk/utils/ImageRegistry.cpp
2017-09-19 16:26:26 +02:00
Adriaan de Groot
d23818b27c Fix code using re-imported spinner 2017-09-19 16:26:26 +02:00
Adriaan de Groot
d2d59e6206 Licensing: add header to QtWaitingSpinner copyright
- mention that this is shipped as part of Calamares
     - SPDX info
2017-09-19 16:26:26 +02:00
Adriaan de Groot
553a66b326 Licensing: re-import QtWaitingSpinner
- include full license headers,
 - copied from
   - repo: https://github.com/snowwlex/QtWaitingSpinner
   - rev:  bb8f8987ca19406dc75704eb382ab52e981b773f

This revision *does not build* because the files have been renamed.
2017-09-19 16:26:26 +02:00
Adriaan de Groot
24f26ee7c8 Licensing: add header to QJsonModel copyright
- mention that this is shipped as part of Calamares
 - SPDX info
2017-09-19 16:26:23 +02:00
Adriaan de Groot
e5c0854e66 Licensing: re-import GPLv3 version of QJsonItem
- include full license headers,
 - copied from
    - repo: https://github.com/dridk/QJsonmodel
    - rev:  fbd4fb3b1c1311f69cd8ada9bbb7a89fd6fe171e
2017-09-19 15:57:46 +02:00
Adriaan de Groot
13807ceabf Licensing: add self
- to all the files I've touched recently
 - to (very incomplete) AUTHORS list

Licensing: add license info to top-level CMakeLists.txt
2017-09-19 15:57:25 +02:00
Adriaan de Groot
6d880b5631 Replace memory-size detection.
- drop use of dmidecode to determine exact physical memory size
 - use sysinfo() to find memory size (assumes linux 2.3.48 or later)
2017-09-19 15:57:25 +02:00
Adriaan de Groot
1c52f961a6 Refactor password-errors-indication (again)
- set message and status icon in one go
 - only check until an error is found
 - Mark TODO for passwordRequirements
2017-09-19 15:57:13 +02:00
Adriaan de Groot
d839f8e0b3 Passwords: introduce password-checking
- Introduce a map 'passwordRequirements' in users.conf,
   which is a list of named requirements. There are only
   two settings right now, min and max length, but
   additional checks can easily be added in UsersPage.cpp
   by defining additional lambda's to check the given
   password string.
 - Add PasswordCheck instances as needed, with functions
   to check acceptability and to produce messages on rejection.
 - Documentation in the users.conf file itself.

 - In passing, refactor setting of pixmaps on labels.

FIXES #790
2017-09-19 00:12:44 +02:00
Adriaan de Groot
ddb6455365 Revert be2338ff0 (intended just to reduce warnings)
- keep the calamaresstyle formatting changes,
 - drop shadowing and nullptr changes.

FIXES #805
2017-09-18 15:11:18 +02:00
Adriaan de Groot
a14e98ce95 Crashreporter: remove further reference to removed lib 2017-09-18 15:02:35 +02:00
Adriaan de Groot
4930484931 CMake: massage build of libcalamares
- Build also two OBJECT libraries,
 - Allow changing Clang warnings for third-party code.
2017-09-18 14:59:53 +02:00
Adriaan de Groot
eede92646d CMake: shuffle includes, drop useless (empty) QT_INCLUDE_DIR 2017-09-18 12:32:37 +02:00
Adriaan de Groot
ddf7b7fc90 CMake: remove superfluous indirection 2017-09-18 12:12:10 +02:00
Adriaan de Groot
a266ecb133 CMake: simplify definitions, distinguish kinds of sources 2017-09-17 06:48:07 -04:00
Adriaan de Groot
e5b59d472e Clang: warnings-- 2017-09-16 10:36:40 -04:00
Adriaan de Groot
c8fd11b103 Replace scandir with listdir, simplify loop
FIXES: ??
2017-09-16 07:01:55 -04:00
Adriaan de Groot
ca60a7fc16 Clang: warnings-- 2017-09-14 07:02:24 -04:00
Adriaan de Groot
342b819a1d Fix build (warnings--, but breakage++ is not good) 2017-09-14 06:59:34 -04:00
Adriaan de Groot
c6297f1db5 Clang: warnings-- 2017-09-14 06:34:31 -04:00
Adriaan de Groot
9f1cca5ec7 FS: use untranslated name to identify filesystem
Resolves issue where 'linuxswap' is translated to 'Linux-Swap',
for instance. FileSystem::name() provides a translated name,
not an untranslated one.

This should move to KPMCore.

FIXES #797
2017-09-14 06:34:18 -04:00
Adriaan de Groot
8b61b3ddc3 Merge pull request #802 from abucodonosor/pr-autologin2
CreateUserJob: do not force any autologin group
2017-09-14 03:28:34 -04:00
Adriaan de Groot
c9f4bc0cc8 Check for crypt(3), also on FreeBSD 2017-09-13 22:32:21 +02:00
Adriaan de Groot
edb1dbaa6e Clang: warnings-- 2017-09-13 22:32:21 +02:00
Gabriel C
5d241f8e09 CreateUserJob: do not force any autologin group
There is no need to force folks haing a random group
 bc that is a Distro think. SDDM/GDM works just fine without
 having a group for the user to autologin.
 Just setup a group in users.conf .. is why we have a configuration
 option for that.
2017-09-13 21:44:15 +02:00
Adriaan de Groot
da4fa6a63a Fix link / library name 2017-09-13 19:03:56 +02:00
Adriaan de Groot
bd37572fd8 Clang: reduce warnings 2017-09-13 19:03:56 +02:00
Adriaan de Groot
03d9dbe099 Clean up CMakeLists, linking 2017-09-13 18:29:56 +02:00
Adriaan de Groot
be2338ff08 Clang: reduce warnings 2017-09-13 08:03:18 -04:00
Adriaan de Groot
ec86922839 Find KPMCore 3.2 quietly, less frightening 2017-09-13 07:01:19 -04:00
Adriaan de Groot
d8a47bb8be Simplify dict() construction for fstab-lines 2017-09-13 06:13:28 -04:00
Gabriel C
b82042a078 fstab: fix btrfs with LUKS and systemd we forgot to fix that in #730 tested with efi/BIOS+LUKS+btrfs , efi/BIOS+btrfs 2017-09-13 10:58:33 +02:00
Adriaan de Groot
cb57de2e65 Clang: float -> qreal where it matches Qt API 2017-09-11 11:07:32 +02:00
Adriaan de Groot
297e97da19 Clang: tidy up warnings in logger 2017-09-11 11:03:25 +02:00
Adriaan de Groot
25de3aca6e Clang: don't shadow global int timezone 2017-09-11 09:42:21 +02:00
Philip
d2964cc71c [locale] default to the states
- see also 239c7534d2
2017-09-10 22:33:25 +01:00
Adriaan de Groot
9116718448 Clang: warnings-reduction 2017-09-10 15:19:36 -04:00
Adriaan de Groot
463615a1c0 Clang: don't shadow local variable names 2017-09-10 13:22:54 -04:00
Adriaan de Groot
764fb742ba Clang: clean up documentation markup 2017-09-10 13:22:54 -04:00
Adriaan de Groot
0b39e50cdc Clang: explicit char-initialization of ByteArray 2017-09-10 13:22:54 -04:00
Adriaan de Groot
3527c82327 Clang: make private internal class less visible 2017-09-10 13:22:54 -04:00
Adriaan de Groot
bd3786ebeb Clang: reduce warnings in various places 2017-09-10 13:22:32 -04:00
Adriaan de Groot
a06911e9aa Clang: refactor units-converters, reduce warnings 2017-09-10 13:22:32 -04:00
Adriaan de Groot
31fa9e4251 Clang: fix warnings on partition splitter
- initialize all the fields
 - member-initialization order
 - silence warnings about double<->int
 - drop unused parameter to setSplitPartition
2017-09-10 06:17:28 -04:00
Adriaan de Groot
3aa540a69e Clang: static constant usage strings 2017-09-10 06:17:28 -04:00
Calamares CI
5b97d2367a [dummypythonqt] Automatic merge of Transifex translations 2017-09-07 05:45:03 -04:00
Adriaan de Groot
3e5916157f A mounted partition cannot be resized or replaced
- add check for isMounted()
 - a device with a mounted partition cannot be (entirely) erased

FIXES #639
2017-09-07 04:55:44 -04:00
Adriaan de Groot
851379628c Reduce Qt runtime warnings.
- deleteLater() doesn't like nullptr (produces a warning, but is harmless)
 - reparenting across threads doesn't work, comment on that but leave
   it in, since this may be relevant for memory management.
2017-09-07 04:24:08 -04:00
Adriaan de Groot
cec7132d2c Swap + LUKS configuration.
Based on patches from crazy@frugalware.org and V3n3RiX.

(presumably) FIXES #730
2017-09-07 03:43:42 -04:00
Adriaan de Groot
cc26fc085a Merge pull request #787 from stikonas/master
kpmcore now requires passing sector size to FileSystem.
2017-09-06 07:54:06 -04:00
Adriaan de Groot
7e25909e18 YAML: refactor YAML-exception reporting
- both NetInstall (group data) and Locale (GeoIP) use network
   data returned as a source of YAML data. Try to explain
   parsing errors for both.

FIXES #786
2017-09-06 07:51:22 -04:00
Andrius Štikonas
252006ea25 kpmcore now requires passing sector size to FileSystem. 2017-09-06 12:24:51 +01:00
Adriaan de Groot
09decf8e06 YAML-NetInstall: log data errors.
When NetInstall receives YAML data, handle parser errors more gracefully:
show line and column, but because it's network data (not in a local file),
do some work to print out the actual data received.

FIXES #786
2017-09-06 05:47:11 -04:00
Adriaan de Groot
6c5199c9cc YAML: on error, report filename along with location 2017-09-06 05:10:33 -04:00
Adriaan de Groot
9096a9ebcd Remove overly-verbose debugging 2017-09-06 04:55:08 -04:00
Adriaan de Groot
73a75e837b Auto-resize the main window.
If the summary widget is large, it gets a scrollbar. This looks really
weird, so prefer to grow the installer window instead. Discussed with
@sitter and settled on this solution.

ViewSteps can signal the ViewManager that they need more space (in pixels),
which may or may not be honored.

FIXES #778
2017-09-05 10:51:54 -04:00
Adriaan de Groot
ec265c073a One more have_dracut check (thanks to @crazy) 2017-09-05 06:09:50 -04:00
Adriaan de Groot
360a114ed4 Be more explicit on why a device is winnowed from the list 2017-09-05 06:09:50 -04:00
Adriaan de Groot
78ef69af02 i18n: update source translations 2017-09-04 08:17:38 -04:00
Adriaan de Groot
e9e6834dd8 Locale: translate OK, Cancel buttons in language selection (reported on IRC) 2017-09-04 07:57:20 -04:00
Adriaan de Groot
e13f7898ac Make check for dracut more readable 2017-09-04 06:42:51 -04:00
Adriaan de Groot
47dcbefe2c Apply patch from V3n3RiX.
https://gitlab.com/redcore/redcore-desktop/raw/master/app-admin/calamares/files/calamares-3.1.1-luks-fstab-write-devmapper.patch

Fixes #772
2017-09-04 06:33:01 -04:00
Adriaan de Groot
b22bd67a5f Avoid race condition around libparted device use.
FIXES #782
2017-08-31 05:28:58 -04:00
Adriaan de Groot
798640be0d PEP8 whining 2017-08-31 04:51:34 -04:00
Adriaan de Groot
11ff935453 Merge branch 'valgrind' 2017-08-31 04:16:31 -04:00
Adriaan de Groot
0e96621b94 Don't leak memory when winnowing disk devices
- Improve logging a little
 - Don't leak Device*, but delete the raw pointer when erasing
 - Document that DeviceInfo takes ownership and doesn't leak
2017-08-31 04:14:52 -04:00
Adriaan de Groot
e26d5ab206 Don't leak memory for allocated modules 2017-08-31 04:13:52 -04:00
Adriaan de Groot
d5dca07e22 Fix uninitialized values (valgrind report) 2017-08-31 04:13:18 -04:00
Adriaan de Groot
a4f4d417a2 Packages module: improve translated progress reporting
- Reduce number of strings a bit
 - Less confusing translation requirements (I hope)
 - Report on progress between groups
2017-08-31 03:51:18 -04:00
Adriaan de Groot
a31c4b4cb3 Packages module: better progress reporting
- introduce multiple modes (remove, install) to
   distinguish progress messages
 - handle plurals via gettext
 - fix PEP8 whining from previous
2017-08-30 17:37:04 -04:00
Adriaan de Groot
e1a93987d0 Packages module: add progress reporting
Adds i18n to the module (but these strings are not yet extracted),
and reports progress as each group of packages is installed.

FIXES #781
2017-08-30 10:09:28 -04:00
Adriaan de Groot
8dd1b7ed4a Merge branch 'distro-example'
This was WIP, working on the fstab / UUID problem, but stands on its
own; since others are zooming in on the fstab / UUID problem, close
down the branch.
2017-08-30 08:18:12 -04:00
Adriaan de Groot
1ea79efce8 Uninitialized value 2017-08-29 14:00:48 -04:00
Adriaan de Groot
162de207c8 Package module: extensive documentation of options 2017-08-29 10:34:38 -04:00
Adriaan de Groot
3799a26b3c Package module: optimize & fix
- Expand example configurations
 - Optimize commoon case of just listing package names
 - Do locale substitution in both kinds of cases
2017-08-29 06:58:30 -04:00
Adriaan de Groot
6c36534206 Package module: fix packages-could-be-objects code
- Check for 'list' when it's actually a 'dict' is strange.
   Reverse logic to consider 'str' a package name and everything
   else is special.
 - Refactor to handle the difference between package names and
   packages-with-script-data in one place.
 - Add code and config documentation.
 - Switch sample configurations to dummy-backend.
2017-08-29 05:51:30 -04:00
Adriaan de Groot
d66434985e Package module: refactor package-manager into multiple classes 2017-08-29 05:51:29 -04:00
Adriaan de Groot
913521d022 Testing: set more locale-globals in testing-script.
When testing Python modules, passing option --lang should also
set the global 'locale' (to a BCP47 string, but hey) like it
already sets localeConf.LANG.
2017-08-29 05:51:29 -04:00
Adriaan de Groot
c5abfd6371 Having a mounted partition should not disqualify the entire device.
FIXES #780
(should reopen #639 for double-checking)
2017-08-28 06:01:11 -04:00
Adriaan de Groot
85595b4e04 #780: check for isMounted(), not for where-would-it-be-mounted 2017-08-28 05:54:04 -04:00
Adriaan de Groot
7791c3cb19 DeviceInfo: refactor translation of DeviceInfoPage
- For Boot and Device info widgets, add a retranslateUi() method,
   since the labels change not only in response to translation
   events but also UI events.

FIXES #779
2017-08-28 05:44:43 -04:00
Adriaan de Groot
7e66499f36 Refactor check for EFI system.
The TODO stands, to delegate this to KPMCore.
2017-08-28 05:36:45 -04:00
Adriaan de Groot
186f6cd1e2 initcpiocfg: accept (but warn) for missing config file in the host 2017-08-23 17:33:03 -04:00
Adriaan de Groot
106f18e074 Log process output of failed commands
FIXES #612
2017-08-23 16:44:09 -04:00
Adriaan de Groot
63f9c25611 Update unpackfs.conf examples and documentation 2017-08-23 06:57:11 -04:00
Adriaan de Groot
3188a47fba Bump version numbers on the example distro 2017-08-23 06:51:45 -04:00
Adriaan de Groot
89c2c8a76e Suppress success-notification on failure 2017-08-23 05:25:07 -04:00
Adriaan de Groot
2c81fceacb Python: KeyError because pretty_name may not exist 2017-08-23 04:59:04 -04:00
Calamares CI
2f5638c34e [dummypythonqt] Automatic merge of Transifex translations 2017-08-22 05:08:39 -04:00
Adriaan de Groot
52f1ac63e3 Update translation sources 2017-08-21 17:58:06 -04:00
Calamares CI
704901762e [dummypythonqt] Automatic merge of Transifex translations 2017-08-21 17:51:44 -04:00
Adriaan de Groot
b3a46c7506 Merge branch 'i18n-pythonjob' 2017-08-21 17:50:16 -04:00
Adriaan de Groot
93115b7385 Popup notification when the installation is done.
- Use DBus and FreeDesktop interface to popup message
 - Code style / formatting

FIXES #599
2017-08-21 17:49:38 -04:00