Adriaan de Groot
2a61116b3c
[partition] Disable swap choice for replace & alongside
2018-10-08 15:32:02 -04:00
Adriaan de Groot
779542a5d1
Merge branch 'master' into fix-swap-ui
2018-10-08 13:56:28 -04:00
Adriaan de Groot
292bc57523
[partition] Fix build with suitable operator <<
2018-10-03 13:49:52 -04:00
Adriaan de Groot
b38316365e
[partition] Be more verbose about why UI buttons appear
2018-10-03 13:58:50 +02:00
Adriaan de Groot
29bae61610
Merge branch 'master' into fix-swap-ui
2018-10-01 03:21:06 -04:00
Adriaan de Groot
e3bf9fc220
[partition] Fix build with KPMCore <= 3.3.0
...
- Reported by Philip Mueller
2018-09-21 16:19:05 -04:00
Adriaan de Groot
d2f4079a18
[partition] Move partitioning options into a class
...
- As (auto) partitioning grows more options, the parameter
list becomes more unwieldy. Add some structure to it.
2018-09-17 06:42:14 -04:00
Adriaan de Groot
5136021416
[partition] Move SwapChoice to another namespace
...
- The choice of swap needs to be handled in more places,
so make the enum available in the partition module core instead
of just inside the choice page.
2018-09-13 06:29:59 -04:00
Adriaan de Groot
846e496d76
[partition] Tidy includes
2018-09-13 05:50:46 -04:00
Adriaan de Groot
959cd7b224
[partition] Simplify creation of comboboxes for swap choices
2018-09-13 04:45:36 -04:00
Adriaan de Groot
cfa940b35c
[partition] Support translations of swap choices
...
- Introduce enum to indicate what is selected
- Support translations
- Fill selections for erase
2018-09-12 11:18:17 -04:00
Adriaan de Groot
7d0451fe69
[partition] Rename Choice -> InstallChoice
...
- There are more choices to be made (or to come) when partitioning,
so don't take the most generic term for one enum.
2018-09-12 10:16:48 -04:00
Adriaan de Groot
10f7bac2df
[partition] Reorder initialization
2018-09-12 10:05:14 -04:00
Adriaan de Groot
c3f3276188
[partition] Improve presentation of swap options
2018-09-12 09:20:44 -04:00
Adriaan de Groot
dc492b301c
[partition] Drop label on swap-options box
2018-09-12 08:42:21 -04:00
Adriaan de Groot
a791818a65
[partition] Add swap drop-down
...
- This is WIP; the drop-down contents should be customised,
depending on configuration and the state of the device being
installed-to.
2018-09-12 08:18:45 -04:00
Adriaan de Groot
c813375908
[partition] Prepare for swap options
...
- Extend PrettyRadioButton with options (combo-boxes which may
be added later).
2018-09-12 08:09:01 -04:00
Caio Carvalho
01a972c6ea
[partition] Fixing LVM LV name line edit visibility.
2018-08-13 13:05:41 -03:00
Caio Carvalho
b5a2a5bbdd
[partition] Don't show erase button for inactive RAID.
2018-08-13 12:26:00 -03:00
Caio Carvalho
7fd0ad5795
[partition] Disabling partition buttons for inactive RAID.
2018-08-13 09:51:35 -03:00
Adriaan de Groot
5d5feeb0ab
Merge branch 'master' of https://github.com/cjlcarvalho/calamares into lvm-update
2018-06-28 23:48:13 +02:00
Caio Carvalho
589628bb9a
[partition] Removing unnecessary horizontal spacer on Partition Page.
2018-06-26 01:44:35 -03:00
Caio Carvalho
67d9ebbfc0
[partition] Setting revertButton enabled after deactivating VG.
2018-06-26 01:29:57 -03:00
Caio Carvalho
295e14530e
[partition] Adding resizing, deactivating and removing procedures for LVM VGs.
2018-06-26 00:38:52 -03:00
Adriaan de Groot
9d17e7210a
[partition] Change shortcut for "Create" to 'a'
...
Untangle the shortcuts; Create and Cancel had an overlap.
Skip 'r' (Revert all changes) and 'e' (Edit) and settle on
'a' (which might also mean "Add").
FIXES #977
2018-06-18 13:28:35 +02:00
Adriaan de Groot
dd8e53dc22
Copyright: update copyright lines on files touched in 2018
...
Contributions from:
Adriaan de Groot <groot@kde.org>
Gabriel Craciunescu <crazy@frugalware.org>
AlmAck <gluca86@gmail.com>
Andrius Štikonas <andrius@stikonas.eu>
Caio Carvalho <caiojcarvalho@gmail.com>
Raul Rodrigo Segura <raurodse@gmail.com>
2018-06-15 05:59:11 -04:00
Caio
0465cc4214
[partition] Including revert on creation of LVM VGs.
2018-06-08 20:20:05 -03:00
Caio
208d58bcd9
[partition] Including CreateVolumeGroupDialog and fixing some of its GUI issues.
2018-06-07 17:22:22 -03:00
Caio
d15ce56c97
[partition] Initial implementation of VolumeGroupBaseDialog.
2018-06-04 16:31:58 -03:00
Adriaan de Groot
90a2e482be
[partition] Check for available partition type before creating
...
- Avoid situation where you make 5 or more primaries in an
MSDOS partition table.
FIXES #953
2018-05-16 10:56:06 -04:00
Adriaan de Groot
bd57f1f2f1
[partition] Fix re-editing a newly created partition
...
- If there is a partition already (newly) created, then pass that
to the dialog so that it can use the setings previously applied
(e.g. mount point and flags).
- This avoids the case where you create or format a partition,
then click on it again to edit it and the previous settings are lost.
2018-05-16 09:14:50 -04:00
Adriaan de Groot
ca03dad67b
[partition] Refactor setting the flags UI
...
- Setup the lsit of flags consistently, by providing the available
and to-be-checked flags.
- In CreatePartitionDialog, assume that ~0 is all the flags.
2018-05-16 09:07:45 -04:00
Adriaan de Groot
4f451eece5
[partition] Refactor getting the checked flags
2018-05-16 08:41:47 -04:00
Adriaan de Groot
950cc9070d
[partition] Rename MountPoints to PartitionDialogHelpers
...
This file is full of helper functions for the partition-editing
dialogs. At first it was just mount-point helper functions,
but there is other functionality that can be refactored.
2018-05-16 08:34:33 -04:00
Adriaan de Groot
0df304b206
[partition] Preserve desired partition flags
...
- Use the desired (future) flags, if set, to initialize the
flags checkboxes. If there are no future flags set, this
returns active flags as before.
- This fixes the situation where editing a partition, changing
flags, then editing it *again* re-starts with the original
flags instead of the modified flags.
2018-05-16 07:19:34 -04:00
Adriaan de Groot
5b4668822d
[partition] Also update combo box index when setting up
...
- Avoids case where you edit a partition with a mountpoint
set; previously, calling setText() would update the text
but leave the selected index unchanged (usually 0), so that
later calling selectedMountPoint() would return empty.
2018-05-16 06:15:33 -04:00
Adriaan de Groot
323d20d1a5
[partition] Avoid sneaking an empty string into the mount points combo
2018-05-15 08:26:01 -04:00
Adriaan de Groot
255a99d714
[partition] Drop now-unneeded debugging
2018-05-15 08:13:15 -04:00
Adriaan de Groot
310555f16b
[partition] Add /srv to standard mount-points list.
2018-05-15 08:06:45 -04:00
Adriaan de Groot
4402198b37
[partition] Centralize setting-of-mountpoint
...
- map empty to the 0'th index
- add new entries as needed
This avoids having selected index 0, but a different text.
2018-05-15 08:01:18 -04:00
Adriaan de Groot
a49c39bb53
[partition] Unmap mount-point special strings
...
- Reverse "(no mount point)" to the empty string
- Provide convenience pointer-taking function
2018-05-15 06:30:18 -04:00
Adriaan de Groot
a4997c4be8
[partition] Convenience for selecting default mount point
...
- map blank to the "(no mount point)" string for UI purposes
2018-05-15 06:13:19 -04:00
Adriaan de Groot
fda2e54e0f
[partition] Refactor filling combobox with moint points
...
- Move to one place which handles the standard mount points
- While here, introduce explicit "(no mount point)" string
into the combo box. This is prep-work for issue #951 .
2018-05-15 05:40:52 -04:00
Caio Carvalho
77d2667b53
[partition] Checking if there is LUKS creation support and if partition is not Extended before enabling encryption in CreatePartitionDialog.
2018-05-08 01:30:41 -03:00
Andrius Štikonas
1b21668bff
[partition] Switch to scoped Device enums.
2018-04-18 23:59:15 +03:00
Adriaan de Groot
3315df5df1
[modules] Use new convenience logging methods across the board
2018-02-13 11:07:12 +01:00
Adriaan de Groot
0b03d56a40
i18n: Massage code to help lupdate understand
2018-02-07 17:43:26 +01:00
Adriaan de Groot
e3b7a2884b
[partition] Relax check with UI-level warning message, too
2018-01-09 11:15:30 -05:00
Adriaan de Groot
05967311de
[partition] Be defensive against no device-device-available.
...
Scenario is this: you have no suitable installation devices on
your system (everything is mounted, or HDD has died), click through
to partition page, where you have all the buttons available, but no
devices in the list. The following actions then cause a crash:
- clicking "back"
- clicking any button
Prevent that:
- you can click "back", but if there is no device selected
nothing happens to the device state (no nullptr deref,
and no crash)
- button code is now more resilient to this scenario
- buttons are hidden until a device is available, so you
can't even click on them to trigger the code.
2018-01-09 06:58:46 -05:00
Adriaan de Groot
1a42b8af41
Merge branch 'kpmcore-3.2'
...
- Bumps requireed KPMCore to 3.3 (in spite of the branch name)
- Cleans up some dependencies
Thanks to Andrius Stikonas.
2018-01-02 13:25:11 +01:00
Adriaan de Groot
762ad54344
Documentation: change http links to GitHub to https
2017-12-20 08:39:09 -05:00
Chantara Tith
2a785bdf89
Disable newPartitionTableButton for LVM device.
2017-11-11 21:47:30 +00:00
Andrius Štikonas
4912d8a6c2
Fix create partition job to work with LVM devices.
2017-10-09 17:31:22 +01:00
Adriaan de Groot
e3e519c06f
Clang: reduce warnings, nullptr, unused parameters
2017-09-21 04:04:01 -04:00
Adriaan de Groot
d23818b27c
Fix code using re-imported spinner
2017-09-19 16:26:26 +02:00
Adriaan de Groot
13807ceabf
Licensing: add self
...
- to all the files I've touched recently
- to (very incomplete) AUTHORS list
Licensing: add license info to top-level CMakeLists.txt
2017-09-19 15:57:25 +02:00
Adriaan de Groot
ca60a7fc16
Clang: warnings--
2017-09-14 07:02:24 -04:00
Adriaan de Groot
9116718448
Clang: warnings-reduction
2017-09-10 15:19:36 -04:00
Adriaan de Groot
31fa9e4251
Clang: fix warnings on partition splitter
...
- initialize all the fields
- member-initialization order
- silence warnings about double<->int
- drop unused parameter to setSplitPartition
2017-09-10 06:17:28 -04:00
Adriaan de Groot
3e5916157f
A mounted partition cannot be resized or replaced
...
- add check for isMounted()
- a device with a mounted partition cannot be (entirely) erased
FIXES #639
2017-09-07 04:55:44 -04:00
Adriaan de Groot
851379628c
Reduce Qt runtime warnings.
...
- deleteLater() doesn't like nullptr (produces a warning, but is harmless)
- reparenting across threads doesn't work, comment on that but leave
it in, since this may be relevant for memory management.
2017-09-07 04:24:08 -04:00
Adriaan de Groot
d5dca07e22
Fix uninitialized values (valgrind report)
2017-08-31 04:13:18 -04:00
Adriaan de Groot
1ea79efce8
Uninitialized value
2017-08-29 14:00:48 -04:00
Adriaan de Groot
7791c3cb19
DeviceInfo: refactor translation of DeviceInfoPage
...
- For Boot and Device info widgets, add a retranslateUi() method,
since the labels change not only in response to translation
events but also UI events.
FIXES #779
2017-08-28 05:44:43 -04:00
Adriaan de Groot
7e66499f36
Refactor check for EFI system.
...
The TODO stands, to delegate this to KPMCore.
2017-08-28 05:36:45 -04:00
Lisa Vitolo
9be15e68b6
Change both size box suffices to MiB.
2017-07-09 18:20:00 +01:00
Lisa Vitolo
925d3a61a7
Add "MB" suffix to the "edit partition" size box.
...
Makes it easier to know which unit Calamares is using when
resizing a partition. The "Create partition" dialog has
it already.
2017-07-09 10:10:04 -04:00
Adriaan de Groot
3c3c0f99f8
C++ trickery, part two: shorten code
2017-07-04 08:42:14 -04:00
Adriaan de Groot
ee4e4dfccc
C++ trickery to make the code shorter to read.
2017-07-03 18:07:18 -04:00
Adriaan de Groot
c0b3f3fe9d
Clang: reduce warnings; make enum-switch explicit
2017-06-28 05:49:53 -04:00
Adriaan de Groot
7ebbcc33b2
Partitionmanager: remove unused code files
2017-06-20 07:23:04 -04:00
Teo Mrnjavac
6545443b24
Documentation++
2017-03-03 12:32:44 +01:00
Teo Mrnjavac
3aebb79d30
Add optional config value neverCreateSwap in partition module.
...
CAL-458 #close The feature has landed in master, please test.
2017-02-09 18:08:47 +01:00
Ramon Buldó
f0b4a21b2d
partition: use always double click to activate a partition tree view item
...
Using activated signal may use single or double click depending on environment settings
2017-02-07 17:58:56 +01:00
Teo Mrnjavac
06b1d4abd2
Don't hardcode /dev/sd* as device path.
2017-02-02 16:59:17 +01:00
Teo Mrnjavac
f4732de975
Always write bootloader path.
2017-01-18 19:38:12 +01:00
Teo Mrnjavac
45adde11e1
Do not write bootloader install path if the system is EFI.
2017-01-18 12:11:25 +01:00
Teo Mrnjavac
a59a79a816
bootloaderInstallPath only applies if !isEfi.
2017-01-12 13:28:34 +01:00
Teo Mrnjavac
f3848cd428
The sender QObject should be in scope so the bootloader path is written.
...
CAL-388
CAL-417
CAL-441
2017-01-10 14:46:07 +01:00
Teo Mrnjavac
c158893b22
Style + translation.
2017-01-04 15:28:09 +01:00
Teo Mrnjavac
2aeadf9682
Better to keep font style manipulation to a minimum.
2017-01-04 15:28:09 +01:00
Teo Mrnjavac
e9f113a6a8
Translate user-visible strings!
2017-01-04 15:28:09 +01:00
Teo Mrnjavac
028f56d94a
Better to keep font style manipulation to a minimum.
2017-01-04 15:28:09 +01:00
Teo Mrnjavac
3ec7c6f881
Style.
2017-01-04 15:28:09 +01:00
Lisa
02abc0d0a7
Merge pull request #276 from shainer/mountpoint
...
Disallow assigning the same mountpoint to two partitions
2016-12-31 18:49:05 +01:00
Teo Mrnjavac
45315e6ae9
Improve debug output for bootloader code path.
2016-12-02 18:36:02 +01:00
shainer
2759529841
Remove current partition's mountpoint from used list.
...
This means that when we edit a partition, we don't consider
its current mountpoint invalid because it is already in-use.
We need to do this for both "edit existing partition" and
"edit a partition that we are still creating".
2016-11-20 23:19:33 +00:00
shainer
349470ae71
Check mountpoints when editing a partition too.
2016-11-20 23:06:03 +00:00
shainer
8c1199df2d
Check first selection of mountpoint too.
...
When opening the dialog.
2016-11-20 23:05:44 +00:00
shainer
f51b05e8aa
Get the mountpoint from PartitionInfo.
...
The Partition object includes the root mountpoint in
the partition mountpoint, which is not what we want.
2016-11-20 22:46:28 +00:00
shainer
c8dbeb5341
Avoid creating a new partition with a used mountpoint.
...
We get the mountpoints already used by other partitions, and
disable the Ok button in the "Create new partition" dialog if
the user selects/writes a mountpoint which is already used.
We are going to do the same in the Edit partition dialog
after testing.
2016-11-20 22:05:55 +00:00
Teo Mrnjavac
83b51a5867
Show warning.
2016-11-17 19:03:24 +01:00
Teo Mrnjavac
17fe2d82f4
Oops.
2016-11-17 18:28:58 +01:00
Teo Mrnjavac
a55bef5d2d
Warn user about encrypted root with unencrypted /boot.
2016-11-17 18:15:37 +01:00
Teo Mrnjavac
6e7dc0b437
Use the target system's boot name in partitioning summary widget.
2016-10-14 15:27:24 +02:00
Teo Mrnjavac
5796b05fda
Allow disabling automated LUKS modes.
2016-09-26 13:14:54 +02:00
Teo Mrnjavac
c316d22b08
Keep an immutable copy for every scanned Device* to avoid rescans.
2016-09-09 11:28:39 +02:00
Chantara Tith
aa10fe982a
API Changes, logicalSectorSize -> logicalSize, totalSectors -> totalLogical.
2016-09-09 11:28:39 +02:00
Andrius Štikonas
9f0ca042fe
Port away from most cases of Q_FOREACH to C++11 ranged for loop.
...
In order to avoid deep copies, Qt containers over which we iterate must be const
The remaining unported cases require qAsConst (Qt 5.7) or std::as_const (C++17)
2016-09-01 16:46:14 +01:00
Teo Mrnjavac
e9da3acd95
Fix EncryptWidget height.
2016-07-22 16:36:26 +02:00