Adriaan de Groot
0aabc89449
[partition] [welcome] Simplify retranslation
2019-08-29 15:02:12 +02:00
Adriaan de Groot
1cde8c20df
[libcalamaresui] Simplify retranslation
...
- Use any object method to connect() to
2019-08-29 15:01:41 +02:00
Adriaan de Groot
f1971eed86
[libcalamares] Support calling a slot on retranslation
...
- sometimes a slot is easier than a lambda. Introduce
a macro CALAMARES_RETRANSLATE_SLOT that calls a given
slot in an object on language change.
- extend the retranslator with support for calling slots:
- use Qt's signal/slot mechanism alongside the private
list of functions to call
- provide convenience for obtaining the retranslator of
an object.
2019-08-29 14:53:03 +02:00
Adriaan de Groot
e3f933259b
CMake: missing return statement should be an error
2019-08-29 14:46:16 +02:00
Adriaan de Groot
535bf01475
[welcome] Refactor lambdas to full slots
...
- This helps give meaningful names to code chunks
- Gives clang-format something to work with
- Reduces indentation depth
I think this is a bit of a code-style opinion issue: big complicated
lambdas doing UI things just don't seem like a good idea.
2019-08-29 11:06:55 +02:00
Adriaan de Groot
fc5aa54cb2
[welcome] Fix code formatting
...
- the RETRANSLATE macro is a real challenge for astyle and clang-format
2019-08-29 11:01:02 +02:00
Adriaan de Groot
07bd22ba95
Merge pull request #1233 from bill-auger/patch-4
...
eliminate magic number in src/modules/welcome/WelcomePage.cpp
2019-08-29 04:46:18 -04:00
Adriaan de Groot
9ca864567a
Merge pull request #1231 from bill-auger/patch-5
...
cross-reference/clarify geoip documentation
2019-08-29 04:36:13 -04:00
Adriaan de Groot
3f90921155
Merge pull request #1232 from bill-auger/patch-3
...
update doc comment in src/modules/initcpio/initcpio.conf
2019-08-29 04:34:55 -04:00
Adriaan de Groot
06e19a3e11
Merge pull request #1234 from bill-auger/patch-2
...
fix typo in comment src/libcalamaresui/ViewManager.cpp
2019-08-29 04:34:04 -04:00
bill-auger
5642576cf3
cross-reference/clarify geoip documentation
2019-08-28 13:21:42 -04:00
bill-auger
bb678e535b
add esperanto branding translations, fix mis-configured ones
2019-08-28 13:12:25 -04:00
bill-auger
4c3c6f3f91
eliminate magic number in src/modules/welcome/WelcomePage.cpp
2019-08-28 13:02:42 -04:00
bill-auger
13a58a4ab2
update doc comment in src/modules/initcpio/initcpio.conf
2019-08-28 13:02:36 -04:00
bill-auger
e459b82cfe
fix typo in src/libcalamaresui/ViewManager.cpp
2019-08-28 13:02:27 -04:00
Adriaan de Groot
559a65d169
Merge branch 'issue-1213'
...
FIXES #1213
Better slideshow loading, both V1 and V2. Keyboard shortcuts only while
the slideshow is visible.
2019-08-27 15:59:00 +02:00
Adriaan de Groot
8ab0fb4e5f
[libcalamaresui] Apply coding style (missed earlier)
2019-08-27 15:58:09 +02:00
Adriaan de Groot
03ac0d2cf0
[qml] Document the new property and how it updates
2019-08-27 15:55:18 +02:00
Adriaan de Groot
be5388abcd
[libcalamaresui] activate -> change state
...
- since we also need to *disable* the shortcuts, and should tell a
V1 slideshow that it no longer is running,
- use existing function to set the property to true / false depending.
- instead of changeState( true ) or changeStage( false ), use
meaningful enum names so that the code at the call site
becomes readable; make the boolean part internal to the
state-changing method.
2019-08-27 15:40:13 +02:00
Adriaan de Groot
1e3e53d30a
[libcalamaresui] Set activatedInCalamares special property
...
- when the QML is activated, if the slideshow has this property,
set it to true. This enables the keyboard shortcuts.
2019-08-27 15:12:47 +02:00
Adriaan de Groot
7df6ed31e9
[libcalamaresui] Refactor QML slideshow activation
...
- one function for activation, since we activate from different
places and each loader-API may need multiple steps for activation.
2019-08-27 13:36:28 +02:00
Adriaan de Groot
0a9d0ddf68
[qml] In the default (sample) slideshow, activate key shortcuts
...
- with V2 loading, the key shortcuts should be enabled when the
slideshow itself is activated, not when it is loaded.
2019-08-27 13:36:28 +02:00
Adriaan de Groot
34cb777b0a
[qml] Disable all the key shortcuts via root.activatedInCalamares
2019-08-27 13:36:28 +02:00
Adriaan de Groot
ac8952f223
[libcalamaresui] Improve QML API v2 debugging
...
- log what is being loaded
- distinguish "component complete" from actuial loading
2019-08-27 13:36:28 +02:00
Adriaan de Groot
e0bb53aff4
[dummycpp] Replace QProcess::execute()
...
- hangs unpredictably during testing
- replace with the Calamares process-invocation runCommand(), which is also
synchronous but doesn't hang (or, hasn't, in testing so far)
2019-08-27 13:34:26 +02:00
Adriaan de Groot
c28c97d3aa
Merge branch 'issue-1215'
...
FIXES #1215
FIXES #1216
2019-08-26 21:42:40 +02:00
Adriaan de Groot
eb21c90861
[libcalamares] Avoid implicit 0-to-flags conversion
...
- clang complains about using 0 as a Flags value, so make the
default (empty) initialization explicit.
2019-08-26 21:42:27 +02:00
Adriaan de Groot
d8a587e16e
[packagechooser] Scale screenshot
...
- if the screenshot is too large, scale it down
- (doesn't react to window resizes though)
2019-08-26 21:40:16 +02:00
Adriaan de Groot
6035a74a93
[packagechooser] Align the screenshot
...
- hcenter + vcenter the screenshot
- make it expand as necessary
- fill in some sample text
2019-08-26 20:48:13 +02:00
Kevin Kofler
9dbd3a765b
[netinstall] Fix typo in netinstall.conf comment
...
s/inmportant/important/
2019-08-26 19:02:15 +02:00
Adriaan de Groot
5868f102f2
[packagechooser] Less-bad "no selection" image
...
- It's only "less bad", not actually a good image, composed from
Breeze "empty" and "generic packages" icon.
2019-08-26 16:49:58 +02:00
Adriaan de Groot
d3660436fe
Merge branch 'issue-1227'
...
FIXES #1227
(Well, "fixes" .. documents the situation)
2019-08-26 16:43:10 +02:00
Adriaan de Groot
d063d60e37
[packages] Explain pre-script isn't actually a shell script
2019-08-26 16:42:05 +02:00
Adriaan de Groot
56792fdcb5
[netinstall] Polish the README
...
- describe the format better
- more consistent typography
- refer to `packages.conf` for details on shell commands
2019-08-26 16:26:06 +02:00
Adriaan de Groot
ee29c45433
[netinstall] Point documentation towards netinstall README.md
2019-08-26 16:01:14 +02:00
Adriaan de Groot
6fb909a799
Merge branch 'networking-service'
2019-08-26 15:49:09 +02:00
Adriaan de Groot
f7215393d1
[tracking] Use the network service
...
- drop own NAM handling
- use timeout mechanism
- report timeout as fatal error (like it already did), other
errors are ignored.
2019-08-26 15:47:17 +02:00
Adriaan de Groot
a1b0049bbf
[libcalamares] Use more readable names
2019-08-26 15:41:30 +02:00
Adriaan de Groot
e2c6591a77
[libcalamares] Refactor request internals
...
- distinguish timeouts from other failures
- git synchronousPing() a more detailed result, which is
still bool-compatible.
2019-08-26 15:24:58 +02:00
Adriaan de Groot
f0be7fd4aa
[libcalamares] Make failures in the internal methods obvious
...
- internally, timeout and error will return nullptr
2019-08-26 14:43:41 +02:00
Adriaan de Groot
87ea14f68a
[libcalamares] Drop INTERFACES again
...
- The compile failure came from bad #include paths, so restoring
this interface declaration wasn't a fix.
- Reported to cause runtime failures on both KaOS and Manjaro.
2019-08-26 10:15:22 +02:00
Adriaan de Groot
ededebbc6c
[libcalamares] Return reply early if the request is bad
2019-08-24 15:23:07 +02:00
Arnaud Ferraris
0f6b2dbe2d
[unpackfs] Enable to use "/" as a source
...
If we don't have/need an image for the rootfs, we might want to
configure the `/` directory as a source for unpackfs. Unfortunately,
this raises an error:
- unpackfs first creates a temporary directory
- it then creates a subdirectory for each source, using the source
path's basename
- when the source is `/`, the basename is an empty string, therefore
the module tries to create an already existing directory
In order to prevent this error, we use the `os.makedirs` function with
parameter `exist_ok=True` instead of `os.mkdir`.
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.com>
2019-08-23 17:26:45 +02:00
Adriaan de Groot
d422c782ba
[libcalamares] Correct include path
...
- no need for the subdirectories, and this confuses MOC
Reported-by: Jonathan Riddell
Fix-by: Harald Sitter
2019-08-23 17:15:51 +02:00
Adriaan de Groot
85f0d38698
[libcalamares] Refactor synchronous get
...
- Add timeout support
- Refactor into a static helper method
2019-08-23 14:59:35 +02:00
Adriaan de Groot
1f2b3b734d
[libcalamares] Extend synchronous API with options
2019-08-23 12:18:59 +02:00
Adriaan de Groot
af1aa701bc
[libcalamares] Shuffle namespace lines around
...
- put all the definitions inside namespace {} to avoid
needlessly long source lines.
2019-08-23 12:09:30 +02:00
Adriaan de Groot
da29c0b0f1
Merge branch 'display-manager'
...
FIXES #1224
Reported by: Алексей Шилин (Debian, downstream)
2019-08-23 03:55:11 -04:00
Adriaan de Groot
383bd97a9c
[displaymanager] Handle variations in config file
...
- GDM3 uses a different config file than previous GDM
2019-08-23 03:40:10 -04:00
Adriaan de Groot
1c61181624
[displaymanager] Handle variations in GDM executable name
...
- Debian https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=934504
- Instead of hard-coding one or the other, search for gdm and gdm3
2019-08-23 03:25:41 -04:00