Adriaan de Groot
390acd41b2
[partition] Factor out manual partitioning translation
...
- needs to be called when the button is created, too
2021-08-04 01:42:00 +02:00
Adriaan de Groot
2820316d16
Partition: don't set text if button doesn't exist
2021-08-05 14:23:11 +02:00
Adriaan de Groot
e8cb5c621a
[partition] Fix build
2021-07-26 20:54:43 +02:00
Adriaan de Groot
616f3d4fd7
[partition] Simplify retranslation of swap choices and manual partitioning
2021-07-26 16:18:31 +02:00
Adriaan de Groot
e0b8942242
[partition] Introduce retranslate slot for ChoicePage, code style
2021-07-26 16:12:41 +02:00
Adriaan de Groot
03e621f4a2
Modules: clean up linking
...
- do not link (explicitly) to Calamares libraries, the CMake
functions do that automatically.
- while here, tidy and remove commented-out-bits
- while here, remove unneeded includes
2021-07-26 15:04:43 +02:00
Adriaan de Groot
c2d0a247a3
[partition] Simplify code for overloads
2021-07-12 16:52:24 +02:00
Adriaan de Groot
96c2c62470
[partition] Fix build on older KPMCore
2021-07-06 12:59:01 +02:00
Adriaan de Groot
a4fadcd9be
[partition] Introduce check for EFI partition type-and-size
...
Re-use the existing message about partition type and size,
since I don't want to introduce another message with all the
specifics; give a works-always message instead.
The check itself is also straightforward, avoiding all of the
nuances and technically-this-might-work cases: FAT32, 300MiB+.
FIXES #607
2021-07-06 12:54:25 +02:00
Adriaan de Groot
b5c56fd579
[partition] Clarify comments on boot-flags
2021-07-05 13:33:09 +02:00
Adriaan de Groot
1a542d3afe
[partition] Write out type rather than aliasing to T
2021-07-05 13:11:00 +02:00
Adriaan de Groot
7ea6768852
[partition] Pick slightly more sensible defaults for FS selection
2021-07-05 12:39:56 +02:00
Adriaan de Groot
56ecf01dea
Merge branch 'pr-1667' into calamares
...
Allow user-selection of FS type
FIXES #1667
2021-07-05 12:31:58 +02:00
Adriaan de Groot
6a7a486b8c
[partition] Document interactions between defaultFS and layout
2021-07-05 12:28:17 +02:00
Adriaan de Groot
453d533d2c
[partition] Use default FS for layout items with type Unknown
2021-06-29 23:47:33 +02:00
Adriaan de Groot
c3528e4e40
[partition] Document that the default FS is used, also when erasing
2021-06-29 14:52:16 +02:00
Adriaan de Groot
67fafa04ac
[partition] Move fs-type handling into Config
...
- the defaultFileSystemType interacts with availableFileSystemTypes
so set them together.
2021-06-29 14:47:09 +02:00
Adriaan de Groot
f494440895
[partition] Don't run bool allowManualPartitioning through GS
...
It's a bit over-wrought to store a bool in a QVariant in GS for
consumption **only** by ChoicePage, so drop that GS key and store
it locally.
2021-06-29 13:21:46 +02:00
Adriaan de Groot
5e3a0eda73
[partition] Reduce confused naming
2021-06-29 13:01:21 +02:00
Adriaan de Groot
ebecfb9f8b
[partition] Simplify config-reading (now the variant-docs are better)
2021-06-29 12:21:14 +02:00
Adriaan de Groot
46f2d72b4c
[partition] requiredPartitionTableType: improve docs
2021-06-29 11:48:53 +02:00
Adriaan de Groot
5f7cfefed7
[partition] Migrate EFI settings-setting to Config object
2021-06-29 11:43:20 +02:00
Adriaan de Groot
c3bc305bb6
[partition] Shuffle Config and ViewStep to top
...
Modules nearly always have a Config and either a Job or ViewStep
as their "top level" components. Everything else is implementation-
detail. The *partition* module was unusual in that those two
"top level" components were tucked away in subdirectories.
Shuffle them to the top: this makes it more clear that these
two files are there to coordinate the module.
2021-06-29 11:22:47 +02:00
Adriaan de Groot
cba5b9e4fb
[partition]: restore defaultFileSystemType in config
...
Add the old key back, document the new key, expand schema.
2021-06-28 22:25:54 +02:00
Adriaan de Groot
131352ca03
[partition] Apply coding style
2021-06-22 00:21:01 +02:00
Adriaan de Groot
e2bf717ea0
[partition] Rewrite new-partition API
...
The existing API required calling the one constructor with
specific pointers (nullptr for a partition-from-free-space)
followed by calling one of the initFrom*() functions. This
is fragile design.
Use tag-classes to distinguish create-from-free-space and
edit-another-freshly-created-partition cases, refactor
to merge the initFrom*() methods into the constructors
and factor out the shared UI creation.
Callers can now use the tag-class to distinguish. While
here, adjust both callers to use QPointer, avoiding some
very specific dialog-on-the-stack crash possibilities.
2021-06-22 00:17:46 +02:00
Adriaan de Groot
dbfd8bea03
[partition] Newly-created (fresh) partitions don't have flags yet
...
When a partition is set as "freshly created", the dialog was
passing in newFlags() as the **already-active** flags on the
partition; then the caller was setting those same flags as
"set these in the future", so that afterwards, no flags would
actually be set (because they're already active -- see the
first sentence).
Now, fresh partitions have no flags.
2021-06-22 00:11:46 +02:00
Adriaan de Groot
f06766085a
[partition] Rename function, to track down consumers
2021-06-22 00:11:46 +02:00
Adriaan de Groot
60f8a7c5fb
[partition] Don't offer /boot if EFI wants something else
...
- Don't leave /boot in the list always; EFI might be configured
for /boot/efi on this system
- While here, apply coding style.
2021-06-18 22:20:11 +02:00
Adriaan de Groot
6936915dd6
[partition] Fix logging (type of debug stream changed)
2021-06-18 17:41:22 +02:00
Adriaan de Groot
7deb6c0e9e
[partition] Improve logging in clearmounts job
2021-06-18 16:18:06 +02:00
Adriaan de Groot
66f96e339c
[libcalamares] Introduce cVerbose() convenience macro (like cDebug())
2021-06-18 16:01:04 +02:00
Adriaan de Groot
17cc0470da
[partition] Log names of partition flags, not just a number
2021-06-18 15:54:51 +02:00
Adriaan de Groot
bf7eed9342
[partition] Tidy debug output when creating table
2021-06-18 15:50:13 +02:00
Adriaan de Groot
fb7e6101ff
[partition] Hook erase-fs-type changes to the config-object
2021-06-18 13:53:47 +02:00
Adriaan de Groot
7ce2a87644
[partition] Fix build
...
- fsName was a QString (a copy) so it could be modified;
- the modification isn't really necessary.
- While here, pick up new PointerSetter convenience class.
2021-06-18 13:49:39 +02:00
Adriaan de Groot
2a0d4e5a23
[partition] Initialize pointers in declaration
2021-06-18 12:35:15 +02:00
Adriaan de Groot
26cabbb3e4
[partition] refactor config-reading from availableFileSystemTypes
2021-06-18 12:18:04 +02:00
Adriaan de Groot
cd804470b5
[partition] Canonicalize the FS choice for erase
2021-06-18 11:51:33 +02:00
Adriaan de Groot
d8a862ec82
[partition] Use Q_EMIT
2021-06-18 11:31:53 +02:00
Adriaan de Groot
4fa61249a8
[partition] Make the fs type used for erase, a config property
2021-06-18 11:29:36 +02:00
Adriaan de Groot
9fa5ab04e5
[partition] Apply coding style to core/
2021-06-18 11:23:27 +02:00
Adriaan de Groot
f9659989b1
[partition] rename findFS
...
Rename findFS -> canonicalFilesystemName because that's what it actually
does. While here, apply coding style to the files that are affected.
2021-06-18 11:09:11 +02:00
Adriaan de Groot
546253d750
[partition] Apply coding style
2021-06-18 11:00:15 +02:00
Adriaan de Groot
9ef22f4168
Merge branch 'calamares' of https://github.com/LordTermor/calamares into pr-1667
2021-06-15 11:48:33 +02:00
Adriaan de Groot
dba346be7a
[partition] Fix build in non-debug settings
2021-06-08 19:51:25 +02:00
Adriaan de Groot
4f70568c65
[partition] Remove unneeded includes
2021-06-08 15:05:44 +02:00
Adriaan de Groot
63c6a8bac8
[partition] Remove unneeded includes
2021-06-08 14:18:28 +02:00
Adriaan de Groot
f67c7f900c
[partition] Make the expanded (pop-up) icon sizes for devices a bit smaller
2021-06-08 14:14:11 +02:00
Adriaan de Groot
df634573bf
[partition] Resize combo box to show whole pop-up
...
The (collapsed) combo box should be wide enough to show the
entire pop-up (expanded) box data.
FIXES #1700
2021-06-08 14:09:31 +02:00