Adriaan de Groot
2a0716bf43
[license] Move the 'please review' text to the top.
2019-11-28 11:24:56 +01:00
Adriaan de Groot
2a45765b93
[license] Next depends not just on the checked box
...
- Toggling the checkbox could disable the next button
because only the checked-state was used, instead of
the next-is-enabled-if-everything-is-optional member variable.
FIXES #1271
2019-11-27 12:17:33 +01:00
Adriaan de Groot
ec605adf3f
[license] Tidy code
...
- Move retranslation to a separate slot to allow it to be
formatted nicely.
- Use calculated m_allLicensesOptional in retranslation.
- Untangle determining if all licenses are optional; std::none_of
returns true on an empty list.
2019-11-26 22:37:25 +01:00
Adriaan de Groot
042852218f
[license] Apply current coding style
2019-08-03 14:52:38 +02:00
Adriaan de Groot
090aee9196
Modules: adjust to split-out utils/Variant.h
...
- Most modules only needed the variant support, not the "whole"
CalamaresUtils header.
- While here improve ordering of headers as well.
2019-04-29 06:14:21 -04:00
Adriaan de Groot
a68a381481
[license] Fix compiler warnings
...
- out-of-order and incomplete initialization
- documentation style
- missing assignment operator
2019-04-25 14:15:14 +02:00
Adriaan de Groot
58770037f4
[license] Allow more things locally
...
- If it says file:, it's local (don't require a specific file
extension).
- Report actual path loaded.
2019-04-24 07:04:38 -04:00
Adriaan de Groot
92a3666dce
[license] Simplify isLocal() by using Qt method
2019-04-23 08:16:54 -04:00
Adriaan de Groot
c696b5c19d
[license] Add show-license toggle button
...
- Non-functional as yet
- Toggles expand / collapse arrow and tooltip
2019-04-21 20:36:11 +02:00
Adriaan de Groot
cb80d47682
[license] Move translation / retranslation to LicenseWidget
...
- Language change didn't otherwise apply to the license items
2019-04-21 13:50:06 +02:00
Adriaan de Groot
1235207ead
[license] Refactor LicenseWidget
...
- Move all the widget code into its own file
2019-04-21 13:36:28 +02:00
Adriaan de Groot
d2957fbad3
[license] Handle the case where all the licenses are optional
...
- If all of the licenses are optional, you should be able to
continue without accepting. Refactor to a single visible
slot to check the conditions.
- Always set the globalsettings value; to "false" on entry
to make sure it's there.
- When setting the list of entries, check the conditions
(because if the list is empty, or all of them are optional,
then it's ok to continue).
FIXES #1124
FIXES #1125
2019-04-20 15:27:00 -04:00
Adriaan de Groot
c245238b89
[license] Use standard algorithms, simplify code
...
- Introduce isRequired() for readability later
- Use std::any_of instead of rolling own loop
2019-04-20 11:58:01 -04:00
Adriaan de Groot
937f332441
[license] Refactor LicenseEntry
...
- Follow Calamares conventions for member naming
- Switch to struct since everything is public anyway
2019-04-20 11:53:16 -04:00
Adriaan de Groot
dc006d58b2
[license] Use NamedEnum
2019-04-20 11:43:19 -04:00
Adriaan de Groot
614bd3c6de
[license] Move logic to LicenseEntry class
2019-04-20 09:52:29 -04:00
Adriaan de Groot
81016667ae
[license] Change to enum class
...
- non-functional change, just chasing modern C++
2019-04-20 09:52:28 -04:00
Adriaan de Groot
cef2f50510
Reduce warnings about extra ;
...
- Trailing ; after Q_UNUSED
- Trailing ; after CALAMARES_RETRANSLATE
2019-04-18 12:06:09 +02:00
Adriaan de Groot
dd8e53dc22
Copyright: update copyright lines on files touched in 2018
...
Contributions from:
Adriaan de Groot <groot@kde.org>
Gabriel Craciunescu <crazy@frugalware.org>
AlmAck <gluca86@gmail.com>
Andrius Štikonas <andrius@stikonas.eu>
Caio Carvalho <caiojcarvalho@gmail.com>
Raul Rodrigo Segura <raurodse@gmail.com>
2018-06-15 05:59:11 -04:00
Adriaan de Groot
51ccd6be4d
[license] Warnings-- by making the one default case explicit
2018-03-06 16:23:29 +01:00
Adriaan de Groot
762ad54344
Documentation: change http links to GitHub to https
2017-12-20 08:39:09 -05:00
Andrius Štikonas
9f0ca042fe
Port away from most cases of Q_FOREACH to C++11 ranged for loop.
...
In order to avoid deep copies, Qt containers over which we iterate must be const
The remaining unported cases require qAsConst (Qt 5.7) or std::as_const (C++17)
2016-09-01 16:46:14 +01:00
Teo Mrnjavac
b2f1e08377
Prevent unnecessary switch fallthrough (fix Coverity defect 114171).
2016-02-26 13:24:13 +01:00
demmm
c1ee36946c
New License module, based on KaOS license module.
...
See README.md for details.
2015-09-14 16:51:04 +02:00