napcok/calamares
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[libcalamaresui] Improve logging for QML modules

Browse Source 
- mention which instance produces warnings
- tag additional debugging from the same method with Logger::SubEntry
This commit is contained in:
Adriaan de Groot 2021-03-15 20:47:27 +01:00
parent 416c2c9689
commit f8afb15c4c
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/libcalamaresui/viewpages/QmlViewStep.cpp
View File

@ -168,7 +168,7 @@ QmlViewStep::loadComplete()
}
if ( m_qmlComponent->isReady() && !m_qmlObject )
{
cDebug() << "QML component complete" << m_qmlFileName;
cDebug() << Logger::SubEntry << "QML component complete" << m_qmlFileName << "creating object";
// Don't do this again
disconnect( m_qmlComponent, &QQmlComponent::statusChanged, this, &QmlViewStep::loadComplete );
@ -196,7 +196,7 @@ QmlViewStep::showQml()
{
if ( !m_qmlWidget || !m_qmlObject )
{
cDebug() << "showQml() called but no QML object";
cWarning() << "showQml() called but no QML object";
return;
}
if ( m_spinner )
@ -208,7 +208,7 @@ QmlViewStep::showQml()
}
else
{
cDebug() << "showQml() called twice";
cWarning() << "showQml() called twice";
}
if ( ViewManager::instance()->currentStep() == this )
@ -228,7 +228,7 @@ QmlViewStep::setConfigurationMap( const QVariantMap& configurationMap )
= CalamaresUtils::qmlSearchNames().find( CalamaresUtils::getString( configurationMap, "qmlSearch" ), ok );
if ( !ok )
{
cDebug() << "Bad QML search mode.";
cWarning() << "Bad QML search mode set for" << moduleInstanceKey();
}
QString qmlFile = CalamaresUtils::getString( configurationMap, "qmlFilename" );
@ -253,7 +253,7 @@ QmlViewStep::setConfigurationMap( const QVariantMap& configurationMap )
}
else
{
cWarning() << "QML configuration set after component has loaded.";
cWarning() << "QML configuration set after component" << moduleInstanceKey() << "has loaded.";
}
}