From efe84bc6c0f1ee8f81a10617a5d55dd43f87422e Mon Sep 17 00:00:00 2001 From: Adriaan de Groot Date: Tue, 16 Nov 2021 15:31:35 +0100 Subject: [PATCH] [partition] Don't log private names - log device node (/dev/sdb) instead of its name - don't log job's prettyName() because that's translated, and also contains user-visible private names (introducing a non-translated, nicely redacted version of prettyName() seems like too much effort for something that can be reconstructed from bits earlier in the log) --- src/modules/partition/core/PartitionCoreModule.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/modules/partition/core/PartitionCoreModule.cpp b/src/modules/partition/core/PartitionCoreModule.cpp index 2475937d2..16e5a7ea1 100644 --- a/src/modules/partition/core/PartitionCoreModule.cpp +++ b/src/modules/partition/core/PartitionCoreModule.cpp @@ -709,10 +709,10 @@ PartitionCoreModule::dumpQueue() const cDebug() << "# Queue:"; for ( auto info : m_deviceInfos ) { - cDebug() << Logger::SubEntry << "## Device:" << info->device->name(); + cDebug() << Logger::SubEntry << "## Device:" << info->device->deviceNode(); for ( const auto& job : info->jobs() ) { - cDebug() << Logger::SubEntry << "-" << job->prettyName(); + cDebug() << Logger::SubEntry << "-" << job->metaObject()->className(); } } }