napcok/calamares
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Change the default value of critical to false.

Browse Source 
This means all package groups are non-critical by default.
Update documentation accordingly.
This commit is contained in:
shainer 2016-11-13 12:12:07 +00:00
parent 5dd6676602
commit e5f5bb99d7
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/modules/netinstall/NetInstallPage.h
View File

@ -38,11 +38,11 @@ class Page_NetInst;
struct Group struct Group
{ {
Group() Group()
: Group( "","",false, false, true ) { } : Group( "","",false, false, false ) { }
Group( QString name, QString description, bool selected, bool hidden, bool critical ) Group( QString name, QString description, bool selected, bool hidden, bool critical )
: name( name ), description( description ), selected( selected ), hidden( hidden ), critical( critical ) { } : name( name ), description( description ), selected( selected ), hidden( hidden ), critical( critical ) { }
Group( QString name, QString description ) Group( QString name, QString description )
: Group( name, description, false, false, true ) { } : Group( name, description, false, false, false ) { }
QString name; QString name;
QString description; QString description;
@ -51,7 +51,7 @@ struct Group
// See README.md for a description of these fields. // See README.md for a description of these fields.
bool selected = false; bool selected = false;
bool hidden = false; bool hidden = false;
bool critical = true; bool critical = false;
}; };
class NetInstallPage : public QWidget class NetInstallPage : public QWidget

2
src/modules/netinstall/README.md
View File

@ -33,7 +33,7 @@ Three more keys are supported:
- selected: if true, display the group as selected. Defaults to false. - selected: if true, display the group as selected. Defaults to false.
- critical: if true, make the installation process fail if installing - critical: if true, make the installation process fail if installing
any of the packages in the group fails. Otherwise, just log a warning. any of the packages in the group fails. Otherwise, just log a warning.
Defaults to true. Defaults to false.
If you set both *hidden* and *selected* for a group, you are basically creating a "default" group of packages If you set both *hidden* and *selected* for a group, you are basically creating a "default" group of packages
which will always be installed in the user's system. which will always be installed in the user's system.