napcok/calamares
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

updatePartitionToCreate: avoid crash

Browse Source 
Create the new partition before deleting the old one: otherwise the
m_partition member of dlg is dangling at the time we call createPartition()
This commit is contained in:
Aurélien Gâteau 2014-08-04 19:23:39 +02:00
parent 3d40527d29
commit e482481262
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/modules/partition/PartitionPage.cpp
View File

@ -216,8 +216,9 @@ PartitionPage::updatePartitionToCreate( Device* device, Partition* partition )
dlg->initFromPartitionToCreate( partition ); dlg->initFromPartitionToCreate( partition );
if ( dlg->exec() == QDialog::Accepted ) if ( dlg->exec() == QDialog::Accepted )
{ {
Partition* newPartition = dlg->createPartition();
m_core->deletePartition( device, partition ); m_core->deletePartition( device, partition );
m_core->createPartition( device, dlg->createPartition() ); m_core->createPartition( device, newPartition );
} }
delete dlg; delete dlg;
} }