From dbcc419218b2409f925d059b030d79d4eca1bea3 Mon Sep 17 00:00:00 2001 From: Adriaan de Groot Date: Wed, 27 Jun 2018 09:39:30 -0400 Subject: [PATCH] [services-openrc] Log failures - If the rc-update command fails for some reason, log that failure instead of skipping it completely silently. - Fix syntax error as well --- src/modules/services-openrc/main.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/modules/services-openrc/main.py b/src/modules/services-openrc/main.py index 27ea6ebb6..cfa7fd457 100644 --- a/src/modules/services-openrc/main.py +++ b/src/modules/services-openrc/main.py @@ -53,13 +53,16 @@ class OpenrcController: service_path = self.root + self.initdDir + "/" + name runlevel_path = self.root + self.runlevelsDir + "/" + runlevel + if exists(service_path): if exists(runlevel_path): - target_env_call(["rc-update", state, name, runlevel]) + ec = target_env_call(["rc-update", state, name, runlevel]) + if ec != 0: + warning("Could not {} service {} in {}, error {!s}".format(state, name, runlevel, ec)) else: warning("Target runlevel {} does not exist for {}.".format(runlevel, name)) else: - warning("Target service {} does not exist int {}.".format(name, self.initDir)) + warning("Target service {} does not exist in {}.".format(name, self.initdDir)) def run(self):