From db0c1ffd6de9dd8d6b8f83519f7d3a973c884950 Mon Sep 17 00:00:00 2001 From: Adriaan de Groot Date: Mon, 19 Feb 2018 04:23:56 -0500 Subject: [PATCH] CMake: just install unversioned .so - Applies to libcalamares and libcalamaresui.so, install with no version, just the bare .so. Since Calamares doesn't do versioning anyway, and its plugins should be re-compiled for any change, putting them in lib as unversioned .so's should make Calamares happy and silence lintian. --- src/calamares/CMakeLists.txt | 2 +- src/libcalamares/CMakeLists.txt | 5 ++--- src/libcalamaresui/CMakeLists.txt | 1 - 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/src/calamares/CMakeLists.txt b/src/calamares/CMakeLists.txt index f47a0a9f5..fc4e508a2 100644 --- a/src/calamares/CMakeLists.txt +++ b/src/calamares/CMakeLists.txt @@ -42,7 +42,7 @@ add_calamares_translations( ${CALAMARES_TRANSLATION_LANGUAGES} ) set( final_src ${calamaresUi_H} ${calamaresSources} ${calamaresRc} ${trans_outfile} ) add_executable( calamares_bin ${final_src} ) -SET_TARGET_PROPERTIES(calamares_bin +set_target_properties(calamares_bin PROPERTIES AUTOMOC TRUE ENABLE_EXPORTS TRUE diff --git a/src/libcalamares/CMakeLists.txt b/src/libcalamares/CMakeLists.txt index 3ee03dd96..94e9145d6 100644 --- a/src/libcalamares/CMakeLists.txt +++ b/src/libcalamares/CMakeLists.txt @@ -92,9 +92,8 @@ target_link_libraries( calamares install( TARGETS calamares EXPORT CalamaresLibraryDepends - RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR} - LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR}/calamares/ - ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR}/calamares/ + LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR} + ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR} ) # Install header files diff --git a/src/libcalamaresui/CMakeLists.txt b/src/libcalamaresui/CMakeLists.txt index 9ef52716b..4d0ec8281 100644 --- a/src/libcalamaresui/CMakeLists.txt +++ b/src/libcalamaresui/CMakeLists.txt @@ -79,5 +79,4 @@ calamares_add_library( calamaresui RESOURCES libcalamaresui.qrc EXPORT CalamaresLibraryDepends NO_VERSION - INSTALL_BINDIR ${CMAKE_INSTALL_LIBDIR}/calamares/ )