From d8be9a94438cfc81d3249823453d2853ce15f227 Mon Sep 17 00:00:00 2001 From: Adriaan de Groot Date: Tue, 1 Feb 2022 14:07:38 +0100 Subject: [PATCH] [partition] Mount points should start with a / --- src/modules/partition/gui/CreatePartitionDialog.cpp | 8 +++++++- src/modules/partition/gui/EditExistingPartitionDialog.cpp | 8 +++++++- 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/src/modules/partition/gui/CreatePartitionDialog.cpp b/src/modules/partition/gui/CreatePartitionDialog.cpp index 6bde9a148..789909867 100644 --- a/src/modules/partition/gui/CreatePartitionDialog.cpp +++ b/src/modules/partition/gui/CreatePartitionDialog.cpp @@ -325,11 +325,17 @@ CreatePartitionDialog::updateMountPointUi() void CreatePartitionDialog::checkMountPointSelection() { - if ( m_usedMountPoints.contains( selectedMountPoint( m_ui->mountPointComboBox ) ) ) + const QString mountPoint = selectedMountPoint( m_ui->mountPointComboBox ); + if ( m_usedMountPoints.contains( mountPoint ) ) { m_ui->labelMountPoint->setText( tr( "Mountpoint already in use. Please select another one." ) ); m_ui->buttonBox->button( QDialogButtonBox::Ok )->setEnabled( false ); } + else if ( !mountPoint.isEmpty() && !mountPoint.startsWith( '/' ) ) + { + m_ui->labelMountPoint->setText( tr( "Mountpoint must start with a
/
." ) ); + m_ui->buttonBox->button( QDialogButtonBox::Ok )->setEnabled( false ); + } else { m_ui->labelMountPoint->setText( QString() ); diff --git a/src/modules/partition/gui/EditExistingPartitionDialog.cpp b/src/modules/partition/gui/EditExistingPartitionDialog.cpp index a3052b3b7..2d25d71ac 100644 --- a/src/modules/partition/gui/EditExistingPartitionDialog.cpp +++ b/src/modules/partition/gui/EditExistingPartitionDialog.cpp @@ -295,11 +295,17 @@ EditExistingPartitionDialog::updateMountPointPicker() void EditExistingPartitionDialog::checkMountPointSelection() { - if ( m_usedMountPoints.contains( selectedMountPoint( m_ui->mountPointComboBox ) ) ) + const QString mountPoint = selectedMountPoint( m_ui->mountPointComboBox ); + if ( m_usedMountPoints.contains( mountPoint ) ) { m_ui->labelMountPoint->setText( tr( "Mountpoint already in use. Please select another one." ) ); m_ui->buttonBox->button( QDialogButtonBox::Ok )->setEnabled( false ); } + else if ( !mountPoint.isEmpty() && !mountPoint.startsWith( '/' ) ) + { + m_ui->labelMountPoint->setText( tr( "Mountpoint must start with a
/
." ) ); + m_ui->buttonBox->button( QDialogButtonBox::Ok )->setEnabled( false ); + } else { m_ui->labelMountPoint->setText( QString() );