napcok/calamares
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[users] Extend tests

Browse Source 
- password requirements can disallow weak passwords
- start checking for signals on password changes
This commit is contained in:
Adriaan de Groot 2020-08-17 14:05:03 +02:00
parent a16ecba2bd
commit d7b895b45d
1 changed files with 29 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
src/modules/users/Tests.cpp
View File

@ -206,6 +206,35 @@ UserTests::testUserPassword()
QCOMPARE( c.userPasswordValidity(), int( Config::PasswordValidity::Invalid ) ); QCOMPARE( c.userPasswordValidity(), int( Config::PasswordValidity::Invalid ) );
c.setUserPasswordSecondary( "bogus" ); c.setUserPasswordSecondary( "bogus" );
QCOMPARE( c.userPasswordValidity(), int( Config::PasswordValidity::Weak ) ); QCOMPARE( c.userPasswordValidity(), int( Config::PasswordValidity::Weak ) );
QVERIFY( !c.requireStrongPasswords() );
c.setRequireStrongPasswords( true );
QVERIFY( c.requireStrongPasswords() );
// Now changed requirements make the password invalid
QCOMPARE( c.userPassword(), "bogus" );
QCOMPARE( c.userPasswordValidity(), int( Config::PasswordValidity::Invalid ) );
}
{
Config c;
QVERIFY( c.userPassword().isEmpty() );
QCOMPARE( c.userPasswordValidity(), Config::PasswordValidity::Valid );
QSignalSpy spy_pwChanged( &c, &Config::userPasswordChanged );
QSignalSpy spy_pwSecondaryChanged( &c, &Config::userPasswordSecondaryChanged );
QSignalSpy spy_pwStatusChanged( &c, &Config::userPasswordStatusChanged );
c.setUserPassword( "bogus" );
c.setUserPassword( "bogus" );
QCOMPARE( spy_pwChanged.count(), 1 );
QCOMPARE( spy_pwStatusChanged.count(), 1 );
QCOMPARE( c.userPasswordValidity(), Config::PasswordValidity::Invalid );
c.setUserPassword( "sugob" );
c.setUserPasswordSecondary( "sugob" );
QCOMPARE( spy_pwChanged.count(), 2 );
QCOMPARE( spy_pwSecondaryChanged.count(), 1 );
QCOMPARE( spy_pwStatusChanged.count(), 3 );
QCOMPARE( c.userPasswordValidity(), Config::PasswordValidity::Valid );
} }
} }