napcok/calamares
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #1949 from dalto8/removeemits

Browse Source 
Remove unneeded emits
This commit is contained in:
Adriaan de Groot 2022-05-14 17:24:48 +02:00 committed by GitHub
commit d318778f53
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/libcalamares/modulesystem/RequirementsModel.cpp
View File

@ -19,10 +19,10 @@ void
RequirementsModel::addRequirementsList( const Calamares::RequirementsList& requirements ) RequirementsModel::addRequirementsList( const Calamares::RequirementsList& requirements )
{ {
QMutexLocker l( &m_addLock ); QMutexLocker l( &m_addLock );
emit beginResetModel(); beginResetModel();
m_requirements.append( requirements ); m_requirements.append( requirements );
changeRequirementsList(); changeRequirementsList();
emit endResetModel(); endResetModel();
} }
void void

8
src/modules/netinstall/PackageModel.cpp
View File

@ -349,11 +349,11 @@ PackageModel::setupModelData( const QVariantList& groupList, PackageTreeItem* pa
void void
PackageModel::setupModelData( const QVariantList& l ) PackageModel::setupModelData( const QVariantList& l )
{ {
Q_EMIT beginResetModel(); beginResetModel();
delete m_rootItem; delete m_rootItem;
m_rootItem = new PackageTreeItem(); m_rootItem = new PackageTreeItem();
setupModelData( l, m_rootItem ); setupModelData( l, m_rootItem );
Q_EMIT endResetModel(); endResetModel();
} }
void void
@ -361,7 +361,7 @@ PackageModel::appendModelData( const QVariantList& groupList )
{ {
if ( m_rootItem ) if ( m_rootItem )
{ {
Q_EMIT beginResetModel(); beginResetModel();
const QStringList sources = collectSources( groupList ); const QStringList sources = collectSources( groupList );
@ -386,6 +386,6 @@ PackageModel::appendModelData( const QVariantList& groupList )
// Add the new data to the model // Add the new data to the model
setupModelData( groupList, m_rootItem ); setupModelData( groupList, m_rootItem );
Q_EMIT endResetModel(); endResetModel();
} }
} }

4
src/modules/summary/Config.cpp
View File

@ -61,7 +61,7 @@ SummaryModel::rowCount( const QModelIndex& ) const
void void
SummaryModel::setSummaryList( const Calamares::ViewStepList& steps, bool withWidgets ) SummaryModel::setSummaryList( const Calamares::ViewStepList& steps, bool withWidgets )
{ {
Q_EMIT beginResetModel(); beginResetModel();
m_summary.clear(); m_summary.clear();
for ( Calamares::ViewStep* step : steps ) for ( Calamares::ViewStep* step : steps )
@ -76,7 +76,7 @@ SummaryModel::setSummaryList( const Calamares::ViewStepList& steps, bool withWid
m_summary << StepSummary { step->prettyName(), text, widget }; m_summary << StepSummary { step->prettyName(), text, widget };
} }
Q_EMIT endResetModel(); endResetModel();
} }
Config::Config( QObject* parent ) Config::Config( QObject* parent )