From d179a9e3b12083f894aa9e72b944b81df38fc3c1 Mon Sep 17 00:00:00 2001
From: crispg72 <chris.e.green@hotmail.com>
Date: Tue, 24 Oct 2017 20:32:15 +0100
Subject: [PATCH] Tidied up bitness check

---
 src/modules/bootloader/main.py | 32 +++++++++++++++++---------------
 1 file changed, 17 insertions(+), 15 deletions(-)

diff --git a/src/modules/bootloader/main.py b/src/modules/bootloader/main.py
index ecc305503..7c3684c8c 100644
--- a/src/modules/bootloader/main.py
+++ b/src/modules/bootloader/main.py
@@ -235,10 +235,18 @@ def install_grub(efi_directory, fw_type):
             # if the kernel is older than 4.0, the UEFI bitness likely isn't
             # exposed to the userspace so we assume a 64 bit UEFI here
             efi_bitness = "64"
-        bitness_translate = {"32": "--target=i386-efi",
-                             "64": "--target=x86_64-efi"}
+
+        if efi_bitness == "32":
+            efi_target = "i386-efi"
+            efi_grub_file = "grubia32.efi"
+            efi_boot_file = "bootia32.efi"
+        elif efi_bitness == "64":
+            efi_target = "x86_64-efi"
+            efi_grub_file = "grubx64.efi"
+            efi_boot_file = "bootx64.efi"
+
         check_target_env_call([libcalamares.job.configuration["grubInstall"],
-                               bitness_translate[efi_bitness],
+                               "--target=" + efi_target,
                                "--efi-directory=" + efi_directory,
                                "--bootloader-id=" + efi_bootloader_id,
                                "--force"])
@@ -260,19 +268,13 @@ def install_grub(efi_directory, fw_type):
             os.makedirs(install_efi_boot_directory)
 
         # Workaround for some UEFI firmwares
-        efi_file_source = {"32": os.path.join(install_efi_directory_firmware,
-                                              efi_bootloader_id,
-                                              "grubia32.efi"),
-                           "64": os.path.join(install_efi_directory_firmware,
-                                              efi_bootloader_id,
-                                              "grubx64.efi")}
+        efi_file_source = os.path.join(install_efi_directory_firmware,
+                                          efi_bootloader_id,
+                                          efi_grub_file),
+        efi_file_target = os.path.join(install_efi_boot_directory,
+                                          efi_boot_file),
 
-        efi_file_target = {"32": os.path.join(install_efi_boot_directory,
-                                              "bootia32.efi"),
-                           "64": os.path.join(install_efi_boot_directory,
-                                              "bootx64.efi")}
-
-        shutil.copy2(efi_file_source[efi_bitness], efi_file_target[efi_bitness])
+        shutil.copy2(efi_file_source, efi_file_target)
     else:
         print("Bootloader: grub (bios)")
         if libcalamares.globalstorage.value("bootLoader") is None: