napcok/calamares
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Adding popup warning/instructions for GPT with BIOS

Browse Source 
see https://github.com/calamares/calamares/issues/1339#issuecomment-600862507
this is a very generic warning, used downstream since 2016
stopped virtual all BIOS GPT failures and questions
This commit is contained in:
demmm 2020-03-24 16:59:31 +01:00
parent 4c893b8260
commit b6228d137c
1 changed files with 36 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
src/modules/partition/gui/PartitionViewStep.cpp
View File

@ -402,7 +402,11 @@ PartitionViewStep::onLeave()
if ( m_widget->currentWidget() == m_manualPartitionPage ) if ( m_widget->currentWidget() == m_manualPartitionPage )
{ {
bool isEfi = false;
if ( PartUtils::isEfiSystem() ) if ( PartUtils::isEfiSystem() )
isEfi = true;
if ( isEfi )
{ {
QString espMountPoint = Calamares::JobQueue::instance()->globalStorage()-> QString espMountPoint = Calamares::JobQueue::instance()->globalStorage()->
value( "efiSystemPartition" ).toString(); value( "efiSystemPartition" ).toString();
@ -448,7 +452,39 @@ PartitionViewStep::onLeave()
description ); description );
} }
} }
if ( !isEfi )
{
cDebug() << "device: BIOS";
Partition* bios_p = m_core->findPartitionByMountPoint( "" );
QString message;
QString description;
message = tr( "Option to use GPT on BIOS" );
description = tr( "A GPT partition table is the best option for all "
"systems. This installer supports such a setup for "
"BIOS systems too."
"<br/><br/>"
"To configure a GPT partition table on BIOS, "
"(if not done so already) go back "
"and set the partion table to GPT, next create a 8 MB "
"unformatted partition with the "
"<strong>bios_grub</strong> flag enabled.<br/><br/>"
"An unformatted 8 MB partition is necessary "
"to start %1 on a BIOS system with GPT." )
.arg( Calamares::Branding::instance()->
string( Calamares::Branding::ShortProductName ) );
if ( !message.isEmpty() )
{
QMessageBox::information( m_manualPartitionPage,
message,
description );
}
}
Partition* root_p = m_core->findPartitionByMountPoint( "/" ); Partition* root_p = m_core->findPartitionByMountPoint( "/" );
Partition* boot_p = m_core->findPartitionByMountPoint( "/boot" ); Partition* boot_p = m_core->findPartitionByMountPoint( "/boot" );