napcok/calamares
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[partition] Avoid heap-wrangling

Browse Source 
- The CreatePartitionDialog doesn't need to be on the heap, it's
   modal here. Avoid QPointer weirdness as well.
This commit is contained in:
Adriaan de Groot 2019-02-26 07:21:36 -05:00
parent 943f3fb1f9
commit b4cefff975
1 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/modules/partition/gui/PartitionPage.cpp
View File

@ -362,18 +362,18 @@ PartitionPage::onCreateClicked()
if ( !checkCanCreate( model->device() ) ) if ( !checkCanCreate( model->device() ) )
return; return;
QPointer< CreatePartitionDialog > dlg = new CreatePartitionDialog( model->device(), CreatePartitionDialog dlg(
partition->parent(), model->device(),
nullptr, partition->parent(),
getCurrentUsedMountpoints(), nullptr,
this ); getCurrentUsedMountpoints(),
dlg->initFromFreeSpace( partition ); this );
if ( dlg->exec() == QDialog::Accepted ) dlg.initFromFreeSpace( partition );
if ( dlg.exec() == QDialog::Accepted )
{ {
Partition* newPart = dlg->createPartition(); Partition* newPart = dlg.createPartition();
m_core->createPartition( model->device(), newPart, dlg->newFlags() ); m_core->createPartition( model->device(), newPart, dlg.newFlags() );
} }
delete dlg;
} }
void void