Clang: reduce warnings

- mark some things override
 - make conversion of 0 to flags explicit
This commit is contained in:
Adriaan de Groot 2018-01-13 21:19:08 +01:00
parent 6e01bb0fa4
commit b0c4fbc1bb
3 changed files with 3 additions and 3 deletions

View File

@ -37,7 +37,7 @@ class CalamaresWindow : public QWidget
Q_OBJECT Q_OBJECT
public: public:
CalamaresWindow( QWidget* parent = nullptr ); CalamaresWindow( QWidget* parent = nullptr );
virtual ~CalamaresWindow() {} virtual ~CalamaresWindow() override {}
public slots: public slots:
/** /**

View File

@ -144,7 +144,7 @@ Qt::ItemFlags
PackageModel::flags( const QModelIndex& index ) const PackageModel::flags( const QModelIndex& index ) const
{ {
if ( !index.isValid() ) if ( !index.isValid() )
return 0; return Qt::ItemFlags();
if ( index.column() == 0 ) if ( index.column() == 0 )
return Qt::ItemIsUserCheckable | QAbstractItemModel::flags( index ); return Qt::ItemIsUserCheckable | QAbstractItemModel::flags( index );
return QAbstractItemModel::flags( index ); return QAbstractItemModel::flags( index );

View File

@ -30,7 +30,7 @@ class TrackingInstallJob : public Calamares::Job
Q_OBJECT Q_OBJECT
public: public:
TrackingInstallJob( const QString& url ); TrackingInstallJob( const QString& url );
~TrackingInstallJob(); ~TrackingInstallJob() override;
QString prettyName() const override; QString prettyName() const override;
QString prettyDescription() const override; QString prettyDescription() const override;